coach 0.4.3 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8fe46b4e391e9c45df5845126662d443a932432b
-  data.tar.gz: 411908ac832580ab48e7681b0b205e93a1b0cf02
+  metadata.gz: e35fa8a294c55fd5d88d89a727ad8a7f0bec3126
+  data.tar.gz: 2f890526ccfa7f667736a5cfc15d757cafb3e6a8
 SHA512:
-  metadata.gz: f6723e45d26aa33823f808f29e3793000be670c7a103698a404290e39098b1ff08cc9f3fd8df04f1cd23e7410f5b92ff771096bf4e95eaa925d5522b27a94ab1
-  data.tar.gz: 6546cf73ea20a8a3367684dfc17e3187cc7200e5057cf5015aeb5cfdc05e587a57dcc3998839073950a32b943d85ecee48603e9943e3d3832d6f98bf6f1cbf4d
+  metadata.gz: 27bf1b60051bc71d710cce036dc2917f74cd74aef227d30a4ffa957f442ea64b851630ba8d9ce1923f6db49e96f7457dfe2e787837dd272d38911c04bff328ff
+  data.tar.gz: f4d518d61d844ade2875ac23ffe609e869e1ff20da4dcdf5a9cc392f2144f0ffc89980f8ee0e550fa20c92eb0e19898437b28a1f0a5f4cfbe946da7356f7c97f

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# 0.4.4 / 2016-08-26
+
+* [https://github.com/gocardless/coach/pull/16] Fix middleware lookup issue in router
+
+# 0.4.3 / 2016-05-07
+
+* [https://github.com/gocardless/coach/pull/15] Clean up `Coach::Handler#inspect`
+
 # 0.4.2 / 2016-05-07
 
 * [https://github.com/gocardless/coach/pull/13] Add support for Rails 5.

data/lib/coach/router.rb

@@ -17,7 +17,10 @@ module Coach
 
     def draw(routes, base: nil, as: nil, constraints: nil, actions: [])
       action_traits(actions).each do |action, traits|
-        route = routes.const_get(camel(action))
+        # Passing false to const_get prevents it searching ancestors until a
+        # match is found. Without this, globally defined constants such as
+        # `Process` will be picked up before consts that need to be autoloaded.
+        route = routes.const_get(camel(action), false)
         match(action_url(base, traits),
               to: Handler.new(route),
               via: traits[:method],

data/lib/coach/version.rb

@@ -1,3 +1,3 @@
 module Coach
-  VERSION = '0.4.3'.freeze
+  VERSION = '0.4.4'.freeze
 end

data/spec/lib/coach/router_spec.rb

@@ -12,14 +12,11 @@ describe Coach::Router do
   end
 
   let(:resource_routes) do
-    Module.new do
-      class Index; end
-      class Show; end
-      class Create; end
-      class Update; end
-      class Destroy; end
-      class Refund; end # custom
+    routes_module = Module.new
+    [:Index, :Show, :Create, :Update, :Destroy, :Refund].each do |class_name|
+      routes_module.const_set(class_name, Class.new)
     end
+    routes_module
   end
 
   shared_examples "mount action" do |action, params|
@@ -74,5 +71,13 @@ describe Coach::Router do
         expect { draw }.to raise_error(Coach::Errors::RouterUnknownDefaultAction)
       end
     end
+
+    context "with unknown action that clashes with a global constant name" do
+      let(:actions) { [process: { method: :post, url: ":id/process" }] }
+
+      it "raises NameError" do
+        expect { draw }.to raise_error(NameError)
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coach
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-25 00:00:00.000000000 Z
+date: 2016-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack