coach 0.4.1 → 0.4.2

Sign up to get free protection for your applications and to get access to all the features.
Files changed (7) hide show
  1. checksums.yaml +4 -4
  2. data/.travis.yml +13 -2
  3. data/Gemfile +2 -0
  4. data/coach.gemspec +2 -2
  5. data/lib/coach/version.rb +1 -1
  6. data/spec/lib/coach/request_serializer_spec.rb +35 -1
  7. metadata +21 -22
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 0a57fdae02f8846063843522cffab967d2c69d09
4
- data.tar.gz: 77f1d849c0f70bea5937c5b6d2b557642cbd6af4
3
+ metadata.gz: d4b64d82b7cda7aa15c655f1f4bd278567c7b048
4
+ data.tar.gz: da44e099a7c4e45c36f1d53d57a495409a6307a2
5
5
  SHA512:
6
- metadata.gz: 831dc3ce5c929a1334d5e94e8069690f08021f064c466ab96008666d9b1c95601340e5cbd747a5c105e5936477ba9511aad1eac3e67c17095b8a851de76348be
7
- data.tar.gz: f1db9bd338045b896dc781996e1e6f710fc877900fd36d042fccefb81c9d24fce239592c53225409057236e80304b2de081e5aeb914956864b7aa8df606c877d
6
+ metadata.gz: 54b1f660a84558c36883f73418df1db907fb00df513285a150217709ce0313d9fb8ea7abe8e558c88860a3f9e169866ffcc51c54b616cf018e0003130a955673
7
+ data.tar.gz: 0a675d0e72ad5b74f9f86d87d4a02dd2ef8e26a8519e99f7999126e8fd8ebe0e8f1a8d34f99e15225af2dc2da7924f9ad51d9191acf9d843e1726057a0871b81
data/.travis.yml CHANGED
@@ -1,12 +1,23 @@
1
1
  language: ruby
2
2
 
3
+ sudo: false
4
+
3
5
  rvm:
4
6
  - 2.3.0
5
- - 2.2
7
+ - 2.2.4
6
8
  - 2.1
7
9
  - 2.0.0
8
10
 
9
- sudo: false
11
+ env:
12
+ - "RAILS_VERSION=4.2.6"
13
+ - "RAILS_VERSION=5.0.0.rc1"
14
+
15
+ matrix:
16
+ exclude:
17
+ - rvm: 2.1
18
+ env: "RAILS_VERSION=5.0.0.rc1"
19
+ - rvm: 2.0.0
20
+ env: "RAILS_VERSION=5.0.0.rc1"
10
21
 
11
22
  script:
12
23
  - bundle exec rubocop
data/Gemfile CHANGED
@@ -1,3 +1,5 @@
1
1
  source 'https://rubygems.org'
2
2
 
3
3
  gemspec
4
+
5
+ gem "rails", "~> #{ENV['RAILS_VERSION']}" if ENV["RAILS_VERSION"]
data/coach.gemspec CHANGED
@@ -17,8 +17,8 @@ Gem::Specification.new do |spec|
17
17
  spec.test_files = spec.files.grep(%r{^spec/})
18
18
  spec.require_paths = ['lib']
19
19
 
20
- spec.add_dependency 'actionpack', '~> 4.2'
21
- spec.add_dependency 'activesupport', '~> 4.2'
20
+ spec.add_dependency 'actionpack', '>= 4.2'
21
+ spec.add_dependency 'activesupport', '>= 4.2'
22
22
 
23
23
  spec.add_development_dependency 'rspec', '~> 3.2'
24
24
  spec.add_development_dependency 'rspec-its', '~> 1.2'
data/lib/coach/version.rb CHANGED
@@ -1,3 +1,3 @@
1
1
  module Coach
2
- VERSION = '0.4.1'.freeze
2
+ VERSION = '0.4.2'.freeze
3
3
  end
data/spec/lib/coach/request_serializer_spec.rb CHANGED
@@ -1,8 +1,9 @@
1
1
  require 'spec_helper'
2
+ require 'active_support/core_ext/object/try'
2
3
  require 'coach/request_serializer'
3
4
 
4
5
  describe Coach::RequestSerializer do
5
- describe '.apply_header_rule' do
6
+ describe ".apply_header_rule" do
6
7
  before { described_class.clear_header_rules! }
7
8
 
8
9
  let(:header) { 'http_abc' }
@@ -34,5 +35,38 @@ describe Coach::RequestSerializer do
34
35
  expect(sanitized).to eq('value')
35
36
  end
36
37
  end
38
+
39
+ context "as an instance" do
40
+ let(:mock_request) do
41
+ instance_double("ActionDispatch::Request", format: nil,
42
+ remote_ip: nil,
43
+ uuid: nil,
44
+ method: nil,
45
+ filtered_parameters: nil,
46
+ filtered_env: {
47
+ "foo" => "bar",
48
+ "HTTP_foo" => "bar"
49
+ })
50
+ end
51
+
52
+ subject(:request_serializer) { described_class.new(mock_request) }
53
+
54
+ describe "#serialize" do
55
+ subject(:serialized) { request_serializer.serialize }
56
+
57
+ it "rescues any exceptions request#fullpath may raise" do
58
+ allow(mock_request).to receive(:fullpath).and_raise
59
+
60
+ expect(serialized[:path]).to eq('unknown')
61
+ end
62
+
63
+ it "filters headers allowing only those prefixed with 'HTTP_'" do
64
+ allow(mock_request).to receive(:fullpath).and_return(nil)
65
+
66
+ expect(serialized[:headers]).not_to include("foo")
67
+ expect(serialized[:headers]).to include("http_foo")
68
+ end
69
+ end
70
+ end
37
71
  end
38
72
  end
metadata CHANGED
@@ -1,97 +1,97 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: coach
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.4.1
4
+ version: 0.4.2
5
5
  platform: ruby
6
6
  authors:
7
7
  - GoCardless
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2016-03-09 00:00:00.000000000 Z
11
+ date: 2016-05-07 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: actionpack
15
15
  requirement: !ruby/object:Gem::Requirement
16
16
  requirements:
17
- - - ~>
17
+ - - ">="
18
18
  - !ruby/object:Gem::Version
19
19
  version: '4.2'
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
- - - ~>
24
+ - - ">="
25
25
  - !ruby/object:Gem::Version
26
26
  version: '4.2'
27
27
  - !ruby/object:Gem::Dependency
28
28
  name: activesupport
29
29
  requirement: !ruby/object:Gem::Requirement
30
30
  requirements:
31
- - - ~>
31
+ - - ">="
32
32
  - !ruby/object:Gem::Version
33
33
  version: '4.2'
34
34
  type: :runtime
35
35
  prerelease: false
36
36
  version_requirements: !ruby/object:Gem::Requirement
37
37
  requirements:
38
- - - ~>
38
+ - - ">="
39
39
  - !ruby/object:Gem::Version
40
40
  version: '4.2'
41
41
  - !ruby/object:Gem::Dependency
42
42
  name: rspec
43
43
  requirement: !ruby/object:Gem::Requirement
44
44
  requirements:
45
- - - ~>
45
+ - - "~>"
46
46
  - !ruby/object:Gem::Version
47
47
  version: '3.2'
48
48
  type: :development
49
49
  prerelease: false
50
50
  version_requirements: !ruby/object:Gem::Requirement
51
51
  requirements:
52
- - - ~>
52
+ - - "~>"
53
53
  - !ruby/object:Gem::Version
54
54
  version: '3.2'
55
55
  - !ruby/object:Gem::Dependency
56
56
  name: rspec-its
57
57
  requirement: !ruby/object:Gem::Requirement
58
58
  requirements:
59
- - - ~>
59
+ - - "~>"
60
60
  - !ruby/object:Gem::Version
61
61
  version: '1.2'
62
62
  type: :development
63
63
  prerelease: false
64
64
  version_requirements: !ruby/object:Gem::Requirement
65
65
  requirements:
66
- - - ~>
66
+ - - "~>"
67
67
  - !ruby/object:Gem::Version
68
68
  version: '1.2'
69
69
  - !ruby/object:Gem::Dependency
70
70
  name: pry
71
71
  requirement: !ruby/object:Gem::Requirement
72
72
  requirements:
73
- - - ~>
73
+ - - "~>"
74
74
  - !ruby/object:Gem::Version
75
75
  version: '0.10'
76
76
  type: :development
77
77
  prerelease: false
78
78
  version_requirements: !ruby/object:Gem::Requirement
79
79
  requirements:
80
- - - ~>
80
+ - - "~>"
81
81
  - !ruby/object:Gem::Version
82
82
  version: '0.10'
83
83
  - !ruby/object:Gem::Dependency
84
84
  name: rubocop
85
85
  requirement: !ruby/object:Gem::Requirement
86
86
  requirements:
87
- - - ~>
87
+ - - "~>"
88
88
  - !ruby/object:Gem::Version
89
89
  version: '0.32'
90
90
  type: :development
91
91
  prerelease: false
92
92
  version_requirements: !ruby/object:Gem::Requirement
93
93
  requirements:
94
- - - ~>
94
+ - - "~>"
95
95
  - !ruby/object:Gem::Version
96
96
  version: '0.32'
97
97
  description: Controller framework
@@ -101,10 +101,10 @@ executables: []
101
101
  extensions: []
102
102
  extra_rdoc_files: []
103
103
  files:
104
- - .gitignore
105
- - .rspec
106
- - .rubocop.yml
107
- - .travis.yml
104
+ - ".gitignore"
105
+ - ".rspec"
106
+ - ".rubocop.yml"
107
+ - ".travis.yml"
108
108
  - CHANGELOG.md
109
109
  - Gemfile
110
110
  - README.md
@@ -139,17 +139,17 @@ require_paths:
139
139
  - lib
140
140
  required_ruby_version: !ruby/object:Gem::Requirement
141
141
  requirements:
142
- - - '>='
142
+ - - ">="
143
143
  - !ruby/object:Gem::Version
144
144
  version: '0'
145
145
  required_rubygems_version: !ruby/object:Gem::Requirement
146
146
  requirements:
147
- - - '>='
147
+ - - ">="
148
148
  - !ruby/object:Gem::Version
149
149
  version: '0'
150
150
  requirements: []
151
151
  rubyforge_project:
152
- rubygems_version: 2.4.8
152
+ rubygems_version: 2.4.5.1
153
153
  signing_key:
154
154
  specification_version: 4
155
155
  summary: coach middleware
@@ -162,4 +162,3 @@ test_files:
162
162
  - spec/lib/coach/request_serializer_spec.rb
163
163
  - spec/lib/coach/router_spec.rb
164
164
  - spec/spec_helper.rb
165
- has_rdoc: