cnb 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a1fc9b6106a803a576a97a106bb7f4b3d20bbd99
-  data.tar.gz: 8ea44b922132d9bc5c0df125ff80972ff3cef254
+  metadata.gz: 1b1981ee623b1b196bac0e1fa96e15c1278d1197
+  data.tar.gz: 8ea6a41b478a5d94feb0fb0a8d832a01e1cd8d12
 SHA512:
-  metadata.gz: cc4fe3b8ea2849295b18e1371282fe1574869fa6e8223820ed8299c72391de7a0f0d48092a6c21a698ee9a9faea80a627892ee21404ba16e896a5d9da53c851c
-  data.tar.gz: 2f19c1e0d98fe58fd06713f406f29dcd3c78553cdce1cee5841a3d41d20e7cfc87ca8d34f6389457527976553b7be417d7a971be077b791e09c44b5a02c9836b
+  metadata.gz: 4ebd88e00c2b4d9ae38f9d552adffe22f711365f090d5cdd0f3b9558af2335fcf0cef9d84f308acf22a117f0573e189110f1ff31e2af8f89b0fb6790ea26358d
+  data.tar.gz: 8740aaad851c8f7dc669e16d6520e0f1213b09e5d4aceff1d907c89469e506044f4913e3b99ad5aab6e36cf7806e0024e10d879b29fec7cc20e67b2c5980e5d1

data/lib/cnb/currency_rates.rb

@@ -5,7 +5,7 @@ module CNB
   class CurrencyRates
     CUR_RATES_URL = 'http://www.cnb.cz/cs/financni_trhy/devizovy_trh/'
 
-    attr_reader :cur_rates_filepath, :date
+    attr_reader :date, :currencies
 
     def rate(cur_code)
       get_currency(cur_code)[:rate]

data/lib/cnb/monthly_rates.rb

@@ -4,8 +4,8 @@ module CNB
       @month = month
       @year = year
 
-      raise 'Invalid year given' unless valid_month?
-      raise 'Invalid month given' unless valid_year?
+      raise 'Invalid month given' unless valid_month?
+      raise 'Invalid year given' unless valid_year?
 
       @currencies = {}
       @cur_rates_url = "#{CUR_RATES_URL}/kurzy_ostatnich_men/kurzy.xml?mesic=#{month}&rok=#{year}"

data/lib/cnb/version.rb

@@ -1,3 +1,3 @@
 module CNB
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/lib/cnb.rb

@@ -5,35 +5,17 @@ require_relative 'cnb/monthly_rates'
 module CNB
   PRIMARY_CURRENCY = 'CZK'
 
+  @rates_objects = {}
+
   class << self
     def daily_rates
-      @parser = DailyRates.new
+      key = :daily
+      @rates_objects[key] ||= DailyRates.new
     end
 
     def monthly_rates(month, year)
-      @parser = MonthlyRates.new(month, year)
-    end
-
-    def date
-      parser.date
-    end
-
-    def rate(cur_code)
-      parser.rate(cur_code)
-    end
-
-    def name(cur_code)
-      parser.name(cur_code)
-    end
-
-    def country(cur_code)
-      parser.country(cur_code)
-    end
-
-    private
-
-    def parser
-      @parser ||= DailyRates.new
+      key = "#{month}-#{year}"
+      @rates_objects[key] ||= MonthlyRates.new(month, year)
     end
   end
 end

data/spec/cnb_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+describe 'CNB' do
+  describe '#daily_rates' do
+    before(:each) do
+      CNB::DailyRates.any_instance.stub(:get_currencies) { {} }
+    end
+
+    it 'returns DailyRates object' do
+      expect(CNB.daily_rates).to be_a(CNB::DailyRates)
+    end
+
+    it 'always returns the same object' do
+      rates = CNB.daily_rates
+      expect(CNB.daily_rates.object_id).to eq rates.object_id
+    end
+  end
+
+  describe '#monthly_rates' do
+    before(:each) do
+      CNB::MonthlyRates.any_instance.stub(:get_currencies) { {} }
+    end
+
+    it 'returns MonthlyRates object' do
+      expect(CNB.monthly_rates(11,2013)).to be_a(CNB::MonthlyRates)
+    end
+
+    it 'always returns the same object for the same combination of month and year params' do
+      rates = CNB.monthly_rates(11, 2013)
+      expect(CNB.monthly_rates(11, 2013).object_id).to eq rates.object_id
+      expect(CNB.monthly_rates(10, 2013).object_id).not_to eq rates.object_id
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -6,9 +6,7 @@ if ENV['COVERAGE']
   SimpleCov.start
 end
 
-require 'cnb/currency_rates'
-require 'cnb/daily_rates'
-require 'cnb/monthly_rates'
+require 'cnb'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cnb
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Jan Zikán
@@ -99,6 +99,7 @@ files:
 - lib/cnb/daily_rates.rb
 - lib/cnb/monthly_rates.rb
 - lib/cnb/version.rb
+- spec/cnb_spec.rb
 - spec/fixtures/daily_rates.xml
 - spec/fixtures/monthly_rates_2013_03.xml
 - spec/models/daily_rates_spec.rb