cmds 0.2.9 → 0.2.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5c155b3a2266b44990db163f49efec7a59044a3b
-  data.tar.gz: f5fa951737f8b51a0a95aee8f49d3ec7344f3a06
+  metadata.gz: fb76b191ec12117d2d68bef750fe3f613d770cc5
+  data.tar.gz: 5afb4768e3fada0c9d088b2552ead175c46d7a94
 SHA512:
-  metadata.gz: d879ac96441d732374252beea066e84f2a1fc771ee21cea94374266b02ea02fdb8b47d8fd4771e8aaaed77d6176fb750d8ace803584fe65ebd5469394d8575be
-  data.tar.gz: cf7e0c8d02f586e8353b494baaf5a0d9171236708243d694ea50a80eadf96d8f4f975bd152345d834bcb39747eaae5e94fc5981d74944f8ff6f4cd5848a1e3f2
+  metadata.gz: ce525833832fd9d2086296e587233e91c4fa86f76bd4ff2ba2913b49d8816a3dd6261f4b768316782598d5e215ab76dbf794591701f927318dbddcf2b2f96b1f
+  data.tar.gz: 9c03d0736dd8c17559c86211bcbf4a4d384703362cd3b954370417d51da6e0c9a27b3ae3600fda6a07fae1814af24fd27d181b5e60fd78f2914847eb73eb844b

data/lib/cmds/io_handler.rb

@@ -1,4 +1,9 @@
 class Cmds
+  # Class for handling IO from threads and passing it back via a {Queue} to
+  # the main thread for processing.
+  # 
+  # NOTE  These are one-use only! Don't try to reuse them.
+  # 
   class IOHandler
     attr_accessor :in, :out, :err
 
@@ -6,6 +11,28 @@ class Cmds
       @in = nil
       @out = $stdout
       @err = $stderr
+      
+      # Initialize a thread-safe queue for passing output from the IO threads
+      # back to the main thread
+      # 
+      # NOTE  This used to be done in {#start}, but I was seeing intermittent
+      #       failures on Travis from what look like thread race conditions,
+      #       guessing that it's from output arriving before {#start} is
+      #       called, which totally looks like it could happen.
+      #       
+      #       See the failure in
+      #       
+      #       https://travis-ci.org/nrser/qb/jobs/348609316
+      #       
+      #       Really, I'm surprised I haven't hit more issues with this
+      #       half-ass threading shit.
+      #       
+      #       Anyways, I moved the queue creation here, see if it helps.
+      # 
+      @queue = Queue.new
+      
+      # Flag that is set to `true` when {#start} is called.
+      @started = false
     end
     
     def out= value
@@ -22,7 +49,7 @@ class Cmds
       @out = block
     end
 
-    # called in seperate thread handling process IO
+    # called in separate thread handling process IO
     def thread_send_out line
       @queue << [:out, line]
     end
@@ -31,19 +58,22 @@ class Cmds
       @err = block
     end
 
-    # called in seperate thread handling process IO
+    # called in separate thread handling process IO
     def thread_send_err line
       @queue << [:err, line]
     end
-
+    
+    # called in separate thread handling process IO
     def thread_send_line sym, line
       @queue << [sym, line]
     end
 
     def start
-      # Initialize a thread-safe queue for passing output from the IO threads
-      # back to the main thread
-      @queue = Queue.new
+      if @started
+        raise "This handler has already been started / run"
+      end
+      
+      @started = true
       
       # if out is a proc, it's not done
       out_done = ! @out.is_a?(Proc)

data/lib/cmds/version.rb

@@ -16,6 +16,6 @@ class Cmds
   # 
   # @return [String]
   # 
-  VERSION = '0.2.9'
+  VERSION = '0.2.10'
   
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cmds
 version: !ruby/object:Gem::Version
-  version: 0.2.9
+  version: 0.2.10
 platform: ruby
 authors:
 - nrser
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-02 00:00:00.000000000 Z
+date: 2018-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nrser