cloudstack_api 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1a71fad5fd898a7b1c3660a34b5c9eb251049ebb
-  data.tar.gz: 3045b355845b58ccb21352d8f394cff175a0a921
+  metadata.gz: d0179b1289f4e567a079e7565888d294ae20a26b
+  data.tar.gz: 6cf313b6bb31a92739a837e22e169221837d54ff
 SHA512:
-  metadata.gz: 864c0045e465200e2e5b6b41706b5c8dfbfd6aedc630a552f2b4c29d833531db344d3a0b624e8373855b56276c76ef19470886ac93f6092c79d0aa852df59467
-  data.tar.gz: c8f27faf0e8175c605f32435fd2b4f17886e5c11cc18ceda50d829099e6b3067b62e465885b0ac16ba8ac2426de7ab37fb71f9aee61807b4da687a7ade358cff
+  metadata.gz: d1ad07f9385a5642879efd7f8df183ad84c324234ad6936d9b289d42718be6297ab547013fd42093e956a6ee4c125bb967ac846aeb2fbe15afa843eca9f027c9
+  data.tar.gz: 803a9da578f5a57b3e101d68e22976f19c74a4c9891761a9f9e040545cff22fdcaa0628dae7a3a49c99cc8de7f611fa46b4791db4ac2b207be4c95cb12a7893c

data/lib/cloudstack/api.rb

@@ -149,15 +149,15 @@ module Cloudstack
     # If command or parameters is invalid, then corresponding error will be
     # added to #errors
     def validate_api_params
-      # retrieve parameters that belongs
-      allowed_params = Cloudstack.config.command_params(@command)
-
-      # if no parameters for current command then command is incorrect
-      unless allowed_params.present?
-        errors.add(:command, "'#{@command}' is invalid command")
+      # validate command
+      unless Cloudstack.config.commands.include? @command
+        errors.add(:command, "#{@command} is invalid command")
         return
       end
 
+      # retrieve parameters that belongs
+      allowed_params = Cloudstack.config.command_params(@command)
+
       # each parameter name should be in allowed parameters for current command
       (@params.keys - allowed_params).each do |param|
         errors.add(:params, "'#{param}' parameter is not allowed")

data/lib/cloudstack/version.rb

@@ -1,3 +1,3 @@
 module Cloudstack
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/test/api_test.rb

@@ -49,6 +49,12 @@ class ApiTest < ActiveSupport::TestCase
       @api.execute_command!('deployVirtualMachine', serviceofferingid: '1bd9a980-0f11-4892-aa0b-7c434dbd6d1c')
     end
     assert_match 'required', @api.errors[:params].to_s
+
+    # call command whichi do not contain params
+    assert_nothing_raised do
+      @api.execute_command!('listEventTypes')
+    end
+    assert @api.errors.messages.size == 0
   end
 
   test 'should check curl errors' do

data/test/dummy/log/test.log

@@ -701,5 +701,35 @@ ApiTest: test_should_check_api_parameters_validation
    (0.1ms)  begin transaction
 --------------------------------------
 ApiTest: test_should_check_curl_errors
+--------------------------------------
+   (0.1ms)  rollback transaction
+   (0.1ms)  begin transaction
+---------------------------------------------------------------------
+ApiTest: test_api_should_request_same_url_regardless_parameters_types
+---------------------------------------------------------------------
+   (0.1ms)  rollback transaction
+   (0.1ms)  begin transaction
+----------------------------------------------------
+ApiTest: test_should_check_api_parameters_validation
+----------------------------------------------------
+   (0.1ms)  rollback transaction
+   (0.1ms)  begin transaction
+--------------------------------------
+ApiTest: test_should_check_curl_errors
+--------------------------------------
+   (0.1ms)  rollback transaction
+   (0.2ms)  begin transaction
+---------------------------------------------------------------------
+ApiTest: test_api_should_request_same_url_regardless_parameters_types
+---------------------------------------------------------------------
+   (0.1ms)  rollback transaction
+   (0.1ms)  begin transaction
+----------------------------------------------------
+ApiTest: test_should_check_api_parameters_validation
+----------------------------------------------------
+   (0.1ms)  rollback transaction
+   (0.1ms)  begin transaction
+--------------------------------------
+ApiTest: test_should_check_curl_errors
 --------------------------------------
    (0.1ms)  rollback transaction

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cloudstack_api
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Bogdan Guban
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-10 00:00:00.000000000 Z
+date: 2014-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails