cloudsight 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 478811edc71cf94a43fbbb5c6f90523abcff2566
-  data.tar.gz: 4ec2871c44911b853f97412d83d69cc4e97668b3
+SHA256:
+  metadata.gz: 8b27c9ad341947fd8365b93eeca9202c44bc6997cc153171e45528e0a4f7553e
+  data.tar.gz: c4a7a7de5c7b9704925edbab211097e675802937ea3d71070ddd10624c54dfe9
 SHA512:
-  metadata.gz: 2c638e70d37ba3ebafd51ec85e3f7d524cad69edf42513351fe22ec41124106ef99a6e2eebfd500224a68c6fb27df60030e046afeecf6de291b44a210e51489a
-  data.tar.gz: 17608322f8b79f1e7ba8ba229a3d05dd96fc1615f07a350414e58992e0bf22819a2f2408b0111be7898f487b89a67b763265fd1adbb2a09f84c4d2d54ffcd60e
+  metadata.gz: 575f5503cee38dfd89d8f58cae1a04ee9ba994d6b0dd03f7ebdf9ee917e8c3923a40c66ffd4ceb7b6221dc4cef6bf4cc5645c14d0f2c5efab8011454418d1ed5
+  data.tar.gz: 439fb02ed6c5164ca146d76150832729c348260337b918205bcb753fa1220aa0fbc3f9ed9652baf596f2fc35918caf5ab1d966215d7d88078b6af7507a87ad41

data/.tool-versions

@@ -0,0 +1 @@
+ruby 2.7.1

data/.travis.yml

@@ -13,7 +13,8 @@ before_install:
   - gem update bundler
 
 rvm:
-  - 2.1
-  - 2.2.0
   - 2.3.0
   - 2.4.0
+  - 2.5.0
+  - 2.6.0
+  - 2.7.0

data/cloudsight.gemspec

@@ -25,7 +25,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'json', '~> 2.1'
   s.add_dependency 'rest-client', '~> 2.0'
 
-  s.add_development_dependency 'bundler', '~> 1.6'
+  s.add_development_dependency 'bundler', '~> 2.0'
   s.add_development_dependency 'rake', '~> 12.0'
   s.add_development_dependency 'rspec', '~> 3.6'
   s.add_development_dependency 'pry', '~> 0.10'

data/lib/cloudsight/request.rb

@@ -12,6 +12,9 @@ module Cloudsight
         raise UnexpectedResponseException.new(response.body) unless data['token']
 
         data
+
+      rescue JSON::ParserError
+        raise UnexpectedResponseException.new(response.body)
       end
 
       def repost(token, options = {})
@@ -25,6 +28,9 @@ module Cloudsight
         raise UnexpectedResponseException.new(response.body) unless data['token']
 
         data
+
+      rescue JSON::ParserError
+        raise UnexpectedResponseException.new(response.body)
       end
 
       def construct_params(options)

data/lib/cloudsight/response.rb

@@ -10,6 +10,9 @@ module Cloudsight
         raise UnexpectedResponseException.new(response.body) unless data['status']
 
         data
+
+      rescue JSON::ParserError
+        raise UnexpectedResponseException.new(response.body)
       end
 
       def retrieve(token, options = {})

data/lib/cloudsight/version.rb

@@ -1,3 +1,3 @@
 module Cloudsight
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/cloudsight/request_spec.rb

@@ -55,7 +55,7 @@ RSpec.describe Cloudsight::Request do
         response: fixture_file('image_request.json')
       )
 
-      response = described_class.send(params) 
+      response = described_class.send(params)
 
       expect(response["token"]).to  eq "sample_token"
       expect(response["url"]).to    eq "https://example.com/image.jpg"
@@ -81,6 +81,16 @@ RSpec.describe Cloudsight::Request do
 
       expect { described_class.send(params) }.to raise_error Cloudsight::UnexpectedResponseException
     end
+
+    it 'responds correctly to an invalid JSON response' do
+      stub_post(
+        path: '/v1/images',
+        body: { "locale" => "en", "remote_image_url" => "test_url" },
+        response: fixture_file('invalid_json.json')
+      )
+
+      expect { described_class.send(params) }.to raise_error Cloudsight::UnexpectedResponseException
+    end
   end
 
   describe '#repost' do
@@ -119,5 +129,15 @@ RSpec.describe Cloudsight::Request do
 
       expect { described_class.repost('sample_token', params) }.to raise_error Cloudsight::UnexpectedResponseException
     end
+
+    it 'responds correctly to an invalid JSON response' do
+      stub_post(
+        path: '/v1/images/sample_token/repost',
+        body: { "locale" => "en", "remote_image_url" => "test_url" },
+        response: fixture_file('invalid_json.json')
+      )
+
+      expect { described_class.repost('sample_token', params) }.to raise_error Cloudsight::UnexpectedResponseException
+    end
   end
 end

data/spec/cloudsight/response_spec.rb

@@ -36,6 +36,15 @@ RSpec.describe Cloudsight::Response do
 
       expect { described_class.get('sample_token') }.to raise_error Cloudsight::UnexpectedResponseException
     end
+
+    it 'responds correctly to an invalid JSON response' do
+      stub_get(
+        path: '/v1/images/sample_token',
+        response: fixture_file('invalid_json.json')
+      )
+
+      expect { described_class.get('sample_token') }.to raise_error Cloudsight::UnexpectedResponseException
+    end
   end
 
   describe '#retrieve' do
@@ -60,6 +69,12 @@ RSpec.describe Cloudsight::Response do
 
       expect { described_class.retrieve('sample_token', poll_wait: 0.01) }.to raise_error Cloudsight::UnexpectedResponseException
     end
+
+    it 'responds correctly to an invalid JSON response' do
+      stub_polling(3, 'image_request.json', 'invalid_json.json', '/v1/images/sample_token')
+
+      expect { described_class.retrieve('sample_token', poll_wait: 0.01) }.to raise_error Cloudsight::UnexpectedResponseException
+    end
   end
 end
 

data/spec/fixtures/invalid_json.json

@@ -0,0 +1,9 @@
+<html><head>
+<meta http-equiv="content-type" content="text/html;charset=utf-8">
+<title>502 Server Error</title>
+</head>
+<body text=#000000 bgcolor=#ffffff>
+<h1>Error: Server Error</h1>
+<h2>The server encountered a temporary error and could not complete your request.<p>Please try again in 30 seconds.</h2>
+<h2></h2>
+</body></html>

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: cloudsight
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Brad Folkens
 - Jack McCallum
 - Chris Weilemann
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-12-11 00:00:00.000000000 Z
+date: 2020-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -46,14 +46,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -134,6 +134,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".tool-versions"
 - ".travis.yml"
 - Gemfile
 - MIT-LICENSE
@@ -154,13 +155,14 @@ files:
 - spec/fixtures/completed_response.json
 - spec/fixtures/error_response.json
 - spec/fixtures/image_request.json
+- spec/fixtures/invalid_json.json
 - spec/fixtures/unexpected_response.json
 - spec/spec_helper.rb
 homepage: http://github.com/cloudsight/cloudsight-ruby
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -175,9 +177,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: CloudSight API Client
 test_files:
@@ -188,5 +189,6 @@ test_files:
 - spec/fixtures/completed_response.json
 - spec/fixtures/error_response.json
 - spec/fixtures/image_request.json
+- spec/fixtures/invalid_json.json
 - spec/fixtures/unexpected_response.json
 - spec/spec_helper.rb