cloud_search 0.1.7 → 0.1.8

data/lib/cloud_search/document.rb

@@ -26,8 +26,10 @@ module CloudSearch
       run_id_validations
       run_version_validations
       run_type_validations
-      run_lang_validations
-      run_fields_validations
+      if type == "add"
+        run_lang_validations
+        run_fields_validations
+      end
       errors.empty?
     end
 

data/lib/cloud_search/version.rb

@@ -1,3 +1,3 @@
 module CloudSearch
-  VERSION = "0.1.7"
+  VERSION = "0.1.8"
 end

data/spec/cloud_search/document_spec.rb

@@ -142,54 +142,74 @@ describe CloudSearch::Document do
   end
 
   context "lang validation" do
-    it "is invalid if lang is nil" do
-      document = described_class.new :lang => nil
-      document.valid?
-      expect(document.errors[:lang]).to eql(["can't be blank"])
-    end
+    context "when type is 'add'" do
+      it "is invalid if lang is nil" do
+        document = described_class.new :lang => nil, :type => "add"
+        document.valid?
+        expect(document.errors[:lang]).to eql(["can't be blank"])
+      end
 
-    it "is invalid if lang contains digits" do
-      document = described_class.new :lang => "a1"
-      document.valid?
-      expect(document.errors[:lang]).to eql(["is invalid"])
-    end
+      it "is invalid if lang contains digits" do
+        document = described_class.new :lang => "a1", :type => "add"
+        document.valid?
+        expect(document.errors[:lang]).to eql(["is invalid"])
+      end
 
-    it "is invalid if lang contains more than 2 characters" do
-      document = described_class.new :lang => "abc"
-      document.valid?
-      expect(document.errors[:lang]).to eql(["is invalid"])
-    end
+      it "is invalid if lang contains more than 2 characters" do
+        document = described_class.new :lang => "abc", :type => "add"
+        document.valid?
+        expect(document.errors[:lang]).to eql(["is invalid"])
+      end
 
-    it "is invalid if lang contains upper case characters" do
-      document = described_class.new :lang => "Ab"
-      document.valid?
-      expect(document.errors[:lang]).to eql(["is invalid"])
+      it "is invalid if lang contains upper case characters" do
+        document = described_class.new :lang => "Ab", :type => "add"
+        document.valid?
+        expect(document.errors[:lang]).to eql(["is invalid"])
+      end
+
+      it "is valid if lang contains 2 lower case characters" do
+        document = described_class.new :lang => "en", :type => "add"
+        document.valid?
+        expect(document.errors[:lang]).to be_nil
+      end
     end
 
-    it "is valid if lang contains 2 lower case characters" do
-      document = described_class.new :lang => "en"
-      document.valid?
-      expect(document.errors[:lang]).to be_nil
+    context "when type is 'delete'" do
+      it "is optional" do
+        document = described_class.new :type => "delete"
+        document.valid?
+        expect(document.errors[:lang]).to be_nil
+      end
     end
   end
 
   context "fields validation" do
-    it "is invalid if fields is nil" do
-      document = described_class.new :fields => nil
-      document.valid?
-      expect(document.errors[:fields]).to eql(["can't be empty"])
-    end
+    context "when type is 'add'" do
+      it "is invalid if fields is nil" do
+        document = described_class.new :fields => nil, :type => "add"
+        document.valid?
+        expect(document.errors[:fields]).to eql(["can't be empty"])
+      end
 
-    it "is invalid if fields is not a hash" do
-      document = described_class.new :fields => []
-      document.valid?
-      expect(document.errors[:fields]).to eql(["must be an instance of Hash"])
+      it "is invalid if fields is not a hash" do
+        document = described_class.new :fields => [], :type => "add"
+        document.valid?
+        expect(document.errors[:fields]).to eql(["must be an instance of Hash"])
+      end
+
+      it "is valid with a Hash" do
+        document = described_class.new :fields => {}, :type => "add"
+        document.valid?
+        expect(document.errors[:fields]).to be_nil
+      end
     end
 
-    it "is valid with a Hash" do
-      document = described_class.new :fields => {}
-      document.valid?
-      expect(document.errors[:fields]).to be_nil
+    context "when type is 'delete'" do
+      it "is optional" do
+        document = described_class.new :type => "delete"
+        document.valid?
+        expect(document.errors[:fields]).to be_nil
+      end
     end
   end
 

data/spec/cloud_search/invalid_document_spec.rb

@@ -4,6 +4,6 @@ describe CloudSearch::InvalidDocument do
   let(:document) { CloudSearch::Document.new }
 
   it "has a message with the document errors" do
-    expect(described_class.new(document).message).to eq("id: can't be blank; version: can't be blank; type: can't be blank; lang: can't be blank; fields: can't be empty")
+    expect(described_class.new(document).message).to eq("id: can't be blank; version: can't be blank; type: can't be blank")
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cloud_search
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-29 00:00:00.000000000 Z
+date: 2012-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -175,18 +175,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 4455518161793254465
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 4455518161793254465
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24
@@ -210,3 +204,4 @@ test_files:
 - spec/fixtures/vcr_cassettes/search/request/paginated_second_page.yml
 - spec/spec_helper.rb
 - spec/support/vcr.rb
+has_rdoc: