cloud_search 0.0.4 → 0.0.5

data/lib/cloud_search/config.rb

@@ -1,6 +1,21 @@
 require "singleton"
 
 module CloudSearch
+  class MissingConfigurationError < StandardError
+    def initialize(parameter_name)
+      super "Missing '#{parameter_name}' configuration parameter"
+    end
+  end
+
+  module ConfigurationChecking
+    private
+
+    def check_configuration_parameters
+      raise MissingConfigurationError.new("domain_id") if CloudSearch.config.domain_id.nil?
+      raise MissingConfigurationError.new("domain_name") if CloudSearch.config.domain_name.nil?
+    end
+  end
+
   class Config
     include Singleton
 

data/lib/cloud_search/indexer.rb

@@ -1,5 +1,7 @@
 module CloudSearch
   class Indexer
+    include ConfigurationChecking
+
     def initialize
       @documents = []
     end
@@ -48,6 +50,8 @@ module CloudSearch
     end
 
     def url
+      check_configuration_parameters
+
       "#{CloudSearch.config.document_url}/documents/batch"
     end
   end

data/lib/cloud_search/searcher.rb

@@ -1,5 +1,6 @@
 module CloudSearch
   class Searcher
+    include ConfigurationChecking
 
     def search
       response = SearchResponse.new
@@ -74,6 +75,8 @@ module CloudSearch
     end
 
     def url
+      check_configuration_parameters
+
       "#{CloudSearch.config.search_url}/search".tap do |u|
         u.concat("?#{query_parameter}=#{CGI.escape(query)}&size=#{items_per_page}&start=#{start}")
         u.concat("&return-fields=#{CGI.escape(@fields.join(","))}") unless @fields.nil? or @fields.empty?

data/lib/cloud_search/version.rb

@@ -1,3 +1,3 @@
 module CloudSearch
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/cloud_search/indexer_spec.rb

@@ -65,6 +65,36 @@ describe CloudSearch::Indexer do
         expect(resp["deletes"]).to eq(0)
         expect(message).to match(/^200/)
       end
+
+      context "when the domain id was not configured" do
+        around do |example|
+          domain_id = CloudSearch.config.domain_id
+          CloudSearch.config.domain_id = nil
+          example.call
+          CloudSearch.config.domain_id = domain_id
+        end
+
+        it "raises an error" do
+          expect {
+            indexer.index
+          }.to raise_error(CloudSearch::MissingConfigurationError, "Missing 'domain_id' configuration parameter")
+        end
+      end
+
+      context "when the domain name was not configured" do
+        around do |example|
+          domain_name = CloudSearch.config.domain_name
+          CloudSearch.config.domain_name = nil
+          example.call
+          CloudSearch.config.domain_name = domain_name
+        end
+
+        it "raises an error" do
+          expect {
+            indexer.index
+          }.to raise_error(CloudSearch::MissingConfigurationError, "Missing 'domain_name' configuration parameter")
+        end
+      end
     end
 
     context "adding a batch of documents" do

data/spec/cloud_search/searcher_spec.rb

@@ -140,34 +140,62 @@ describe CloudSearch::Searcher do
   describe "#search" do
     before do
       subject
-        .with_fields(:actor, :director, :title, :year, :text_relevance)
-        .with_query("star wars")
+      .with_fields(:actor, :director, :title, :year, :text_relevance)
+      .with_query("star wars")
     end
 
     around { |example| VCR.use_cassette "search/request/full", &example }
 
-    context "given valid parameters" do
-      it "returns http 200 code" do
-        resp = subject.search
-        resp.http_code.should == 200
+    context "when the domain id was not configured" do
+      around do |example|
+        domain_id = CloudSearch.config.domain_id
+        CloudSearch.config.domain_id = nil
+        example.call
+        CloudSearch.config.domain_id = domain_id
       end
 
-      it "has found results" do
-        resp = subject.search
-        resp.should be_found
+      it "raises an error" do
+        expect {
+          subject.search
+        }.to raise_error(CloudSearch::MissingConfigurationError, "Missing 'domain_id' configuration parameter")
       end
+    end
 
-      it "returns number of hits" do
-        resp = subject.search
-        expect(resp.hits).to be == 7
+    context "when the domain name was not configured" do
+      around do |example|
+        domain_name = CloudSearch.config.domain_name
+        CloudSearch.config.domain_name = nil
+        example.call
+        CloudSearch.config.domain_name = domain_name
       end
 
-      it "returns Episode II" do
-        resp = subject.search
-        resp.results.inject([]){|acc, i| acc << i['data']['title']}.flatten
-        .should include "Star Wars: Episode II - Attack of the Clones"
+      it "raises an error" do
+        expect {
+          subject.search
+        }.to raise_error(CloudSearch::MissingConfigurationError, "Missing 'domain_name' configuration parameter")
       end
     end
+
+    it "returns http 200 code" do
+      resp = subject.search
+      resp.http_code.should == 200
+    end
+
+    it "has found results" do
+      resp = subject.search
+      resp.should be_found
+    end
+
+    it "returns number of hits" do
+      resp = subject.search
+      expect(resp.hits).to be == 7
+    end
+
+    it "returns Episode II" do
+      resp = subject.search
+      resp.results.inject([]){|acc, i| acc << i['data']['title']}.flatten
+      .should include "Star Wars: Episode II - Attack of the Clones"
+    end
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cloud_search
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors: