cloud_five_push 0.1.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9cac6d8ce09bbcbb5a1a26cfcaa55721384ae44f
-  data.tar.gz: 831176ac60992f5b5ea1861e6b09ad98bc450a42
+  metadata.gz: 65c4d60a60ac7154dad31c52c1bf9f572b1c8160
+  data.tar.gz: 151eb3c4e347c4c340f353071e7698ccd615597a
 SHA512:
-  metadata.gz: 40a929ae5afd337f6b964b94b97ebad9a77a898c50fbf5a5e6e236a5c3a1d122f21a2ef21cbd2408c1e66f5d7d67c891a1d8efc159a72d05f7e082d483181bd7
-  data.tar.gz: 87975a51cd08af1b24b151263e579dc92bd4cd109fb8c85e598f31905d6ac553e12d94b82306e179745a27b989e30cf4b08120642ba36c39fc571e1532084981
+  metadata.gz: 074e235d847cfaec0328f779ecbef5ab8344fdca808d0b9b8fc59a22cb7b5179a6ba58f6ec3714b35322e2e6a5bbf1f69c7b63c5cc36bce74af23cae1b3a80cc
+  data.tar.gz: 3c7b665805de5d5da468a5cce71461e0075240eba9bd5a0cc7c03a7c275de549e4bd2e4bcaaaa22207603065c08997bd2bf6ca86007e2b6ee73156cdf9340101

data/.gitignore

@@ -15,3 +15,5 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+spec/examples.txt
+spec/vcr_cassettes

data/cloud_five_push.gemspec

@@ -21,6 +21,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "vcr"
+  spec.add_development_dependency "webmock"
 
   spec.add_dependency "httparty"
   spec.add_dependency "json"

data/lib/cloud_five_push/notification.rb

@@ -1,17 +1,19 @@
 require 'httparty'
+
 module CloudFivePush
   class Notification
+    include HTTParty
+
     attr_accessor :user_identifiers, :alert, :message, :badge, :scheduled_at, :broadcast,
                   :api_key, :data, :aps_environment, :content_available
 
-    include HTTParty
     base_uri 'https://push.cloudfiveapp.com'
     # debug_output $stderr
 
-    def initialize(api_key=nil)
+    def initialize(api_key = nil)
       @api_key = api_key || CloudFivePush.api_key
       if @api_key.nil?
-        raise "api_key is required (or set CloudFivePush.api_key)"
+        raise "api_key is required. Pass into initializer or set CloudFivePush.api_key first"
       end
       @broadcast = false
       @user_identifiers = []
@@ -27,7 +29,7 @@ module CloudFivePush
         raise "Can't both broadcast and set user_identifiers"
       end
 
-      self.class.post('/push/notify', body: push_params)
+      self.class.post('/api/push/notify', body: push_params).parsed_response
     end
 
     def user_identifiers=(user_identifiers)

data/lib/cloud_five_push/version.rb

@@ -1,3 +1,3 @@
 module CloudFivePush
-  VERSION = "0.1.1"
+  VERSION = "1.0.0"
 end

data/spec/notification_spec.rb

@@ -1,9 +1,58 @@
 require 'spec_helper'
 
-describe CloudFivePush::Notification do
-  before(:all) { CloudFivePush.api_key = "fake"; }
+RSpec.describe CloudFivePush::Notification do
+  before(:all) { CloudFivePush.api_key = "fake" }
+
   let(:notification) { CloudFivePush::Notification.new }
-  context "Setting user identifiers" do
+
+  describe '::new' do
+    it 'sets broadcast to false' do
+      expect(notification.broadcast).to eq false
+    end
+
+    it 'sets user identifiers to blank array' do
+      expect(notification.user_identifiers).to eq []
+    end
+
+    it 'sets the aps_environment from CloudFivePush' do
+      CloudFivePush.aps_environment = 'production'
+      expect(notification.aps_environment).to eq 'production'
+    end
+
+    it 'raises error if there is no api_key' do
+      CloudFivePush.api_key = nil
+      expect {
+        notification
+      }.to raise_error "api_key is required. Pass into initializer or set CloudFivePush.api_key first"
+      CloudFivePush.api_key = 'fake'
+    end
+  end
+
+  describe '#notify!' do
+    it 'posts to the cloud five api url and returns our json' do
+      notification.broadcast = true
+      expect(notification.notify!).to eq({
+         "success"=>false,
+         "error"=>"Invalid API key"
+      })
+    end
+
+    it 'raises error if broadcast is false and there are no user identifiers' do
+      expect{
+        notification.notify!
+      }.to raise_error "Please set user_identifiers or set broadcast=true"
+    end
+
+    it 'raises error if broadcast is true and there are user identifiers' do
+      notification.broadcast = true
+      notification.user_identifiers = [1]
+      expect{
+        notification.notify!
+      }.to raise_error "Can't both broadcast and set user_identifiers"
+    end
+  end
+
+  describe "#user_identifiers=" do
     it "accepts an array of identifiers" do
       notification.user_identifiers = [1,2,3]
       expect(notification.user_identifiers).to eq [1,2,3]
@@ -15,11 +64,10 @@ describe CloudFivePush::Notification do
     end
   end
 
-
-  it "Uses the global aps_environment setting" do
-    CloudFivePush.aps_environment = :development
-    expect(notification.aps_environment).to eq :development
-    CloudFivePush.aps_environment = nil #reset
+  describe '#user_identifier=' do
+    it 'is an alias to user_identifiers=' do
+      notification.user_identifier = 1
+      expect(notification.user_identifiers).to eq [1]
+    end
   end
-
-end
+end

data/spec/spec_helper.rb

@@ -1,18 +1,100 @@
 require 'cloud_five_push'
+
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# Require this file using `require "spec_helper"` to ensure that it is only
-# loaded once.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# The `.rspec` file also contains a few flags that are not defaults but that
+# users commonly want.
 #
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+
+# Auto-require all files in the support directory.
+Dir[File.join(__dir__, 'support/**/*.rb')].each { |f| require f }
+
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
-  config.run_all_when_everything_filtered = true
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+  # These two settings work together to allow you to limit a spec run
+  # to individual examples or groups you care about by tagging them with
+  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  # get run.
   config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
+  config.disable_monkey_patching!
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  config.warnings = true
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  #config.profile_examples = 10
 
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
-  config.order = 'random'
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
 end

data/spec/support/vcr.rb

@@ -0,0 +1,19 @@
+require 'vcr'
+
+VCR.configure do |config|
+  config.allow_http_connections_when_no_cassette = true
+  config.cassette_library_dir = File.join __dir__, '../vcr_cassettes'
+  config.configure_rspec_metadata!
+  config.hook_into :webmock
+  config.ignore_localhost = true
+end
+
+RSpec.configure do |config|
+  config.around :each do |example|
+    # VCR won't create cassettes for examples that do not make requests
+    # so set the vcr metadata for every example
+    # so VCR is invoked automagically for every test that makes external requests
+    example.metadata[:vcr] = true
+    example.run
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cloud_five_push
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Brian Samson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-16 00:00:00.000000000 Z
+date: 2015-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,6 +52,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: vcr
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
@@ -99,6 +127,7 @@ files:
 - lib/cloud_five_push/version.rb
 - spec/notification_spec.rb
 - spec/spec_helper.rb
+- spec/support/vcr.rb
 homepage: ''
 licenses:
 - MIT
@@ -126,3 +155,4 @@ summary: Wraps the API for push.cloudfiveapp.com
 test_files:
 - spec/notification_spec.rb
 - spec/spec_helper.rb
+- spec/support/vcr.rb