closure_tree 4.2.2 → 4.2.3

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: b7af59d338586f417b0d1c02f5a235cb6f62e6d8
-  data.tar.gz: 91940db8a3f150178fd1937aa2a810d11370c32a
-SHA512:
-  metadata.gz: 746919295c964e6d86940068405f4b955751540d56916ab44a3a4a9277c4862ac570fb5527717a6fe889f8786167d008138ca142558137c348dd205b443d6dfe
-  data.tar.gz: dde679414da16f0bd2d84bb4ebab7f4a755c4dcee9c0eea91ab81106ebc89fd3040e45b0bded9bd76bf9d9d8db853e408aa0bbaabe33aa2cc21bbd361e0a441d
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    NGI4ZjJlMTkxYzc2MDc1OWNmZWZjZmE5NDYzMDIyMzhlZTRjMmY4YQ==
+  data.tar.gz: !binary |-
+    MTdjZTY3OWMzOThlODYyODBjYWY5MmFlYmE1ZGE4Mjc3NTBkNjE4Yg==
+!binary "U0hBNTEy":
+  metadata.gz: !binary |-
+    Njc0MTM5MTg1ZmMzMDFiNTg2YmExYmNmOThjNWVhNDljNzlkYzA4OTg1MTZi
+    MzcyOTc0YjhiOTIxYmZjNGI2ZTJiYTA2NGJhMDg2ZTA0N2QxYTIyNzFlODJm
+    OTBhZjgxNWFlZDBiMWNlYjMxYjk1MTBkNTliNjkyYWM1MmZjNWM=
+  data.tar.gz: !binary |-
+    M2MzYTY5ZTgwNjQ1M2FlMWZkMWYzNGU0OTY1NWVhNWEyZDg5OGI1ZTUxMGU5
+    ZWY4ZDY4MTE2MjY4YzdhYjM1MjhlNGI1ZDBkMGNiNzhkZWU0NmIwYjlhZmI1
+    NzZhNTM0MTc2N2U3NWEyZGMwMWYwZDlkODczMWU1MGViNjIxYTg=

data/README.md

@@ -8,7 +8,6 @@ and tracking user referrals.
 [![Build Status](https://secure.travis-ci.org/mceachen/closure_tree.png?branch=master)](http://travis-ci.org/mceachen/closure_tree)
 [![Gem Version](https://badge.fury.io/rb/closure_tree.png)](http://rubygems.org/gems/closure_tree)
 [![Code Climate](https://codeclimate.com/github/mceachen/closure_tree.png)](https://codeclimate.com/github/mceachen/closure_tree)
-[![Coverage Status](https://coveralls.io/repos/mceachen/closure_tree/badge.png?branch=master)](https://coveralls.io/r/mceachen/closure_tree?branch=master)
 
 Substantially more efficient than
 [ancestry](https://github.com/stefankroes/ancestry) and
@@ -25,7 +24,7 @@ closure_tree has some great features:
 * __Best-in-class mutation performance__:
   * 2 SQL INSERTs on node creation
   * 3 SQL INSERT/UPDATEs on node reparenting
-* __Support for Rails 3.0, 3.1, 3.2, and 4.0.0.rc2__
+* __Support for Rails 3.0, 3.1, 3.2, and 4.0__
 * Support for reparenting children (and all their progeny)
 * Support for [concurrency](#concurrency) (using [with_advisory_lock](https://github/mceachen/with_advisory_lock))
 * Support for polymorphism [STI](#sti) within the hierarchy
@@ -478,7 +477,7 @@ end
 
 Closure tree is [tested under every valid combination](http://travis-ci.org/#!/mceachen/closure_tree) of
 
-* Ruby 1.8.7, Ruby 1.9.3, and Ruby 2.0.0
+* Ruby 1.9.3 and Ruby 2.0.0
 * The latest Rails 3.0, 3.1, 3.2, and 4.0 branches, and
 * MySQL and PostgreSQL. SQLite works in a single-threaded environment.
 
@@ -491,6 +490,11 @@ Parallelism is not tested with Rails 3.0.x nor 3.1.x due to this
 
 ## Change log
 
+### 4.2.3
+
+* Fixed ```attr_accessible?``` error introduced in 4.2.2 ([issue 66](https://github.com/mceachen/closure_tree/issues/66)).
+* Switched to use new WithAdvisoryLock::DatabaseAdapterSupport (in v0.0.9) to add Postgis support
+
 ### 4.2.2
 
 * Support attr_accessible and strong_attributes even if you're on Rails 4

data/lib/closure_tree/numeric_order_support.rb

@@ -2,13 +2,13 @@ module ClosureTree
   module NumericOrderSupport
 
     def self.adapter_for_connection(connection)
-      case connection.adapter_name.downcase.to_sym
-        when :postgresql
-          ::ClosureTree::NumericOrderSupport::PostgreSQLAdapter
-        when :mysql, :mysql2
-          ::ClosureTree::NumericOrderSupport::MysqlAdapter
-        else
-          ::ClosureTree::NumericOrderSupport::GenericAdapter
+      das = WithAdvisoryLock::DatabaseAdapterSupport.new(connection)
+      if das.postgresql?
+        ::ClosureTree::NumericOrderSupport::PostgreSQLAdapter
+      elsif das.mysql?
+        ::ClosureTree::NumericOrderSupport::MysqlAdapter
+      else
+        ::ClosureTree::NumericOrderSupport::GenericAdapter
       end
     end
 

data/lib/closure_tree/support_flags.rb

@@ -2,15 +2,13 @@ module ClosureTree
   module SupportFlags
 
     def use_attr_accessible?
-      (3..4).include? ActiveRecord::VERSION::MAJOR  &&
-        defined?(ActiveModel::MassAssignmentSecurity) &&
+      defined?(ActiveModel::MassAssignmentSecurity) &&
         model_class.respond_to?(:accessible_attributes) &&
         model_class.accessible_attributes.present?
     end
 
     def include_forbidden_attributes_protection?
-      (3..4).include? ActiveRecord::VERSION::MAJOR &&
-        defined?(ActiveModel::ForbiddenAttributesProtection) &&
+      defined?(ActiveModel::ForbiddenAttributesProtection) &&
         model_class.ancestors.include?(ActiveModel::ForbiddenAttributesProtection)
     end
 

data/lib/closure_tree/version.rb

@@ -1,3 +1,3 @@
 module ClosureTree
-  VERSION = Gem::Version.new("4.2.2") unless defined?(::ClosureTree::VERSION)
+  VERSION = Gem::Version.new("4.2.3") unless defined?(::ClosureTree::VERSION)
 end

data/spec/spec_helper.rb

@@ -12,8 +12,6 @@ require 'rspec/rails/adapters'
 require 'rspec/rails/fixture_support'
 require 'closure_tree'
 require 'tmpdir'
-require 'coveralls'
-Coveralls.wear! if ENV['DB_PREFIX'].present? && ENV['DB_SUFFIX'].present?
 
 #log = Logger.new(STDOUT)
 #log.sev_threshold = Logger::DEBUG

metadata

@@ -1,181 +1,167 @@
 --- !ruby/object:Gem::Specification
 name: closure_tree
 version: !ruby/object:Gem::Version
-  version: 4.2.2
+  version: 4.2.3
 platform: ruby
 authors:
 - Matthew McEachen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-23 00:00:00.000000000 Z
+date: 2013-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: with_advisory_lock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.0.6
+        version: 0.0.9
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.0.6
+        version: 0.0.9
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: fuubar
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mysql2
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: uuidtools
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: coveralls
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Easily and efficiently make your ActiveRecord model support hierarchies
@@ -226,17 +212,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.2
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Easily and efficiently make your ActiveRecord model support hierarchies