closure_tree 3.8.2 → 3.9.0

checksums.yaml

@@ -0,0 +1,7 @@
+--- 
+SHA512: 
+  metadata.gz: 4eba6a7034297fd15958c27428782adc3a1b36abc1f0723039583418c33eb08377e3b5cfa744aae985cdd2b1b2cbd91138486e2a0591c0ff2f9c1fcb9893361d
+  data.tar.gz: 8f8f339d462f846bfb59c260756d94ad8328a9bea1f4bf9ad2d9d00317f05efd7f8d099eee2b1c1a8e661ccef827fcbb46cb9f5a22f9e0f816bd5b8118fea9c4
+SHA1: 
+  metadata.gz: f04e325774ddd75fddfaeb47753095903350aed8
+  data.tar.gz: 66ed5c26efe5cac30d3bb3e3d1d128ae67d4e184

data/README.md

@@ -15,8 +15,8 @@ closure_tree has some great features:
   * Fetch your whole ancestor lineage in 1 SELECT.
   * Grab all your descendants in 1 SELECT.
   * Get all your siblings in 1 SELECT.
-  * Fetch all [7-degrees-of-bacon in a nested hash](#nested-hashes) in 1 SELECT.
-  * [Find a node by path](#find_or_create_by_path) in 1 SELECT.
+  * Fetch all [descendants as a nested hash](#nested-hashes) in 1 SELECT.
+  * [Find a node by ancestry path](#find_or_create_by_path) in 1 SELECT.
 * __Best-in-class mutation performance__:
   * 2 SQL INSERTs on node creation
   * 3 SQL INSERT/UPDATEs on node reparenting
@@ -26,7 +26,6 @@ closure_tree has some great features:
 * ```find_or_create_by_path``` for [building out hierarchies quickly and conveniently](#find_or_create_by_path)
 * Support for [deterministic ordering](#deterministic-ordering) of children
 * Support for [preordered](http://en.wikipedia.org/wiki/Tree_traversal#Pre-order) traversal of descendants
-* Support for single-select depth-limited [nested hashes](#nested-hashes)
 * Excellent [test coverage](#testing) in a variety of environments
 
 See [Bill Karwin](http://karwin.blogspot.com/)'s excellent
@@ -115,12 +114,6 @@ Child nodes are created by appending to the children collection:
 parent = grandparent.children.create(:name => 'Parent')
 ```
 
-Or by giving the parent to the constructor:
-
-```ruby
-child1 = Tag.create(:name => 'First Child', :parent => parent)
-```
-
 Or by appending to the children collection:
 
 ```ruby
@@ -250,6 +243,7 @@ When you include ```acts_as_tree``` in your model, you can provide a hash to ove
 * ```tag.depth``` returns the depth, or "generation", for this node in the tree. A root node will have a value of 0.
 * ```tag.parent``` returns the node's immediate parent. Root nodes will return nil.
 * ```tag.children``` is a ```has_many``` of immediate children (just those nodes whose parent is the current node).
+* ```tag.child_ids``` is an array of the IDs of the children.
 * ```tag.ancestors``` is a ordered scope of [ parent, grandparent, great grandparent, … ]. Note that the size of this array will always equal ```tag.depth```.
 * ```tag.ancestor_ids``` is an array of the IDs of the ancestors.
 * ```tag.self_and_ancestors``` returns a scope containing self, parent, grandparent, great grandparent, etc.
@@ -426,6 +420,16 @@ Parallelism is not tested with Rails 3.0.x nor 3.1.x due to this
 
 ## Change log
 
+### 3.9.0
+
+* Added ```.child_ids```.
+* Removed ```dependent => destroy``` on the descendant_hierarchy and ancestor_hierarchy collections
+  (they were a mistake).
+* Clarified documentation for creation and child associations.
+  Because ```Tag.create!(:parent => ...)``` requires a ```.reload```, I removed it as an example.
+
+All three of these improvements were suggested by Andrew Bromwich. Thanks!
+
 ### 3.8.2
 
 * find_by_path uses 1 SELECT now. BOOM.

data/lib/closure_tree/model.rb

@@ -27,8 +27,7 @@ module ClosureTree
       has_many :ancestor_hierarchies,
         :class_name => hierarchy_class_name,
         :foreign_key => "descendant_id",
-        :order => "#{quoted_hierarchy_table_name}.generations asc",
-        :dependent => :destroy
+        :order => "#{quoted_hierarchy_table_name}.generations asc"
 
       has_many :self_and_ancestors,
         :through => :ancestor_hierarchies,
@@ -38,8 +37,7 @@ module ClosureTree
       has_many :descendant_hierarchies,
         :class_name => hierarchy_class_name,
         :foreign_key => "ancestor_id",
-        :order => "#{quoted_hierarchy_table_name}.generations asc",
-        :dependent => :destroy
+        :order => "#{quoted_hierarchy_table_name}.generations asc"
       # TODO: FIXME: this collection currently ignores sort_order
       # (because the quoted_table_named would need to be joined in to get to the order column)
 
@@ -94,6 +92,10 @@ module ClosureTree
       self_and_ancestors.reverse.collect { |n| n.send to_s_column.to_sym }
     end
 
+    def child_ids
+      ids_from(children)
+    end
+
     def descendants
       without_self(self_and_descendants)
     end

data/lib/closure_tree/version.rb

@@ -1,3 +1,3 @@
 module ClosureTree
-  VERSION = "3.8.2" unless defined?(::ClosureTree::VERSION)
+  VERSION = "3.9.0" unless defined?(::ClosureTree::VERSION)
 end

data/spec/label_spec.rb

@@ -43,6 +43,19 @@ def create_preorder_tree
 end
 
 describe Label do
+
+  context "destruction" do
+    it "properly destroys descendents" do
+      c = Label.find_or_create_by_path %w(a b c)
+      b = c.parent
+      a = c.root
+      a.destroy
+      Label.exists?(a).should be_false
+      Label.exists?(b).should be_false
+      Label.exists?(c).should be_false
+    end
+  end
+
   context "Base Label class" do
     it "should find or create by path" do
       # class method:

data/spec/support/models.rb

@@ -44,7 +44,9 @@ end
 
 class Label < ActiveRecord::Base
   attr_accessible :name # < - make sure order doesn't matter
-  acts_as_tree :order => "sort_order", :parent_column_name => "mother_id"
+  acts_as_tree :order => "sort_order",
+    :parent_column_name => "mother_id",
+    :dependent => :destroy
 
   def to_s
     "#{self.class}: #{name}"

data/spec/tag_spec.rb

@@ -33,11 +33,19 @@ shared_examples_for "Tag (1)" do
     end
 
     context "2 tag db" do
+      before :each do
+        @root = Tag.create!(:name => "root")
+        @leaf = @root.add_child(Tag.create!(:name => "leaf"))
+      end
       it "should return a simple root and leaf" do
-        root = Tag.create!(:name => "root")
-        leaf = root.add_child(Tag.create!(:name => "leaf"))
-        Tag.roots.should == [root]
-        Tag.leaves.should == [leaf]
+        Tag.roots.should == [@root]
+        Tag.leaves.should == [@leaf]
+      end
+      it "should return child_ids for root" do
+        @root.child_ids.should == [@leaf.id]
+      end
+      it "should return an empty array for leaves" do
+        @leaf.child_ids.should be_empty
       end
     end
 
@@ -220,7 +228,6 @@ shared_examples_for "Tag (1)" do
       a.find_or_create_by_path(%w{b c}).ancestry_path.should == %w{a b c}
     end
   end
-
 end
 
 shared_examples_for "Tag (2)" do

data/spec/user_spec.rb

@@ -125,4 +125,12 @@ describe "empty db" do
     a.siblings.should be_empty
     b1.siblings.should =~ [b2, b3]
   end
+
+  it "properly nullifies descendents" do
+    c = User.find_or_create_by_path %w(a b c)
+    b = c.parent
+    c.root.destroy
+    b.reload.should be_root
+    b.child_ids.should == [c.id]
+  end
 end

metadata

@@ -1,215 +1,129 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: closure_tree
-version: !ruby/object:Gem::Version
-  version: 3.8.2
-  prerelease: 
+version: !ruby/object:Gem::Version 
+  version: 3.9.0
 platform: ruby
-authors:
+authors: 
 - Matthew McEachen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-03 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
+
+date: 2013-03-06 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: activerecord
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 3.0.0
   type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
         version: 3.0.0
-- !ruby/object:Gem::Dependency
+  version_requirements: *id001
+  prerelease: false
+- !ruby/object:Gem::Dependency 
   name: with_advisory_lock
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 0.0.6
   type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
+  requirement: &id002 !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
         version: 0.0.6
-- !ruby/object:Gem::Dependency
+  version_requirements: *id002
+  prerelease: false
+- !ruby/object:Gem::Dependency 
   name: rake
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   type: :development
+  requirement: &id003 !ruby/object:Gem::Requirement 
+    requirements: 
+    - &id004 
+      - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+  version_requirements: *id003
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+- !ruby/object:Gem::Dependency 
   name: yard
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   type: :development
+  requirement: &id005 !ruby/object:Gem::Requirement 
+    requirements: 
+    - *id004
+  version_requirements: *id005
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+- !ruby/object:Gem::Dependency 
   name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   type: :development
+  requirement: &id006 !ruby/object:Gem::Requirement 
+    requirements: 
+    - *id004
+  version_requirements: *id006
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+- !ruby/object:Gem::Dependency 
   name: rails
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   type: :development
+  requirement: &id007 !ruby/object:Gem::Requirement 
+    requirements: 
+    - *id004
+  version_requirements: *id007
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+- !ruby/object:Gem::Dependency 
   name: rspec-rails
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   type: :development
+  requirement: &id008 !ruby/object:Gem::Requirement 
+    requirements: 
+    - *id004
+  version_requirements: *id008
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+- !ruby/object:Gem::Dependency 
   name: mysql2
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   type: :development
+  requirement: &id009 !ruby/object:Gem::Requirement 
+    requirements: 
+    - *id004
+  version_requirements: *id009
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+- !ruby/object:Gem::Dependency 
   name: pg
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   type: :development
+  requirement: &id010 !ruby/object:Gem::Requirement 
+    requirements: 
+    - *id004
+  version_requirements: *id010
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+- !ruby/object:Gem::Dependency 
   name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   type: :development
+  requirement: &id011 !ruby/object:Gem::Requirement 
+    requirements: 
+    - *id004
+  version_requirements: *id011
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+- !ruby/object:Gem::Dependency 
   name: uuidtools
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   type: :development
+  requirement: &id012 !ruby/object:Gem::Requirement 
+    requirements: 
+    - *id004
+  version_requirements: *id012
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+- !ruby/object:Gem::Dependency 
   name: strong_parameters
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   type: :development
+  requirement: &id013 !ruby/object:Gem::Requirement 
+    requirements: 
+    - *id004
+  version_requirements: *id013
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Easily and efficiently make your ActiveRecord model support hierarchies
-email:
+email: 
 - matthew-github@mceachen.org
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - lib/closure_tree/acts_as_tree.rb
 - lib/closure_tree/columns.rb
 - lib/closure_tree/deterministic_ordering.rb
@@ -236,35 +150,28 @@ files:
 - spec/user_spec.rb
 homepage: http://matthew.mceachen.us/closure_tree
 licenses: []
+
+metadata: {}
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-      segments:
-      - 0
-      hash: 625197628069455012
-required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-      segments:
-      - 0
-      hash: 625197628069455012
+required_ruby_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - *id004
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - *id004
 requirements: []
+
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.0
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Easily and efficiently make your ActiveRecord model support hierarchies
-test_files:
+test_files: 
 - spec/cuisine_type_spec.rb
 - spec/db/database.yml
 - spec/db/schema.rb