closure_tree 3.6.1 → 3.6.2

data/README.md

@@ -5,9 +5,15 @@ Closure Tree is a mostly-API-compatible replacement for the
 [acts_as_tree](https://github.com/amerine/acts_as_tree) and
 [awesome_nested_set](https://github.com/collectiveidea/awesome_nested_set/) gems, giving you:
 
-* Much better mutation performance thanks to the Closure Tree storage algorithm
-* Very efficient select performance (again, thanks to Closure Tree)
-* Efficient subtree selects
+* Best-in-class select performance:
+  * Fetch your whole ancestor lineage in 1 SELECT.
+  * Grab all your descendants: 1 SELECT.
+  * Get all your siblings: 1 SELECT.
+  * Fetch all [7-degrees-of-bacon in a nested hash](#nested-hashes): 1 SELECT.
+* Best-in-class mutation performance:
+  * 2 SQL INSERTs on node creation
+  * 3 SQL INSERT/UPDATEs on node reparenting
+* Support for reparenting children (and all their progeny)
 * Support for polymorphism [STI](#sti) within the hierarchy
 * ```find_or_create_by_path``` for [building out hierarchies quickly and conveniently](#find_or_create_by_path)
 * Support for [deterministic ordering](#deterministic-ordering) of children
@@ -355,6 +361,11 @@ Closure tree is [tested under every combination](http://travis-ci.org/#!/mceache
 
 ## Change log
 
+### 3.6.2
+
+* Fixed [issue 23](https://github.com/mceachen/closure_tree/issues/23), which added support for ```#siblings```
+  when sort_order wasn't specified. Thanks, [garygreyling](https://github.com/garygreyling)!
+
 ### 3.6.1
 
 * Fixed [issue 20](https://github.com/mceachen/closure_tree/issues/20), which affected

data/lib/closure_tree/acts_as_tree.rb

@@ -182,7 +182,7 @@ module ClosureTree
 
     def self_and_siblings
       s = ct_base_class.where(parent_column_sym => parent)
-      quoted_order_column ? s.order(quoted_order_column) : s
+      order_option.present? ? s.order(quoted_order_column) : s
     end
 
     def siblings

data/lib/closure_tree/version.rb

@@ -1,3 +1,3 @@
 module ClosureTree
-  VERSION = "3.6.1" unless defined?(::ClosureTree::VERSION)
+  VERSION = "3.6.2" unless defined?(::ClosureTree::VERSION)
 end

data/spec/user_spec.rb

@@ -87,7 +87,6 @@ describe "empty db" do
     u.root.indirect_contracts.to_a.should =~ [c1, c2]
   end
 
-
   it "supports << on shallow unsaved hierarchies" do
     a = User.new(:email => "a")
     b = User.new(:email => "b")
@@ -116,4 +115,14 @@ describe "empty db" do
     User.leaves.should =~ [b1, c1, d]
     d.ancestry_path.should == %w(a b2 c2 d)
   end
+
+  it "supports siblings" do
+    User.order_option.should be_nil
+    a = User.create(:email => "a")
+    b1 = a.children.create(:email => "b1")
+    b2 = a.children.create(:email => "b2")
+    b3 = a.children.create(:email => "b3")
+    a.siblings.should be_empty
+    b1.siblings.should =~ [b2, b3]
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: closure_tree
 version: !ruby/object:Gem::Version
-  version: 3.6.1
+  version: 3.6.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-17 00:00:00.000000000 Z
+date: 2012-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -192,7 +192,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4291018222933120120
+      hash: -956461018663594337
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -201,7 +201,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4291018222933120120
+      hash: -956461018663594337
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23