closure_tree 3.3.0 → 3.3.1

data/README.md

@@ -317,6 +317,16 @@ Closure tree is [tested under every combination](https://secure.travis-ci.org/mc
 
 ## Change log
 
+### 3.3.1
+
+* Added support for partially-unsaved hierarchies [issue 13](https://github.com/mceachen/closure_tree/issues/13):
+```
+a = Tag.new(name: "a")
+b = Tag.new(name: "b")
+a.children << b
+a.save
+```
+
 ### 3.3.0
 
 * Added [```hash_tree```](#nested-hashes).

data/lib/closure_tree/acts_as_tree.rb

@@ -240,6 +240,8 @@ module ClosureTree
 
     def ct_after_save
       rebuild! if changes[parent_column_name] || @was_new_record
+      @was_new_record = false # we aren't new anymore.
+      true # don't cancel anything.
     end
 
     def rebuild!

data/lib/closure_tree/version.rb

@@ -1,3 +1,3 @@
 module ClosureTree
-  VERSION = "3.3.0" unless defined?(::ClosureTree::VERSION)
+  VERSION = "3.3.1" unless defined?(::ClosureTree::VERSION)
 end

data/spec/label_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
 def nuke_db
-  Label.delete_all
   LabelHierarchy.delete_all
+  Label.delete_all
 end
 
 describe Label do

data/spec/tag_spec.rb

@@ -4,8 +4,8 @@ shared_examples_for Tag do
   describe "empty db" do
 
     def nuke_db
-      Tag.delete_all
       TagHierarchy.delete_all
+      Tag.delete_all
     end
 
     before :each do
@@ -353,6 +353,24 @@ shared_examples_for Tag do
       city.self_and_ancestors.should == [city, tags(:california), tags(:united_states), tags(:places)]
     end
 
+    it "performs as the readme says it does" do
+      grandparent = Tag.create(:name => 'Grandparent')
+      parent = grandparent.children.create(:name => 'Parent')
+      child1 = Tag.create(:name => 'First Child')
+      parent.children << child1
+      child2 = Tag.create(:name => 'Second Child')
+      parent.add_child child2
+      grandparent.self_and_descendants.collect(&:name).should ==
+        ["Grandparent", "Parent", "First Child", "Second Child"]
+      child1.ancestry_path.should ==
+        ["Grandparent", "Parent", "First Child"]
+      d = Tag.find_or_create_by_path %w(a b c d)
+      h = Tag.find_or_create_by_path %w(e f g h)
+      e = h.root
+      d.add_child(e) # "d.children << e" would work too, of course
+      h.ancestry_path.should == %w(a b c d e f g h)
+    end
+
   end
 end
 

data/spec/user_spec.rb

@@ -3,8 +3,8 @@ require 'spec_helper'
 describe "empty db" do
 
   before :each do
-    User.delete_all
     ReferralHierarchy.delete_all
+    User.delete_all
   end
 
   context "empty db" do
@@ -87,21 +87,33 @@ describe "empty db" do
     u.root.indirect_contracts.to_a.should =~ [c1, c2]
   end
 
-  it "performs as the readme says it does" do
-    grandparent = Tag.create(:name => 'Grandparent')
-    parent = grandparent.children.create(:name => 'Parent')
-    child1 = Tag.create(:name => 'First Child')
-    parent.children << child1
-    child2 = Tag.create(:name => 'Second Child')
-    parent.add_child child2
-    grandparent.self_and_descendants.collect(&:name).should ==
-      ["Grandparent", "Parent", "First Child", "Second Child"]
-    child1.ancestry_path.should ==
-      ["Grandparent", "Parent", "First Child"]
-    d = Tag.find_or_create_by_path %w(a b c d)
-    h = Tag.find_or_create_by_path %w(e f g h)
-    e = h.root
-    d.add_child(e) # "d.children << e" would work too, of course
-    h.ancestry_path.should == %w(a b c d e f g h)
+
+  it "supports << on shallow unsaved hierarchies" do
+    a = User.new(:email => "a")
+    b = User.new(:email => "b")
+    a.children << b
+    a.save
+    User.roots.should == [a]
+    User.leaves.should == [b]
+    b.ancestry_path.should == %w(a b)
+  end
+
+  it "supports << on deep unsaved hierarchies" do
+    a = User.new(:email => "a")
+    b1 = User.new(:email => "b1")
+    a.children << b1
+    b2 = User.new(:email => "b2")
+    a.children << b2
+    c1 = User.new(:email => "c1")
+    b2.children << c1
+    c2 = User.new(:email => "c2")
+    b2.children << c2
+    d = User.new(:email => "d")
+    c2.children << d
+
+    a.save
+    User.roots.should == [a]
+    User.leaves.should == [b1, c1, d]
+    d.ancestry_path.should == %w(a b2 c2 d)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: closure_tree
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-22 00:00:00.000000000 Z
+date: 2012-08-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -193,7 +193,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1888023415669580942
+      hash: 2911561954531339982
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -202,7 +202,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1888023415669580942
+      hash: 2911561954531339982
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.21