closure-compiler 0.1.6 → 0.1.7

data/README.textile

@@ -1,6 +1,8 @@
 h1. The Closure Compiler (as a Ruby Gem)
 
-The *closure-compiler* gem is a super-thin wrapper around the "Google Closure Compiler":http://code.google.com/closure/compiler/ for JavaScript compression.
+The *closure-compiler* gem is a svelte wrapper around the "Google Closure Compiler":http://code.google.com/closure/compiler/ for JavaScript compression.
+
+Latest Version: *"0.1.7":http://gemcutter.org/gems/closure-compiler*
 
 The Closure Compiler's *2009-12-17* JAR-file is included with the gem, so you'll need *Java 6* installed in order to run the compiler.
 

data/closure-compiler.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name      = 'closure-compiler'
-  s.version   = '0.1.6'            # Keep version in sync with closure-compiler.rb
-  s.date      = '2010-1-18'
+  s.version   = '0.1.7'            # Keep version in sync with closure-compiler.rb
+  s.date      = '2010-1-23'
 
   s.homepage    = "http://github.com/documentcloud/closure-compiler/"
   s.summary     = "Ruby Wrapper for the Google Closure Compiler"
@@ -20,6 +20,8 @@ Gem::Specification.new do |s|
                          '--exclude'  << 'test' <<
                          '--all'
 
+  s.add_dependency 'popen4', ['>= 0.1.2']
+
   s.files = Dir['lib/**/*', 'vendor/**/*', 'closure-compiler.gemspec', 'README.textile', 'LICENSE', 'COPYING']
 
 end

data/lib/closure-compiler.rb

@@ -2,7 +2,7 @@ require File.expand_path(File.dirname(__FILE__) + '/closure/compiler')
 
 module Closure
 
-  VERSION           = "0.1.6"
+  VERSION           = "0.1.7"
 
   COMPILER_VERSION  = "20091217"
 

data/lib/closure/compiler.rb

@@ -1,8 +1,12 @@
-require 'open3'
+require 'rubygems'
+require 'popen4'
 require 'stringio'
 
 module Closure
 
+  # We raise a Closure::Error when compilation fails for any reason.
+  class Error < StandardError; end
+
   # The Closure::Compiler is a basic wrapper around the actual JAR. There's not
   # much to see here.
   class Compiler
@@ -18,7 +22,8 @@ module Closure
     # JavaScript as a string or yields an IO object containing the response to a
     # block, for streaming.
     def compile(io)
-      Open3.popen3(*command) do |stdin, stdout, stderr|
+      result, error = nil, nil
+      status = POpen4.popen4(*command) do |stdout, stderr, stdin, pid|
         if io.respond_to? :read
           while buffer = io.read(4096) do
             stdin.write(buffer)
@@ -27,8 +32,11 @@ module Closure
           stdin.write(io.to_s)
         end
         stdin.close
-        block_given? ? yield(stdout) : stdout.read
+        result = block_given? ? yield(stdout) : stdout.read
+        error = stderr.read
       end
+      raise Error, error unless status.success?
+      result
     end
     alias_method :compress, :compile
 
@@ -41,7 +49,7 @@ module Closure
     end
 
     def command
-      [@java, '-jar', @jar, @options].flatten
+      [@java, '-jar', @jar, @options].flatten.join(' ')
     end
 
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: closure-compiler
 version: !ruby/object:Gem::Version 
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors: 
 - Jeremy Ashkenas
@@ -9,10 +9,19 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-18 00:00:00 -05:00
+date: 2010-01-23 00:00:00 -05:00
 default_executable: 
-dependencies: []
-
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: popen4
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 0.1.2
+    version: 
 description: "    A Ruby Wrapper for the Google Closure Compiler.\n"
 email: jeremy@documentcloud.org
 executables: []