cliver 0.1.1 → 0.1.2

data/.travis.yml

@@ -0,0 +1,16 @@
+---
+language: ruby
+before_install: "gem install bundler"
+script: "bundle exec rake spec"
+rvm:
+  - 2.0.0
+  - 1.9.3
+  - jruby-19mode # JRuby in 1.9 mode
+  - rbx-19mode
+branches:
+  only:
+    - develop
+    - master
+    - /^release\/-.*$/
+    - /^support\/-.*$/
+    - /^hotfix\/-.*$/

data/README.md

@@ -54,6 +54,12 @@ end
 Since `Cliver` uses `Gem::Requirement` for version comparrisons, it obeys all
 the same rules including pre-release semantics.
 
+## Supported Platforms
+
+The goal is to have full support for all platforms running ruby >= 1.9.2,
+including rubinius and jruby implementations. Windows has support
+but is not available as a build target in [travis_ci][].
+
 ## See Also:
 
  - [YARD Documentation][yard-docs]
@@ -63,3 +69,4 @@ the same rules including pre-release semantics.
 
 [rubygems/requirements]: https://github.com/rubygems/rubygems/blob/master/lib/rubygems/requirement.rb
 [yard-docs]: http://yaauie.github.io/cliver/
+[travis-ci]: https://travis-ci.org/yaauie/cliver

data/lib/cliver/detector.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
-require 'open3'
+require 'shellwords'
 
 module Cliver
   # The interface for Cliver::Detector classes.
@@ -28,7 +28,9 @@ module Cliver
     # @param executable [String] - the path to the executable to test
     # @return [String] - should be Gem::Version-parsable.
     def detect_version(executable)
-      output, _ = Open3.capture2e(*version_command(executable))
+      command_parts = version_command(executable)
+      escaped_command_parts = command_parts.map(&Shellwords.method(:escape))
+      output = `#{escaped_command_parts.join(' ')} 2>&1`
       ver = output.scan(version_pattern)
       ver && ver.first
     end

data/lib/cliver/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 
 module Cliver
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/lib/cliver/which/posix.rb

@@ -1,6 +1,5 @@
 # encoding: utf-8
-
-require 'open3'
+require 'shellwords'
 
 module Cliver
   module Which
@@ -10,11 +9,12 @@ module Cliver
       # @param executable [String]
       # @return [nil,String] - path to found executable
       def which(executable)
-        # command -v is the POSIX-specified implementation behind which.
-        # http://pubs.opengroup.org/onlinepubs/009695299/utilities/command.html
-        which, status = Open3.capture2e('command', '-v', executable)
-        return nil unless status.success?
-        which.chomp
+        which = `which #{Shellwords.escape executable} 2>&1`
+        executable_path = which.chomp
+        return nil if executable_path.empty?
+        executable_path
+      rescue Errno::ENOENT
+        raise '"which" must be on your path to use Cliver on this system.'
       end
     end
   end

data/lib/cliver/which/windows.rb

@@ -1,6 +1,5 @@
 # encoding: utf-8
-
-require 'open3'
+require 'shellwords'
 
 module Cliver
   module Which
@@ -12,11 +11,13 @@ module Cliver
       def which(executable)
         # `where` returns newline-separated files found on path, but doesn't
         # ensure that they are executable as commands.
-        where, _ = Open3.capture2e('where', executable)
+        where = `where #{Shellwords.escape executable} 2>&1`
         where.split("\n").find do |found|
           next if found.empty?
           File.executable?(found)
         end
+      rescue Errno::ENOENT
+        raise '"where" must be on your path to use Cliver on Windows.'
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cliver
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -116,6 +116,7 @@ extra_rdoc_files: []
 files:
 - .githooks/pre-commit/ruby-appraiser
 - .gitignore
+- .travis.yml
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt