clinch-talent 0.2 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3c91e6dc9be2c4c9b4a1e419160f7c365b3474812765a7a0948dad810565d52d
-  data.tar.gz: 7f41ff0f51fc0dfdae028a77ac8e0f79c07c1e7f9361d315249bfe60af814ada
+  metadata.gz: 231b908831adf498b598d6eef29152e51e4764ce109c01615b3d59b27cbeede1
+  data.tar.gz: 0ccf8a2b09778626d1ed884b417d4cb32c3f28227eddf4ef992bf56921f0c128
 SHA512:
-  metadata.gz: dee36046767ca1069f7d0a1b2ce452923dee4e854e0bab187755158b4717abf0613c8464890fcfbdda0a76a5ac124e729020a9f30bfbe4dceeb62e072e795a14
-  data.tar.gz: 0d1c72e1a4bf4d20a4d80bca2aed4c3db2b1c725096c31df8759115515dd6c538ccf54a151b34851ce173b19f4acaa1ebb82a09382c0fe9e43834beabd8ef8b2
+  metadata.gz: cf868b3ef0822074f3ee5e287dcc31ec2442c6f8fe8efe45d1b499c3774a961b8ed832d24ea3df62dd3f1f657e1435b270114f514310fac42ae6a1a5e668d26a
+  data.tar.gz: d411d3a6e4d0d1c07182cc69a2eb54f2470375076f854bee96216ee0b2e8f0905f5999437f0f5d6066e02acbb834eb3647a1b183f155977256397dbd832e852e

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    clinch-talent (0.2)
+    clinch-talent (0.2.1)
       json_api_client (~> 1.5)
 
 GEM

data/clinch-talent.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'clinch-talent'
-  s.version     = '0.2'
+  s.version     = '0.2.1'
   s.summary     = 'A ruby client for the Clinch Talent API'
   s.description = 'A ruby client for the Clinch Talent API. Requests are HMAC signed. Responses are in JSON API format (https://jsonapi.org). See https://support.clinchtalent.com/article/77-getting-started'
   s.authors     = ['Damien Glancy', 'Steve Quinlan']

data/lib/clinch_talent/hmac_signing_middleware.rb

@@ -12,32 +12,11 @@ module ClinchTalent
       env.request_headers['Authorization'] = "APIAuth #{@options[:access_id]}:#{hmac_signature(env, @options[:secret])}"
       @app.call(env)
     end
-private
-    def calculated_md5(env)
-      # if env.request.body
-      #   body = env.request.body
-      # else
-      #  body = ''
-      # end
-      #excluding the body as part of the md5'ing
-      md5_base64digest('')
-    end
 
-    def md5_base64digest(string)
-      if Digest::MD5.respond_to?(:base64digest)
-        Digest::MD5.base64digest(string)
-      else
-        b64_encode(Digest::MD5.digest(string))
-      end
-    end
+    private
 
-    def b64_encode(string)
-      if Base64.respond_to?(:strict_encode64)
-        Base64.strict_encode64(string)
-      else
-        # Fall back to stripping out newlines on Ruby 1.8.
-        Base64.encode64(string).gsub(/\n/, '')
-      end
+    def calculated_md5(env)
+      Digest::MD5.base64digest(env.body || '')
     end
 
     def fetch_headers(env)
@@ -46,21 +25,21 @@ private
 
     def capitalize_keys(hsh)
       capitalized_hash = {}
-      hsh.each_pair {|k,v| capitalized_hash[k.to_s.upcase] = v }
+      hsh.each_pair {|k, v| capitalized_hash[k.to_s.upcase] = v}
       capitalized_hash
     end
 
     def hmac_signature(env, secret_key)
       canonical_string = canonical_string(env)
       digest = OpenSSL::Digest.new('sha1')
-      b64_encode(OpenSSL::HMAC.digest(digest, secret_key, canonical_string))
+      Base64.strict_encode64(OpenSSL::HMAC.digest(digest, secret_key, canonical_string))
     end
 
     def canonical_string(env)
-      [ content_type(env),
-        content_md5(env),
-        parse_uri(env.url.to_s),
-        timestamp(env)
+      [content_type(env),
+       content_md5(env),
+       parse_uri(env.url.to_s),
+       timestamp(env)
       ].join(',')
     end
 
@@ -80,7 +59,7 @@ private
     end
 
     def find_header(env, keys)
-      keys.map {|key| env.request_headers[key] }.compact.first
+      keys.map {|key| env.request_headers[key]}.compact.first
     end
 
     def parse_uri(uri)

data/test/clinch_talent/candidate_test.rb

@@ -2,11 +2,11 @@ require_relative '../test_helper'
 
 module ClinchTalent
   class CandidateTest < Minitest::Test
-    def test_signing
+    def setup
       Time.stubs(:now).returns(Time.new(2014, 01, 01, 01, 01, 01))
+    end
 
-      # Having problem stubbing the body response, so not doing this now
-
+    def test_get_signing
       stub_request(:get, 'https://api.clinchtalent.com/v1/candidates').
         with(:headers => {'Accept' => 'application/vnd.api+json',
                           'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
@@ -18,5 +18,40 @@ module ClinchTalent
       ClinchTalent::Base.config('access_id', 'secret')
       ClinchTalent::Candidate.all
     end
+
+    def test_post_signing
+      stub_request(:post, "https://api.clinchtalent.com/v1/candidates").
+        with(
+          body: "{\"data\":{\"type\":\"candidates\",\"attributes\":{\"first_name\":\"Steve\",\"last_name\":\"Jobs\",\"email\":\"steve.jobs@example.com\"}}}",
+          headers: {
+            'Accept' => 'application/vnd.api+json',
+            'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+            'Authorization' => 'APIAuth access_id:GpqVWbyL6re9hA4PVFciK9JGXtE=',
+            'Content-Md5' => 'BHelHgS90QHICtQEYCK1CA==',
+            'Content-Type' => 'application/vnd.api+json',
+            'Date' => 'Wed, 01 Jan 2014 01:01:01 GMT',
+            'User-Agent' => 'Faraday v0.15.2'
+          }).
+        to_return(status: 200, body: "", headers: {})
+
+      ClinchTalent::Base.config('access_id', 'secret')
+      ClinchTalent::Candidate.create("first_name": "Steve", "last_name": "Jobs", "email": "steve.jobs@example.com")
+    end
+
+    def test_post_signing_no_body
+      stub_request(:post, "https://api.clinchtalent.com/v1/candidates").
+        with(:body => "{\"data\":{\"type\":\"candidates\",\"attributes\":{}}}",
+             :headers => {'Accept'=>'application/vnd.api+json', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+                          'Authorization'=>'APIAuth access_id:P9RDanGcxbHK/aWLPC/T6Eitplc=',
+                          'Content-Md5'=>'hy9ALXrYXtG7YZXuVdXzjA==',
+                          'Content-Type'=>'application/vnd.api+json',
+                          'Date'=>'Wed, 01 Jan 2014 01:01:01 GMT',
+                          'User-Agent'=>'Faraday v0.15.2'}).
+        to_return(:status => 200, :body => "", :headers => {})
+
+      ClinchTalent::Base.config('access_id', 'secret')
+      ClinchTalent::Candidate.create
+    end
+
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: clinch-talent
 version: !ruby/object:Gem::Version
-  version: '0.2'
+  version: 0.2.1
 platform: ruby
 authors:
 - Damien Glancy