client_authenticator 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5e4428f1bb86beaa8e564058808065147864c854
-  data.tar.gz: f44ce71992a1839af175abeb7f42e1844650ac2b
+  metadata.gz: 2fc9b51913b6cd5ffd49892766c365909bf8dbeb
+  data.tar.gz: ed240716c5b7e7998f79ec736058a91ba8dbd5fa
 SHA512:
-  metadata.gz: 2647045f499caf50754429913d90bb63d22567847400e40b696b2b95186b75f05116f50f1871512ab390cef44595600e00ba33e7a0d4c867040c1204583b0735
-  data.tar.gz: c95736663a89cc03ddf72eab7758c04af18e66ed6739efe3339f71797311d73c2c905199fefc484d16cc8798b2f513f09f706884fbb192b61724729e45bebf73
+  metadata.gz: ec186fb050688ccc32d3fd350cbebc3025cad2e8a87c1c79601569ef7945863eb8ede6ccc4aa1645ea79e6714f2fb37386084b566556394089a0c48e2a9ffbac
+  data.tar.gz: a43323c521ef2e409c9bfb188a145e388eae599580b5feff07975be242027f5d5b6912e0e7c647da3862d8270f46a40865f28ca5a4444af5f5d9bbbb86097eec

data/.travis.yml

@@ -1,4 +1 @@
 language: ruby
-deploy:
-  provider: rubygems
-  gemspec: client_authenticator.gemspec

data/Gemfile

@@ -5,4 +5,6 @@ gemspec
 
 group :test do
   gem 'pry'
+  gem 'simplecov'
+  gem 'rubocop'
 end

data/README.md

@@ -1,4 +1,7 @@
-# ClientAuthenticator
+# Client Authenticator
+[![Build Status](https://travis-ci.org/gojek-engineering/client-authenticator-rb.svg?branch=master)](https://travis-ci.org/gojek-engineering/client-authenticator-rb)
+
+A gem to authenticate your service clients via headers `client-id, pass-key` before processing api requests.
 
 ## Installation
 
@@ -12,7 +15,7 @@ And then execute:
 
 Or install it yourself as:
 
-    $ gem install client_authenticatore
+    $ gem install client_authenticator
 
 ## Usage
 

data/client_authenticator.gemspec

@@ -20,8 +20,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "rspec-rails"
-  spec.add_development_dependency "factory_girl_rails"
-  spec.add_development_dependency "shoulda-matchers"
   spec.add_development_dependency "activerecord"
   spec.add_development_dependency "generator_spec"
 end

data/lib/client_authenticator/api_authenticable.rb

@@ -7,9 +7,17 @@ module ClientAuthenticator
     def authenticate_client!
       client_id = request.headers['client-id']
       pass_key = request.headers['pass-key']
-      if client_id.nil? || pass_key.nil? || (not ApiClient.authenticated?(client_id, pass_key))
+      if client_id.nil? || pass_key.nil? || unauthorized?(client_id, pass_key)
         render json: {'error' => 'unauthorized'}, status: :unauthorized
       end
     end
+
+    def unauthorized?(client_id, pass_key)
+      ttl = ClientAuthenticator.configuration.cache_expiry_duration
+      Rails.cache.fetch("#{client_id}_#{pass_key}", expires_in: ttl) do
+        not ApiClient.authenticated?(client_id, pass_key)
+      end
+    end
+
   end
 end

data/lib/client_authenticator/configuration.rb

@@ -5,9 +5,10 @@ module ClientAuthenticator
       @table_name = 'whitelisted_clients'
       @client_id_field = 'client_id'
       @password_field = 'pass_key'
+      @cache_expiry_duration = 12.hours
     end
 
-    attr_accessor :table_name, :client_id_field, :password_field
+    attr_accessor :table_name, :client_id_field, :password_field, :cache_expiry_duration
   end
 
   def self.configuration

data/lib/client_authenticator/version.rb

@@ -1,3 +1,3 @@
 module ClientAuthenticator
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/spec/client_authenticator_spec.rb

@@ -19,16 +19,25 @@ RSpec.describe ClientAuthenticator do
   end
 
   context 'client authentication' do
-    let(:client_id) { 'clientid' }
-    let(:pass_key) { 'pass_key' }
+    let!(:client_id) { 'clientid' }
+    let!(:pass_key) { 'pass_key' }
     let(:header) { {'client-id': client_id, 'pass-key': pass_key}.with_indifferent_access }
     let(:request) { Request.new(header) }
     let(:auth) { auth = Authorizer.new
                  auth.request = request
                  auth
     }
+    let(:cache) { double('cache') }
+
 
     context 'when client id and pass key is sent' do
+    before(:each) do
+      expect(Rails).to receive(:cache) { cache }
+      expect(cache).to receive(:fetch).with("#{client_id}_#{pass_key}", { expires_in: 12.hours}) do |&block|
+        block.call
+      end
+    end
+
       it 'when authorised, should not render 401' do
         expect(ClientAuthenticator::ApiClient).to receive(:authenticated?).with(client_id, pass_key).and_return(true)
         expect(auth).not_to receive(:render)

data/spec/spec_helper.rb

@@ -1,3 +1,7 @@
+require 'simplecov'
+SimpleCov.start
+SimpleCov.minimum_coverage 88
+
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 require 'generator_spec'
 require 'client_authenticator'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: client_authenticator
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - manoharakshetty
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-08 00:00:00.000000000 Z
+date: 2017-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -67,34 +67,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: factory_girl_rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: shoulda-matchers
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement