click_and_send 0.2.1 → 0.2.2

data/lib/click_and_send/errors.rb

@@ -1,6 +1,7 @@
 module ClickAndSend::Errors
-  class APIError < StandardError; end
-  class InvalidConfiguration < StandardError; end
-  class InvalidInput < StandardError; end
-  class NotImplemented < StandardError; end
+  APIError = Class.new(StandardError)
+  InvalidConfiguration = Class.new(StandardError)
+  InvalidInput = Class.new(StandardError)
+  NotImplemented = Class.new(StandardError)
+  UnhandledResponse = Class.new(StandardError)
 end

data/lib/click_and_send/request.rb

@@ -98,8 +98,17 @@ module ClickAndSend
         raw = request.to_hash[key(:response)][key(:response)]
         result = Nori.parse(raw)
         result.fetch(key(:answer))
-      rescue IndexError => e
-        raise
+      rescue StandardError => e
+        message = <<-EOS.strip.gsub(/\n +/, "\n")
+        #{e.class} #{e.message}
+        
+        raw response:
+        #{raw}
+        
+        result:
+        #{result}
+        EOS
+        raise(ClickAndSend::Errors::UnhandledResponse, message)
       end
     end
 

data/lib/click_and_send/version.rb

@@ -1,3 +1,3 @@
 module ClickAndSend
-  VERSION = '0.2.1'
+  VERSION = '0.2.2'
 end

data/spec/click_and_send/request_spec.rb

@@ -82,14 +82,17 @@ describe ClickAndSend::Request do
 
     context "keys undefined" do
       it "raises NotImplemented" do
-        expect { subject }.to raise_error(ClickAndSend::Errors::NotImplemented)
+        expect { subject }.to raise_error { |e| # warning: do..end block gives false positive
+          e.should be_a(ClickAndSend::Errors::UnhandledResponse)
+          e.message.should include('ClickAndSend::Errors::NotImplemented')
+        }
       end
     end
 
     context "missing key" do
       before { klass.send(:define_method, :keys) { {} } }
       it "raises KeyError" do
-        expect { subject }.to raise_error { |e| %w(IndexError KeyError).should include(e.class.name) }
+        expect { subject }.to raise_error(ClickAndSend::Errors::UnhandledResponse)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: click_and_send
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-04 00:00:00.000000000 Z
+date: 2012-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -178,7 +178,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2996821537768733287
+      hash: 3744272376626061336
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -187,7 +187,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2996821537768733287
+      hash: 3744272376626061336
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24