clearance 2.9.1 → 2.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b3164482da14d878bfca32632ebbabf81635add8143adaca1be3baa7ec41cd83
-  data.tar.gz: 037f0f5a5c30f3022b0d29a9c100e40538c0b176b4935c061ec96c469d8c3ca9
+  metadata.gz: d073db2741ab71668d850e8dbaf90ca72b53e3e5a89d3f559b81f8f134e97f21
+  data.tar.gz: 040fa25f6c685961366b26c9ea6a5889885aee3e17969459aa902db2355160c8
 SHA512:
-  metadata.gz: 5b889666cb2a46f6bfdcf41b9aaf9c7f0414b986f07ab4f31bb4846d3b4ef900f3d6076d50d9f8463657033488b118472d9e8dace8c4786aadd0f2999f5b2bed
-  data.tar.gz: 0fbc755f11f689843852ef18201963d0d56be06b8bf22326e82d2c83162d092ade4af85dfff3469867e0cf3937f545351a84b83425094cfb064d3466c361dd7c
+  metadata.gz: cc224586b281768a92734b9d56eaedb0788de1b894f5fbaebff4d7eb0414cfcfb90286db50206bb060fad8ec26cd9aabd9f8f8dff94253832e6b9576c86347d7
+  data.tar.gz: 279be8bc4d4d5024dd14103de0d9feac00b483364200b4cf0edda9b2a9098360f0ba8a19d9b6fe590200463d7458e291d7980a59a618628fc7b1c72d98b8e001

data/CHANGELOG.md

@@ -5,11 +5,18 @@ complete changelog, see the git history for each version via the version links.
 
 ## [Unreleased]
 
-[Unreleased]: https://github.com/thoughtbot/clearance/compare/v2.9.1...main
+[Unreleased]: https://github.com/thoughtbot/clearance/compare/v2.9.2...main
+
+## [2.9.2] - November 14, 2024
+- Fix query params being clobbered by Clearance::BackDoor (#1041) Frederick Cheung
+
+[2.9.2]: https://github.com/thoughtbot/clearance/compare/v2.9.1...v2.9.2
 
 ## [2.9.1] - October 29, 2024
  - Update gemspec
 
+[2.9.1]: https://github.com/thoughtbot/clearance/compare/v2.9.0...v2.9.1
+
 ## [2.9.0] - October 29, 2024
 - Added Rails 7.2 and Ruby 3.3 to testing matrix
   and overhauled dummy app (#1032) Hamed Asghari

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    clearance (2.9.1)
+    clearance (2.9.2)
       actionmailer (>= 5.0)
       activemodel (>= 5.0)
       activerecord (>= 5.0)

data/lib/clearance/back_door.rb

@@ -54,7 +54,6 @@ module Clearance
       if user_param.present?
         query_string = Rack::Utils.build_query(params)
         env[Rack::QUERY_STRING] = query_string
-        env[Rack::RACK_REQUEST_QUERY_STRING] = query_string
         user = find_user(user_param)
         env[:clearance].sign_in(user)
       end

data/lib/clearance/version.rb

@@ -1,3 +1,3 @@
 module Clearance
-  VERSION = "2.9.1".freeze
+  VERSION = "2.9.2".freeze
 end

data/spec/dummy/app/controllers/application_controller.rb

@@ -2,6 +2,6 @@ class ApplicationController < ActionController::Base
   include Clearance::Controller
 
   def show
-    render inline: "Hello user #<%= current_user.id %>", layout: false
+    render inline: "Hello user #<%= current_user.id %> #{params.to_json}", layout: false
   end
 end

data/spec/requests/backdoor_spec.rb

@@ -8,4 +8,12 @@ describe "Backdoor Middleware" do
 
     expect(cookies["remember_token"]).to eq user.remember_token
   end
+
+  it "removes the `as` param but leaves other parameters unchanged" do
+    user = create(:user)
+
+    get root_path(as: user.to_param, foo: 'bar')
+
+    expect(response.body).to include('{"foo":"bar","controller":"application","action":"show"}')
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: clearance
 version: !ruby/object:Gem::Version
-  version: 2.9.1
+  version: 2.9.2
 platform: ruby
 authors:
 - Dan Croak
@@ -27,7 +27,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-29 00:00:00.000000000 Z
+date: 2024-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bcrypt