classifieds_cli_app 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 01be9206924ea8e879c3236c148e9c2d6a339ae5
-  data.tar.gz: 3588d77e9d44be47a69d3fb05ecf11da97624cd7
+  metadata.gz: c16f45478a5a574ffad8f21da75ab3c5d82be2ac
+  data.tar.gz: 33cb3156c226ffec9ccee433077c0f80a61758bc
 SHA512:
-  metadata.gz: d499692bde2dc07c237c0e4ac450755d848e7fcf935e0e9b8d962bae5c3c6114f87a6e9f41b08b11b08d97909e4316abd835acc4e956f556107e3d2ebe425c40
-  data.tar.gz: 158f1ba26b7b52697104b73e80203782849ef4658177687b618f42ce464aa39bfde9a55a975e6be66ca967ba83586e0b35c69d4a5d33683ed1bd6eac15cad71c
+  metadata.gz: 7295e6ab313b0d86a611a3e0c43c140df3526bfd48b6411b2fb9ce1b40a0090b9cb0924c515cf17338dc51a20a541e3d85e8426efbff6df2a86e938162528efa
+  data.tar.gz: b653a96f8ae4be2341ac1979e08ec111d1798397e6a1b1909193f83904331bb9feefb0da345cf44b1d56d2e814b59dc7bd72ad05c4cdcaea5b2a17b65a8f30ad

data/README.md

@@ -3,6 +3,10 @@
 Display classified ads from the current online edition of Newsday.com and BoatTrader.com.
 This gem was created to meet the requirements of the learn.co CLI Data Gem Project.
 
+  0.1.1  Initial release.
+  0.1.2  Improved column display formatting.
+  0.1.3  Improved use of Nokogiri methods.
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -13,15 +17,15 @@ gem 'classifieds-cli-app'
 
 And then execute:
 
-    $ bundle
+  `$ bundle`
 
 Or install it yourself as:
 
-    $ gem install classifieds-cli-app
+  `$ gem install classifieds-cli-app`
 
 ## Usage
 
-$ classifieds
+  `$ classifieds`
 
 ## Development
 

data/lib/classifieds/auto_scraper.rb

@@ -9,12 +9,12 @@ class Classifieds::AutoScraper  # converts automobile classified listings into o
       id = listing_id(result)
       title_parts = title_parts(result)  # => [year, make, model]
 
-      description_pod_div = result.css('.aiDescriptionPod')
+      description_pod_div = result.at_css('.aiDescriptionPod')
       start_date = start_date(description_pod_div)
       mileage = mileage(description_pod_div)
       sale_price = sale_price(description_pod_div)
 
-      contact_div = result.css('.contactLinks')
+      contact_div = result.at_css('.contactLinks')
       seller_name = seller_name(contact_div)
       seller_location = seller_location(contact_div)
       seller_phone = seller_phone(contact_div, id, results_url_file)
@@ -31,14 +31,14 @@ class Classifieds::AutoScraper  # converts automobile classified listings into o
   # Returns detail attributes and values in detail_values hash
   def self.scrape_results_detail_page(detail_doc, item_condition, detail_values)
     # Create some entries manually.
-    detail_values['Description'.to_sym] = detail_doc.css('.aiDetailsDescription')[0].children[2].text.strip  # Description must be first attribute.
+    detail_values['Description'.to_sym] = detail_doc.at_css('.aiDetailsDescription h2').next.text.strip  # Description must be first attribute.
     detail_values['Condition'.to_sym] = item_condition
     detail_values['Certified'.to_sym] = ''
     # Create the rest from scraping the html's detail attrribute/value table.
     detail_cells = detail_cells(detail_doc)
     index = 0
     while index < detail_cells.size
-      if ("\u00A0" == detail_cells[index].text)  && ('aiCPOiconDetail' == detail_cells[index].children[0].attributes['class'].content)
+      if ("\u00A0" == detail_cells[index].text) && detail_cells[index].at_css('span.aiCPOiconDetail')
         detail_values[:Certified] = 'Yes' # The table row containing attribute Certified Icon does not have a value column.
         index += 1
       else  # Grab the attribute and value from the html table.
@@ -66,43 +66,43 @@ private
   # Returns a summary record's detail page url
   def self.detail_url(url, doc)  # detail link is given as relative to the summary page's domain
     uri = URI.parse(url)
-    "#{uri.scheme}://#{uri.host}#{doc.css('.aiResultTitle h3 a')[0]['href']}"
+    "#{uri.scheme}://#{uri.host}#{doc.at_css('.aiResultTitle h3 a')['href']}"
   end
 
   # Returns the listing's id
   def self.listing_id(doc)  # e.g. from "aiResultsMainDiv547967889"
-    doc.css('.aiResultsMainDiv')[0]['id'].match(/\d+/).to_s
+    doc.at_css('.aiResultsMainDiv')['id'].match(/\d+/).to_s
   end
 
   # Returns the listing's mileage value
   def self.mileage(doc)
-    value = doc.css('.listingType').text  # e.g. 'Mileage: xx,xxx'
+    value = doc.at_css('.listingType').text  # e.g. 'Mileage: xx,xxx'
     (value.include? 'Available') ? 'NA' : value.match(/Mileage: (\d*,{,1}\d+)/)[1]
   end
 
   # Returns the listing's sale price
   def self.sale_price(doc)
-    value = doc.css('.price').text
+    value = doc.at_css('.price').text
     (value.include? 'Call') ? 'Call' : value
   end
 
   # Returns the seller's address
   def self.seller_location(doc)
-    doc.css('strong')[1].text.strip
+    doc.at_css('strong')[1].text.strip
   end
 
   # Returns the seller's name
   def self.seller_name(doc)
-    doc.css('strong')[0].text.strip
+    doc.at_css('strong')[0].text.strip
   end
 
   PHONE_PATTERN = '\(\d\d\d\) \d\d\d-\d\d\d\d'
 
   # Returns the seller's phone number, if it exists
   def self.seller_phone(doc, id, url_file)
-    span = doc.css('span')
-    if 1 < span.size
-      match_data = span[0].text.match(/#{PHONE_PATTERN}/)
+    span = doc.at_css('span')
+    if span
+      match_data = span.text.match(/#{PHONE_PATTERN}/)
       match_data ? match_data.to_s : ''
     else
       seller_phone_private(url_file, id)
@@ -118,12 +118,12 @@ private
 
   # Returns listing start date
   def self.start_date(doc)
-    doc.css('.listingDate').text
+    doc.at_css('.listingDate').text
   end
 
   # Returns the summary listing's title
   def self.title(doc)
-    doc.css('.aiResultTitle h3').text  # '2010 Ford Explorer XL'
+    doc.at_css('.aiResultTitle h3').text  # '2010 Ford Explorer XL'
   end
 
   # Returns the year, make, and model from the title string

data/lib/classifieds/boat_scraper.rb

@@ -9,7 +9,7 @@ class Classifieds::BoatScraper  # converts Boattrader.com power boat classified
       id = listing_id(result)
       next if id.nil?
 
-      descr_div = result.css('.description')
+      descr_div = result.at_css('.description')
       title_parts = split_title(descr_div)  # => [year, make, model]
       start_date = ''  # Listing start_date currently not available from web page.
       sale_price = sale_price(descr_div)
@@ -53,14 +53,14 @@ private
   # Returns a summary record's detail page url
   def self.detail_url(url, doc)  # detail link is given as relative to the summary page's domain
     uri = URI.parse(url)
-    "#{uri.scheme}://#{uri.host}#{doc.css('.inner a')[0]['href']}"
+    "#{uri.scheme}://#{uri.host}#{doc.at_css('.inner a')['href']}"
   end
 
   # Returns detail attributes and values in detail_values hash
   def self.do_alt_processing(doc, item_condition, detail_values)
     # Create some entries manually.
-    main_content = doc.css('#main-content')
-    detail_values['Description'.to_sym] = main_content.css('p').text.strip  # Description must be first attribute.
+    main_content = doc.at_css('#main-content')
+    detail_values['Description'.to_sym] = main_content.at_css('p').text.strip  # Description must be first attribute.
     detail_values['Condition'.to_sym] = item_condition
 
     # Create the rest from scraping the html's detail attrribute/value table.
@@ -80,7 +80,7 @@ private
   # Returns detail attributes and values in detail_values hash
   def self.do_normal_processing(doc, boat_doc, item_condition, detail_values)
     # Create some entries manually.
-    detail_values['Description'.to_sym] = doc.css('#main-details').text.strip
+    detail_values['Description'.to_sym] = doc.at_css('#main-details').text.strip
     detail_values['Condition'.to_sym] = item_condition
 
     # Create the rest from scraping the html's detail attrribute/value table.
@@ -95,7 +95,7 @@ private
           process_detail_list_alt(dl_tag, detail_values)
         else
           attribute = attribute_tag.text.chomp(':')
-          value_tag = detail_cells[index].children[3]
+          value_tag = detail_cells[index].at_css('td')
 
           if value_tag
             text_value = (attribute == 'Owner Video' ? 'Yes' : value_tag.text)  # substitute Yes for the video link.
@@ -107,7 +107,7 @@ private
       end
     }
 
-    detail_values['Phone'.to_sym] = doc.css('.phone').text  # NOTE: keep phone number last in list for display consistency.
+    detail_values['Phone'.to_sym] = doc.at_css('.phone').text  # NOTE: keep phone number last in list for display consistency.
   end
 
   # Returns the listing's id. If the listing doesn't have an id, it's not really a listing.
@@ -148,25 +148,25 @@ private
 
   # Returns the listing's sale price
   def self.sale_price(doc)
-    value = doc.css('.price .data').text
-    value != '' ? value : doc.css('.price .txt')[0].children[1].text
+    value = doc.at_css('.price .data')
+    value ? value.text : doc.at_css('.price .txt').children[1].text
   end
 
   # Returns the seller's address
   def self.seller_location(doc)
-    value = doc.css('.location .data').text
-    value != '' ? value : doc.css('.location .txt')[0].children[1].text
+    value = doc.at_css('.location .data')
+    value ? value.text : doc.at_css('.location .txt').children[1].text
   end
 
   # Returns the seller's name
   def self.seller_name(doc)
-    value = doc.css('.offered-by .data').text
-    value != '' ? value : doc.css('.offered-by .txt')[0].children[1].text
+    value = doc.at_css('.offered-by .data')
+    value ? value.text : doc.at_css('.offered-by .txt').children[1].text
   end
 
   # Returns the Seller's phone number
   def self.seller_phone(doc)
-    phone = doc.css('.seller-info .phone').text
+    phone = doc.at_css('.seller-info .phone').text
     phone.reverse!  # alt listing phone has css format 'direction: rtl'
     phone[0] = '('; phone[4] = ')'
     phone
@@ -185,6 +185,6 @@ private
 
   # Returns the summary listing's title
   def self.title(doc)
-    doc.css('.name').text  # '2000 JASON 25 Downeaster' (also Grady White, Grady-White, Sea Ray, ...)
+    doc.at_css('.name').text  # '2000 JASON 25 Downeaster' (also Grady White, Grady-White, Sea Ray, ...)
   end
 end

data/lib/classifieds/version.rb

@@ -1,3 +1,3 @@
 module Classifieds
-    VERSION = "0.1.2"
+    VERSION = "0.1.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: classifieds_cli_app
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - John Pfingst