clamby 1.2.5 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b01112eed29677aba4c41681568068a07d1fd44f
-  data.tar.gz: ea48a1a4470c40bcdc5e5d19ccda1c3013f711a5
+  metadata.gz: edb162206fdfb7dde77a731db954904ff0820e83
+  data.tar.gz: '069980cc92fa7a0fafa00023bdb8c1b7149c1515'
 SHA512:
-  metadata.gz: fa1d122187e6860f951be981e45fddc4cc7ba816228f4b0665954595f90a93653b205f24099e6a0df5aae99c79234337f1f89126cb770d607576ece7890c5d0d
-  data.tar.gz: 330b3bea8825e486404436c55e0b18ba4848673aa5e19e6f6b0fc75a62ce05d056db0d28ab3fc8d52ec2c99cb69dc6ae393a7dccf07949234b4b32ee55b90a95
+  metadata.gz: 4ae23ce1f09e0459784dfe12d69a3abaff9baaa871cd53649ecfc2e3d6394d14594286201f51710d043f68e35f29fed522a788d6b75993900c1a594c861d6ed8
+  data.tar.gz: 3f196f2bf45fcec04813d7e923d665d97c7e5ffbdd9c205afb75d3ac7b3048c395effdeeb75154200aaf9b2857cf3c088215a1963b3adfd5a60dd2e05710f14e

data/.travis.yml

@@ -4,9 +4,10 @@ before_install:
   - gem install rake
   - gem install rspec
 rvm:
-  - 1.9.3
   - 2.0.0
   - 2.1.1
+  - 2.3.4
+  - 2.4.1
 install: 
  - sudo apt-get install clamav
  - sudo freshclam

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+#v1.3.0
+ - Fixed Dangerous Send on `system_command` method
+
 #v1.2.5
  - [bess](https://github.com/kobaltz/clamby/commits/master?author=bess) added `fdpass` option
 

data/lib/clamby.rb

@@ -27,17 +27,19 @@ module Clamby
   # @param [String] path path to the file being scanned
   # @return [String] command to be executed
   def self.system_command(path)
-    command = clamd_executable_name
-    command += ' --fdpass' if @config[:fdpass]
-    command += " #{path}"
-    command += ' --no-summary'
+    command = [].tap do |cmd|
+      cmd << clamd_executable_name
+      cmd << '--fdpass' if @config[:fdpass]
+      cmd << path
+      cmd << '--no-summary'
+    end
     command
   end
 
   def self.virus?(path)
     return nil unless scanner_exists?
     return nil unless file_exists?(path)
-    scanner = system(system_command(path))
+    scanner = system(*system_command(path))
 
     return false if scanner
     return true unless @config[:error_file_virus]

data/lib/clamby/version.rb

@@ -1,3 +1,3 @@
 module Clamby
-  VERSION = "1.2.5"
+  VERSION = "1.3.0"
 end

data/spec/clamby_spec.rb

@@ -61,11 +61,11 @@ describe Clamby do
     end
     it 'does not include fdpass in the command by default' do
       Clamby.configure(fdpass: false)
-      expect(Clamby.system_command(good_path)).to eq "clamscan #{good_path} --no-summary"
+      expect(Clamby.system_command(good_path)).to eq ["clamscan", good_path, "--no-summary"]
     end
     it 'passes the fdpass option when invoking clamscan if it is set' do
       Clamby.configure(fdpass: true)
-      expect(Clamby.system_command(good_path)).to eq "clamscan --fdpass #{good_path} --no-summary"
+      expect(Clamby.system_command(good_path)).to eq ["clamscan", "--fdpass", good_path, "--no-summary"]
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: clamby
 version: !ruby/object:Gem::Version
-  version: 1.2.5
+  version: 1.3.0
 platform: ruby
 authors:
 - kobaltz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-12 00:00:00.000000000 Z
+date: 2017-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler