claide-plugins 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5ad1f52c0be19c6682f2f3d80e72bb1c5f2f47a0
-  data.tar.gz: 10b9e27ab9a8518cdfbeda69d88347adaec6fa24
+  metadata.gz: 3bf05e511929565f0bf09a993816fcff77deb684
+  data.tar.gz: d4acbe03d9b46f9d2e545bc5eb5059fd10ba88dd
 SHA512:
-  metadata.gz: 4474443f0b957e4b3c5a1f9c60f6066419893cd19559e800600fc8986208dc021634e1e284c9ab4ce407ab88f9a6160b232168b0fb9a10dbb0ab7a6ff4e6179d
-  data.tar.gz: 8d3f047420b850b0b67c888235cace7e16ed032eb58299b703bc9fff992acdb00585b2ebb6ce619d3f4723deef2a98230766695533373f1f36522220c7944e8d
+  metadata.gz: 7075dfd3dba9626b5189591d00d48661bd7410728afb581d0a0b56cf8113c74c835adf97535bb94784d55ccf3d4fbc5fdea36fc5aa57875c6075b9ad102fbc3c
+  data.tar.gz: 37e581149de86676added6f1f7ec62d39e74c8654c5f6784d8b44fd43e7bb6769b0a7827315842f7d8cf53bc459ebbe6a89860124c7d803646085fbe2358af54

data/Gemfile.lock

@@ -23,6 +23,7 @@ GEM
     bacon (1.2.0)
     codeclimate-test-reporter (0.4.0)
       simplecov (>= 0.7.1, < 1.0.0)
+    coderay (1.1.1)
     colored (1.2)
     cork (0.1.0)
       colored (~> 1.2)
@@ -30,6 +31,7 @@ GEM
       safe_yaml (~> 1.0.0)
     docile (1.1.5)
     metaclass (0.0.4)
+    method_source (0.8.2)
     mocha (1.1.0)
       metaclass (~> 0.0.1)
     mocha-on-bacon (0.2.2)
@@ -42,6 +44,10 @@ GEM
     powerpack (0.1.0)
     prettybacon (0.0.2)
       bacon (~> 1.2)
+    pry (0.10.4)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
     rainbow (2.0.0)
     rake (10.3.2)
     rubocop (0.29.1)
@@ -57,6 +63,7 @@ GEM
       multi_json
       simplecov-html (~> 0.8.0)
     simplecov-html (0.8.0)
+    slop (3.6.0)
     vcr (2.9.3)
     webmock (1.20.4)
       addressable (>= 2.3.6)
@@ -73,6 +80,7 @@ DEPENDENCIES
   codeclimate-test-reporter
   mocha-on-bacon
   prettybacon
+  pry
   rake
   rubocop
   vcr

data/Rakefile

@@ -29,6 +29,7 @@ begin
     duration = Time.now - start_time
     puts "Tests completed in #{duration}s"
     Rake::Task['rubocop'].invoke
+    Rake::Task['validate_json'].invoke
   end
 
   def specs(dir)
@@ -46,6 +47,38 @@ begin
     abort('RuboCop failed!') unless result == 0
   end
 
+  # plugins.json
+  #----------------------------------------------------------------------------#
+
+  desc 'Validates plugins.json'
+  task :validate_json do
+    require 'json'
+    require 'pathname'
+
+    puts 'Validating plugins.json'
+
+    json_file = Pathname(__FILE__).parent + 'plugins.json'
+    json = json_file.read
+    plugins = JSON.load(json)
+    abort('Invalid JSON in plugins.json') unless plugins
+    keys = %w(gem name author social_media_url url description)
+    optional_keys = %w(social_media_url)
+    errors = plugins['plugins'].reduce([]) do |errors, plugin|
+      extra_keys = plugin.keys - keys
+      unless extra_keys.empty?
+        errors << "plugin `#{plugin['name']}` has extra keys #{extra_keys}"
+      end
+      (keys - optional_keys).each do |key|
+        unless plugin[key]
+          errors << "plugin `#{plugin['name']}` is missing key `#{key}`"
+        end
+      end
+      errors
+    end
+    unless errors.empty?
+      abort("Invalid plugins.json:\n\n#{errors.join("\n")}")
+    end
+  end
 
 rescue LoadError
   $stderr.puts "\033[0;31m" \

data/claide-plugins.gemspec

@@ -21,12 +21,13 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'nap', '~> 1.0'
-  spec.add_runtime_dependency 'cork', '~> 0'
+  spec.add_runtime_dependency 'nap'
+  spec.add_runtime_dependency 'cork'
   spec.add_runtime_dependency 'open4', '~> 1.3'
 
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'pry'
 
   spec.required_ruby_version = '>= 2.0.0'
 end

data/lib/claide/command/plugins/create.rb

@@ -9,17 +9,17 @@ module CLAide
       # template
       #
       class Create < Plugins
-        NAME_PREFIX = 'claide-'
-
         self.summary = 'Creates a new plugin'
-        self.description = <<-DESC
+        def self.description
+          <<-DESC
                 Creates a scaffold for the development of a new plugin
-                named `NAME` according to the CocoaPods best practices.
+                named `NAME` according to the best practices.
 
                 If a `TEMPLATE_URL`, pointing to a git repo containing a
                 compatible template, is specified, it will be used
                 in place of the default one.
-        DESC
+          DESC
+        end
 
         self.arguments = [
           CLAide::Argument.new('NAME', true),
@@ -28,8 +28,9 @@ module CLAide
 
         def initialize(argv)
           @name = argv.shift_argument
-          unless @name.nil? || @name.empty? || @name.start_with?(NAME_PREFIX)
-            @name = NAME_PREFIX + @name.dup
+          prefix = CLAide::Plugins.config.plugin_prefix + '-'
+          unless @name.nil? || @name.empty? || @name.start_with?(prefix)
+            @name = prefix + @name.dup
           end
           @template_url = argv.shift_argument
           super
@@ -59,10 +60,6 @@ module CLAide
         extend CLAide::Executable
         executable :git
 
-        TEMPLATE_BASE_URL = 'https://github.com/CocoaPods/'
-        TEMPLATE_REPO = TEMPLATE_BASE_URL + 'cocoapods-plugin-template.git'
-        TEMPLATE_INFO_URL = TEMPLATE_BASE_URL + 'cocoapods-plugin-template'
-
         # Clones the template from the remote in the working directory using
         # the name of the plugin.
         #
@@ -72,14 +69,7 @@ module CLAide
           UI.section("-> Creating `#{@name}` plugin") do
             UI.notice "using template '#{template_repo_url}'"
             command = ['clone', template_repo_url, @name]
-            if method(:git!).arity == -1
-              git! command
-            else
-              # TODO: delete this conditional and use the other branch when
-              # 0.5.0 is released
-              require 'shellwords'
-              git! command.map(&:to_s).map(&:shellescape).join(' ')
-            end
+            git! command
           end
         end
 
@@ -99,12 +89,12 @@ module CLAide
           end
         end
 
-        # Checks if a template URL is given else returns the TEMPLATE_REPO URL
+        # Checks if a template URL is given else returns the Plugins.config URL
         #
         # @return String
         #
         def template_repo_url
-          @template_url || TEMPLATE_REPO
+          @template_url || CLAide::Plugins.config.plugin_template_url
         end
 
         # Shows a reminder to the plugin author to make a Pull Request

data/lib/claide/command/plugins/list.rb

@@ -8,10 +8,10 @@ module CLAide
       #
       class List < Plugins
         self.summary = 'List all known plugins'
-        self.description = <<-DESC
-                List all known plugins (according to the list
-                hosted on github.com/CocoaPods/cocoapods-plugins)
-        DESC
+        def self.description
+          "List all known plugins (according to the list
+                hosted on #{ CLAide::Plugins.config.plugin_list_url })"
+        end
 
         def self.options
           super.reject { |option, _| option == '--silent' }

data/lib/claide/command/plugins_helper.rb

@@ -11,6 +11,10 @@ module CLAide
         CLAide::Plugins.config.plugin_list_url
       end
 
+      def self.plugin_prefix
+        CLAide::Plugins.config.plugin_prefix
+      end
+
       # Force-download the JSON
       #
       # @return [Hash] The hash representing the JSON with all known plugins
@@ -22,7 +26,7 @@ module CLAide
           parse_json(response.body)
         else
           raise Informative, 'Could not download plugins list ' \
-            "from cocoapods-plugins: #{response.inspect}"
+            "from #{plugin_prefix}-plugins: #{response.inspect}"
         end
       end
 
@@ -109,7 +113,8 @@ module CLAide
       def self.parse_json(json_str)
         JSON.parse(json_str)
       rescue JSON::ParserError => e
-        raise Informative, "Invalid plugins list from cocoapods-plugins: #{e}"
+        raise Informative,
+              "Invalid plugins list from #{plugin_prefix}-plugins: #{e}"
       end
 
       # Format the title line to print the plugin info with print_plugin

data/lib/claide_plugins.rb

@@ -1,3 +1,3 @@
 module CLAidePlugins
-  VERSION = '0.9.0'.freeze
+  VERSION = '0.9.1'.freeze
 end

data/spec/command/plugins/create_spec.rb

@@ -7,8 +7,20 @@ module CLAide
   describe Command::Plugins::Create do
     extend SpecHelper::PluginsCreateCommand
 
+    # We need to have a working repo for the template inside this test
+    # suite so we're using the real Danger config file, then setting
+    # it back to the default.
     before do
       UI_OUT.reopen
+      config = CLAide::Plugins::Configuration.new('Danger',
+                                                  'danger',
+                                                  'https://raw.githubusercontent.com/danger/danger.systems/master/plugins-search-generated.json',
+                                                  'https://github.com/danger/danger-plugin-template')
+      CLAide::Plugins.config = config
+    end
+
+    after do
+      CLAide::Plugins.config = default_testing_config
     end
 
     it 'registers itself' do
@@ -41,6 +53,9 @@ module CLAide
 
     #--- Naming
 
+    # These have to be `danger` as the configure script runs from the danger
+    # plugin template repo.
+
     it 'should prefix the given name if not already' do
       @command = create_command('unprefixed')
       Dir.mktmpdir do |tmpdir|
@@ -48,42 +63,42 @@ module CLAide
           @command.run
         end
       end
-      UI_OUT.string.should.include('Creating `claide-unprefixed` plugin')
+      UI_OUT.string.should.include('Creating `danger-unprefixed` plugin')
     end
 
     it 'should not prefix the name if already prefixed' do
-      @command = create_command('claide-prefixed')
+      @command = create_command('danger-prefixed')
       Dir.mktmpdir do |tmpdir|
         Dir.chdir(tmpdir) do
           @command.run
         end
       end
-      UI_OUT.string.should.include('Creating `claide-prefixed` plugin')
+      UI_OUT.string.should.include('Creating `danger-prefixed` plugin')
     end
 
     #--- Template download
 
     it 'should download the default template repository' do
-      @command = create_command('claide-banana')
+      @command = create_command('danger-banana')
 
-      template_repo = 'https://github.com/CocoaPods/' \
-        'cocoapods-plugin-template.git'
-      git_command = ['clone', template_repo, 'claide-banana']
+      template_repo = 'https://github.com/danger/' \
+        'danger-plugin-template'
+      git_command = ['clone', template_repo, 'danger-banana']
       @command.expects(:git!).with(git_command)
       @command.expects(:configure_template)
       @command.run
-      UI_OUT.string.should.include('Creating `claide-banana` plugin')
+      UI_OUT.string.should.include('Creating `danger-banana` plugin')
     end
 
     it 'should download the passed in template repository' do
-      alt_repo = 'https://github.com/CocoaPods/' \
-        'claide-banana-plugin-template.git'
-      @command = create_command('claide-banana', alt_repo)
+      alt_repo = 'https://github.com/danger/' \
+        'danger-banana-plugin-template'
+      @command = create_command('danger-banana', alt_repo)
 
-      @command.expects(:git!).with(['clone', alt_repo, 'claide-banana'])
+      @command.expects(:git!).with(['clone', alt_repo, 'danger-banana'])
       @command.expects(:configure_template)
       @command.run
-      UI_OUT.string.should.include('Creating `claide-banana` plugin')
+      UI_OUT.string.should.include('Creating `danger-banana` plugin')
     end
   end
 end

data/spec/command/plugins_helper_spec.rb

@@ -16,7 +16,7 @@ module CLAide
 
     it 'handles empty/bad JSON' do
       stub_plugins_json_request 'This is not JSON'
-      expected_error = /Invalid plugins list from cocoapods-plugins/
+      expected_error = /Invalid plugins list from claidetest-plugins/
       should.raise(CLAide::Informative) do
         Command::PluginsHelper.download_json
       end.message.should.match(expected_error)
@@ -24,7 +24,7 @@ module CLAide
 
     it 'notifies the user if the download fails' do
       stub_plugins_json_request '', [404, 'Not Found']
-      expected_error = /Could not download plugins list from cocoapods-plugins/
+      expected_error = /Could not download plugins list from claidetest-plugins/
       should.raise(CLAide::Informative) do
         Command::PluginsHelper.download_json
       end.message.should.match(expected_error)

data/spec/command/plugins_spec.rb

@@ -25,7 +25,7 @@ module CLAide
     end
 
     it 'should default to a CLAide plugin config' do
-      config = CLAide::Plugins.config
+      config = CLAide::Plugins::Configuration.new
       config.name.should.equal('default name')
       config.plugin_prefix.should.equal('claide')
       config.plugin_list_url.should.equal('https://github.com/cocoapods/claide-plugins/something.json')

data/spec/spec_helper.rb

@@ -62,6 +62,19 @@ end
 
 #-----------------------------------------------------------------------------#
 
+# Use test specific settings inside all of the tests
+#
+
+def default_testing_config
+  CLAide::Plugins::Configuration.new('CLAideTesting',
+                                     'claidetest',
+                                     'https://github.com/cocoapods/claide-plugins/something.json',
+                                     'https://github.com/danger/danger-plugin-template')
+end
+
+CLAide::Plugins.config = default_testing_config
+#-----------------------------------------------------------------------------#
+
 # SpecHelper namespace
 #
 module SpecHelper

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: claide-plugins
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - David Grandinetti
@@ -9,34 +9,34 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-09 00:00:00.000000000 Z
+date: 2016-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nap
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: cork
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -81,6 +81,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |2
                            This CLAide plugin shows information about all available CLAide plugins
                            (yes, this is very meta!).