clack 0.4.1 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c0622f234b9f83906c6440e54c29a12715ecfc7a2b3777ec68efaf3882defcb7
-  data.tar.gz: 450c6376c40ad88a27683294e97292f227e2081ccc90a0c076949bba3e5afd1d
+  metadata.gz: 1a59e5250ad3fb130ffda74b6fdfa5bda7bb4f57062cd6305c5c07f0af7b82ee
+  data.tar.gz: 8fb2da61ab0120a8f95189c9112463e742d87a7a915a30d9c5ae7d192c90475b
 SHA512:
-  metadata.gz: '08a7d471122e503168817430b65ad3618488eef6a2c79229a50e20a0a3ff3f2df741faef330a81b57875ddca3a37a68d0aebd19e770b7bbe73addd9a737bc9ec'
-  data.tar.gz: 76e01f5eef142fd64069e1d9ba705edebc5694834ab68d5f7a8370eb345f1bf1473f2f1771d0178ed80e0b6c977c05d032d0059112bf36e72dd2fbe18f3850a3
+  metadata.gz: f64a271d61f1e0b93938b418d2907a173cde44a901a98ba1f691b3c45c84e97ef8096e6b1a1b6e7b94470287920340f75df65ec62a213b661707ab935f266ead
+  data.tar.gz: 6bf0a82964715fa130c64f15dc974a373aa00e996d285e19cf0518175b9916ff042b2fe7a042e1ea3d5720d3dee20c1fdbd914d5a77fd9f5a1f428f24622f7ee

data/CHANGELOG.md

@@ -1,5 +1,29 @@
 # Changelog
 
+## [0.4.3] - 2026-02-21
+
+### Fixed
+- Multiselect variants now ignore `initial_values` that don't match any option (prevents phantom values in return)
+- SIGWINCH handler now uses `.dup` for safe array iteration inside signal trap
+- `GroupMultiselect` propagates `:hint` into flat items so hints actually render
+
+### Changed
+- `AutocompleteMultiselect` final frame now shows selected labels instead of "N items selected", matching `Multiselect` behavior
+- Removed dead `@mutex` from `Testing` module
+- Removed unused `raw:` parameter from `TaskLog` and `TaskLogGroup` message methods
+
+## [0.4.2] - 2026-02-20
+
+### Fixed
+- `GroupMultiselect` now preserves `:hint` on options (was silently dropped during normalization)
+- `GroupMultiselect` renders hints on active options, matching `Select` behavior
+- `Spinner` no longer raises when finished in timer mode before the animation thread starts
+- YARD docs: corrected `selectable_groups` default from `true` to `false`
+
+### Changed
+- `Range` prompt now accepts `initial_value:` for consistency with all other prompts (`default:` still works)
+- README: corrected Range example to use `initial_value:` and tab completion description
+
 ## [0.4.1] - 2026-02-20
 
 ### Fixed
@@ -21,7 +45,7 @@
 ## [0.4.0] - 2026-02-19
 
 ### Added
-- `range` slider prompt for numeric selection (`Clack.range(message:, min:, max:, step:, default:)`)
+- `range` slider prompt for numeric selection (`Clack.range(message:, min:, max:, step:, initial_value:)`)
 - Tab completion on `text` prompt via `completions:` parameter (array or proc)
 - Minimum terminal width warning (non-blocking, 40 columns)
 

data/README.md

@@ -198,7 +198,7 @@ name = Clack.text(
 )
 ```
 
-**Tab completion** - press `Tab` to cycle through matching candidates:
+**Tab completion** - press `Tab` to fill the longest common prefix of matching candidates:
 
 ```ruby
 # Tab completion from a static list
@@ -367,7 +367,7 @@ volume = Clack.range(
   min: 0,
   max: 100,
   step: 5,
-  default: 50
+  initial_value: 50
 )
 ```
 

data/lib/clack/core/prompt.rb

@@ -32,9 +32,6 @@ module Clack
       MIN_TERMINAL_WIDTH = 40
 
       # Track active prompts for SIGWINCH notification.
-      # Signal handler may fire during register/unregister. We can't use
-      # .dup (allocates, forbidden in trap context) so we accept a benign
-      # race: worst case, a prompt misses one resize notification.
       @active_prompts = []
 
       class << self
@@ -57,7 +54,7 @@ module Clack
           return unless Signal.list.key?("WINCH")
 
           Signal.trap("WINCH") do
-            @active_prompts.each(&:request_redraw)
+            @active_prompts.dup.each(&:request_redraw)
           end
         end
       end

data/lib/clack/prompts/autocomplete_multiselect.rb

@@ -53,7 +53,8 @@ module Clack
         @cursor = 0
         @selected_index = 0
         @scroll_offset = 0
-        @selected_values = Set.new(initial_values || [])
+        valid_values = Set.new(@all_options.map { |o| o[:value] })
+        @selected_values = Set.new(initial_values || []) & valid_values
         update_filtered
       end
 
@@ -167,11 +168,9 @@ module Clack
         lines << "#{bar}\n"
         lines << "#{symbol_for_state}  #{@message}\n"
 
-        display = if @state == :cancel
-          Colors.strikethrough(Colors.dim("cancelled"))
-        else
-          Colors.dim("#{@selected_values.size} items selected")
-        end
+        labels = @all_options.select { |o| @selected_values.include?(o[:value]) }.map { |o| o[:label] }
+        display_text = labels.join(", ")
+        display = (@state == :cancel) ? Colors.strikethrough(Colors.dim(display_text)) : Colors.dim(display_text)
         lines << "#{bar}  #{display}\n"
 
         lines.join

data/lib/clack/prompts/group_multiselect.rb

@@ -55,7 +55,8 @@ module Clack
         super(message:, **opts)
         @groups = normalize_groups(options)
         @flat_items = build_flat_items
-        @selected = Set.new(initial_values)
+        valid_values = Set.new(@flat_items.select { |item| item[:type] == :option }.map { |item| item[:value] })
+        @selected = Set.new(initial_values) & valid_values
         @required = required
         @selectable_groups = selectable_groups
         @group_spacing = group_spacing
@@ -152,9 +153,9 @@ module Clack
       def normalize_option(opt)
         case opt
         when Hash
-          {value: opt[:value], label: opt[:label] || opt[:value].to_s, disabled: opt[:disabled] || false}
+          {value: opt[:value], label: opt[:label] || opt[:value].to_s, hint: opt[:hint], disabled: opt[:disabled] || false}
         else
-          {value: opt, label: opt.to_s, disabled: false}
+          {value: opt, label: opt.to_s, hint: nil, disabled: false}
         end
       end
 
@@ -167,6 +168,7 @@ module Clack
             type: :option,
             value: opt[:value],
             label: opt[:label],
+            hint: opt[:hint],
             disabled: opt[:disabled],
             group: group,
             last_in_group: idx == group[:options].length - 1
@@ -261,13 +263,14 @@ module Clack
         else
           "  "
         end
+        hint = (item[:hint] && active) ? " #{Colors.dim("(#{item[:hint]})")}" : ""
 
         if item[:disabled]
           "#{active_bar}  #{Colors.dim(prefix)}#{Colors.dim(Symbols::S_CHECKBOX_INACTIVE)} #{Colors.strikethrough(Colors.dim(item[:label]))}\n"
         elsif active && selected
-          "#{active_bar}  #{Colors.dim(prefix)}#{Colors.green(Symbols::S_CHECKBOX_SELECTED)} #{item[:label]}\n"
+          "#{active_bar}  #{Colors.dim(prefix)}#{Colors.green(Symbols::S_CHECKBOX_SELECTED)} #{item[:label]}#{hint}\n"
         elsif active
-          "#{active_bar}  #{Colors.dim(prefix)}#{Colors.cyan(Symbols::S_CHECKBOX_ACTIVE)} #{item[:label]}\n"
+          "#{active_bar}  #{Colors.dim(prefix)}#{Colors.cyan(Symbols::S_CHECKBOX_ACTIVE)} #{item[:label]}#{hint}\n"
         elsif selected
           "#{active_bar}  #{Colors.dim(prefix)}#{Colors.green(Symbols::S_CHECKBOX_SELECTED)} #{Colors.dim(item[:label])}\n"
         else

data/lib/clack/prompts/multiselect.rb

@@ -40,7 +40,8 @@ module Clack
       def initialize(message:, options:, initial_values: [], required: true, max_items: nil, cursor_at: nil, **opts)
         super(message:, **opts)
         @options = normalize_options(options)
-        @selected = Set.new(initial_values)
+        valid_values = Set.new(@options.map { |o| o[:value] })
+        @selected = Set.new(initial_values) & valid_values
         @required = required
         @max_items = max_items
         @scroll_offset = 0

data/lib/clack/prompts/range.rb

@@ -10,11 +10,11 @@ module Clack
     # @example Basic usage
     #   level = Clack.range(message: "Volume", min: 0, max: 100, step: 5)
     #
-    # @example With default value
+    # @example With initial value
     #   workers = Clack.range(
     #     message: "Concurrency",
     #     min: 1, max: 16,
-    #     step: 1, default: 4
+    #     step: 1, initial_value: 4
     #   )
     #
     class Range < Core::Prompt
@@ -26,9 +26,10 @@ module Clack
       # @param min [Numeric] minimum value (default: 0)
       # @param max [Numeric] maximum value (default: 100)
       # @param step [Numeric] increment size (default: 1)
-      # @param default [Numeric, nil] initial value (defaults to min)
+      # @param initial_value [Numeric, nil] initial value (defaults to min)
+      # @param default [Numeric, nil] deprecated alias for initial_value
       # @param opts [Hash] additional options passed to {Core::Prompt}
-      def initialize(message:, min: 0, max: 100, step: 1, default: nil, **opts)
+      def initialize(message:, min: 0, max: 100, step: 1, initial_value: nil, default: nil, **opts)
         super(message:, **opts)
 
         raise ArgumentError, "min must be less than max" if min >= max
@@ -37,7 +38,7 @@ module Clack
         @min = min
         @max = max
         @step = step
-        @value = clamp(default || min)
+        @value = clamp(initial_value || default || min)
       end
 
       protected

data/lib/clack/prompts/spinner.rb

@@ -178,7 +178,7 @@ module Clack
           @finished = true
           @running = false
           thread_to_join = @thread
-          suffix = (@indicator == :timer) ? " #{format_timer}" : ""
+          suffix = (@indicator == :timer && @start_time) ? " #{format_timer}" : ""
           [message || @message, suffix]
         end
 

data/lib/clack/task_log.rb

@@ -32,8 +32,7 @@ module Clack
 
     # Add a message to the log
     # @param msg [String] Message to display
-    # @param raw [Boolean] If true, don't add newline between messages
-    def message(msg, raw: false)
+    def message(msg)
       clear_buffer
       @buffer << msg.to_s.gsub(/\e\[[\d;]*[ABCDEFGHfJKSTsu]/, "") # Strip cursor movement codes
       apply_limit
@@ -155,7 +154,7 @@ module Clack
     end
 
     # Add a message to this group
-    def message(msg, raw: false)
+    def message(msg)
       @parent.add_group_message(self, msg)
     end
 

data/lib/clack/testing.rb

@@ -105,8 +105,6 @@ module Clack
       end
     end
 
-    @mutex = Mutex.new
-
     class << self
       # Simulate a prompt interaction by feeding a predefined key sequence.
       #

data/lib/clack/version.rb

@@ -2,5 +2,5 @@
 
 module Clack
   # Current gem version.
-  VERSION = "0.4.1"
+  VERSION = "0.4.3"
 end

data/lib/clack.rb

@@ -343,7 +343,7 @@ module Clack
     # @option opts [Array, nil] :initial_values initially selected values
     # @option opts [Boolean] :required require at least one selection (default: true)
     # @option opts [Object, nil] :cursor_at value of initially focused option
-    # @option opts [Boolean] :selectable_groups allow toggling entire groups (default: true)
+    # @option opts [Boolean] :selectable_groups allow toggling entire groups (default: false)
     # @option opts [Integer] :group_spacing lines between groups (default: 0)
     # @return [Array, CANCEL] selected values or CANCEL if cancelled
     def group_multiselect(message:, options:, **opts)
@@ -375,7 +375,7 @@ module Clack
     # @option opts [Numeric] :min minimum value (default: 0)
     # @option opts [Numeric] :max maximum value (default: 100)
     # @option opts [Numeric] :step increment size (default: 1)
-    # @option opts [Numeric, nil] :default initial value (defaults to min)
+    # @option opts [Numeric, nil] :initial_value initial value (defaults to min)
     # @option opts [Proc, nil] :validate validation proc
     # @option opts [String, nil] :help help text shown below the message
     # @return [Numeric, CANCEL] selected value or CANCEL if cancelled

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: clack
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.3
 platform: ruby
 authors:
 - Steve Whittaker