ckeditor5 1.17.2 → 1.17.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 789a4ca2ac0428fa31866a6fd99433577137e9ccbe64e321e86c20126814dc80
-  data.tar.gz: f4d3bc6f16777dd8dc03c4e62aada4c772021fc72bc99eeecbc668ac0dcc39b6
+  metadata.gz: fe514f6683b41d1fff1a64788a8ab4a608a567563fb904c7af684c9d24f94fe9
+  data.tar.gz: 411ce73542f83467ae713fbf8bd2976a3597b82f2df4b7cc8ee19ab93cc65ea2
 SHA512:
-  metadata.gz: '02238ab74fc9982f48177b33bc20b59332ca58f9cb594868649e72ec5e504760d41e5a0ce4afee0cbeb5463335e34fb4303e5e30fd6b21abd96968a017ba715f'
-  data.tar.gz: f4a331e7b9afca50f1063626a73c083ed521521333e7492eaf252bd30a360b435459fe5a8d321c4b5a4355c291272c2ee352a01bbd15d8c916434222fbdaa804
+  metadata.gz: b3420f1f381e795d37416b0038dba3c60980a2038d959a267ab6c70cbaf883af7e12ee3bcdd9a3f80c2ff27edb38d01c2da1a98133aa08cd6736e01e8d6d25db
+  data.tar.gz: 2a1102d9f90cf10f41a28b8d644d1d51c88a1b90553d3b65c8c8d486180282a9bcb61a3d5f5975333616711da7e3129632f0cb50bc835c43e131102beed62918

data/lib/ckeditor5/rails/cdn/ckeditor_bundle.rb

@@ -43,7 +43,9 @@ module CKEditor5::Rails
       end
 
       def translations_js_url_imports
-        translations.map do |lang|
+        translations.filter_map do |lang|
+          next if lang == :en
+
           url = create_cdn_url(import_name, version, "translations/#{lang}.js")
 
           Assets::JSUrlImportMeta.new(

data/lib/ckeditor5/rails/version.rb

@@ -2,7 +2,7 @@
 
 module CKEditor5
   module Rails
-    VERSION = '1.17.2'
+    VERSION = '1.17.3'
 
     DEFAULT_CKEDITOR_VERSION = '43.3.1'
   end

data/spec/e2e/features/locale_spec.rb

@@ -2,46 +2,53 @@
 
 require 'e2e/spec_helper'
 
+TRANSLATIONS = {
+  'en' => { 'Edit' => 'Edit', 'Insert' => 'Insert', 'Format' => 'Format' },
+  'pl' => { 'Edit' => 'Zmiana', 'Insert' => 'Wstaw', 'Format' => 'Format' },
+  'es' => { 'Edit' => 'Editar', 'Insert' => 'Insertar', 'Format' => 'Formato' },
+  'ru' => { 'Edit' => 'Редактировать', 'Insert' => 'Вставить', 'Format' => 'Формат' },
+  'de' => { 'Edit' => 'Bearbeiten', 'Insert' => 'Einfügen', 'Format' => 'Format' }
+}.freeze
+
 RSpec.describe 'Editor localization', type: :system do
-  describe 'setting locale via assets' do
-    it 'displays menubar in Polish' do
-      visit '/locale_via_assets'
+  shared_examples 'localized editor' do |locale|
+    it "displays menubar in #{locale}" do
+      visit path
 
       expect(page).to have_css('.ck-editor__main')
 
       within('.ck-menu-bar') do
-        expect(page).to have_content('Zmiana')
-        expect(page).to have_content('Wstaw')
-        expect(page).to have_content('Format')
+        TRANSLATIONS[locale].each_value do |translation|
+          expect(page).to have_content(translation)
+        end
       end
     end
   end
 
-  describe 'setting locale via editor prop' do
-    it 'displays menubar in Spanish' do
-      visit '/locale_via_editor'
-
-      expect(page).to have_css('.ck-editor__main')
+  describe 'setting locale via assets' do
+    let(:path) { '/locale_via_assets' }
+    it_behaves_like 'localized editor', 'pl'
+  end
 
-      within('.ck-menu-bar') do
-        expect(page).to have_content('Editar')
-        expect(page).to have_content('Insertar')
-        expect(page).to have_content('Formato')
-      end
-    end
+  describe 'setting locale via editor prop' do
+    let(:path) { '/locale_via_editor' }
+    it_behaves_like 'localized editor', 'es'
   end
 
   describe 'setting locale via preset' do
-    it 'displays menubar in Russian' do
-      visit '/locale_via_preset'
+    let(:path) { '/locale_via_preset' }
+    it_behaves_like 'localized editor', 'ru'
+  end
 
-      expect(page).to have_css('.ck-editor__main')
+  describe 'setting locale via Rails I18n' do
+    context 'using default I18n.locale' do
+      let(:path) { '/locale_via_rails_i18n' }
+      it_behaves_like 'localized editor', 'en'
+    end
 
-      within('.ck-menu-bar') do
-        expect(page).to have_content('Редактировать')
-        expect(page).to have_content('Вставить')
-        expect(page).to have_content('Формат')
-      end
+    context 'using custom I18n.locale' do
+      let(:path) { '/locale_via_rails_i18n?locale=de' }
+      it_behaves_like 'localized editor', 'de'
     end
   end
 end

data/spec/lib/ckeditor5/rails/cdn/ckeditor_bundle_spec.rb

@@ -58,6 +58,28 @@ RSpec.describe CKEditor5::Rails::Cdn::CKEditorBundle do
         "#{cdn}/npm/#{import_name}@#{version}/build/translations/de.js"
       )
     end
+
+    context 'when handling English translation' do
+      before { bundle.translations << :en }
+
+      it 'excludes English translation file' do
+        translation_urls = bundle.scripts.select(&:translation?).map(&:url)
+        expect(translation_urls).not_to include(
+          "#{cdn}/npm/#{import_name}@#{version}/build/translations/en.js"
+        )
+      end
+    end
+
+    context 'when adding additional translations' do
+      before { bundle.translations << :ru }
+
+      it 'includes new non-English translations' do
+        translation_urls = bundle.scripts.select(&:translation?).map(&:url)
+        expect(translation_urls).to include(
+          "#{cdn}/npm/#{import_name}@#{version}/build/translations/ru.js"
+        )
+      end
+    end
   end
 
   describe '#stylesheets' do

data/spec/lib/ckeditor5/rails/hooks/form_spec.rb

@@ -22,7 +22,7 @@ RSpec.describe CKEditor5::Rails::Hooks::Form do
           name: 'post[content]',
           id: 'post_content',
           type: 'ClassicEditor',
-          translations: '[{"import_name":"ckeditor5/translations/en.js"}]',
+          translations: '[]',
           watchdog: 'true'
         }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ckeditor5
 version: !ruby/object:Gem::Version
-  version: 1.17.2
+  version: 1.17.3
 platform: ruby
 authors:
 - Mateusz Bagiński