civil_service 2.3.0 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c81938a431b93fc416ce04cd6062971c03f6cb397b909afcca2c8b8e8bb1164a
-  data.tar.gz: 1786acdbe99e9245bf0c8e244fada4d5dc84bc40cfab4b860bbe5d65faf81c46
+  metadata.gz: 3cc309b95109e1703e10facefa160b6b3ec0d2c9cdeecc55c4d7fcca4fd3b788
+  data.tar.gz: bd935e564c4170b464e0fc5a577d885201c4a506f57bd5dd67ca69ceb5f5de5a
 SHA512:
-  metadata.gz: 80ffe9daa4f19ccb5b6aff3ead328758e4005b1cdccdac14cbbf66f8642d4b69c6d750bb0f50a1be03fc899dd1d6b8816de1b6db93847b8040b866e15a06e3ca
-  data.tar.gz: ace5d7948426b071564cb8696a2da2c6a8362ec47b26b0a5593d2b1530e3db0d870f48a053744c441c52918ef81b770fbeb55c03986d2bbac8537b1a0f882af1
+  metadata.gz: 10fbcc6182d07401c5e13580246511f9b8d9de9724bf049e21e0b343dee7b147dd2447ad1b58660488366dd892e05cfd5a2dba30dfeb2bf02d7d526117f09316
+  data.tar.gz: cb07f3d6487e639cac8c0645dc2b316a0ef017986e7d3bea0e0eaef66e66f37241b34d08989f2c558e737a549afba2e8d8c0dd49ca9cdc642c7af9c0d7914578

data/CHANGELOG.md

@@ -1,30 +1,36 @@
+# Version 2.4.0 - January 15, 2021
+
+- `#call`, `#call_and_raise`, and `#call!` now accept an optional keyword parameter called `validate`. This will
+  skip validations if passed `false`. (`true` is the default value.)
+- `#call!` now takes advantage of the `validate:` parameter internally to avoid running validations twice.
+
 # Version 2.3.0 - April 3, 2020
 
-* `#call!` now raises the underlying exception if the service threw an exception,
+- `#call!` now raises the underlying exception if the service threw an exception,
   rather than hiding it inside a `CivilService::ServiceFailure`.
 
 # Version 2.2.1 - October 4, 2019
 
-* `CivilService::MultiResultService::MultiResult#exception` now checks the underlying exception on
+- `CivilService::MultiResultService::MultiResult#exception` now checks the underlying exception on
   the root result object, in case the service threw an exception.
 
 # Version 2.2.0 - September 26, 2019
 
-* Services now have a new `#call_and_raise` method, which will return a result object on failure
+- Services now have a new `#call_and_raise` method, which will return a result object on failure
   but will raise exceptions that are thrown inside the service call (effectively, the behavior of
   `#call` in CivilService 1.0.0).
-* Added a new mixin called `CivilService::MultiResultService`, which allows creating services whose
+- Added a new mixin called `CivilService::MultiResultService`, which allows creating services whose
   results are composed of multiple results that are aggregated together.
 
 # Version 2.1.0 - September 25, 2019
 
-* `CivilService::Result#errors` now always returns an Errors object even if it hasn't been
+- `CivilService::Result#errors` now always returns an Errors object even if it hasn't been
   explicitly set.
 
 # Version 2.0.0 - June 26, 2019
 
-* BREAKING CHANGE: The behavior of `CivilService::Service#call` has changed when exceptions are
-  raised inside the service.  The `call` method will now catch the exception and return a failing
+- BREAKING CHANGE: The behavior of `CivilService::Service#call` has changed when exceptions are
+  raised inside the service. The `call` method will now catch the exception and return a failing
   result object, with the exception message as an error on `:base`.
 
   The behavior of `call!` has not changed: a failing result will be raised as a
@@ -35,8 +41,9 @@
   will (almost) never raise an exception, whereas `call!` can raise an exception.
 
   The exception to this rule (pun intended, always intend your puns) is that `call` will not catch
-  exceptions that don't inherit from `StandardError`, such as `SystemExit`.  See
+  exceptions that don't inherit from `StandardError`, such as `SystemExit`. See
   [Honeybadger's explanation](https://www.honeybadger.io/blog/a-beginner-s-guide-to-exceptions-in-ruby/)
   of why this is a good idea.
-* `CivilService::Result` now has an additional attribute called `exception`, which can be used to
+
+- `CivilService::Result` now has an additional attribute called `exception`, which can be used to
   retrieve an exception thrown inside a `call` method.

data/Gemfile.lock

@@ -1,29 +1,26 @@
 PATH
   remote: .
   specs:
-    civil_service (2.3.0)
+    civil_service (2.4.0)
       activemodel (>= 3.0.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (6.0.0)
-      activesupport (= 6.0.0)
-    activesupport (6.0.0)
+    activemodel (7.0.0)
+      activesupport (= 7.0.0)
+    activesupport (7.0.0)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-      zeitwerk (~> 2.1, >= 2.1.8)
-    concurrent-ruby (1.1.6)
-    i18n (1.8.2)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+    concurrent-ruby (1.1.9)
+    i18n (1.8.11)
       concurrent-ruby (~> 1.0)
     minitest (5.11.3)
     rake (13.0.1)
-    thread_safe (0.3.6)
-    tzinfo (1.2.6)
-      thread_safe (~> 0.1)
-    zeitwerk (2.2.0)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
 
 PLATFORMS
   ruby

data/lib/civil_service/service.rb

@@ -12,8 +12,8 @@ class CivilService::Service
     end
   end
 
-  def call
-    unless self.class.validate_manually
+  def call(validate: true)
+    if validate && !self.class.validate_manually
       return failure(errors) unless valid?
     end
 
@@ -25,8 +25,8 @@ class CivilService::Service
     end
   end
 
-  def call_and_raise
-    result = call
+  def call_and_raise(validate: true)
+    result = call(validate: validate)
     if result.exception
       raise result.exception, result.exception.message, result.exception.backtrace
     end
@@ -34,12 +34,12 @@ class CivilService::Service
     result
   end
 
-  def call!
-    unless self.class.validate_manually
+  def call!(validate: true)
+    if validate && !self.class.validate_manually
       raise CivilService::ServiceFailure.new(self, failure(errors)) unless valid?
     end
 
-    result = call_and_raise
+    result = call_and_raise(validate: false) # we already just did the validation step if needed
     raise CivilService::ServiceFailure.new(self, result) if result.failure?
     result
   end

data/lib/civil_service/version.rb

@@ -1,3 +1,3 @@
 module CivilService
-  VERSION = '2.3.0'
+  VERSION = '2.4.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: civil_service
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.4.0
 platform: ruby
 authors:
 - Nat Budin
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-04-03 00:00:00.000000000 Z
+date: 2022-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -96,7 +96,7 @@ files:
 homepage: https://github.com/neinteractiveliterature/civil_service
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -111,8 +111,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: A tiny service object framework for Rails apps
 test_files: []