civil_service 1.0.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3505ccbce978bbeeea7a494316cd161eee31460207b6b3b2c322315089bd1442
-  data.tar.gz: cf203b21b33f1f3b5e87a010bc3c2b8006703ca1cf1b53b1328b107264b21890
+  metadata.gz: c0155a0d0cbcf7c649725deedc1eb51e64ebe4f6a5f77ea4fbb6022768598afd
+  data.tar.gz: 82f50992961ad30130760307434340c180a459052fe4fa04c1bd295472be8a19
 SHA512:
-  metadata.gz: 8d99b796b01ecaa22eacf3b4bea961037749c927b798d7f2b153a7114192b6a40b8d1833e014abc2c736a929d2c5250f6ea8e4f2c94445c1df4df97a1fb41ae4
-  data.tar.gz: 73885e7a905e506e0f7c65324b370af89ed21f5df44755b40b7b44e414a5ffc75e635b6ab93e767fd910b107a18f66ac6ba20cd8ed3a34e40dca7b99fcc68068
+  metadata.gz: ec1adf3b57089d4849ca5ce70b2ed8b9938ee03aabd55b3e0952ee0d3cb0734e87bac765794b023c83b80276312c1e754a3ce517a97af9eaed80ac1f94e242b0
+  data.tar.gz: ff3622cb3f407734e8adfe0b4f844d9db437f72a642b17669920339027bdd62cf1a0aaf27d11fa4e35bcfdb2c878572579f1066cb5ec25567a6d0253dc6f32ab

data/CHANGELOG.md

@@ -0,0 +1,19 @@
+# Version 2.0.0 - June 26, 2019
+
+* BREAKING CHANGE: The behavior of `CivilService::Service#call` has changed when exceptions are
+  raised inside the service.  The `call` method will now catch the exception and return a failing
+  result object, with the exception message as an error on `:base`.
+
+  The behavior of `call!` has not changed: a failing result will be raised as a
+  `CivilService::ServiceFailure` exception, and an exception thrown inside the service will not be
+  caught (and therefore will be raised to the caller).
+
+  The idea of this change is that the behaviors of `call` and `call!` are now predictable: `call`
+  will (almost) never raise an exception, whereas `call!` can raise an exception.
+
+  The exception to this rule (pun intended, always intend your puns) is that `call` will not catch
+  exceptions that don't inherit from `StandardError`, such as `SystemExit`.  See
+  [Honeybadger's explanation](https://www.honeybadger.io/blog/a-beginner-s-guide-to-exceptions-in-ruby/)
+  of why this is a good idea.
+* `CivilService::Result` now has an additional attribute called `exception`, which can be used to
+  retrieve an exception thrown inside a `call` method.

data/Gemfile.lock

@@ -1,21 +1,21 @@
 PATH
   remote: .
   specs:
-    civil_service (1.0.0)
+    civil_service (2.0.0)
       activemodel (>= 3.0.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (5.1.5)
-      activesupport (= 5.1.5)
-    activesupport (5.1.5)
+    activemodel (5.2.3)
+      activesupport (= 5.2.3)
+    activesupport (5.2.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (~> 0.7)
+      i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
-    concurrent-ruby (1.0.5)
-    i18n (0.9.5)
+    concurrent-ruby (1.1.5)
+    i18n (1.6.0)
       concurrent-ruby (~> 1.0)
     minitest (5.11.3)
     rake (10.5.0)
@@ -33,4 +33,4 @@ DEPENDENCIES
   rake (~> 10.0)
 
 BUNDLED WITH
-   1.16.1
+   1.17.2

data/README.md

@@ -53,7 +53,7 @@ class PasswordChangeService < CivilService::Service
     success
   end
 
-  def ensure_valid
+  def ensure_valid_password
     return if new_password.length >= 8
     errors.add(:base, "Passwords must be at least 8 characters long")
   end

data/lib/civil_service/result.rb

@@ -1,6 +1,6 @@
 class CivilService::Result
   include ActiveModel::Model
-  attr_accessor :success, :errors
+  attr_accessor :success, :errors, :exception
 
   def self.success(attributes = {})
     new(attributes.merge(success: true))

data/lib/civil_service/service.rb

@@ -17,7 +17,12 @@ class CivilService::Service
       return failure(errors) unless valid?
     end
 
-    inner_call
+    begin
+      inner_call
+    rescue StandardError => exception
+      errors.add :base, exception.message
+      failure(errors, exception: exception)
+    end
   end
 
   def call!

data/lib/civil_service/version.rb

@@ -1,3 +1,3 @@
 module CivilService
-  VERSION = "1.0.0"
+  VERSION = "2.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: civil_service
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Nat Budin
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-03-28 00:00:00.000000000 Z
+date: 2019-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -77,6 +77,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
@@ -109,8 +110,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A tiny service object framework for Rails apps