cirneco 0.6.7 → 0.6.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e8cacedf8b97958116cab01245a96f3aaa207000
-  data.tar.gz: dfd05de68f8a7a38494728dc1478f430f3bf15a3
+  metadata.gz: c1f55d250fbc2819ba6dcb0e149578dfae54d66f
+  data.tar.gz: c2901c9c035c9e90733446082cbc792ad21a024f
 SHA512:
-  metadata.gz: 94d04dc8162acc9351b8150c03b0cd7c44882e9bb64b4f31d3a8875055e0bbe4ce89c23fed701d829e333e2224e5809e38497cb26f297ccc16d1f4c012295a94
-  data.tar.gz: cf6a0d25742f89f45b673b123fb56af08d35825a64be94aaf9b3b64e37a8aa68902bed3ff72fdeecc9295a879c401e9476b6b63e1cbeabc918245822f4e02ff7
+  metadata.gz: e16557958449568427784eafa7c5c19ddc02330d44cacc7a65ccd887e8f4ac732a094c77210d5f638c9cd77b05879f3dfa2fcac0e423449a0131a5a23efa7cc9
+  data.tar.gz: 0ecc5a7b6c286de088191953894f41a11e6acd401925a8337c0bf32f4987d6c96dd6ece1f36f224544620038406108f1632beca6aca845db867731b30c6809c7

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cirneco (0.6.7)
+    cirneco (0.6.8)
       activesupport (~> 4.2, >= 4.2.5)
       base32-crockford-checksum (~> 0.2.2)
       bergamasco (~> 0.2)

data/lib/cirneco/utils.rb

@@ -192,13 +192,10 @@ module Cirneco
     def register_work_for_metadata(metadata)
       work = Cirneco::Work.new(metadata)
 
-      if work.data.to_s.length > 0
-        filename  = metadata["doi"].split("/", 2).last + ".xml"
-        IO.write(filename, work.data)
-      else
-        puts work.validation_errors
-        puts work.inspect
-      end
+      filename  = metadata["doi"].split("/", 2).last + ".xml"
+      IO.write(filename, work.data)
+
+      puts work.validation_errors if work.validation_errors.present?
 
       work
     end
@@ -206,13 +203,10 @@ module Cirneco
     def unregister_work_for_metadata(metadata)
       work = Cirneco::Work.new(metadata)
 
-      if work.data.to_s.length > 0
-        filename  = metadata["doi"].split("/", 2).last + ".xml"
-        File.delete(filename) if File.exist?(filename)
-      else
-        puts work.validation_errors
-        puts work.inspect
-      end
+      filename  = metadata["doi"].split("/", 2).last + ".xml"
+      File.delete(filename) if File.exist?(filename)
+
+      puts work.validation_errors if work.validation_errors.present?
 
       work
     end

data/lib/cirneco/version.rb

@@ -1,3 +1,3 @@
 module Cirneco
-  VERSION = "0.6.7"
+  VERSION = "0.6.8"
 end

data/lib/cirneco/work.rb

@@ -36,13 +36,7 @@ module Cirneco
 
     SCHEMA = File.expand_path("../../../resources/kernel-4.0/metadata.xsd", __FILE__)
 
-    def has_required_elements?
-      doi && creators && title && publisher && publication_year && resource_type
-    end
-
     def data
-      return nil unless has_required_elements?
-
       Nokogiri::XML::Builder.new(:encoding => 'UTF-8') do |xml|
         xml.send(:'resource', root_attributes) do
           insert_work(xml)

data/spec/work_spec.rb

@@ -50,7 +50,8 @@ describe Cirneco::Work, vcr: true do
 
     it 'validates work without title with errors' do
       subject.title = nil
-      expect(subject.validation_errors).to eq(["The document has no document element."])
+      expect(subject.validation_errors).to eq(["Element '{http://datacite.org/schema/kernel-4}title': [facet 'minLength'] The value has a length of '0'; this underruns the allowed minimum length of '1'.",
+        "Element '{http://datacite.org/schema/kernel-4}title': '' is not a valid value of the atomic type '{http://datacite.org/schema/kernel-4}nonemptycontentStringType'."])
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cirneco
 version: !ruby/object:Gem::Version
-  version: 0.6.7
+  version: 0.6.8
 platform: ruby
 authors:
 - Martin Fenner