circuitbox 0.10.3 → 0.10.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 33b29e5d48278413b699741f144fdde38057ad46
-  data.tar.gz: f4d2897cf0f020aab8ace760976099104e308afc
+  metadata.gz: 5dd97fd3064e288e32ebae417b38a8e4e95439e4
+  data.tar.gz: 0b5ede74d70a2bfeffaf8178304afb24e3ac1c61
 SHA512:
-  metadata.gz: 69b31ae9c7fa29fb6400c40da41baeb5d63d6cc625d82c64c00aa0a2cf7eaaf5a1d02a184672a5135481310d9be7ee4ef949b38b0763d99814c2c5aa3f89ea70
-  data.tar.gz: aad5e9f545af39c9fbd792d8b76c8c06202461b32c7113522115cda8da6095bb66cdaaac6591e5edbc8e69ead22ba96c611ee9523efd589f3f16b66a22577992
+  metadata.gz: 7b6dfa97e8ea99ddf7d3ff06c08460e7820a07461f8c4c9cedf84c012879ba72870ae9f032cc6047e1121024ba64329ae2f9c96929f05e90268569f6279a0c9c
+  data.tar.gz: 9870a54f290f71a377ae850cc02945d6f76eeec7c5dc3627cf710e67adeb844cc14eaaf4341683508fb9c81e1e8d35f7fc51f841874dbf5163c1bca251b49cf7

data/README.md

@@ -213,6 +213,10 @@ c.use Circuitbox::FaradayMiddleware, open_circuit: lambda { |response| response.
 
 ### version next
 
+### v0.10.4
+- Issue #39, keep the original backtrace for the wrapped exception around when
+  re-raising a Circuitbox::Error
+
 ### v0.10.3
 - Circuitbox::ServiceFailureError wraps the original exception that was raised.
   The behaviour for to_s wasn't exposing this information and was returning the

data/circuitbox.gemspec

@@ -21,8 +21,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rack"
-  spec.add_development_dependency "guard-minitest"
-  spec.add_development_dependency "guard"
   spec.add_development_dependency "gimme"
   spec.add_development_dependency "minitest"
   spec.add_development_dependency "mocha"

data/lib/circuitbox/errors/service_failure_error.rb

@@ -5,11 +5,12 @@ class Circuitbox
     def initialize(service, exception)
       @service = service
       @original = exception
+      # we copy over the original exceptions backtrace if there is one
+      set_backtrace(exception.backtrace) unless exception.backtrace.empty?
     end
 
     def to_s
       "#{self.class.name} wrapped: #{original}"
     end
-
   end
 end

data/lib/circuitbox/version.rb

@@ -1,3 +1,3 @@
 class Circuitbox
-  VERSION='0.10.3'
+VERSION='0.10.4'
 end

data/test/service_failure_error_test.rb

@@ -1,13 +1,30 @@
 require 'test_helper'
 
-class ServiceFailureErrorTest < Minitest::Test
+describe Circuitbox::ServiceFailureError do
   class SomeOtherError < StandardError; end;
-  
-  describe 'to_s' do
+
+  attr_reader :error
+
+  before do
+    begin
+      raise SomeOtherError, "some other error"
+    rescue => ex
+      @error = ex
+    end
+  end
+
+  describe '#to_s' do
     it 'includes message for wrapped exception' do
-      some_error = SomeOtherError.new("some other error")
-      ex = Circuitbox::ServiceFailureError.new('test', some_error)
-      assert_equal "Circuitbox::ServiceFailureError wrapped: #{some_error}", ex.to_s
+      ex = Circuitbox::ServiceFailureError.new('test', error)
+      assert_equal "Circuitbox::ServiceFailureError wrapped: #{error}", ex.to_s
     end
   end
+
+  describe '#backtrace' do
+    it 'keeps the original exception backtrace' do
+      ex = Circuitbox::ServiceFailureError.new('test', error)
+      assert_equal error.backtrace, ex.backtrace
+    end
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: circuitbox
 version: !ruby/object:Gem::Version
-  version: 0.10.3
+  version: 0.10.4
 platform: ruby
 authors:
 - Fahim Ferdous
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-16 00:00:00.000000000 Z
+date: 2015-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,34 +52,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: guard-minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: guard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: gimme
   requirement: !ruby/object:Gem::Requirement
@@ -216,7 +188,6 @@ files:
 - ".gitignore"
 - ".travis.yml"
 - Gemfile
-- Guardfile
 - LICENSE
 - README.md
 - Rakefile

data/Guardfile

@@ -1,9 +0,0 @@
-# A sample Guardfile
-# More info at https://github.com/guard/guard#readme
-
-guard :minitest do
-  # with Minitest::Unit
-  watch(%r{^test/(.*)_test\.rb$})
-  watch(%r{^lib/circuitbox/([^/]+)\.rb$})     { |m| "test/#{m[1]}_test.rb" }
-  watch(%r{^test/test_helper\.rb$})      { 'test' }
-end