circleci-bundle-update-pr 1.14.4 → 1.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f0132033cd212b7a4de6428ae448cf78fc452f8766141e54eaeff0e85f583a32
-  data.tar.gz: 6265c70896a7a0e9e4aa474d0447a7b574ac6c9bcf901e055e843aa0fb2f0ad5
+  metadata.gz: 8fbe8bbe94a5d748796b73ddf80bcfc9df4a1cd83478a31e056275a95e6f1f37
+  data.tar.gz: 1cbe85ff25928c0503a974f03ae11d7f0332e675d5f93b0434cc53dd63a863c1
 SHA512:
-  metadata.gz: 4c4825bd2e230a48f8ae2b67a7210bd430a6294188df0bdbd5506aa47fdbd7b1060a6c009cb96d57e72c3d655169806ed7cdfa3b985fb14f08067beb831fd214
-  data.tar.gz: bb016368f762b942f75cb7080052683ec83e097e40e95914e3153af2d49261b5ddc9b8e3fef74ccc749ccf15de0d93fcfcbe8b7e91e77a02c1730c1c080e1f95
+  metadata.gz: 64873c5e921eb91012104d263751f1c3ab12239d83595278d2c227e7a7abf07f04d3ca698a2fbee32f4ad301ad44c43b3fc64b18d0a1a15dbcf5bb31db9cb3f1
+  data.tar.gz: e90fa41fd9d91e056aad2f61abe0949c3b70e8d82dad95c8db73a0119009cfd508f7b8eb829a62692d2023a17ee6f961c18594af3ee8f0b0b03c6117e526f6c3

data/.circleci/config.yml

@@ -1,46 +1,120 @@
 version: 2
+
+references:
+  - &setup_requirements
+    name: Install System Dependencies
+    command: |
+      # See also https://circleci.com/docs/2.0/custom-images/#adding-required-and-custom-tools-or-files
+      apk add --update --no-cache --no-progress git openssh-client tar gzip ca-certificates \
+        build-base tzdata
+  - &set_timezone
+    name: Set timezone to Asia/Tokyo
+    command: cp /usr/share/zoneinfo/Asia/Tokyo /etc/localtime
+  - &bundle_install
+    name: Install Ruby Dependencies
+    command: |
+      bundle check || bundle install --jobs=4 --retry=3
+      bundle clean
+  - &rubocop
+    name: Run RuboCop
+    command: rubocop
+  - &rspec
+    name: Run RSpec
+    command: rspec
+
 jobs:
-  build:
-    docker: &docker
-      - image: ruby:2.5.1-alpine
+  build_on_ruby2_3:
+    docker:
+       - image: ruby:2.3-alpine
     working_directory: /work
     steps:
-      - run: &setup_requirements
-          name: Install System Dependencies
-          command: |
-            # See also https://circleci.com/docs/2.0/custom-images/#adding-required-and-custom-tools-or-files
-            apk add --update --no-cache git openssh-client tar gzip ca-certificates \
-              tzdata
-      - run: &set_timezone
-          name: Set timezone to Asia/Tokyo
-          command: cp /usr/share/zoneinfo/Asia/Tokyo /etc/localtime
+      - run: *setup_requirements
+      - run: *set_timezone
       - checkout
-      - restore_cache: &restore_gems_cache
+      - restore_cache:
           name: Restore bundler cache
           keys:
-            - gems-{{ .Environment.COMMON_CACHE_KEY }}-{{ checksum "Gemfile.lock" }}
-            - gems-{{ .Environment.COMMON_CACHE_KEY }}-
-      - run:
-          name: Install Ruby Dependencies
-          command: |
-            bundle check || bundle install --jobs=4 --retry=3
-            bundle clean
-      - save_cache: &save_gems_cache
+            - gems-ruby2.3-{{ .Environment.COMMON_CACHE_KEY }}-{{ checksum "Gemfile.lock" }}
+            - gems-ruby2.3-{{ .Environment.COMMON_CACHE_KEY }}-
+      - run: *bundle_install
+      - save_cache:
           name: Save bundler cache
-          key: gems-{{ .Environment.COMMON_CACHE_KEY }}-{{ checksum "Gemfile.lock" }}
+          key: gems-ruby2.3-{{ .Environment.COMMON_CACHE_KEY }}-{{ checksum "Gemfile.lock" }}
           paths:
             - /usr/local/bundle
-      - run:
-          name: Run RSpec
-          command: rspec
+      - run: *rubocop
+      - run: *rspec
+  build_on_ruby2_4:
+    docker:
+       - image: ruby:2.4-alpine
+    working_directory: /work
+    steps:
+      - run: *setup_requirements
+      - run: *set_timezone
+      - checkout
+      - restore_cache:
+          name: Restore bundler cache
+          keys:
+            - gems-ruby2.4-{{ .Environment.COMMON_CACHE_KEY }}-{{ checksum "Gemfile.lock" }}
+            - gems-ruby2.4-{{ .Environment.COMMON_CACHE_KEY }}-
+      - run: *bundle_install
+      - save_cache:
+          name: Save bundler cache
+          key: gems-ruby2.4-{{ .Environment.COMMON_CACHE_KEY }}-{{ checksum "Gemfile.lock" }}
+          paths:
+            - /usr/local/bundle
+      - run: *rubocop
+      - run: *rspec
+  build_on_ruby2_5:
+    docker:
+       - image: ruby:2.5-alpine
+    working_directory: /work
+    steps:
+      - run: *setup_requirements
+      - run: *set_timezone
+      - checkout
+      - restore_cache:
+          name: Restore bundler cache
+          keys:
+            - gems-ruby2.5-{{ .Environment.COMMON_CACHE_KEY }}-{{ checksum "Gemfile.lock" }}
+            - gems-ruby2.5-{{ .Environment.COMMON_CACHE_KEY }}-
+      - run: *bundle_install
+      - save_cache:
+          name: Save bundler cache
+          key: gems-ruby2.5-{{ .Environment.COMMON_CACHE_KEY }}-{{ checksum "Gemfile.lock" }}
+          paths:
+            - /usr/local/bundle
+      - run: *rubocop
+      - run: *rspec
+  build_on_ruby2_6:
+    docker: &docker_ruby2_6
+       - image: ruby:2.6-alpine
+    working_directory: /work
+    steps:
+      - run: *setup_requirements
+      - run: *set_timezone
+      - checkout
+      - restore_cache: &restore_cache_ruby2_6
+          name: Restore bundler cache
+          keys:
+            - gems-ruby2.6-{{ .Environment.COMMON_CACHE_KEY }}-{{ checksum "Gemfile.lock" }}
+            - gems-ruby2.6-{{ .Environment.COMMON_CACHE_KEY }}-
+      - run: *bundle_install
+      - save_cache:
+          name: Save bundler cache
+          key: gems-ruby2.6-{{ .Environment.COMMON_CACHE_KEY }}-{{ checksum "Gemfile.lock" }}
+          paths:
+            - /usr/local/bundle
+      - run: *rubocop
+      - run: *rspec
   continuous_bundle_update:
-    docker: *docker
+    docker: *docker_ruby2_6
     working_directory: /work
     steps:
       - run: *setup_requirements
       - run: *set_timezone
       - checkout
-      - restore_cache: *restore_gems_cache
+      - restore_cache: *restore_cache_ruby2_6
       - run:
           name: Setup requirements for continuous bundle update
           command: gem install -N circleci-bundle-update-pr
@@ -50,9 +124,12 @@ jobs:
 
 workflows:
   version: 2
-  build:
+  ordinary:
     jobs:
-      - build
+      - build_on_ruby2_3
+      - build_on_ruby2_4
+      - build_on_ruby2_5
+      - build_on_ruby2_6
   nightly:
     triggers:
       - schedule:

data/.rubocop.yml

@@ -0,0 +1,28 @@
+inherit_from: .rubocop_todo.yml
+require: rubocop-rspec
+
+AllCops:
+  DisplayCopNames: true
+  TargetRubyVersion: 2.3
+
+Metrics:
+  Enabled: false
+
+RSpec/DescribedClass:
+  Enabled: false
+
+Style/BlockComments:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
+Style/Documentation:
+  Enabled: false
+
+Style/DoubleNegation:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/IfUnlessModifier:
+  Enabled: false

data/.rubocop_todo.yml

@@ -0,0 +1,8 @@
+Layout/IndentHeredoc:
+  Exclude:
+    - 'lib/circleci/bundle/update/pr.rb'
+
+# See also https://github.com/masutaka/circleci-bundle-update-pr/issues/84
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'lib/circleci/bundle/update/pr.rb'

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in circleci-bundle-update-pr.gemspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    circleci-bundle-update-pr (1.14.4)
+    circleci-bundle-update-pr (1.16.0)
       compare_linker (>= 1.4.0)
       octokit
 
@@ -10,6 +10,7 @@ GEM
   specs:
     addressable (2.5.2)
       public_suffix (>= 2.0.2, < 4.0)
+    ast (2.4.0)
     compare_linker (1.4.3)
       httpclient
       octokit
@@ -17,10 +18,16 @@ GEM
     faraday (0.15.4)
       multipart-post (>= 1.2, < 3)
     httpclient (2.8.3)
+    jaro_winkler (1.5.2)
     multipart-post (2.0.0)
     octokit (4.14.0)
       sawyer (~> 0.8.0, >= 0.5.3)
+    parallel (1.17.0)
+    parser (2.6.2.1)
+      ast (~> 2.4.0)
+    psych (3.1.0)
     public_suffix (3.0.3)
+    rainbow (3.0.0)
     rake (12.3.2)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
@@ -35,9 +42,21 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.0)
+    rubocop (0.67.2)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.5, != 2.5.1.1)
+      psych (>= 3.1.0)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 1.6)
+    rubocop-rspec (1.32.0)
+      rubocop (>= 0.60.0)
+    ruby-progressbar (1.10.0)
     sawyer (0.8.1)
       addressable (>= 2.3.5, < 2.6)
       faraday (~> 0.8, < 1.0)
+    unicode-display_width (1.5.0)
 
 PLATFORMS
   ruby
@@ -50,6 +69,8 @@ DEPENDENCIES
   circleci-bundle-update-pr!
   rake
   rspec (~> 3.7)
+  rubocop
+  rubocop-rspec
 
 BUNDLED WITH
    1.17.2

data/Rakefile

@@ -1,2 +1,3 @@
-require "bundler/gem_tasks"
+# frozen_string_literal: true
 
+require 'bundler/gem_tasks'

data/bin/circleci-bundle-update-pr

@@ -1,6 +1,7 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "circleci/bundle/update/pr"
+require 'circleci/bundle/update/pr'
 require 'optparse'
 
 opt = OptionParser.new
@@ -14,7 +15,7 @@ opt.parse!(ARGV)
 Circleci::Bundle::Update::Pr.create_if_needed(
   git_username: ARGV.shift,
   git_email: ARGV.shift,
-  git_branches: ARGV.empty? ? ["master"] : ARGV,
+  git_branches: ARGV.empty? ? ['master'] : ARGV,
   assignees: options[:assignees],
   reviewers: options[:reviewers],
   labels: options[:labels],

data/circleci-bundle-update-pr.gemspec

@@ -1,26 +1,30 @@
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'circleci/bundle/update/pr/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "circleci-bundle-update-pr"
+  spec.name          = 'circleci-bundle-update-pr'
   spec.version       = Circleci::Bundle::Update::Pr::VERSION
-  spec.authors       = ["Takashi Masuda"]
-  spec.email         = ["masutaka.net@gmail.com"]
-  spec.summary       = %q{Create GitHub PullRequest of bundle update in CircleCI}
-  spec.description   = %q{A script for continues bundle update. Use in CircleCI}
-  spec.homepage      = "https://github.com/masutaka/circleci-bundle-update-pr"
-  spec.license       = "MIT"
+  spec.authors       = ['Takashi Masuda']
+  spec.email         = ['masutaka.net@gmail.com']
+  spec.summary       = 'Provide continues bundle update using CircleCI'
+  spec.description   = 'Create GitHub PullRequest of bundle update in CircleCI'
+  spec.homepage      = 'https://github.com/masutaka/circleci-bundle-update-pr'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
+  spec.add_dependency 'compare_linker', '>= 1.4.0'
   spec.add_dependency 'octokit'
-  spec.add_dependency 'compare_linker', ">= 1.4.0"
 
-  spec.add_development_dependency "bundler"
-  spec.add_development_dependency "rake"
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec', '~> 3.7'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'rubocop-rspec'
 end

data/lib/circleci/bundle/update/pr.rb

@@ -1,13 +1,13 @@
-require "circleci/bundle/update/pr/version"
-require "octokit"
-require "compare_linker"
-require "circleci/bundle/update/pr/note"
+require 'circleci/bundle/update/pr/version'
+require 'octokit'
+require 'compare_linker'
+require 'circleci/bundle/update/pr/note'
 
 module Circleci
   module Bundle
     module Update
       module Pr
-        def self.create_if_needed(git_username: nil, git_email: nil, git_branches: ["master"],
+        def self.create_if_needed(git_username: nil, git_email: nil, git_branches: ['master'],
                                   assignees: nil, reviewers: nil, labels: nil, allow_dup_pr: false)
           raise_if_env_unvalid!
 
@@ -59,6 +59,7 @@ module Circleci
         # @return [Boolean]
         def self.skip?(allow_dup_pr)
           return false if allow_dup_pr
+
           exists_bundle_update_pr?
         end
         private_class_method :skip?
@@ -87,10 +88,11 @@ module Circleci
         #
         # @return [Boolean]
         def self.need_to_commit?
-          unless system("bundle update && bundle update --ruby")
-            raise "Unable to execute `bundle update && bundle update --ruby`"
+          unless system('bundle update && bundle update --ruby')
+            raise 'Unable to execute `bundle update && bundle update --ruby`'
           end
-          `git status -sb 2> /dev/null`.include?("Gemfile.lock")
+
+          `git status -sb 2> /dev/null`.include?('Gemfile.lock')
         end
         private_class_method :need_to_commit?
 
@@ -103,7 +105,7 @@ module Circleci
           system("git remote add github-url-with-token #{remote}")
           system("git config user.name '#{git_username}'")
           system("git config user.email #{git_email}")
-          system("git add Gemfile.lock")
+          system('git add Gemfile.lock')
           system("git commit -m '$ bundle update && bundle update --ruby'")
           system("git branch -M #{branch}")
           system("git push -q github-url-with-token #{branch}")
@@ -127,25 +129,25 @@ module Circleci
         private_class_method :add_labels
 
         def self.update_pull_request_body(pr_number)
-          ENV["OCTOKIT_ACCESS_TOKEN"] = ENV["GITHUB_ACCESS_TOKEN"]
+          ENV['OCTOKIT_ACCESS_TOKEN'] = ENV['GITHUB_ACCESS_TOKEN']
           compare_linker = CompareLinker.new(repo_full_name, pr_number)
           compare_linker.formatter = CompareLinker::Formatter::Markdown.new
 
-          body = <<-EOB
+          body = <<-PR_BODY
 **Updated RubyGems:**
 
 #{compare_linker.make_compare_links.to_a.join("\n")}
 
 Powered by [circleci-bundle-update-pr](https://rubygems.org/gems/circleci-bundle-update-pr)
-          EOB
+          PR_BODY
 
           if Note.exist?
-            body << <<-EOB
+            body << <<-PR_BODY
 
 ---
 
 #{Note.read}
-            EOB
+            PR_BODY
           end
 
           client.update_pull_request(repo_full_name, pr_number, body: body)
@@ -167,7 +169,7 @@ Powered by [circleci-bundle-update-pr](https://rubygems.org/gems/circleci-bundle
             Octokit::Client.new(access_token: ENV['ENTERPRISE_OCTOKIT_ACCESS_TOKEN'],
                                 api_endpoint: ENV['ENTERPRISE_OCTOKIT_API_ENDPOINT'])
           else
-            Octokit::Client.new(access_token: ENV["GITHUB_ACCESS_TOKEN"])
+            Octokit::Client.new(access_token: ENV['GITHUB_ACCESS_TOKEN'])
           end
         end
         private_class_method :client
@@ -192,9 +194,10 @@ Powered by [circleci-bundle-update-pr](https://rubygems.org/gems/circleci-bundle
 
         def self.github_host
           # A format like https://github.com/masutaka/circleci-bundle-update-pr.git
-          return $1 if ENV['CIRCLE_REPOSITORY_URL'] =~ %r{https://(.+?)/}
+          return Regexp.last_match(1) if ENV['CIRCLE_REPOSITORY_URL'] =~ %r{https://(.+?)/}
           # A format like git@github.com:masutaka/compare_linker.git
-          return $1 if ENV['CIRCLE_REPOSITORY_URL'] =~ %r{([^@]+?):}
+          return Regexp.last_match(1) if ENV['CIRCLE_REPOSITORY_URL'] =~ /([^@]+?):/
+
           'github.com'
         end
         private_class_method :github_host

data/lib/circleci/bundle/update/pr/note.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Circleci
   module Bundle
     module Update

data/lib/circleci/bundle/update/pr/version.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module Circleci
   module Bundle
     module Update
       module Pr
-        VERSION = '1.14.4'
+        VERSION = '1.16.0'
       end
     end
   end

data/spec/circleci/bundle/update/pr/note_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'tmpdir'
 
 describe Circleci::Bundle::Update::Pr::Note do
@@ -17,7 +19,7 @@ describe Circleci::Bundle::Update::Pr::Note do
   describe '.exist?' do
     subject { Circleci::Bundle::Update::Pr::Note.exist? }
 
-    context 'given only .circleci/BUNDLE_UPDATE_NOTE.md' do
+    context 'with only .circleci/BUNDLE_UPDATE_NOTE.md' do
       before do
         FileUtils.touch('.circleci/BUNDLE_UPDATE_NOTE.md')
       end
@@ -25,7 +27,7 @@ describe Circleci::Bundle::Update::Pr::Note do
       it { is_expected.to be_truthy }
     end
 
-    context 'given only CIRCLECI_BUNDLE_UPDATE_NOTE.md' do
+    context 'with only CIRCLECI_BUNDLE_UPDATE_NOTE.md' do
       before do
         FileUtils.touch('CIRCLECI_BUNDLE_UPDATE_NOTE.md')
       end
@@ -33,7 +35,7 @@ describe Circleci::Bundle::Update::Pr::Note do
       it { is_expected.to be_truthy }
     end
 
-    context 'given .circleci/BUNDLE_UPDATE_NOTE.md and CIRCLECI_BUNDLE_UPDATE_NOTE.md' do
+    context 'with .circleci/BUNDLE_UPDATE_NOTE.md and CIRCLECI_BUNDLE_UPDATE_NOTE.md' do
       before do
         FileUtils.touch('.circleci/BUNDLE_UPDATE_NOTE.md')
         FileUtils.touch('CIRCLECI_BUNDLE_UPDATE_NOTE.md')
@@ -42,7 +44,7 @@ describe Circleci::Bundle::Update::Pr::Note do
       it { is_expected.to be_truthy }
     end
 
-    context 'given nothing' do
+    context 'with nothing' do
       it { is_expected.to be_falsy }
     end
   end
@@ -50,7 +52,7 @@ describe Circleci::Bundle::Update::Pr::Note do
   describe '.read' do
     subject { Circleci::Bundle::Update::Pr::Note.read }
 
-    context 'given .circleci/BUNDLE_UPDATE_NOTE.md' do
+    context 'with .circleci/BUNDLE_UPDATE_NOTE.md' do
       before do
         File.open('.circleci/BUNDLE_UPDATE_NOTE.md', 'w') { |f| f.write('I am .circleci/BUNDLE_UPDATE_NOTE.md') }
       end
@@ -58,7 +60,7 @@ describe Circleci::Bundle::Update::Pr::Note do
       it { is_expected.to eq 'I am .circleci/BUNDLE_UPDATE_NOTE.md' }
     end
 
-    context 'given CIRCLECI_BUNDLE_UPDATE_NOTE.md' do
+    context 'with CIRCLECI_BUNDLE_UPDATE_NOTE.md' do
       before do
         File.open('CIRCLECI_BUNDLE_UPDATE_NOTE.md', 'w') { |f| f.write('I am CIRCLECI_BUNDLE_UPDATE_NOTE.md') }
       end
@@ -66,7 +68,7 @@ describe Circleci::Bundle::Update::Pr::Note do
       it { is_expected.to eq 'I am CIRCLECI_BUNDLE_UPDATE_NOTE.md' }
     end
 
-    context 'given .circleci/BUNDLE_UPDATE_NOTE.md and CIRCLECI_BUNDLE_UPDATE_NOTE.md' do
+    context 'with .circleci/BUNDLE_UPDATE_NOTE.md and CIRCLECI_BUNDLE_UPDATE_NOTE.md' do
       before do
         File.open('.circleci/BUNDLE_UPDATE_NOTE.md', 'w') { |f| f.write('I am .circleci/BUNDLE_UPDATE_NOTE.md') }
         File.open('CIRCLECI_BUNDLE_UPDATE_NOTE.md', 'w') { |f| f.write('I am CIRCLECI_BUNDLE_UPDATE_NOTE.md') }
@@ -75,7 +77,7 @@ describe Circleci::Bundle::Update::Pr::Note do
       it { is_expected.to eq 'I am .circleci/BUNDLE_UPDATE_NOTE.md' }
     end
 
-    context 'given nothing' do
+    context 'with nothing' do
       it { is_expected.to be_nil }
     end
   end

data/spec/circleci/bundle/update/pr_spec.rb

@@ -1,45 +1,54 @@
+# frozen_string_literal: true
+
 describe Circleci::Bundle::Update::Pr do
   describe '.github_host' do
     subject { Circleci::Bundle::Update::Pr.send(:github_host) }
+
     after { ENV['CIRCLE_REPOSITORY_URL'] = nil }
 
-    context 'given git@github.com:masutaka/compare_linker.git' do
+    context "when ENV['CIRCLE_REPOSITORY_URL'] is git@github.com:masutaka/compare_linker.git" do
       before { ENV['CIRCLE_REPOSITORY_URL'] = 'git@github.com:masutaka/compare_linker.git' }
+
       it { is_expected.to eq 'github.com' }
     end
 
-    context 'given https://github.com/masutaka/circleci-bundle-update-pr.git' do
+    context "when ENV['CIRCLE_REPOSITORY_URL'] is https://github.com/masutaka/circleci-bundle-update-pr.git" do
       before { ENV['CIRCLE_REPOSITORY_URL'] = 'https://github.com/masutaka/circleci-bundle-update-pr.git' }
+
       it { is_expected.to eq 'github.com' }
     end
 
-    context 'given nil' do
+    context "with ENV['CIRCLE_REPOSITORY_URL'] is nil" do
       before { ENV['CIRCLE_REPOSITORY_URL'] = nil }
+
       it { is_expected.to eq 'github.com' }
     end
   end
 
-  describe ".target_branch?" do
+  describe '.target_branch?' do
     subject do
       Circleci::Bundle::Update::Pr.send(
         :target_branch?,
         running_branch: running_branch,
-        target_branches: ["target"],
+        target_branches: ['target']
       )
     end
 
-    context "running_target is included in target branches" do
+    context 'when running_target is included in target branches' do
       let(:running_branch) { 'target' }
+
       it { is_expected.to be_truthy }
     end
 
-    context "ENV['CIRCLE_BRANCH'] is not included in target branches" do
+    context "when ENV['CIRCLE_BRANCH'] is not included in target branches" do
       let(:running_branch) { 'not_included' }
+
       it { is_expected.to be_falsy }
     end
 
-    context "ENV['CIRCLE_BRANCH'] is nil" do
+    context "when ENV['CIRCLE_BRANCH'] is nil" do
       let(:running_branch) { nil }
+
       it { is_expected.to be_falsy }
     end
   end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'circleci/bundle/update/pr'
 
 # This file was generated by the `rspec --init` command. Conventionally, all

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: circleci-bundle-update-pr
 version: !ruby/object:Gem::Version
-  version: 1.14.4
+  version: 1.16.0
 platform: ruby
 authors:
 - Takashi Masuda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-14 00:00:00.000000000 Z
+date: 2019-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: octokit
+  name: compare_linker
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.4.0
 - !ruby/object:Gem::Dependency
-  name: compare_linker
+  name: octokit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -80,7 +80,35 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.7'
-description: A script for continues bundle update. Use in CircleCI
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Create GitHub PullRequest of bundle update in CircleCI
 email:
 - masutaka.net@gmail.com
 executables:
@@ -91,6 +119,8 @@ files:
 - ".circleci/config.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -126,7 +156,7 @@ requirements: []
 rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
-summary: Create GitHub PullRequest of bundle update in CircleCI
+summary: Provide continues bundle update using CircleCI
 test_files:
 - spec/circleci/bundle/update/pr/note_spec.rb
 - spec/circleci/bundle/update/pr_spec.rb