cineworld_uk 4.3.1-aarch64-linux-gnu → 4.3.2-aarch64-linux-gnu

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 20a7a31fc492ed6b31e0047b5c41ff199ebf519c92629e7093a3dce5239e8982
-  data.tar.gz: '05893e4d311d0fe22a5f4b79279fbf8c9ce880be15ef33ccc2786bd8f14d5240'
+  metadata.gz: 14cb5242f05eeed5d33d552343b6e8776c0c503dcf5ffc160da8c27a12f64f7e
+  data.tar.gz: 15f50f8493be63748390c5511bc8d9def8ce730a67c79e07f53df602f89f64cc
 SHA512:
-  metadata.gz: 0a95217187527f30820ec7f0c6b562809a4d7d75ef1413eeeef2cbeccf850ad31caa83a1d13908e787d5d2e772fc74bb4bcead1d4ec8d793a513627f17ccbeab
-  data.tar.gz: b95d72f18095738d9f6cbdba38b695f2d3a4274ced24735629c25b0bd05c9b7feb9785831ffe705144e7229dfb909605912adca7147ff12e4805faa36081515b
+  metadata.gz: 700a1af26d3110e3b2b920144280a53d2892390ba7e08d87e268b8ca54e8e79e327e0dfd7a2b02c136a554f2d0225966e9ffb4a18d3bb843f6b9e7815d5eec24
+  data.tar.gz: b6a2b40e8b5f0df0a12f3c357245ef150d87042b0131ed350b754e7d227b9141d3e794318cef2e6804b5052c9b7c48e80b10d094424c4ea2e007f2465b0cfbcb

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 4.3.2 - 2026-10-22
+
+### Changed
+- Reuse one Vista client, and so one kept-alive connection, per thread instead of opening a TLS connection for every request. Requires cinebase 5.5. A cinema day now takes about 0.19s rather than 0.37s.
+
 ## 4.3.1 - 2026-10-22
 
 ### Fixed

data/README.md

@@ -229,7 +229,7 @@ To build and check just one platform on a matching host:
 
 ```sh
 bundle exec rake 'package:native[x86_64-linux-gnu]'
-CINEWORLD_PACKAGE=pkg/cineworld_uk-4.3.1-x86_64-linux-gnu.gem bundle exec ruby test/package_test.rb
+CINEWORLD_PACKAGE=pkg/cineworld_uk-4.3.2-x86_64-linux-gnu.gem bundle exec ruby test/package_test.rb
 ```
 
 Native packaging downloads pinned upstream archives at **build time**, verifies

data/cineworld_uk.gemspec

@@ -25,6 +25,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'simplecov', '< 1'
   spec.add_development_dependency 'webmock'
 
-  spec.add_runtime_dependency 'cinebase', '~> 5.4'
+  spec.add_runtime_dependency 'cinebase', '~> 5.5'
   spec.add_runtime_dependency 'nokogiri', '>= 1.11'
 end

data/lib/cineworld_uk/internal/api_response.rb

@@ -86,8 +86,17 @@ module CineworldUk
       private
 
       def fetch(path, query = {})
-        Cinebase::Vista::Client.new(base_url: BASE_URL, region_code: "GB",
-                                    token: CineworldUk.token).get(path, query)
+        client.get(path, query)
+      end
+
+      # One client keeps one connection open, so reuse it until the token changes.
+      def client
+        token = CineworldUk.token
+        if @client.nil? || @client_token != token
+          @client_token = token
+          @client = Cinebase::Vista::Client.new(base_url: BASE_URL, region_code: "GB", token: token)
+        end
+        @client
       end
     end
   end

data/lib/cineworld_uk/performance.rb

@@ -56,9 +56,13 @@ module CineworldUk
 
     # private
 
+    API = :cineworld_uk_performance_api
+
     # @api private
+    # One API, and so one kept-alive connection, per thread: job runners
+    # import several cinemas at once.
     def self.api
-      @api ||= Internal::ApiResponse.new
+      Thread.current[API] ||= Internal::ApiResponse.new
     end
     private_class_method :api
 

data/lib/cineworld_uk/version.rb

@@ -1,6 +1,6 @@
 # Ruby interface for http://www.cineworld.co.uk
-# @version 4.3.1
+# @version 4.3.2
 module CineworldUk
   # Gem version
-  VERSION = "4.3.1".freeze
+  VERSION = "4.3.2".freeze
 end

data/test/lib/cineworld_uk/internal/api_response_test.rb

@@ -14,6 +14,45 @@ class CineworldUk::Internal::ApiResponseTest < Minitest::Test
     super
   end
 
+  def test_reuses_one_client_while_the_token_holds
+    stub_request(:get, "#{BASE_URL}sites").to_return(body: '{"sites":[]}')
+    api = CineworldUk::Internal::ApiResponse.new
+
+    clients = count_clients { 3.times { api.cinema_list } }
+
+    assert_equal 1, clients
+  end
+
+  def test_builds_a_new_client_for_a_new_token
+    stub_request(:get, "#{BASE_URL}sites").to_return(body: '{"sites":[]}')
+    api = CineworldUk::Internal::ApiResponse.new
+
+    clients = count_clients do
+      api.cinema_list
+      CineworldUk.token = "renewed-token"
+      api.cinema_list
+    end
+
+    assert_equal 2, clients
+  end
+
+  def test_each_thread_has_its_own_performance_api
+    main = CineworldUk::Performance.send(:api)
+
+    other = Thread.new { CineworldUk::Performance.send(:api) }.value
+
+    assert_same main, CineworldUk::Performance.send(:api)
+    refute_same main, other
+  end
+
+  def count_clients
+    clients = 0
+    original = Cinebase::Vista::Client.method(:new)
+    counting = ->(**options) { clients += 1; original.call(**options) }
+    Cinebase::Vista::Client.stub(:new, counting) { yield }
+    clients
+  end
+
   def test_rejects_missing_token
     CineworldUk.token = nil
 

data/test/support/vista_fixtures.rb

@@ -53,6 +53,7 @@ module Support
       [CineworldUk::Cinema, CineworldUk::Performance].each do |klass|
         klass.instance_variables.each { |name| klass.remove_instance_variable(name) }
       end
+      Thread.current[CineworldUk::Performance::API] = nil if defined?(CineworldUk::Performance::API)
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cineworld_uk
 version: !ruby/object:Gem::Version
-  version: 4.3.1
+  version: 4.3.2
 platform: aarch64-linux-gnu
 authors:
 - Andy Croll
@@ -113,14 +113,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.4'
+        version: '5.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.4'
+        version: '5.5'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement