cineworld_uk 3.0.2 → 3.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ebbf1f918885187d0b5018962df36b462f28a0b4
-  data.tar.gz: c543d3705fef10efaf8040ff46df581472a10b78
+  metadata.gz: 487458108a3bd3d3c9c4c80662db1f9e1da34a3f
+  data.tar.gz: 2a314a2557cf8507863f7a316067f1b2131a9ab0
 SHA512:
-  metadata.gz: fccdbaef9c63ddd2c87a76bdef0f3f3994f964aa806c2054029a823e994adad0199d01e43f60d5022c5f08428390cfc95592305ca4ed9cb97b6ac7c2d848a4aa
-  data.tar.gz: 35f472840f1c329e871b71b2c41483b7ace212ea8c44f63ee4d7e2627d37fe655fb30145bc9e52840fff04ac4cfbe16929e6af2214ec6a84cc0f092823bcde3b
+  metadata.gz: c322a658ed67ab7b87226bddca7330da2cb87109c3b45cd3b998af747e7ed650053d7ff7d033a510439af5f86fea6607701d7453334278dd315e8682ad4e9a02
+  data.tar.gz: 69b3c6a0aaf283904e613142eea47e89db02b2c4cea1014ca536c9065d627aafab44051d5bd8b19bfc45f1c70dbd4261c1aaa5b7602dc995f96d8f034185a749

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 3.0.3 - 2016-02-10
+
+### Changed
+- Performance.at uses a Fixnum internally
+
 ## 3.0.2 - 2016-02-09
 
 ### Added

data/lib/cineworld_uk/cinema.rb

@@ -4,10 +4,12 @@ module CineworldUk
     # @!attribute [r] id
     #   @return [Integer] the numeric id of the cinema on the Cineworld website
 
-    # @!method initialize(id)
-    #   Constructor
-    #   @param [Integer, String] id cinema id
-    #   @return [CineworldUk::Cinema]
+    # Constructor
+    # @param [Integer, String] id cinema id
+    # @return [CineworldUk::Cinema]
+    def initialize(id)
+      @id = id.to_i
+    end
 
     # Return basic cinema information for all cinemas
     # @return [Array<CineworldUk::Cinema>]

data/lib/cineworld_uk/performance.rb

@@ -26,6 +26,7 @@ module CineworldUk
     # @param [Integer] cinema_id id of the cinema on the website
     # @return [Array<CineworldUk::Screening>]
     def self.at(cinema_id)
+      cinema_id = cinema_id.to_i
       dates(cinema_id).flat_map do |date|
         performances_on(cinema_id, date).flat_map do |p|
           new cinema_hash(cinema_id).merge(p)

data/lib/cineworld_uk/version.rb

@@ -1,6 +1,6 @@
 # Ruby interface for http://www.cineworld.co.uk
-# @version 3.0.2
+# @version 3.0.3
 module CineworldUk
   # Gem version
-  VERSION = '3.0.2'.freeze
+  VERSION = '3.0.3'.freeze
 end

data/test/lib/cineworld_uk/cinema_test.rb

@@ -114,6 +114,16 @@ describe CineworldUk::Cinema do
       end
     end
 
+    describe 'simple name (Brighton) called with String' do
+      let(:id) { '3' }
+
+      it 'returns the brand in the name' do
+        CineworldUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_equal 'Cineworld Brighton'
+        end
+      end
+    end
+
     describe 'complex name (Glasgow IMAX)' do
       let(:id) { 88 }
 

data/test/lib/cineworld_uk/performance_test.rb

@@ -11,7 +11,7 @@ describe CineworldUk::Performance do
   after { WebMock.allow_net_connect! }
 
   describe '.at(cinema_id)' do
-    subject { described_class.at(3) }
+    subject { described_class.at(cinema_id) }
 
     before do
       api_response.expect(:cinema_list, cinema_list_json)
@@ -23,18 +23,41 @@ describe CineworldUk::Performance do
                           [3, Date.today + 1])
     end
 
-    it 'returns an array of performances' do
-      CineworldUk::Internal::ApiResponse.stub :new, api_response do
-        subject.must_be_instance_of(Array)
-        subject.each do |performance|
-          performance.must_be_instance_of(described_class)
+    describe 'called with integer' do
+      let(:cinema_id) { 3 }
+
+      it 'returns an array of performances' do
+        CineworldUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_be_instance_of(Array)
+          subject.each do |performance|
+            performance.must_be_instance_of(described_class)
+          end
+        end
+      end
+
+      it 'returns at least a sensible number' do
+        CineworldUk::Internal::ApiResponse.stub :new, api_response do
+          subject.count.must_be :>, 5
         end
       end
     end
 
-    it 'returns at least a sensible number' do
-      CineworldUk::Internal::ApiResponse.stub :new, api_response do
-        subject.count.must_be :>, 5
+    describe 'called with string' do
+      let(:cinema_id) { '3' }
+
+      it 'returns an array of performances' do
+        CineworldUk::Internal::ApiResponse.stub :new, api_response do
+          subject.must_be_instance_of(Array)
+          subject.each do |performance|
+            performance.must_be_instance_of(described_class)
+          end
+        end
+      end
+
+      it 'returns at least a sensible number' do
+        CineworldUk::Internal::ApiResponse.stub :new, api_response do
+          subject.count.must_be :>, 5
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cineworld_uk
 version: !ruby/object:Gem::Version
-  version: 3.0.2
+  version: 3.0.3
 platform: ruby
 authors:
 - Andy Croll
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-09 00:00:00.000000000 Z
+date: 2016-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler