cineworld_uk 2.1.1 → 2.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8d3988973fca9514cfe44b60244650dbe5d2d92a
-  data.tar.gz: 7b4e3b7ca15920c3914b6e56909a766eef981856
+  metadata.gz: 20a09c3d7ac65fa3cbed58f12ddea318eb5b4278
+  data.tar.gz: dbe8959a56d9051b3cdb843a0d042f30a2ab22b9
 SHA512:
-  metadata.gz: 2f41d91e4ec3ba503693dfbe4c5d954db0d2a074f265be9a019bdc4796c7a674aac106c2e784f64b2316e5e8244b1d5ebf17285e1e055208a052e19de21bd3de
-  data.tar.gz: 327dfa5a595d1ff11c89105ade182fa4675cdcf9608f4972ea62a1fa052fe042249f363d87283257122760e4278ab40c5ad4d7f0f33f5f69d6fe97bfa29a0c0b
+  metadata.gz: 5efe8ed183e87ce42d3436d48a9107b65d6d3e999a6b4e634aa65537dce8ffed5bcb047e15df6d79256808291676475539592248d83a15ebd2c974e1b6f3c113
+  data.tar.gz: 2bc533fecfdcfa5e15b50d84fd062f930072d9f9d6fc41b6b7b4fb6c2d5bb279d81f9ae073ec2b0f5a938afd2988c569cfa822663f8f7caf6b9eea27701bf8f6

data/CHANGELOG.md

@@ -1,57 +1,70 @@
-## 2.1.1 _30th September 2014_
+# Change Log
 
-Bug fix
+All notable changes to this project will be documented in this file.
 
+
+## 2.1.2 - 2014-10-20
+
+### Added
+- better title sanitization
+- ENO -> English National Opera
+
+### Fixed
+- typos in the test suite
+
+
+## 2.1.1 - 2014-09-30
+
+### Fixed
 - pilot error
 
-## 2.1.0 _30th September 2014_
 
-Feature
+## 2.1.0 2014-09-30
 
+### Added
 - Name Sanitization
 
-Bugfix
-
+### Fixed
 - Films with no 'link' on the screenings page now parsed
 
-## 2.0.5 _28th September 2014_
 
-Bugfix
+## 2.0.5 2014-09-28
 
+### Fixed
 - fix cinema parsing call to website class
 
-## 2.0.4 _5th September 2014_
 
-Bugfix
+## 2.0.4 2014-09-05
 
+### Fixed
 - fix the parsing
 
-## 2.0.3 _5th September 2014_
 
-Bugfix
+## 2.0.3 2014-09-05
 
+### Fixed
 - fix the Website class and use `open-uri`
 
-## 2.0.2 _25th July 2014_
 
-Bugfix
+## 2.0.2 2014-07-25
 
+### Fixed
 - bad behaviour for screening#variant
 
-## 2.0.1 _25th July 2014_
 
-Bugfix
+## 2.0.1 2014-07-25
 
+### Fixed
 - httparty still required, oops
 
-## 2.0.0 _25th July 2014_
 
-Bugfix
+## 2.0.0 2014-07-25
 
+### Fixed
 - Cineworld changed their markup
+- General Rubocop improvements
 
-Features
-
+### Added
 - Less logic in the Cinema class. Moved to `Film` and `Screening`.
 - Introduce `Internal::Website` class for all website comms
 - Rewrite Parsers and tests to be less exact but less fragile
@@ -59,59 +72,56 @@ Features
 - Build `WhatsonParser` to break into 'films with screenings'
 - `FilmWithScreenings` then uses `ScreeningParser` class to get individual screening info
 - `ruby test/fixture_updator.rb` produces new fixtures from the live website
-  - it will break a few tests when run and committed but most should be ok
 - documentation
+- Travis gets Ruby 2.1.2
 
-Under the hood
-
+### Removed
 - Remove dependancy on HTTParty
-- Travis gets Ruby 2.1.2
-- General Rubocop improvements
 
-## 1.0.6 _28th Feb 2014_
 
-Bugfix
+## 1.0.6 2014-02-28
 
+### Fixed
 - UTF encoding in Titleize internal class for ruby 1.9.3
 
-## 1.0.5 _28th Feb 2014_
 
-Bugfix
+## 1.0.5 2014-02-28
 
+### Fixed
 - Vestigal require of titleize gem
 
-## 1.0.4 _27th Feb 2014_
 
-Under the hood
+## 1.0.4 2014-02-27
 
+### Added
 - Standardizing film names using modified titlecase from `titlecase` gem
 - Film name parsing now moved to seperate class
-- rake console task added
+- `rake console` task added
 - MRI 2.1.0 support on Travis CI
 
-## 1.0.3, _16th Jan 2014_
 
-Additional methods
+## 1.0.3 2014-01-16
 
+### Added
 - cinema#full_name including cinema brand
 - tidy up cinema naming to use colons
 
-## 1.0.2, _3rd Jan 2014_
 
-Under the hood
+## 1.0.2 2014-01-03
 
+### Added
 - deal with HFR screenings, bloody hobbitses
 
-## 1.0.1, _3rd Jan 2014_
 
-External interface
+## 1.0.1 2014-01-03
 
+### Added
 - screening#variant for spelling win, #varient maintained for compatability
 
-## 1.0.0, _6th Dec 2013_
 
-First ready-for-public release
+## 1.0.0 2013-12-06
 
+### Added
 - Added changelog
 - added booking url to screenings
 - screenings created with UTC Time objects not strings

data/lib/cineworld_uk/internal/film_with_screenings_parser.rb

@@ -23,6 +23,8 @@ module CineworldUk
       # attributes of all the screenings
       # @return [Array<Hash>]
       def to_a
+        return [] unless performances_doc
+
         performances_doc.map do |node|
           next unless screening_parser_hash(node)
           screening_parser_hash(node).merge(film_hash)

data/lib/cineworld_uk/internal/title_sanitizer.rb

@@ -19,11 +19,14 @@ module CineworldUk
         '- Special Performance',        # special performance
         /\ATake 2 -/,                   # take 2
         ' - Movies for Juniors',        # movies for juniors
+        '(IMAX)',                       # IMAX
+        'SciScreen: ',                  # SciScreen
       ]
 
       # regexes and their replacements
       REPLACE = {
         /Bolshoi Ballet: (.*)/         => 'Bolshoi: ',
+        /ENO: (.*)/i                   => 'English National Opera: ',
         /Guardian Live - (.*)/         => 'The Guardian: ',
         /Met Opera - (.*)/i            => 'Met Opera: ',
         /NT Live: (.*)/                => 'National Theatre: ',

data/lib/cineworld_uk/screening.rb

@@ -32,9 +32,9 @@ module CineworldUk
     # @param [Integer] cinema_id id of the cinema on the website
     # @return [Array<CineworldUk::Screening>]
     def self.at(cinema_id)
-      whatson_parser(cinema_id).films_with_screenings.map do |html|
+      whatson_parser(cinema_id).films_with_screenings.flat_map do |html|
         create_for_single_film(html, cinema_id)
-      end.flatten
+      end
     end
 
     # The date of the screening

data/lib/cineworld_uk/version.rb

@@ -1,6 +1,6 @@
 # Ruby interface for http://www.cineworld.co.uk
-# @version 2.1.1
+# @version 2.1.2
 module CineworldUk
   # Gem version
-  VERSION = '2.1.1'
+  VERSION = '2.1.2'
 end

data/test/lib/cineworld_uk/cinema_test.rb

@@ -299,8 +299,4 @@ describe CineworldUk::Cinema do
   def information_html(filename)
     read_file("../../../fixtures/information/#{filename}.html")
   end
-
-  def parse(html)
-    Nokogiri::HTML(html)
-  end
 end

data/test/lib/cineworld_uk/internal/title_sanitizer_test.rb

@@ -46,7 +46,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       end
     end
 
-    describe 'Bolshoi screeening' do
+    describe 'Bolshoi screening' do
       let(:title) { 'Bolshoi Ballet: The Legend of Love' }
 
       it 'removes prefix' do
@@ -54,7 +54,23 @@ describe CineworldUk::Internal::TitleSanitizer do
       end
     end
 
-    describe 'Met Opera screeening' do
+    describe 'English National Opera screening' do
+      let(:title) { 'ENO: La Traviata ' }
+
+      it 'removes prefix' do
+        subject.must_equal('English National Opera: La Traviata')
+      end
+    end
+
+    describe 'with IMAX' do
+      let(:title) { '(IMAX) Fury' }
+
+      it 'removes prefix' do
+        subject.must_equal('Fury')
+      end
+    end
+
+    describe 'Met Opera screening' do
       let(:title) { 'MET Opera - Le Nozze Di Figaro' }
 
       it 'removes prefix' do
@@ -62,7 +78,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       end
     end
 
-    describe 'NT Live screeening' do
+    describe 'NT Live screening' do
       let(:title) { 'NT Live Encore: Frankenstein (starring Benedict Cumberbatch)' }
 
       it 'removes prefix' do
@@ -70,7 +86,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       end
     end
 
-    describe 'National Theatre screeening' do
+    describe 'National Theatre screening' do
       let(:title) { 'NT Live: Treasure Island' }
 
       it 'removes prefix' do
@@ -78,7 +94,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       end
     end
 
-    describe 'National Theatre Encore screeening' do
+    describe 'National Theatre Encore screening' do
       let(:title) { 'NT Live: A Streetcar Named Desire (Young Vic) - Encore' }
 
       it 'removes prefix' do
@@ -86,7 +102,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       end
     end
 
-    describe 'ROH screeening' do
+    describe 'ROH screening' do
       let(:title) { 'ROH - I Due Foscari' }
 
       it 'removes prefix' do
@@ -94,7 +110,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       end
     end
 
-    describe 'RSC screeening' do
+    describe 'RSC screening' do
       let(:title) { "RSC Live: Love's Labour's Lost" }
 
       it 'removes prefix' do
@@ -102,7 +118,15 @@ describe CineworldUk::Internal::TitleSanitizer do
       end
     end
 
-    describe 'special screeening' do
+    describe 'SciScreen screening' do
+      let(:title) { 'SciScreen: Dallas Buyers Club' }
+
+      it 'removes prefix' do
+        subject.must_equal('Dallas Buyers Club')
+      end
+    end
+
+    describe 'special screening' do
       let(:title) { 'Billy Elliot The Musical Live - Special Performance' }
 
       it 'removes prefix' do
@@ -110,7 +134,7 @@ describe CineworldUk::Internal::TitleSanitizer do
       end
     end
 
-    describe 'Take 2 screeening' do
+    describe 'Take 2 screening' do
       let(:title) { 'Take 2 - Boyhood' }
 
       it 'removes prefix' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cineworld_uk
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 2.1.2
 platform: ruby
 authors:
 - Andy Croll
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-30 00:00:00.000000000 Z
+date: 2014-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler