cia 0.5.1 → 0.5.2

data/.travis.yml

@@ -1,4 +1,3 @@
 rvm:
-  - ree
-  - 1.9.2
   - 1.9.3
+  - 2.0.0

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cia (0.5.1)
+    cia (0.5.2)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/cia
   specs:
-    cia (0.4.4)
+    cia (0.5.1)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails3.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/cia
   specs:
-    cia (0.4.4)
+    cia (0.5.1)
 
 GEM
   remote: https://rubygems.org/

data/lib/cia.rb

@@ -38,7 +38,7 @@ module CIA
     return if options and options[:unless] and source.send(options[:unless])
 
     changes = (source.cia_previous_changes || source.cia_changes).slice(*source.class.audited_attributes)
-    message = source.audit_message if source.respond_to?(:audit_message)
+    message = source.audit_message.presence if source.respond_to?(:audit_message)
 
     return if not message and changes.empty? and action.to_s == "update"
 

data/lib/cia/version.rb

@@ -1,3 +1,3 @@
 module CIA
-  VERSION = '0.5.1'
+  VERSION = '0.5.2'
 end

data/spec/cia/event_spec.rb

@@ -43,12 +43,12 @@ describe CIA::Event do
     end
 
     it "does not validates source when source_display_name is present" do
-      create_event(:source_id => -111, :source_type => 'FakeTypeHere', :source_display_name => 'abc')
+      create_event(:source => nil, :source_id => -111, :source_type => 'FakeTypeHere', :source_display_name => 'abc')
     end
 
     it "validates source when source_display_name is blank" do
       expect{
-        create_event(:source_id => -111, :source_type => 'FakeTypeHere', :source_display_name => '')
+        create_event(:source => nil, :source_id => -111, :source_type => 'FakeTypeHere', :source_display_name => '')
       }.to raise_error
     end
   end

data/spec/cia_spec.rb

@@ -211,6 +211,15 @@ describe CIA do
         event.attribute_changes.map { |c| [c.attribute_name, c.old_value, c.new_value] }
       end
 
+      def no_audit_created!
+        event = nil
+        expect{
+          event = yield
+        }.to_not change{ CIA::Event.count }
+
+        event.should == nil
+      end
+
       it "records attributes in transaction" do
         event = nil
         CIA.audit :actor => User.create!, :ip_address => "1.2.3.4" do
@@ -262,12 +271,7 @@ describe CIA do
       it "does not record unaudited attribute changes" do
         source = Car.create!
         source.drivers = 2
-        event = nil
-        expect{
-          event = CIA.record(:update, source)
-        }.to_not change{ CIA::Event.count }
-
-        event.should == nil
+        no_audit_created!{ CIA.record(:update, source) }
       end
 
       it "records audit_message as message even if there are no changes" do
@@ -279,10 +283,15 @@ describe CIA do
         parse_event_changes(event).should == []
       end
 
+      it "does not record if it's empty and there are no changes" do
+        source = CarWithAMessage.create!
+        source.audit_message = "   "
+        no_audit_created!{ CIA.record(:update, source) }
+      end
+
       it "record non-updates even without changes" do
         source = Car.create!
         event = CIA.record(:create, source)
-
         parse_event_changes(event).should == []
       end
     end

data/spec/spec_helper.rb

@@ -15,6 +15,7 @@ ActiveRecord::Base.establish_connection(
   :database => ":memory:"
 )
 
+ActiveRecord::Schema.verbose = false
 ActiveRecord::Schema.define(:version => 1) do
   eval(File.read(File.expand_path('../../MIGRATION.rb', __FILE__)))
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cia
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-03 00:00:00.000000000 Z
+date: 2013-04-11 00:00:00.000000000 Z
 dependencies: []
 description: 
 email: michael@grosser.it
@@ -53,7 +53,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 763715577879063056
+      hash: 3219662641279385344
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -62,7 +62,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 763715577879063056
+      hash: 3219662641279385344
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25