cia 0.3.4 → 0.3.5

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cia (0.3.4)
+    cia (0.3.5)
 
 GEM
   remote: http://rubygems.org/

data/gemfiles/rails2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/cia
   specs:
-    cia (0.3.3)
+    cia (0.3.4)
 
 GEM
   remote: http://rubygems.org/

data/gemfiles/rails3.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/cia
   specs:
-    cia (0.3.3)
+    cia (0.3.4)
 
 GEM
   remote: http://rubygems.org/

data/lib/cia.rb

@@ -32,12 +32,13 @@ module CIA
 
     return if not message and changes.empty? and action.to_s == "update"
 
-    event = CIA::Event.create!(current_transaction.merge(
+    event = CIA::Event.new(current_transaction.merge(
       :action => action.to_s,
       :source => source,
       :message => message
     ))
-    event.record_attribute_changes!(changes)
+    event.add_attribute_changes(changes)
+    event.save!
     event
   rescue Object => e
     if exception_handler

data/lib/cia/event.rb

@@ -19,9 +19,10 @@ module CIA
     end
 
     # tested via transaction_test.rb
-    def record_attribute_changes!(changes)
+    def add_attribute_changes(changes)
       changes.each do |attribute_name, (old_value, new_value)|
-        attribute_changes.create!(
+        attribute_changes.build(
+          :event => self,
           :attribute_name => attribute_name,
           :old_value => old_value,
           :new_value => new_value,

data/lib/cia/version.rb

@@ -1,3 +1,3 @@
 module CIA
-  VERSION = '0.3.4'
+  VERSION = '0.3.5'
 end

data/spec/cia/attribute_change_spec.rb

@@ -1,6 +1,23 @@
 require 'spec_helper'
 
 describe CIA::AttributeChange do
+  it "stores times as db format" do
+    create_change(:old_value => Time.at(123456789)).reload.old_value.sub(/\.\d+$/,'').should == "1973-11-29 13:33:09"
+  end
+
+  it "stores dates as db format" do
+    create_change(:old_value => Date.new(2012)).reload.old_value.should == "2012-01-01"
+  end
+
+  it "stores booleans as db format" do
+    create_change(:old_value => false).reload.old_value.should == "f"
+    create_change(:old_value => true).reload.old_value.should == "t"
+  end
+
+  it "stores nil as nil" do
+    create_change(:old_value => nil).reload.old_value.should == nil
+  end
+
   it "delegates create_at to event" do
     t = Time.now
     event = CIA::Event.new(:created_at => t)

data/spec/cia_spec.rb

@@ -119,32 +119,40 @@ describe CIA do
       it "records attribute creations" do
         source = Car.create!
         source.wheels = 4
-        event = CIA.record(:update, source)
+        event = CIA.record(:update, source).reload
 
         parse_event_changes(event).should == [["wheels", nil, "4"]]
       end
 
+      it "can act on attributes in before_save" do
+        x = nil
+        CIA.current_transaction[:hacked_before_save_action] = lambda{|event| x = event.attribute_changes.size }
+        source = Car.create!
+        source.wheels = 4
+        CIA.record(:update, source)
+        x.should == 1
+      end
+
       it "records multiple attributes" do
         source = CarWith3Attributes.create!
         source.wheels = 4
         source.drivers = 2
         source.color = "red"
-        event = CIA.record(:update, source)
-
+        event = CIA.record(:update, source).reload
         parse_event_changes(event).should =~ [["wheels", nil, "4"], ["drivers", nil, "2"], ["color", nil, "red"]]
       end
 
       it "records attribute changes" do
         source = Car.create!(:wheels => 2)
         source.wheels = 4
-        event = CIA.record(:update, source)
+        event = CIA.record(:update, source).reload
         parse_event_changes(event).should == [["wheels", "2", "4"]]
       end
 
       it "records attribute deletions" do
         source = Car.create!(:wheels => 2)
         source.wheels = nil
-        event = CIA.record(:update, source)
+        event = CIA.record(:update, source).reload
         parse_event_changes(event).should == [["wheels", "2", nil]]
       end
 

data/spec/spec_helper.rb

@@ -68,3 +68,13 @@ def create_change(options={})
   event = options.delete(:event) || create_event
   CIA::AttributeChange.create!({:event => event, :source => event.source, :attribute_name => "bar"}.merge(options))
 end
+
+# simulate a hacked cia event
+CIA::Event.class_eval do
+  before_save :hacked_before_save
+  attr_accessor :hacked_before_save_action
+
+  def hacked_before_save
+    hacked_before_save_action.call(self) if hacked_before_save_action
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cia
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-10 00:00:00.000000000 Z
+date: 2012-09-11 00:00:00.000000000 Z
 dependencies: []
 description: 
 email: michael@grosser.it
@@ -53,7 +53,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1027248915022211509
+      hash: 4110523684065790258
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -62,7 +62,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1027248915022211509
+      hash: 4110523684065790258
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24