ci_toolkit 1.6.3 → 1.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 160688a62bc8bfc33855fbdff7cdad68442b2f889d2b61ff097072db98c65e6c
-  data.tar.gz: a67225ba9ad09394dabe6f5069dfe080bde1a3765c71b1694f1197a32cc1b613
+  metadata.gz: bf8748ff0d666c907fac0f8bb328531e6536c49b19cd39fd99662d8aea067d8a
+  data.tar.gz: 79caaeae3543c703d77c8f239c3b7f37e0d86aae44f78a22c542e7694855a11a
 SHA512:
-  metadata.gz: aa002219f7cbaf57a8677e567ef16651037a86fd7cdc127e979bcb70d625940b586ceff489f92f37655014d7b7d565c25901bd85ae5b048da2f53bd68771efee
-  data.tar.gz: 8fc239ad0866169020e73e5b396d6fb51a9e8aa257a9b75b8727b91292041e606cc74dc80df1432e7dc90953b83be2ecf03ef3fbe57e701ca52167133640e29a
+  metadata.gz: 88c8227691bc19dac3d5b6c7b79a785067780d1021488035b355dcbd9f02c70250196db31410c6ff245187ab7fa1376dd98f4f07117c8a2aa208eaf60c93a261
+  data.tar.gz: fb4df2fe415536e4a61872a93f507da43e0378b47af051050e35b4b82fc10413c153ad065e87c6f17a3d40b2463a722f2de7a472062115b347b325d497267951

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ci_toolkit (1.6.3)
+    ci_toolkit (1.6.4)
       faraday
       faraday-multipart
       faraday_middleware

data/RELEASING.md

@@ -3,5 +3,5 @@
 - Bump the version number in `Gemfile.lock` to the new version.
 - Bump the version number in `ci_toolkit.gemspec` to the new version.
 - `git commit -am "Version X.Y.Z."` (where X.Y.Z is the new version).
-- `git tag -a X.Y.X -m "Version X.Y.Z"` (where X.Y.Z is the new version).
+- `git tag -a vX.Y.X -m "Version X.Y.Z"` (where X.Y.Z is the new version).
 - `git push && git push --tags`.

data/ci_toolkit.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "ci_toolkit"
-  spec.version       = "1.6.3"
+  spec.version       = "1.6.4"
   spec.authors       = ["Gero Keller"]
   spec.email         = ["gero.f.keller@gmail.com"]
 

data/lib/ci_toolkit/build_types.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module CiToolkit
+  # util class to get actual valid list of build types
+  class BuildTypes
+    # get actual valid list of build types
+    def get_build_types(build_types_arr, comments, labels)
+      types = []
+      build_types_arr.each do |type|
+        if comments.include?("#{type} build") || labels.include?("#{type} build") ||
+           comments.include?(type) || labels.include?(type)
+          types.push(type)
+        end
+      end
+      types
+    end
+  end
+end

data/lib/ci_toolkit/dvcs_pr.rb

@@ -98,6 +98,10 @@ module CiToolkit
       CiToolkit::DvcsPr.api_not_implemented(self)
     end
 
+    def certificate_pinning_logic_modified?
+      CiToolkit::DvcsPr.api_not_implemented(self)
+    end
+
     def get_status_description(_context)
       CiToolkit::DvcsPr.api_not_implemented(self)
     end

data/lib/ci_toolkit/github_pr.rb

@@ -18,6 +18,8 @@ module CiToolkit
       @_client = client
       @build_types = build_types
       @bot = CiToolkit::GithubBot.new
+      @changes_detector = GithubSpecificFilesChangesDetector.new
+      @build_types_getter = CiToolkit::BuildTypes.new
     end
 
     def title
@@ -83,14 +85,7 @@ module CiToolkit
     end
 
     def build_types
-      types = []
-      @build_types.each do |type|
-        if comments.include?("#{type} build") || labels.include?("#{type} build") ||
-           comments.include?(type) || labels.include?(type)
-          types.push(type)
-        end
-      end
-      types
+      @build_types_getter.get_build_types(@build_types, comments, labels)
     end
 
     def infrastructure_work?
@@ -106,8 +101,11 @@ module CiToolkit
     end
 
     def realm_module_modified?
-      modified_files = files.select { |file| file[:filename]&.start_with? "cache/" }
-      modified_files.length.positive?
+      @changes_detector.realm_module_modified(files)
+    end
+
+    def certificate_pinning_logic_modified?
+      @changes_detector.certificate_pinning_logic_modified(files)
     end
 
     def get_status_description(context)
@@ -126,4 +124,30 @@ module CiToolkit
       @_client
     end
   end
+
+  # util class to verify modifications in app files that may have been broken in the past
+  class GithubSpecificFilesChangesDetector
+    def realm_module_modified(files)
+      modified_files = files.select { |file| file[:filename]&.start_with? "cache/" }
+      modified_files.length.positive?
+    end
+
+    def certificate_pinning_logic_modified(files)
+      modified_files = files.select do |file|
+        contains_substring(file[:filename],
+                           %w[HttpClientFactory SecurePreferences CertificatePinningConfiguration SSLPinner
+                              CertificateDateChecker])
+      end
+      modified_files.length.positive?
+    end
+
+    private
+
+    def contains_substring(input_string, substrings)
+      return false if input_string.nil?
+
+      regex = Regexp.union(substrings.map { |s| Regexp.new(s, Regexp::IGNORECASE) })
+      !!(input_string =~ regex)
+    end
+  end
 end

data/lib/ci_toolkit/gitlab_pr.rb

@@ -20,6 +20,8 @@ module CiToolkit
       @_client = bot.client
       @build_types = build_types
       @bot = bot
+      @changes_detector = GitlabSpecificFilesChangesDetector.new
+      @build_types_getter = CiToolkit::BuildTypes.new
     end
 
     def title
@@ -86,14 +88,7 @@ module CiToolkit
     end
 
     def build_types
-      types = []
-      @build_types.each do |type|
-        if comments.include?("#{type} build") || labels.include?("#{type} build") ||
-           comments.include?(type) || labels.include?(type)
-          types.push(type)
-        end
-      end
-      types
+      @build_types_getter.get_build_types(@build_types, comments, labels)
     end
 
     def infrastructure_work?
@@ -109,8 +104,11 @@ module CiToolkit
     end
 
     def realm_module_modified?
-      modified_files = files.select { |file| file&.old_path&.start_with? "cache/" }
-      modified_files.length.positive?
+      @changes_detector.realm_module_modified(files)
+    end
+
+    def certificate_pinning_logic_modified?
+      @changes_detector.certificate_pinning_logic_modified(files)
     end
 
     def get_status_description(context)
@@ -127,4 +125,30 @@ module CiToolkit
       @_client
     end
   end
+
+  # util class to verify modifications in app files that may have been broken in the past
+  class GitlabSpecificFilesChangesDetector
+    def realm_module_modified(files)
+      modified_files = files.select { |file| file&.old_path&.start_with? "cache/" }
+      modified_files.length.positive?
+    end
+
+    def certificate_pinning_logic_modified(files)
+      modified_files = files.select do |file|
+        contains_substring(file&.old_path,
+                           %w[HttpClientFactory SecurePreferences CertificatePinningConfiguration SSLPinner
+                              CertificateDateChecker])
+      end
+      modified_files.length.positive?
+    end
+
+    private
+
+    def contains_substring(input_string, substrings)
+      return false if input_string.nil?
+
+      regex = Regexp.union(substrings.map { |s| Regexp.new(s, Regexp::IGNORECASE) })
+      !!(input_string =~ regex)
+    end
+  end
 end

data/lib/ci_toolkit/pr_messenger.rb

@@ -55,6 +55,15 @@ module CiToolkit
       delete(@messenger_text.realm_modified_warning_title)
     end
 
+    def send_certificate_pinning_modified_android_warning
+      delete_certificate_pinning_modified_android_warning
+      send(@messenger_text.certificate_pinning_logic_modified_android_title)
+    end
+
+    def delete_certificate_pinning_modified_android_warning
+      delete(@messenger_text.certificate_pinning_logic_modified_android_title)
+    end
+
     def send_big_pr_warning
       delete_big_pr_warning
       send(@messenger_text.big_pr_warning_title)

data/lib/ci_toolkit/pr_messenger_text.rb

@@ -45,6 +45,13 @@ module CiToolkit
       warning_with_message("Realm module modified. Did you remember to add migrations?")
     end
 
+    def certificate_pinning_logic_modified_android_title
+      warning_with_message("Detected modifications in Certificate pinning related files " \
+                           "(HttpClientFactory / SecurePreferences / CertificatePinningConfiguration / " \
+                           "SSLPinner / CertificateDateChecker). If you are doing temporary changes " \
+                           "to pinning, do not merge this MR until you revert them!")
+    end
+
     def big_pr_warning_title
       warning_with_message("Big PR")
     end

data/lib/ci_toolkit.rb

@@ -18,6 +18,7 @@ require "ci_toolkit/jira"
 require "ci_toolkit/pr_messenger"
 require "ci_toolkit/pr_messenger_text"
 require "ci_toolkit/bitrise_client"
+require "ci_toolkit/build_types"
 
 module CiToolkit
   class Error < StandardError; end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ci_toolkit
 version: !ruby/object:Gem::Version
-  version: 1.6.3
+  version: 1.6.4
 platform: ruby
 authors:
 - Gero Keller
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-10-25 00:00:00.000000000 Z
+date: 2024-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -238,6 +238,7 @@ files:
 - lib/ci_toolkit/bitrise_env.rb
 - lib/ci_toolkit/build.rb
 - lib/ci_toolkit/build_status.rb
+- lib/ci_toolkit/build_types.rb
 - lib/ci_toolkit/duplicate_files_finder.rb
 - lib/ci_toolkit/dvcs_pr.rb
 - lib/ci_toolkit/dvcs_pr_factory.rb
@@ -277,7 +278,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.4.19
 signing_key:
 specification_version: 4
 summary: Set of CI utilities