chutney 2.0.3.1 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e2638bbebf9e9f48bf42c2871d2c5c3ef4a13b06bd67d3c52096fd270135e759
-  data.tar.gz: 18c502227f4918d434dc876fd3548bd532218b2e3250f94cdd33b4860119eea2
+  metadata.gz: 9b678f90aea391f8707bda58ec5e2f6caf9b5d1f1bf5b1503c6862d4023d5f18
+  data.tar.gz: ecb2e762fa06c882869ff007e80261137816f431a78c07257d2f140e8f8f6f78
 SHA512:
-  metadata.gz: e5ca617c4feec58478cef5f00784e52425b79489cac43244824019e1ab7e7f7136dc4a7f355175282e55e634fb924ebd52a69400dfadace0bf140c824aa8a922
-  data.tar.gz: 4effe41d2b7d6213aff06a4083d78b57461366f540508c1ad946028a6c19d3e96f77411bc134e82de337a3fcdf376faf7fde96d7475fe82ab05a6c5d36b40b66
+  metadata.gz: 5f1f5c793a5d0080320606d56471f8ebcb7b0c3ceedca3e5e492eb877d1f0582aef997cd686c9e4782afeff407fb0346a0acbee288bca7306b39f2d8dc951540
+  data.tar.gz: 362d6bf5c6a1cb8c14a005534259e0ad5592df046a6dc3f747562b0b1875ee22e19b2076ff60873ca54967e2bd2188513566c36d0433ccd1c886fbc73b5c71ab

data/.rufo

@@ -0,0 +1 @@
+quote_style :single

data/chutney.gemspec

@@ -51,10 +51,11 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'coveralls', '~> 0.8'
   spec.add_development_dependency 'cucumber', '~> 3.0'
+  spec.add_development_dependency 'pry-byebug', '~> 3.0'
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rerun', '~> 0.13'
   spec.add_development_dependency 'rspec-expectations', '~> 3.0'
-  spec.add_development_dependency 'rubocop', '~> 0.82.0'
+  spec.add_development_dependency 'rubocop', '~> 0.85.1'
   spec.add_development_dependency 'rspec', '~> 3.8'
   
 end

data/config/chutney.yml

@@ -4,6 +4,8 @@ AvoidFullStop:
     Enabled: true
 AvoidScripting:
     Enabled: true
+AvoidTypographersQuotes:
+    Enabled: true
 BackgroundDoesMoreThanSetup:
     Enabled: true
 BackgroundRequiresMultipleScenarios:

data/lib/chutney.rb

@@ -4,6 +4,7 @@ require 'chutney/linter'
 require 'chutney/linter/avoid_full_stop'
 require 'chutney/linter/avoid_outline_for_single_example'
 require 'chutney/linter/avoid_scripting'
+require 'chutney/linter/avoid_typographers_quotes'
 require 'chutney/linter/background_does_more_than_setup'
 require 'chutney/linter/background_requires_multiple_scenarios'
 require 'chutney/linter/bad_scenario_name'

data/lib/chutney/linter/avoid_typographers_quotes.rb

@@ -0,0 +1,37 @@
+module Chutney
+  # service class to lint for avoid scripting
+  class AvoidTypographersQuotes < Linter
+    TYPOGRAPHER_QUOTES = ["\u201c", "\u201d", "\u2018", "\u2019"].map(&:encode)
+
+    def lint
+      scenarios do |_feature, scenario|
+        lint_steps(scenario[:steps])
+
+        example_count = scenario[:examples]&.length || 0
+        next unless example_count.positive?
+
+        lint_examples(scenario[:examples])
+      end
+    end
+
+    def lint_steps(steps)
+      steps.each do |step|
+        issue(step) if TYPOGRAPHER_QUOTES.any? { |tq| step[:text].include? tq }
+      end
+    end
+
+    def lint_examples(examples)
+      examples.each do |example|
+        example[:tableBody].each do |body|
+          body[:cells].each do |cell|
+            issue(cell) if TYPOGRAPHER_QUOTES.any? { |tq| cell[:value].include? tq }
+          end
+        end
+      end
+    end
+
+    def issue(location)
+      add_issue(I18n.t('linters.avoid_typographers_quotes'), location)
+    end
+  end
+end

data/lib/chutney/version.rb

@@ -1,3 +1,3 @@
 module Chutney
-  VERSION = '2.0.3.1'.freeze
+  VERSION = '2.1.0'.freeze
 end

data/lib/config/locales/en.yml

@@ -11,6 +11,10 @@ en:
     avoid_scripting: >-
       You have %{count} When steps when you should only have one.
       Be careful not to add And steps following a When.
+    avoid_typographers_quotes: >-
+      You are using typographers quotation marks (curly quotes).
+      Make sure you intend to use this character and not a neutral quote
+      (straight quote) instead.
     background_does_more_than_setup: >-
       The Background does more than setup. It should only contain Given steps.
     background_requires_multiple_scenarios: >-

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: chutney
 version: !ruby/object:Gem::Version
-  version: 2.0.3.1
+  version: 2.1.0
 platform: ruby
 authors:
 - Nigel Brookes-Thomas
 - Stefan Rohe
 - Nishtha Argawal
 - John Gluck
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-04-28 00:00:00.000000000 Z
+date: 2020-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: amatch
@@ -111,6 +111,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -159,14 +173,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.85.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.85.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -195,6 +209,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".rufo"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -228,6 +243,7 @@ files:
 - lib/chutney/linter/avoid_full_stop.rb
 - lib/chutney/linter/avoid_outline_for_single_example.rb
 - lib/chutney/linter/avoid_scripting.rb
+- lib/chutney/linter/avoid_typographers_quotes.rb
 - lib/chutney/linter/background_does_more_than_setup.rb
 - lib/chutney/linter/background_requires_multiple_scenarios.rb
 - lib/chutney/linter/bad_scenario_name.rb
@@ -266,7 +282,7 @@ metadata:
   homepage_uri: https://billyruffian.github.io/chutney/
   source_code_uri: https://github.com/BillyRuffian/chutney
   changelog_uri: https://github.com/BillyRuffian/chutney/releases
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -282,7 +298,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: A linter for English language Gherkin
 test_files: []