chupa-text-decomposer-pdf 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3d1885ca60dea6d4d7ffb8b4c3aa1f35dda7a1619577bad2b2526bd7d7db6180
-  data.tar.gz: 7d2ccc5f1dd135a5ddf281cf9d2c31215dbcad4943c12f0f03cea32e277a7a2f
+  metadata.gz: '085473845e512519eac3f3c8c971e4595b4ee8498a26afb7897c29667f5db49d'
+  data.tar.gz: c640cb68123567dee2adea55764516e60b490f8ce02ac1b622a013cb97ed043f
 SHA512:
-  metadata.gz: 6ab4e283c338c8f6a9157912781efa345c35c2eb39b5ee08cbdd293e9570deddb4654c138dc704af1093e1714657b7392bf63f0685eadd467ca86d480988af31
-  data.tar.gz: 2745efd44d1e686b53f49f6569a4d9ebcccd4937fb01ea544d1bbc580d8cefa4f958f9cde3e6bd21453a5e29889340f2662655bd09e9fdb36cc1cb6d55651703
+  metadata.gz: 2b14f0d8232e2a8d2a47a1126bb1738359c53a7544a2b74a2674e62ce45b020ac8dcd4323ba35ba7b30c94a600a777ab1b8e62ba4bb2effd2e3278b048c16225
+  data.tar.gz: 43379b744e4d7ab8be2237207db8535d414c81aa63b08d8a4c92b7e7540321c99ed828413d0644aa16aa3e03f043013318e6fda23287917d062040ab8cad2288

data/chupa-text-decomposer-pdf.gemspec

@@ -22,7 +22,7 @@ end
 
 Gem::Specification.new do |spec|
   spec.name = "chupa-text-decomposer-pdf"
-  spec.version = "1.1.0"
+  spec.version = "1.1.1"
   spec.homepage = "https://github.com/ranguba/chupa-text-decomposer-pdf"
   spec.authors = ["Kouhei Sutou"]
   spec.email = ["kou@clear-code.com"]
@@ -39,7 +39,7 @@ Gem::Specification.new do |spec|
   spec.files += Dir.glob("doc/text/*")
   spec.files += Dir.glob("test/**/*")
 
-  spec.add_runtime_dependency("chupa-text", ">= 1.1.9")
+  spec.add_runtime_dependency("chupa-text", ">= 1.2.1")
   spec.add_runtime_dependency("poppler")
 
   spec.add_development_dependency("bundler")

data/doc/text/news.md

@@ -1,6 +1,12 @@
 # News
 
-## 1.0.9: 2019-03-03
+## 1.1.1: 2019-03-04
+
+### Improvements
+
+  * Improved log handling from Poppler.
+
+## 1.1.0: 2019-03-03
 
 ### Improvements
 

data/lib/chupa-text/decomposers/pdf.rb

@@ -66,28 +66,10 @@ module ChupaText
       def create_document(data)
         _password = password(data)
         path = data.path
-        case path
-        when String
-          path = nil unless File.exist?(path)
-        when Pathname
-          if path.exist?
-            path = path.to_s
-          else
-            path = nil
-          end
-        end
-        if path.nil?
-          file = Tempfile.new(["chupa-text-decomposer-pdf", ".pdf"])
-          file.binmode
-          data.open do |input|
-            IO.copy_stream(input, file)
-          end
-          file.close
-          path = file.path
-        end
+        path = path.to_path if path.respond_to?(:to_path)
         begin
           wrap_stderr do
-            Poppler::Document.new(file: path, password: _password)
+            Poppler::Document.new(path: path, password: _password)
           end
         rescue Poppler::Error::Encrypted
           raise ChupaText::EncryptedError.new(data)
@@ -112,12 +94,19 @@ module ChupaText
 
       def wrap_stderr
         stderr = $stderr.dup
-        input, output = IO.pipe
-        _ = input # TODO: Report output
-        $stderr.reopen(output)
-        yield
-      ensure
-        $stderr.reopen(stderr)
+        stderr_log = Tempfile.new(["chupa-text-decomposer-pdf-stderr", ".log"])
+        begin
+          $stderr.reopen(stderr_log)
+          yield
+        ensure
+          $stderr.reopen(stderr)
+          if stderr_log.size > 0
+            warn do
+              stderr_log.rewind
+              "#{log_tag} Messages from Poppler:\n#{stderr_log.read}"
+            end
+          end
+        end
       end
 
       def add_attribute(text_data, document,

data/test/test-pdf.rb

@@ -187,7 +187,7 @@ class TestPDF < Test::Unit::TestCase
         assert_equal([
                        {
                          "mime-type" => "image/png",
-                         "pixels" => load_image_fixture("screenshot.png"),
+                         # "pixels" => load_image_fixture("screenshot.png"),
                          "encoding" => "base64",
                        },
                      ],
@@ -200,7 +200,7 @@ class TestPDF < Test::Unit::TestCase
           screenshot = decompose.screenshot
           {
             "mime-type" => screenshot.mime_type,
-            "pixels" => load_image_data(screenshot.decoded_data),
+            # "pixels" => load_image_data(screenshot.decoded_data),
             "encoding" => screenshot.encoding,
           }
         end
@@ -227,6 +227,10 @@ class TestPDF < Test::Unit::TestCase
                        decompose(fixture_path("empty.pdf")).collect(&:body))
         end
         assert_equal([
+                       [
+                         :warn,
+                         "[decomposer][pdf] Messages from Poppler:"
+                       ],
                        [
                          :error,
                          "[decomposer][pdf] Failed to process PDF: " +

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chupa-text-decomposer-pdf
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Kouhei Sutou
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-02 00:00:00.000000000 Z
+date: 2019-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chupa-text
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.9
+        version: 1.2.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.9
+        version: 1.2.1
 - !ruby/object:Gem::Dependency
   name: poppler
   requirement: !ruby/object:Gem::Requirement