chrisk-fakeweb 1.1.2.1 → 1.1.2.2

data/CHANGELOG

@@ -1,6 +1,12 @@
 fakeweb (development)
 
   [ Chris Kampmeier ]
+  * sort query params before storing internally, so that
+    http://example.com/?a=1&b=2 and http://example.com/?b=2&a=1 are considered
+    the same URL (although this is technically incorrect, it's much more
+    convenient--most web apps work that way, and Net::HTTP's use of a hash to
+    pass query params means that the order in which FakeWeb stores them can be
+    unpredictable)
   * add support for ports in URLs, so that http://example.com/ and
     http://example.com:3000/ are not the same
   * fix for non-faked SSL requests failing with "Unable to create local socket"

data/README

@@ -29,15 +29,9 @@ soap4r[http://dev.ctor.org/soap4r/], etc.)
 
 = Known Issues
 
-* Request bodies are ignored, including GET, PUT, and POST parameters. If you
+* Request bodies are ignored, including PUT and POST parameters. If you
   need different responses for different request bodies, you need to request
   different URLs, and register different responses for each.
-* Query-string parameter order is significant, so GET http://example.com/?a=1&b=1
-  and GET http://example.com/?b=1&a=1 are considered different requests. This is
-  technically correct, but it's often a nuisance in practice since 1) many servers
-  return the same resource for any ordering of the key=value pairs, and
-  2) Net::HTTP's use of a hash to specify query parameters means that the order
-  is unpredictable.
 
 = Copyright
 

data/Rakefile

@@ -25,7 +25,7 @@ spec = Gem::Specification.new do |s|
   s.add_dependency('rake')
   s.add_dependency('rcov')
   s.name = "FakeWeb" 
-  s.version = "1.1.2.1"
+  s.version = "1.1.2.2"
   s.author = "Blaine Cook" 
   s.email = "romeda@gmail.com" 
   s.homepage = "http://fakeweb.rubyforge.org/" 

data/fakeweb.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name     = "fakeweb"
-  s.version  = "1.1.2.1"
-  s.date     = "2008-10-13"
+  s.version  = "1.1.2.2"
+  s.date     = "2008-10-22"
   s.summary  = "A test helper that makes it simple to test HTTP interaction"
   s.homepage = "http://github.com/chrisk/fakeweb"
   s.has_rdoc = true

data/lib/fake_web.rb

@@ -120,9 +120,16 @@ module FakeWeb
       when URI: uri
       else
         uri = 'http://' + uri unless uri.match('^https?://')
-        URI.parse(uri)
+        parsed_uri = URI.parse(uri)
+        parsed_uri.query = sort_query_params(parsed_uri.query)
+        parsed_uri
       end
     end
+
+    def sort_query_params(query)
+      return nil if query.nil?
+      query.split('&').sort.join('&')
+    end
   end
 
   module Response #:nodoc:

data/test/test_fake_web.rb

@@ -319,4 +319,11 @@ class TestFakeWeb < Test::Unit::TestCase
     assert_equal 'Not Found', exception.response.msg
   end
 
+  def test_registry_sort_query_params
+    assert_equal "a=1&b=2", FakeWeb::Registry.instance.send(:sort_query_params, "b=2&a=1")
+  end
+
+  def test_registry_sort_query_params_sorts_by_value_if_keys_collide
+    assert_equal "a=1&a=2&b=2", FakeWeb::Registry.instance.send(:sort_query_params, "a=2&b=2&a=1")
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: chrisk-fakeweb
 version: !ruby/object:Gem::Version 
-  version: 1.1.2.1
+  version: 1.1.2.2
 platform: ruby
 authors: 
 - Blaine Cook
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-10-13 00:00:00 -07:00
+date: 2008-10-22 00:00:00 -07:00
 default_executable: 
 dependencies: []