chinese_phrases 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae4a506c3e070f95b66f15ea7428c97290fc905ff14a61ace6f08d7b887178fa
-  data.tar.gz: 74de3191cbae02a656273013af90dd6b9c9b27eb99b3f4b32cd8e3f2ff023acf
+  metadata.gz: 5a40f9ca2c1c3f081bfbe3cd4b4371b2652ff6afe8bf8ccf48e7c53fd2e452b8
+  data.tar.gz: 842158b8b92e0b93b8dbdd46bb2bca6737bf9e8a6790664ec97b696be58c32eb
 SHA512:
-  metadata.gz: 671d1f4379a533ed57bd0b7259d110aa2fe4b7f0c6b114269e959d95b3dc601e3e54fdeaa03ec23e898abcbceb03c8c94d6ccd94cf519feccfdb54f0771e174e
-  data.tar.gz: 6d8c3fd9adb09b81528aaab0eff671ebdfec9d3c37afbb7664a52b212b7cd8eb0c8c091a1d9112c08aaffc5e33147e08aa969d40a8bcec8c971eeaee7754de5b
+  metadata.gz: d941b57de26d9e6a873c3c7b90fb428bc96a23563b952a84f1613b8f9a4fe9ca7d70865c0d232d4269e37728f5f84f5d59ef098929ab1aeeac2c55ff4ea25c2c
+  data.tar.gz: 9c45078edf7e1ad5f887cc389e8d4b843875503feb01ff430065bd5330e2c3c4dc5cb12c9ab4cbfb70e11cfbeeeeb9a82bf0b47aafb063fbf735f003ed116609

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    chinese_phrases (0.1.3)
+    chinese_phrases (0.1.4)
       httparty (~> 0.17)
       thor (~> 0.20)
       tradsim (~> 0.5)

data/README.md

@@ -2,6 +2,21 @@
 
 Converts a csv of Chinese words to a csv of example sentences for use in Anki.
 
+*Note:* This uses the free online dictionary at dict.naver.com to pull sentences, please be respectful.
+
+## Context
+
+As you're learning Chinese you'll come across new words that you would
+like to practice. You can use this gem as such:
+
+* As you read an article or watch a video
+* Write down any new words you find on a new in line a text file
+* Enter only one word per line
+* Once done, save the file
+* Use this library to convert those words into examples sentences
+* These sentences can be used for your own study in Anki or whatever you like
+
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -41,7 +56,7 @@ Options:
   [--max-per=N]
                                # Default: 10
   [--page-size=N]
-                               # Default: 100
+                               # Default: 50
   [--trad], [--no-trad]
                                # Default: true
 

data/bin/chinese_phrases

@@ -7,7 +7,7 @@ class CLI < Thor
   option :output_file
   option :max_len, type: :numeric, default: 15
   option :max_per, type: :numeric, default: 10
-  option :page_size, type: :numeric, default: 100
+  option :page_size, type: :numeric, default: 50
   option :trad, type: :boolean, default: true
   desc "export", "Output given word csv to phrases csv"
   def export(name)

data/lib/chinese_phrases.rb

@@ -15,11 +15,13 @@ module ChinesePhrases
 
       params = {
         page: options[:page] || 1, # page to check on source
-        page_size: options[:page_size] || 100, # number of examples from api call
+        page_size: options[:page_size] || 50, # number of examples from api call
         max_length: options[:max_len] || 15, # only accept examples length than this
         max_per: options[:max_per] || 10, # only accept this number of examples
       }
 
+      puts "Running with params #{params}"
+
       query_list = []
       total_examples = []
 
@@ -28,6 +30,12 @@ module ChinesePhrases
         query_list << Tradsim::to_sim(csv[input_index])
       end
 
+      if query_list.empty?
+        puts "CSV file is empty!"
+      elsif query_list.count > 1000
+        puts "[WARNING] CSV file has over 1000 lines, this can take a long time and/or fail! Consider splitting the file."
+      end
+
       # query each word individually and combine to total list
       query_list.each do |q|
         exs = get_examples q, params
@@ -43,9 +51,11 @@ module ChinesePhrases
             example = Tradsim::to_trad(example)
           end
 
-          puts "Writing #{a["recentTrslation"]} #{example}"
+          pinyin = a["pinyin"]
+
+          puts "Writing #{a["recentTrslation"]} #{example} #{pinyin}"
 
-          csv << [a["recentTrslation"], example, a["pinyin"]]
+          csv << [a["recentTrslation"], example, pinyin]
         end
       end
 
@@ -56,6 +66,8 @@ module ChinesePhrases
       query_escaped = CGI::escape query
       callback = "jQuery1111013304390430117385_1567195383336"
 
+      puts "Fetching examples for #{query}"
+
       url = "https://dict.naver.com/linedict/cnen/example/search.dict?callback=#{callback}&query=#{query_escaped}&page=#{params[:page]}&page_size=#{params[:page_size]}&examType=normal&fieldType=&author=&country=&ql=default&format=json&platform=isPC&_=1567195383337"
 
       response = HTTParty.get(url)
@@ -81,6 +93,8 @@ module ChinesePhrases
 
       exampleList = data["exampleList"]
 
+      puts "Found #{exampleList.count} examples"
+
       # collect shortest examples
       examples = exampleList.filter { |i| i["example"].length < params[:max_length] }
 
@@ -88,6 +102,8 @@ module ChinesePhrases
         examples = examples[0..params[:max_per] - 1]
       end
 
+      puts "Filtered down to #{examples.count} examples"
+
       examples
     end
 

data/lib/chinese_phrases/version.rb

@@ -1,3 +1,3 @@
 module ChinesePhrases
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chinese_phrases
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Ben D'Angelo
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-20 00:00:00.000000000 Z
+date: 2020-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty