chimera_http_client 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 01402cd235d413d16acc9adb72267b7a244898b5913d14d07e039ad6b1bd830b
-  data.tar.gz: 3909459cb620e544da67ee5864f39ab7ea51a6c33b6dd1b3fcddda5a56ec4dd5
+  metadata.gz: 245adb27237d0970454580b14f6973ed7bf732a8ce3f4426b35978ff27eed9d8
+  data.tar.gz: 02e8646e5757b60b7d4617d58f3413bdd4b5675d8d307342fabc7ce03c90471b
 SHA512:
-  metadata.gz: 655127ba58b327eb2bc9f2ff6342ad3c93bd84c9cfa08fc262a4628005643e2562ae76ee68378331a92edb11cd9fb91fe0cf942f45d4ce911f176bfae8392c02
-  data.tar.gz: b3b282c08dc802b187ee95e974deb996ee833d3350f86ef4d6c89818ef1b182bedee2f043aaad50f392157829559b18b579480d7d50beef154617bb744e6cf9e
+  metadata.gz: 0caca4f777876526ab8fb4f1652b0643e545bd768e7722424e2007e3e1e79f397cc043dd5ad81d4319ec0703242c72a9481bcac589a48d82374a7e646cef2974
+  data.tar.gz: caf3dc496a546c75a07475148a063caf8b312f9fb63f9a65de02577c3f7b4398e8c05660660d003c6dc7a14bf50b33e5e46cba6d7c2599901b265d3df3f5155c

data/.rubocop.yml

@@ -19,6 +19,7 @@ Metrics/AbcSize:
 
 Metrics/BlockLength:
   Exclude:
+    - chimera_http_client.gemspec
     - spec/**/*
 
 # Configuration parameters: CountComments.

data/README.markdown

@@ -387,6 +387,8 @@ When updating the version, do not forget to run
 
 After checking out the repo, run `bundle install` and then `bundle execute rake` to run the **tests and rubocop**.
 
+> The test suite uses a Sinatra server to make real HTTP requests. It is mounted via Capybara_discoball and running in the same process.
+
 You can also run `rake console` to open an irb session with the `ChimeraHttpClient` pre-loaded that will allow you to experiment.
 
 To build and install this gem onto your local machine, run `bundle exec rake install`.

data/Rakefile

@@ -3,7 +3,11 @@ require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
 Bundler::Audit::Task.new
-RSpec::Core::RakeTask.new(:rspec)
+
+RSpec::Core::RakeTask.new(:rspec) do |t|
+  # t.exclude_pattern = "**/server/*_spec.rb" # skip real http server specs
+  # t.exclude_pattern = "**/stubbed/*_spec.rb" # skip the stubbed Typhoeus specs
+end
 
 desc "Open a console with the ChimeraHttpClient loaded"
 task :console do

data/TODO.markdown

@@ -31,11 +31,16 @@ _none known_
 
 ### Add server for testing
 
-* [ ] add a simple (Sinatra) server for testing
-* [ ] run (all?) tests against the server (with capybara_discoball?)
+* [x] ~~add a simple (Sinatra) server for testing~~
+* [x] ~~run (all?) tests against the server (with capybara_discoball)~~
 * [ ] make server also available for console testing
 * [ ] add example to README
 
+### Miscellaneous
+
+- [ ] Determine by parameter if 3xx Redirects should be handled as an Error or not
+- [ ] Add a longer description to the gemspec file
+
 ### Enable more Typhoeus functionality
 
 * [ ] accept_encoding: "gzip"
@@ -52,13 +57,6 @@ _none known_
 * [ ] or enable to access the Typhoeos directly through Chimera?
 * [ ] add example to README
 
-### Custom Serializer
-
-* [ ] allow to pass custom serializer
-* [ ] use custom serializer instead of expecting a JSON (or other) body
-* [ ] set header for the serializer
-* [ ] add example to README
-
 ### File Uploads
 
 * [ ] add example to README

data/chimera_http_client.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["webmaster@mediafinger.com"]
 
   spec.summary       = "Http Client to connect to REST APIs"
-  spec.description   = "General http client functionality to easily connect to JSON endpoints"
+  spec.description   = "General http client functionality to easily connect to JSON endpoints" # TODO: extend and polish
   spec.homepage      = "https://github.com/mediafinger/chimera_http_client"
   spec.license       = "MIT"
 
@@ -18,15 +18,24 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
+  # the only sub-dependencies
   spec.add_runtime_dependency "typhoeus", "~> 1.1"
   spec.add_runtime_dependency "zeitwerk", ">= 2.0"
 
-  spec.add_development_dependency "awesome_print", "~> 1.8"
-  spec.add_development_dependency "bundler",       ">= 1.0"
-  spec.add_development_dependency "bundler-audit", "~> 0.6"
-  spec.add_development_dependency "irb",           "~> 1.0"
-  spec.add_development_dependency "rake",          ">= 10.0"
-  spec.add_development_dependency "rspec",         "~> 3.0"
-  spec.add_development_dependency "rubocop",       "~> 0.50"
-  spec.add_development_dependency "rubocop-rspec", "~> 1.4"
+  # general development and test dependencies
+  spec.add_development_dependency "awesome_print",      "~> 1.8"
+  spec.add_development_dependency "bundler",            ">= 1.0"
+  spec.add_development_dependency "bundler-audit",      "~> 0.6"
+  spec.add_development_dependency "irb",                "~> 1.0"
+  spec.add_development_dependency "rake",               ">= 10.0"
+  spec.add_development_dependency "rspec",              "~> 3.0"
+  spec.add_development_dependency "rubocop",            "~> 0.50"
+  spec.add_development_dependency "rubocop-rspec",      "~> 1.4"
+
+  # only for server specs with real HTTP requests
+  spec.add_development_dependency "capybara",           "~> 3.0"
+  spec.add_development_dependency "capybara_discoball", "~> 0.1"
+  spec.add_development_dependency "sinatra",            "~> 2.0"
+  spec.add_development_dependency "sinatra-contrib",    "~> 2.0"
+  spec.add_development_dependency "webmock",            "~> 3.0"
 end

data/lib/chimera_http_client.rb

@@ -5,4 +5,7 @@ module ChimeraHttpClient
 
   loader = Zeitwerk::Loader.for_gem
   loader.setup
+
+  # as Zeitwerk can't handle innner classes properly :-/
+  require_relative "./chimera_http_client/error.rb"
 end

data/lib/chimera_http_client/request.rb

@@ -61,7 +61,7 @@ module ChimeraHttpClient
 
       case response.code.to_i
       when 301, 302, 303, 307
-        RedirectionError.new(response, @options)
+        RedirectionError.new(response, @options) # TODO: throw error conditionally
       when 200..399
         nil
       when 400

data/lib/chimera_http_client/version.rb

@@ -1,3 +1,3 @@
 module ChimeraHttpClient
-  VERSION = "1.1.0".freeze
+  VERSION = "1.1.1".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chimera_http_client
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Andreas Finger
@@ -150,6 +150,76 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.4'
+- !ruby/object:Gem::Dependency
+  name: capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: capybara_discoball
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+- !ruby/object:Gem::Dependency
+  name: sinatra
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: sinatra-contrib
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 description: General http client functionality to easily connect to JSON endpoints
 email:
 - webmaster@mediafinger.com