chicagowarehouse 0.6.1 → 0.6.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MmViNTc2MjUzYTFiNjI0NDZmODM2Y2Y0ZDQ2N2ZmYjE0Y2MwNzFjYw==
+    OTNkMGY3MWQ3NGEwNmRkZjE5YjRhZWI5NTVlYjkzNDM4MTg5OTA5Zg==
   data.tar.gz: !binary |-
-    YzRlNjA5MjEzYjQ5NzBlZjg3MDBhNjU1NjI5Mzk5NDNkN2I5M2Q0OA==
+    NmJkNzExMDE4ZDc2MjgyZDU5OTEzNGJhNWJlYzI0MTZjYWIzOWFiZg==
 SHA512:
   metadata.gz: !binary |-
-    NWUwYzE3ZDIwYWNjYjE4YWE1MjU5NWU0ZDJiNjE0ZDZlMGU3YmQ4ZjJkNjJh
-    Nzg2MWU1Njk4YmI5ZDE0ZjQ4ZTY2M2FlZTIzMDQ5NDdiMWFiN2Q1NzgwMGVm
-    ZWYwZTA3MDE3MDMxM2Q0MWFkYzM3ZDcwMjY0ZWVlOTNiNmJkZTE=
+    MWNmOGUyYmI4ZWU4Y2M0MjY5ZWMyMzFkZWQ2ZTI3OTM2ZWFmNDFiNWNjOTI5
+    ZWQ3YWRjYzY1OWJhZTNhYmQ0ZjNmMWNjYmMzNmIxZDRmOWYwZjIyNzFmYjAy
+    YTRlNjEzMTg2ZTM0N2RlZjVmZWVmNjkxYzYzODUxNTQ0ZDI4MmE=
   data.tar.gz: !binary |-
-    YzgxZGY5YTg1NTM1YTk1OTFmZGJjMGFjMjJkOWViNTE3MjFmNTU0MGRhY2Uy
-    NzZjMDYwNzRlMmViYTliOTU1MmM1OWEzNjgxNTdlZjQ1MzhlNDJjODdhMDY4
-    NTJhMzE0NTJlN2QyM2Q1Njc4MWY3NDAxODIyYjE3Yjk4YmUzODM=
+    YmQ0ZGVlMDcyOWY4OTk5NWQxMWViYmExMGQ3YzhlMTlkN2VlNjg4ZjI4OTk2
+    MDhjMTRjZjE2MzI3ZmRjNGU0YTlmYmFkNDM4ZmUzMDNjZTBlNzE0MGExOTUz
+    MWYyYTAwOGJiNTM0MzhmMWI5NDg5YzdmN2Y4ZjkxNDE0M2M5MDE=

data/Rakefile

@@ -14,7 +14,7 @@ require 'rake'
 require 'jeweler'
 Jeweler::Tasks.new do |gem|
   gem.name              = "chicagowarehouse"
-  gem.version           = "0.6.1"
+  gem.version           = "0.6.2"
   gem.summary           = "Ruby Data Warehousing"
   gem.description       = "Simple Data Warehouse toolkit for ruby"
   gem.author            = "Roland Swingler"

data/chicagowarehouse.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: chicagowarehouse 0.6.1 ruby lib
+# stub: chicagowarehouse 0.6.2 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "chicagowarehouse"
-  s.version = "0.6.1"
+  s.version = "0.6.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Roland Swingler"]
-  s.date = "2014-09-02"
+  s.date = "2014-09-03"
   s.description = "Simple Data Warehouse toolkit for ruby"
   s.email = "roland.swingler@gmail.com"
   s.extra_rdoc_files = [
@@ -58,7 +58,7 @@ Gem::Specification.new do |s|
     "lib/chicago/schema/table.rb",
     "lib/chicago/star_schema.rb",
     "spec/data/month_spec.rb",
-    "spec/database/concrete_schema_strategies.rb",
+    "spec/database/concrete_schema_strategies_spec.rb",
     "spec/database/migration_file_writer_spec.rb",
     "spec/database/schema_generator_spec.rb",
     "spec/db_connections.yml.dist",

data/lib/chicago/database/concrete_schema_strategies.rb

@@ -103,8 +103,13 @@ module Chicago
       protected
 
       def in_numeric_range?(min, max, unsigned_limit)
+        in_signed_limit?(min, max, unsigned_limit) || 
+          (min >= 0 && max <= unsigned_limit)
+      end
+
+      def in_signed_limit?(min, max, unsigned_limit)
         signed_limit = (unsigned_limit + 1) / 2
-        (min >= -signed_limit && max <= signed_limit - 1)  ||  (min >= 0 && max <= unsigned_limit)
+        (min >= -signed_limit && max <= signed_limit - 1)
       end
     end
 
@@ -149,6 +154,11 @@ module Chicago
       def indexes(table)
         []
       end
+
+      # Redshift does not support unsigned Integers
+      def in_numeric_range?(min, max, unsigned_limit)
+        in_signed_limit?(min, max, unsigned_limit)
+      end
     end
 
     # MySql-specific database schema strategy

data/spec/database/{concrete_schema_strategies.rb → concrete_schema_strategies_spec.rb}

@@ -85,7 +85,7 @@ describe "Generic DbTypeConverter" do
   it "should have an unsigned integer id column" do
     @tc.id_column.should == {
       :name => :id,
-      :column_type => :integer
+      :column_type => :integer,
       :unsigned => true
     }
   end
@@ -99,10 +99,20 @@ describe Chicago::Database::RedshiftStrategy do
   it "should have an integer id column (not unsigned)" do
     @tc.id_column.should == {
       :name => :id,
-      :column_type => :integer
+      :column_type => :integer,
       :unsigned => false
     }
   end
+
+  it "creates an integer column for an unsigned small int" do
+    column = Schema::Column.new(:id, :integer, :max => 65535, :min => 0)
+    @tc.db_type(column).should == :integer
+  end
+
+  it "multiplies the space requirements for string columns by 4" do
+    column = Schema::Column.new(:id, :string, :max => 25)
+    expect(@tc.column_hash(column)[:size]).to eql(100)
+  end
 end
 
 describe Chicago::Database::MysqlStrategy do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chicagowarehouse
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Roland Swingler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-02 00:00:00.000000000 Z
+date: 2014-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sequel
@@ -211,7 +211,7 @@ files:
 - lib/chicago/schema/table.rb
 - lib/chicago/star_schema.rb
 - spec/data/month_spec.rb
-- spec/database/concrete_schema_strategies.rb
+- spec/database/concrete_schema_strategies_spec.rb
 - spec/database/migration_file_writer_spec.rb
 - spec/database/schema_generator_spec.rb
 - spec/db_connections.yml.dist