chicagowarehouse 0.3.3 → 0.4.0

data/Rakefile

@@ -14,7 +14,7 @@ require 'rake'
 require 'jeweler'
 Jeweler::Tasks.new do |gem|
   gem.name              = "chicagowarehouse"
-  gem.version           = "0.3.3"
+  gem.version           = "0.4.0"
   gem.summary           = "Ruby Data Warehousing"
   gem.description       = "Simple Data Warehouse toolkit for ruby"
   gem.author            = "Roland Swingler"

data/chicagowarehouse.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{chicagowarehouse}
-  s.version = "0.3.3"
+  s.version = "0.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{Roland Swingler}]

data/lib/chicago/database/schema_generator.rb

@@ -18,18 +18,8 @@ module Chicago
       end
 
       def visit_dimension(dimension)
-        table = basic_table(dimension)
-
-        # TODO: Why shouldn't facts have etl_batch_id?
-        table[:columns] << {
-          :name => :etl_batch_id,
-          :column_type => :integer,
-          :unsigned => true
-        }
-        
-        tables = {dimension.table_name => table}
-        tables.merge!(key_table(dimension))
-        tables
+        {dimension.table_name => basic_table(dimension)}.
+          merge!(key_table(dimension))
       end
 
       def visit_column(column)
@@ -52,7 +42,14 @@ module Chicago
                          :unsigned => true
                        }]
         }
+
         t[:columns] += table.columns.map {|c| c.visit(self) }
+        t[:columns] << {
+          :name => :_inserted_at,
+          :column_type => :timestamp,
+          :null => true
+        }
+        
         t
       end
 

data/spec/database/schema_generator_spec.rb

@@ -65,6 +65,11 @@ describe Chicago::Database::SchemaGenerator do
         :reference_idx => { :columns => :reference, :unique => false }
       }
     end
+
+    it "has an inserted at column" do
+      subject.visit_fact(@fact)[:facts_sales][:columns].
+        should include(:name => :_inserted_at, :column_type => :timestamp, :null => true)
+    end
   end
 
   describe "#visit_dimension" do
@@ -190,10 +195,10 @@ describe Chicago::Database::SchemaGenerator do
       subject.visit_dimension(@dimension)[:keys_dimension_currency].should be_nil
     end
 
-    it "should have an unsigned integer :etl_batch_id column" do
+    it "has an inserted at column" do
       @dimension = @schema.define_dimension(:user)
-      expected = {:name => :etl_batch_id, :column_type => :integer, :unsigned => true}
-      subject.visit_dimension(@dimension)[:dimension_user][:columns].should include(expected)
+      subject.visit_dimension(@dimension)[:dimension_user][:columns].
+        should include(:name => :_inserted_at, :column_type => :timestamp, :null => true)
     end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: chicagowarehouse
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 15
   prerelease: 
   segments: 
   - 0
-  - 3
-  - 3
-  version: 0.3.3
+  - 4
+  - 0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Roland Swingler