cherby 0.0.4 → 0.0.5

data/cherby.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = "cherby"
-  s.version = "0.0.4"
+  s.version = "0.0.5"
   s.summary = "Cherwell-Ruby bridge"
   s.description = <<-EOS
     Cherby is a Ruby wrapper for the Cherwell Web Service.

data/lib/cherby/business_object.rb

@@ -217,6 +217,28 @@ module Cherby
       field.content = value.to_s
     end
 
+    # Return true if `other_object` has the same values in all fields
+    # given by`field_names`.
+    #
+    # @param [BusinessObject] other_object
+    #   The object to compare with
+    # @param [Array<String>] field_names
+    #   Names of fields whose values you want to compare. If omitted,
+    #   compare *all* fields for equality.
+    #
+    # @return [Boolean]
+    #   True if all fields are equal, false if any differ
+    #
+    def fields_equal?(other_object, *field_names)
+      if field_names.empty?
+        return self.to_hash == other_object.to_hash
+      else
+        return field_names.all? do |field|
+          self[field] == other_object[field]
+        end
+      end
+    end
+
     # Copy designated fields from one BusinessObject to another.
     #
     # @example

data/lib/cherby/incident.rb

@@ -17,24 +17,6 @@ module Cherby
       return id.to_s =~ /\d+/
     end
 
-    # Mark this incident as complete by filling in relevant fields.
-    # FIXME: Parameterize these, instead of assuming Jira relationship.
-    #
-    def complete!(comments = "Closed in Jira => automated close.")
-      self["CloseDescription"] = comments
-      self["LastModDateTime"] = DateTime.now.to_s
-      self["Stat_NumberOfTouches"] = self["Stat_NumberOfTouches"].to_i + 1
-      #self["PhaseInvestigateStatus"] = "Complete"
-      self["PhaseResolveStatus"] = "Complete"
-      #self["PhaseCloseStatus"] = "Complete"
-      self["ClosureCode"] = "Completed"
-      self["CMDBUpdate"] = "No"
-      self["BusinessService"] = "Not Applicable"
-      self["RequestType"] = "Not Applicable"
-      self["SubCategory"] = "JIRA"
-      self["SubcategoryNonHR"] = "JIRA"
-    end
-
     # Return Task instances for all tasks associated with this Incident.
     #
     # @return [Array<Task>]
@@ -92,21 +74,6 @@ module Cherby
       @dom.at_css('RelationshipList').add_child(rel_node)
     end
 
-    # Return True if this Incident has important fields differing from the
-    # given Incident.
-    #
-    # @param [Incident] incident
-    #   The Incident to compare this one to.
-    #
-    # @return [Boolean]
-    #   `true` if the incidents differn `false` otherwise.
-    #
-    def differs_from?(incident)
-      return true if self['Status'] != incident['Status']
-      return true if self['JIRAID'] != incident['JIRAID']
-      return false
-    end
-
     # DO NOT REMOVE: use the follow code for code-gen of Cherwell consts
 =begin
     def extract_lines(css, l)

data/lib/cherby/task.rb

@@ -14,12 +14,6 @@ module Cherby
       return !id.to_s.empty?
     end
 
-    # Return True if this Task has important fields differing from the given Task.
-    def differs_from?(task)
-      return true if self['Status'] != task['Status']
-      return false
-    end
-
     # Add a JournalNote to this Task. Since Tasks cannot directly have JournalNotes
     # associated with them, this just appends the note's content to the Technician Notes
     # field (aka 'CompletionDetails') in the Task.

data/spec/business_object_spec.rb

@@ -298,6 +298,47 @@ describe Cherby::BusinessObject do
       end
     end
 
+    describe "#fields_equal?" do
+      before(:each) do
+        xml = '<BusinessObject Name="MySubclass"><FieldList/></BusinessObject>'
+        @obj1 = MySubclass.new(xml)
+        @obj2 = MySubclass.new(xml)
+
+        @obj1['Status'] = 'Open'
+        @obj2['Status'] = 'Open'
+        @obj1['Comment'] = 'Whatever'
+        @obj2['Comment'] = 'Whatever'
+      end
+
+      context "compare specific fields" do
+        it "returns true if all fields are equal" do
+          @obj1.fields_equal?(@obj2, 'Status').should be_true
+          @obj1.fields_equal?(@obj2, 'Comment').should be_true
+          @obj1.fields_equal?(@obj2, 'Status', 'Comment').should be_true
+        end
+
+        it "returns false if any field differs" do
+          @obj1['ID'] = '123'
+          @obj2['ID'] = '456'
+          @obj1.fields_equal?(@obj2, 'ID').should be_false
+          @obj1.fields_equal?(@obj2, 'ID', 'Status').should be_false
+          @obj1.fields_equal?(@obj2, 'Status', 'ID').should be_false
+        end
+      end
+
+      context "compare all fields (default)" do
+        it "returns true if all fields are equal" do
+          @obj1.fields_equal?(@obj2).should be_true
+        end
+
+        it "returns false if any field differs" do
+          @obj1['ID'] = '123'
+          @obj2['ID'] = '456'
+          @obj1.fields_equal?(@obj2).should be_false
+        end
+      end
+    end #fields_equal?
+
     describe "#copy_fields_from" do
       before(:each) do
         xml = %Q{

data/spec/incident_spec.rb

@@ -29,23 +29,6 @@ module Cherby
         end
       end #exists?
 
-      describe "#complete!" do
-        it "sets appropriate fields to indicate incident completion" do
-          @incident.complete!('Testing completion')
-
-          @incident['CloseDescription'].should == 'Testing completion'
-          @incident['PhaseResolveStatus'].should == 'Complete'
-          @incident['ClosureCode'].should == 'Completed'
-          @incident['CMDBUpdate'].should == 'No'
-          @incident['SubCategory'].should == 'JIRA'
-          @incident['SubcategoryNonHR'].should == 'JIRA'
-        end
-      end #complete!
-
-      describe "#reopen!" do
-        it "TODO"
-      end #reopen!
-
       describe "#tasks" do
         it "returns an array of Task instances" do
           @incident.tasks.count.should == 5
@@ -87,22 +70,6 @@ module Cherby
           last_journal_note['Details'].should == 'New note on incident'
         end
       end #add_journal_note
-
-      describe "#differs_from?" do
-        it "false when comparing with self" do
-          @incident.differs_from?(@incident).should be_false
-        end
-        it "false when comparing with an identical Incident" do
-          incident2 = Cherby::Incident.new(@incident_xml)
-          incident2.differs_from?(@incident).should be_false
-        end
-        it "true if certain fields are different" do
-          incident2 = Cherby::Incident.new(@incident_xml)
-          @incident['Status'] = 'New'
-          incident2['Status'] = 'Assigned'
-          incident2.differs_from?(@incident).should be_true
-        end
-      end #differs_from?
     end # Instance methods
 
     context "Inherited instance methods" do

data/spec/task_spec.rb

@@ -37,28 +37,6 @@ module Cherby
         end
       end #exists?
 
-      describe "#differs_from?" do
-        it "false when compared with itself" do
-          task = Task.new(@task_xml)
-          task.differs_from?(task).should be_false
-        end
-
-        it "false when compared with a task with identical fields" do
-          task1 = Task.new(@task_xml)
-          task2 = Task.new(@task_xml)
-          task2.differs_from?(task1).should be_false
-        end
-
-        it "true if certain fields are different" do
-          task1 = Task.new(@task_xml)
-          task2 = Task.new(@task_xml)
-          task1['Status'] = 'New'
-          task2['Status'] = 'Assigned'
-          task1.differs_from?(task2).should be_true
-          task2.differs_from?(task1).should be_true
-        end
-      end #differs_from?
-
       describe "#add_journal_note" do
         it "adds a note to the Task" do
           task = Task.new(@task_xml)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cherby
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-07 00:00:00.000000000 Z
+date: 2014-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient