chemistrykit 1.1.1 → 1.2.0

data/.gitignore

@@ -3,7 +3,7 @@
 .bundle
 pkg/*
 tags
-tmp/
+build
 Gemfile.lock
 
 # Installed gems

data/README.md

@@ -6,9 +6,9 @@ ChemistryKit
 
 ### A simple and opinionated web testing framework for Selenium WebDriver
 
-This framework was designed to help you get started with Selenium WebDriver quickly, to grow as needed, and to avoid common pitfalls by following convention over configuration.  
+This framework was designed to help you get started with Selenium WebDriver quickly, to grow as needed, and to avoid common pitfalls by following convention over configuration.
 
-ChemistryKit's inspiration comes from the Saunter Selenium framework which is available in Python and PHP. You can find more about it [here](http://element34.ca/products/saunter).  
+ChemistryKit's inspiration comes from the Saunter Selenium framework which is available in Python and PHP. You can find more about it [here](http://element34.ca/products/saunter).
 
 ## Getting Started
 
@@ -30,3 +30,11 @@ This will run ckit and execute your beakers. By default it will run the tests lo
 ## Contributing
 
 This project conforms to the [neverstopbuilding/craftsmanship](https://github.com/neverstopbuilding/craftsmanship) guidelines. Please see them for details.
+
+### Install Dependencies
+
+    bundle install
+
+### Run rake task to test code
+
+    rake build

data/Rakefile

@@ -1 +1,18 @@
 require "bundler/gem_tasks"
+require "cucumber"
+require "cucumber/rake/task"
+require 'rspec/core/rake_task'
+
+task :default => [:build]
+
+desc 'Runs standard build activities.'
+task :build => [:clean, :spec, :cucumber]
+
+desc 'Removes the build directory.'
+task :clean do
+  FileUtils.rm_rf('build');
+end
+
+RSpec::Core::RakeTask.new(:spec)
+
+Cucumber::Rake::Task.new(:cucumber)

data/bin/ckit

@@ -2,4 +2,13 @@
 
 require 'chemistrykit'
 
-ChemistryKit::CLI::CKitCLI.start
+ckit_result = ChemistryKit::CLI::CKitCLI.start
+
+# Had difficulties getting Thor to return a proper exit status on failure
+# Will need to revisit
+
+if ckit_result.is_a? Array
+  exit 0
+else
+  exit ckit_result
+end

data/chemistrykit.gemspec

@@ -1,12 +1,12 @@
 Gem::Specification.new do |s|
   s.name          = "chemistrykit"
-  s.version       = "1.1.1"
+  s.version       = "1.2.0"
   s.platform      = Gem::Platform::RUBY
-  s.authors       = ["Dave Haeffner", "Jason Wieringa"]
-  s.email         = ["dave@arrgyle.com", "jason@arrgyle.com"]
+  s.authors       = ["Dave Haeffner"]
+  s.email         = ["dave@arrgyle.com"]
   s.homepage      = "https://github.com/arrgyle/chemistrykit"
   s.summary       = "A simple and opinionated web testing framework for Selenium that follows convention over configuration."
-  s.description   = "Bumping to new version of selenium-connect to account for breaking changes in sauce gem usage."
+  s.description   = "Fixing a bug with exit status codes not returning properly on failure. And bumping to a new version of selenium-connect to get better logging and access to GhostDriver/PhantomJS."
   s.license       = 'MIT'
 
   s.files         = `git ls-files`.split($/)
@@ -21,7 +21,7 @@ Gem::Specification.new do |s|
   s.add_dependency "selenium-webdriver", "~> 2.29.0"
   s.add_dependency "ci_reporter", "~> 1.8.3"
   s.add_dependency "rest-client", "~> 1.6.7"
-  s.add_dependency "selenium-connect", "~> 1.8.1"
+  s.add_dependency "selenium-connect", "~> 1.9.0"
 
   s.add_development_dependency "rspec", "~> 2.12.0"
   s.add_development_dependency "aruba", "~> 0.5.1"

data/features/exit_status.feature

@@ -0,0 +1,31 @@
+Feature: Exit Status
+
+  Background:
+    Given I run `ckit new cheese`
+    And I cd to "cheese"
+
+  Scenario: Passing
+    And a file named "beaker/test_beaker.rb" with:
+    """
+    describe "Cheese", :depth => 'shallow' do
+      it "loads an external web page" do
+        @driver.get "http://www.google.com"
+        @driver.title.should include("Google")
+      end
+    end
+    """
+    When I run `ckit brew`
+    Then the exit code should be 0
+
+  Scenario: Failing
+    And a file named "beaker/test_beaker.rb" with:
+    """
+    describe "Cheese", :depth => 'shallow' do
+      it "loads an external web page" do
+        @driver.get "http://www.google.com"
+        @driver.title.should_not include("Google")
+      end
+    end
+    """
+    When I run `ckit brew`
+    Then the exit code should be 1

data/features/new.feature

@@ -3,8 +3,8 @@ Feature: ckit new
   Run "ckit new <project_name>" to generate a new ChemistryKit project
 
   Background: Running ckit new
-    When I run `bundle exec ckit new booker`
-    And I cd to "booker"
+    When I run `bundle exec ckit new new-project`
+    And I cd to "new-project"
 
   @announce
   Scenario: Test Harness is created

data/features/step_definitions/steps.rb

@@ -0,0 +1,10 @@
+When /^I overwrite ([^"]*) with:$/ do |file_name, file_content|
+  #Modified from https://github.com/cucumber/aruba/blob/master/lib/aruba/cucumber.rb
+  require 'erb'
+  data = ERB.new(file_content)
+  overwrite_file(file_name, data.result)
+end
+
+Then(/^the exit code should be (\d+)$/) do |exit_status|
+  $?.exitstatus.should == exit_status.to_i
+end

data/features/support/env.rb

@@ -2,5 +2,5 @@ require 'aruba/cucumber'
 
 Before do
   @aruba_timeout_seconds = 90
-  @dirs = ["tmp"]
+  @dirs = ["build/tmp"]
 end

data/lib/chemistrykit/cli/cli.rb

@@ -14,6 +14,7 @@ module ChemistryKit
     end
 
     class CKitCLI < Thor
+
       register(ChemistryKit::CLI::New, 'new', 'new [NAME]', 'Creates a new ChemistryKit project')
       check_unknown_options!
       default_task :help

metadata

@@ -1,16 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: chemistrykit
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
   prerelease: 
 platform: ruby
 authors:
 - Dave Haeffner
-- Jason Wieringa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-09 00:00:00.000000000 Z
+date: 2013-06-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -99,7 +98,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -107,7 +106,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.9.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -172,11 +171,11 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 10.0.3
-description: Bumping to new version of selenium-connect to account for breaking changes
-  in sauce gem usage.
+description: Fixing a bug with exit status codes not returning properly on failure.
+  And bumping to a new version of selenium-connect to get better logging and access
+  to GhostDriver/PhantomJS.
 email:
 - dave@arrgyle.com
-- jason@arrgyle.com
 executables:
 - ckit
 extensions:
@@ -195,8 +194,9 @@ files:
 - chemistrykit.gemspec
 - ext/mkrf_conf.rb
 - features/brew.feature
+- features/exit_status.feature
 - features/new.feature
-- features/step_definitions/modified_steps.rb
+- features/step_definitions/steps.rb
 - features/support/env.rb
 - lib/chemistrykit.rb
 - lib/chemistrykit/cli/beaker.rb
@@ -214,7 +214,6 @@ files:
 - lib/templates/chemistrykit/formulas/.gitkeep
 - lib/templates/formula.tt
 - readme2.md
-- spec/chemistrykit/cli_spec.rb
 homepage: https://github.com/arrgyle/chemistrykit
 licenses:
 - MIT
@@ -243,7 +242,7 @@ summary: A simple and opinionated web testing framework for Selenium that follow
   convention over configuration.
 test_files:
 - features/brew.feature
+- features/exit_status.feature
 - features/new.feature
-- features/step_definitions/modified_steps.rb
+- features/step_definitions/steps.rb
 - features/support/env.rb
-- spec/chemistrykit/cli_spec.rb

data/features/step_definitions/modified_steps.rb

@@ -1,7 +0,0 @@
-require 'erb'
-
-#Modified from https://github.com/cucumber/aruba/blob/master/lib/aruba/cucumber.rb
-When /^I overwrite ([^"]*) with:$/ do |file_name, file_content|
-  data = ERB.new(file_content)
-  overwrite_file(file_name, data.result)
-end

data/spec/chemistrykit/cli_spec.rb

@@ -1,9 +0,0 @@
-module ChemistryKit
- describe CLI do
-   it "should return new project" do
-     cli = ChemistryKit::CLI.start
-     new = CLI.new
-     new = "new"
-   end
- end
-end