chefstyle 0.13.0 → 0.13.2

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: d4e12a2a3382d42dd88e672f7e5e13a4208f629bcea40fcb7743d0b8c4981aec
4
- data.tar.gz: 82393a1e028e5be97a672865dc329ad47c7a053997a055224f764de9ceecbf35
3
+ metadata.gz: 564191d5ebde4f0e11b5818aa7813f796b8a6cb32edda6c1e4a6ab12a2caddff
4
+ data.tar.gz: 40bf6d6f41890788e3a70e2d83e8ea449e9d6489096ad31112ce5d3d350d7bf3
5
5
  SHA512:
6
- metadata.gz: c17083813e7a064e7204069d52dce2566b83f3e06b32c0aedc424adecb773ba43e03742d620d6490da420e854e0ba438bd26a9fb1a34c2ddc3f8ca991b4adece
7
- data.tar.gz: fd37b3e4c50f020b1fe14d750236d9bb8c7b46c18860f562f81233f7f4798fed0ad4d6aaf585c54e38bd700e51bde74c2730f17d25445e25a34788283ccc3ae6
6
+ metadata.gz: bf30b331d2a785a6c82e4fd5b4d2f0cd3d7482edf05e2862247ae0fa85e6d749ed75aeadba67af00cd3001c59aeb215a2662c8a945cc09417c9e6714366db2f4
7
+ data.tar.gz: 3d03f6e924ec844ea0f6002b0de3f083ee98a3b3b1c6878cd773814234eea32685297f98de53f4ca1159d4c5332c193ba8f173812c60d13bde3418b09a10b66e
@@ -21,6 +21,7 @@ Lint/AmbiguousRegexpLiteral:
21
21
  Lint/AssignmentInCondition:
22
22
  Enabled: true
23
23
  Layout/BlockAlignment:
24
+ EnforcedStyleAlignWith: start_of_block
24
25
  Enabled: true
25
26
  Lint/CircularArgumentReference:
26
27
  Enabled: true
@@ -66,7 +67,7 @@ Lint/InheritException:
66
67
  Enabled: true
67
68
  Lint/IneffectiveAccessModifier:
68
69
  Enabled: true
69
- Lint/LiteralInCondition:
70
+ Lint/LiteralAsCondition:
70
71
  Enabled: true
71
72
  Lint/LiteralInInterpolation:
72
73
  Enabled: true
@@ -137,7 +138,7 @@ Lint/RescueException:
137
138
  Enabled: false
138
139
 
139
140
  # disabling this will make it easier to stage chefstyle rollouts
140
- Lint/UnneededDisable:
141
+ Lint/UnneededCopDisableDirective:
141
142
  Enabled: false
142
143
 
143
144
  #
@@ -176,11 +177,19 @@ Metrics/PerceivedComplexity:
176
177
 
177
178
 
178
179
  #
179
- # Style
180
+ # Style/Naming/Layout
180
181
  #
181
182
 
182
183
  Layout/AccessModifierIndentation:
183
184
  Enabled: true
185
+ Layout/AlignArguments:
186
+ Enabled: true
187
+ EnforcedStyle: with_fixed_indentation
188
+ Layout/AlignParameters:
189
+ Enabled: true
190
+ EnforcedStyle: with_fixed_indentation
191
+ # the "ignore_implict" is here for keyword args in method calls which are
192
+ # "implicit" hashes, and those should not be treated like normal hashes
184
193
  Layout/AlignHash:
185
194
  Enabled: true
186
195
  EnforcedLastArgumentHashStyle: ignore_implicit
@@ -196,12 +205,18 @@ Style/BeginBlock:
196
205
  Enabled: true
197
206
  Style/BlockDelimiters:
198
207
  Enabled: true
208
+ Layout/BlockEndNewline:
209
+ Enabled: true
199
210
  Style/CharacterLiteral:
200
211
  Enabled: true
212
+ Style/ClassCheck:
213
+ Enabled: true
201
214
  Style/ClassMethods:
202
215
  Enabled: true
203
216
  Layout/ClosingHeredocIndentation:
204
217
  Enabled: true
218
+ Layout/ClosingParenthesisIndentation:
219
+ Enabled: true
205
220
  Style/ColonMethodCall:
206
221
  Enabled: true
207
222
  Style/CommandLiteral:
@@ -216,6 +231,8 @@ Style/EachForSimpleLoop:
216
231
  Enabled: true
217
232
  Layout/ElseAlignment:
218
233
  Enabled: true
234
+ Layout/EmptyLineAfterGuardClause:
235
+ Enabled: true
219
236
  Layout/EmptyLineBetweenDefs:
220
237
  Enabled: true
221
238
  Layout/EmptyLines:
@@ -224,6 +241,10 @@ Layout/EmptyLinesAroundAccessModifier:
224
241
  Enabled: true
225
242
  Layout/EmptyLinesAroundMethodBody:
226
243
  Enabled: true
244
+ Style/EmptyLiteral:
245
+ Enabled: true
246
+ Style/EmptyMethod:
247
+ Enabled: true
227
248
  Style/EndBlock:
228
249
  Enabled: true
229
250
  Layout/EndOfLine:
@@ -247,6 +268,9 @@ Style/IfWithSemicolon:
247
268
  Enabled: true
248
269
  Layout/IndentAssignment:
249
270
  Enabled: true
271
+ Layout/IndentFirstArgument:
272
+ EnforcedStyle: consistent
273
+ Enabled: true
250
274
  Layout/IndentHeredoc:
251
275
  Enabled: true
252
276
  Layout/IndentationConsistency:
@@ -263,6 +287,8 @@ Layout/LeadingCommentSpace:
263
287
  Enabled: true
264
288
  Style/MethodDefParentheses:
265
289
  Enabled: true
290
+ Style/MethodCallWithoutArgsParentheses:
291
+ Enabled: true
266
292
  Layout/MultilineBlockLayout:
267
293
  Enabled: true
268
294
  Style/MultilineIfModifier:
@@ -271,6 +297,11 @@ Style/MultilineIfThen:
271
297
  Enabled: true
272
298
  Style/MultilineMemoization:
273
299
  Enabled: true
300
+ Layout/MultilineMethodCallBraceLayout:
301
+ Enabled: true
302
+ Layout/MultilineMethodCallIndentation:
303
+ Enabled: true
304
+ EnforcedStyle: indented
274
305
  Layout/MultilineMethodDefinitionBraceLayout:
275
306
  Enabled: true
276
307
  Layout/MultilineOperationIndentation:
@@ -280,8 +311,12 @@ Style/MultilineTernaryOperator:
280
311
  Enabled: true
281
312
  Style/MutableConstant:
282
313
  Enabled: true
314
+ Style/NegatedIf:
315
+ Enabled: true
283
316
  Style/NegatedWhile:
284
317
  Enabled: true
318
+ Style/NegatedUnless:
319
+ Enabled: true
285
320
  Style/NestedModifier:
286
321
  Enabled: true
287
322
  Style/NestedTernaryOperator:
@@ -336,6 +371,8 @@ Style/RedundantSelf:
336
371
  Enabled: true
337
372
  Layout/RescueEnsureAlignment:
338
373
  Enabled: true
374
+ Style/RegexpLiteral:
375
+ Enabled: true
339
376
  # temporarily disabled, but we should do this
340
377
  Style/SafeNavigation:
341
378
  Enabled: false
@@ -388,26 +425,30 @@ Style/StabbyLambdaParentheses:
388
425
  Style/StringLiterals:
389
426
  EnforcedStyle: double_quotes
390
427
  Enabled: true
428
+ Style/StringLiteralsInInterpolation:
429
+ EnforcedStyle: double_quotes
430
+ Enabled: true
391
431
  Style/StructInheritance:
392
432
  Enabled: true
393
433
  Style/SymbolLiteral:
394
434
  Enabled: true
395
435
  Style/StringMethods:
396
436
  Enabled: true
437
+ Style/SymbolArray:
438
+ Enabled: true
439
+ Style/SymbolProc:
440
+ Enabled: true
397
441
  Layout/Tab:
398
442
  Enabled: true
399
443
  Layout/TrailingBlankLines:
400
444
  Enabled: true
401
445
  Style/TrailingCommaInArguments:
402
446
  Enabled: true
403
- Style/TrailingCommaInHashLiteral:
404
- Enabled: true
405
- EnforcedStyleForMultiline: comma
406
447
  # rubocop's default gets this completely backwards
407
- Style/TrailingCommaInArray:
448
+ Style/TrailingCommaInArrayLiteral:
408
449
  Enabled: true
409
450
  EnforcedStyleForMultiline: comma
410
- Style/TrailingCommaInHash:
451
+ Style/TrailingCommaInHashLiteral:
411
452
  Enabled: true
412
453
  EnforcedStyleForMultiline: comma
413
454
  Style/TrailingUnderscoreVariable:
@@ -453,14 +494,14 @@ Layout/SpaceBeforeFirstArg:
453
494
  Enabled: false
454
495
 
455
496
  # whitespace in expressions is useful to enhance readability
456
- Layout/SpaceInsideBrackets:
497
+ Layout/SpaceInsideArrayLiteralBrackets:
498
+ Enabled: false
499
+ Layout/SpaceInsideReferenceBrackets:
457
500
  Enabled: false
458
501
  Layout/SpaceInsideParens:
459
502
  Enabled: false
460
503
  Layout/SpaceInsidePercentLiteralDelimiters:
461
504
  Enabled: false
462
- Layout/SpaceInsideArrayLiteralBrackets:
463
- Enabled: false
464
505
 
465
506
  # more whitespace cops that we allow since they can enhance readability
466
507
  Layout/EmptyLinesAroundBlockBody:
@@ -565,3 +606,17 @@ Naming/VariableNumber:
565
606
  # This breaks all kinds of specs in chef (i don't think it will ever quite work correctly)
566
607
  Style/BracesAroundHashParameters:
567
608
  Enabled: false
609
+
610
+ # We almost never use format strings but this cop triggers on any string with "%{whatever}" in it and is 99% false positives
611
+ Style/FormatStringToken:
612
+ Enabled: false
613
+
614
+ # This cop is annoying. The rubocop default of course goes against the most popular community guidelines due to contrariness
615
+ # and then the autocorrect mangles specs in chef/chef. Burned more time than it was worth looking at this one so its off.
616
+ Style/Alias:
617
+ Enabled: false
618
+
619
+ # No autofix for this one, and I don't care to fix 138 instances of it in the chef/chef codebase. Don't think its worth wasting
620
+ # anyone else's time either.
621
+ Style/CommentedKeyword:
622
+ Enabled: false
@@ -1,4 +1,4 @@
1
1
  module Chefstyle
2
- VERSION = "0.13.0".freeze
2
+ VERSION = "0.13.2".freeze
3
3
  RUBOCOP_VERSION = "0.72.0".freeze
4
4
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: chefstyle
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.13.0
4
+ version: 0.13.2
5
5
  platform: ruby
6
6
  authors:
7
7
  - Chef Software, Inc.
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2019-07-02 00:00:00.000000000 Z
11
+ date: 2019-07-08 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: bundler