chefstyle 0.13.0 → 0.13.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d4e12a2a3382d42dd88e672f7e5e13a4208f629bcea40fcb7743d0b8c4981aec
-  data.tar.gz: 82393a1e028e5be97a672865dc329ad47c7a053997a055224f764de9ceecbf35
+  metadata.gz: 564191d5ebde4f0e11b5818aa7813f796b8a6cb32edda6c1e4a6ab12a2caddff
+  data.tar.gz: 40bf6d6f41890788e3a70e2d83e8ea449e9d6489096ad31112ce5d3d350d7bf3
 SHA512:
-  metadata.gz: c17083813e7a064e7204069d52dce2566b83f3e06b32c0aedc424adecb773ba43e03742d620d6490da420e854e0ba438bd26a9fb1a34c2ddc3f8ca991b4adece
-  data.tar.gz: fd37b3e4c50f020b1fe14d750236d9bb8c7b46c18860f562f81233f7f4798fed0ad4d6aaf585c54e38bd700e51bde74c2730f17d25445e25a34788283ccc3ae6
+  metadata.gz: bf30b331d2a785a6c82e4fd5b4d2f0cd3d7482edf05e2862247ae0fa85e6d749ed75aeadba67af00cd3001c59aeb215a2662c8a945cc09417c9e6714366db2f4
+  data.tar.gz: 3d03f6e924ec844ea0f6002b0de3f083ee98a3b3b1c6878cd773814234eea32685297f98de53f4ca1159d4c5332c193ba8f173812c60d13bde3418b09a10b66e

data/config/chefstyle.yml

@@ -21,6 +21,7 @@ Lint/AmbiguousRegexpLiteral:
 Lint/AssignmentInCondition:
   Enabled: true
 Layout/BlockAlignment:
+  EnforcedStyleAlignWith: start_of_block
   Enabled: true
 Lint/CircularArgumentReference:
   Enabled: true
@@ -66,7 +67,7 @@ Lint/InheritException:
   Enabled: true
 Lint/IneffectiveAccessModifier:
   Enabled: true
-Lint/LiteralInCondition:
+Lint/LiteralAsCondition:
   Enabled: true
 Lint/LiteralInInterpolation:
   Enabled: true
@@ -137,7 +138,7 @@ Lint/RescueException:
   Enabled: false
 
 # disabling this will make it easier to stage chefstyle rollouts
-Lint/UnneededDisable:
+Lint/UnneededCopDisableDirective:
   Enabled: false
 
 #
@@ -176,11 +177,19 @@ Metrics/PerceivedComplexity:
 
 
 #
-# Style
+# Style/Naming/Layout
 #
 
 Layout/AccessModifierIndentation:
   Enabled: true
+Layout/AlignArguments:
+  Enabled: true
+  EnforcedStyle: with_fixed_indentation
+Layout/AlignParameters:
+  Enabled: true
+  EnforcedStyle: with_fixed_indentation
+# the "ignore_implict" is here for keyword args in method calls which are
+# "implicit" hashes, and those should not be treated like normal hashes
 Layout/AlignHash:
   Enabled: true
   EnforcedLastArgumentHashStyle: ignore_implicit
@@ -196,12 +205,18 @@ Style/BeginBlock:
   Enabled: true
 Style/BlockDelimiters:
   Enabled: true
+Layout/BlockEndNewline:
+  Enabled: true
 Style/CharacterLiteral:
   Enabled: true
+Style/ClassCheck:
+  Enabled: true
 Style/ClassMethods:
   Enabled: true
 Layout/ClosingHeredocIndentation:
   Enabled: true
+Layout/ClosingParenthesisIndentation:
+  Enabled: true
 Style/ColonMethodCall:
   Enabled: true
 Style/CommandLiteral:
@@ -216,6 +231,8 @@ Style/EachForSimpleLoop:
   Enabled: true
 Layout/ElseAlignment:
   Enabled: true
+Layout/EmptyLineAfterGuardClause:
+  Enabled: true
 Layout/EmptyLineBetweenDefs:
   Enabled: true
 Layout/EmptyLines:
@@ -224,6 +241,10 @@ Layout/EmptyLinesAroundAccessModifier:
   Enabled: true
 Layout/EmptyLinesAroundMethodBody:
   Enabled: true
+Style/EmptyLiteral:
+  Enabled: true
+Style/EmptyMethod:
+  Enabled: true
 Style/EndBlock:
   Enabled: true
 Layout/EndOfLine:
@@ -247,6 +268,9 @@ Style/IfWithSemicolon:
   Enabled: true
 Layout/IndentAssignment:
   Enabled: true
+Layout/IndentFirstArgument:
+  EnforcedStyle: consistent
+  Enabled: true
 Layout/IndentHeredoc:
   Enabled: true
 Layout/IndentationConsistency:
@@ -263,6 +287,8 @@ Layout/LeadingCommentSpace:
   Enabled: true
 Style/MethodDefParentheses:
   Enabled: true
+Style/MethodCallWithoutArgsParentheses:
+  Enabled: true
 Layout/MultilineBlockLayout:
   Enabled: true
 Style/MultilineIfModifier:
@@ -271,6 +297,11 @@ Style/MultilineIfThen:
   Enabled: true
 Style/MultilineMemoization:
   Enabled: true
+Layout/MultilineMethodCallBraceLayout:
+  Enabled: true
+Layout/MultilineMethodCallIndentation:
+  Enabled: true
+  EnforcedStyle: indented
 Layout/MultilineMethodDefinitionBraceLayout:
   Enabled: true
 Layout/MultilineOperationIndentation:
@@ -280,8 +311,12 @@ Style/MultilineTernaryOperator:
   Enabled: true
 Style/MutableConstant:
   Enabled: true
+Style/NegatedIf:
+  Enabled: true
 Style/NegatedWhile:
   Enabled: true
+Style/NegatedUnless:
+  Enabled: true
 Style/NestedModifier:
   Enabled: true
 Style/NestedTernaryOperator:
@@ -336,6 +371,8 @@ Style/RedundantSelf:
   Enabled: true
 Layout/RescueEnsureAlignment:
   Enabled: true
+Style/RegexpLiteral:
+  Enabled: true
 # temporarily disabled, but we should do this
 Style/SafeNavigation:
   Enabled: false
@@ -388,26 +425,30 @@ Style/StabbyLambdaParentheses:
 Style/StringLiterals:
   EnforcedStyle: double_quotes
   Enabled: true
+Style/StringLiteralsInInterpolation:
+  EnforcedStyle: double_quotes
+  Enabled: true
 Style/StructInheritance:
   Enabled: true
 Style/SymbolLiteral:
   Enabled: true
 Style/StringMethods:
   Enabled: true
+Style/SymbolArray:
+  Enabled: true
+Style/SymbolProc:
+  Enabled: true
 Layout/Tab:
   Enabled: true
 Layout/TrailingBlankLines:
   Enabled: true
 Style/TrailingCommaInArguments:
   Enabled: true
-Style/TrailingCommaInHashLiteral:
-  Enabled: true
-  EnforcedStyleForMultiline: comma
 # rubocop's default gets this completely backwards
-Style/TrailingCommaInArray:
+Style/TrailingCommaInArrayLiteral:
   Enabled: true
   EnforcedStyleForMultiline: comma
-Style/TrailingCommaInHash:
+Style/TrailingCommaInHashLiteral:
   Enabled: true
   EnforcedStyleForMultiline: comma
 Style/TrailingUnderscoreVariable:
@@ -453,14 +494,14 @@ Layout/SpaceBeforeFirstArg:
   Enabled: false
 
 # whitespace in expressions is useful to enhance readability
-Layout/SpaceInsideBrackets:
+Layout/SpaceInsideArrayLiteralBrackets:
+  Enabled: false
+Layout/SpaceInsideReferenceBrackets:
   Enabled: false
 Layout/SpaceInsideParens:
   Enabled: false
 Layout/SpaceInsidePercentLiteralDelimiters:
   Enabled: false
-Layout/SpaceInsideArrayLiteralBrackets:
-  Enabled: false
 
 # more whitespace cops that we allow since they can enhance readability
 Layout/EmptyLinesAroundBlockBody:
@@ -565,3 +606,17 @@ Naming/VariableNumber:
 # This breaks all kinds of specs in chef (i don't think it will ever quite work correctly)
 Style/BracesAroundHashParameters:
   Enabled: false
+
+# We almost never use format strings but this cop triggers on any string with "%{whatever}" in it and is 99% false positives
+Style/FormatStringToken:
+  Enabled: false
+
+# This cop is annoying.  The rubocop default of course goes against the most popular community guidelines due to contrariness
+# and then the autocorrect mangles specs in chef/chef.  Burned more time than it was worth looking at this one so its off.
+Style/Alias:
+  Enabled: false
+
+# No autofix for this one, and I don't care to fix 138 instances of it in the chef/chef codebase.  Don't think its worth wasting
+# anyone else's time either.
+Style/CommentedKeyword:
+  Enabled: false

data/lib/chefstyle/version.rb

@@ -1,4 +1,4 @@
 module Chefstyle
-  VERSION = "0.13.0".freeze
+  VERSION = "0.13.2".freeze
   RUBOCOP_VERSION = "0.72.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chefstyle
 version: !ruby/object:Gem::Version
-  version: 0.13.0
+  version: 0.13.2
 platform: ruby
 authors:
 - Chef Software, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-02 00:00:00.000000000 Z
+date: 2019-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler