chefstyle 0.12.0 → 0.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fb5721af35b1c0dbf266e85921b08c6d666c7af40b9a3b9e87662b207669cebe
-  data.tar.gz: a284368f9f483342b0fc2aa9dadaab347dd0745c9ee6e4ab63b4ed92483cfd5d
+  metadata.gz: d4e12a2a3382d42dd88e672f7e5e13a4208f629bcea40fcb7743d0b8c4981aec
+  data.tar.gz: 82393a1e028e5be97a672865dc329ad47c7a053997a055224f764de9ceecbf35
 SHA512:
-  metadata.gz: 75a594f57342a142e71a4b36c72d85d3d6ee43a87498de252a06205a9c263dfded4e6b04590c59998a54de5a4d8ffa7b2b38262f9820f03cb26c2aa6a3e0ab65
-  data.tar.gz: fcaa9aa906c5cd70fad5f1c7cbc62488ff78cea2b41ae95b7b6f14d4305ecb99cc0545f9bd1b7da3a9a8ccbe53ab4be1b2edfbe94b7d62eafa16901d9bcbaf1c
+  metadata.gz: c17083813e7a064e7204069d52dce2566b83f3e06b32c0aedc424adecb773ba43e03742d620d6490da420e854e0ba438bd26a9fb1a34c2ddc3f8ca991b4adece
+  data.tar.gz: fd37b3e4c50f020b1fe14d750236d9bb8c7b46c18860f562f81233f7f4798fed0ad4d6aaf585c54e38bd700e51bde74c2730f17d25445e25a34788283ccc3ae6

data/config/chefstyle.yml

@@ -6,7 +6,7 @@ AllCops:
 #
 
 Bundler/DuplicatedGem:
-  Enabled: true
+  Enabled: false
 
 #
 # Lint
@@ -66,8 +66,6 @@ Lint/InheritException:
   Enabled: true
 Lint/IneffectiveAccessModifier:
   Enabled: true
-Lint/InvalidCharacterLiteral:
-  Enabled: true
 Lint/LiteralInCondition:
   Enabled: true
 Lint/LiteralInInterpolation:
@@ -104,8 +102,6 @@ Lint/UnderscorePrefixedVariableName:
   Enabled: true
 Lint/UnifiedInteger:
   Enabled: true
-Lint/UnneededDisable:
-  Enabled: true
 Lint/UnneededSplatExpansion:
   Enabled: true
 Lint/UnreachableCode:
@@ -144,88 +140,6 @@ Lint/RescueException:
 Lint/UnneededDisable:
   Enabled: false
 
-#
-# Performance
-#
-
-Performance/Casecmp:
-  Enabled: true
-Performance/CaseWhenSplat:
-  Enabled: true
-Performance/CompareWithBlock:
-  Enabled: true
-Performance/Count:
-  Enabled: true
-Performance/Detect:
-  Enabled: true
-Performance/DoubleStartEndWith:
-  Enabled: true
-Performance/EndWith:
-  Enabled: true
-Performance/FixedSize:
-  Enabled: true
-Performance/FlatMap:
-  Enabled: true
-Performance/HashEachMethods:
-  Enabled: true
-Performance/LstripRstrip:
-  Enabled: true
-Performance/RangeInclude:
-  Enabled: true
-Performance/RedundantBlockCall:
-  Enabled: true
-Performance/RedundantMatch:
-  Enabled: true
-Performance/RedundantMerge:
-  Enabled: true
-Performance/RedundantSortBy:
-  Enabled: true
-Performance/RegexpMatch:
-  Enabled: true
-Performance/ReverseEach:
-  Enabled: true
-Performance/Sample:
-  Enabled: true
-Performance/Size:
-  Enabled: true
-Performance/SortWithBlock:
-  Enabled: true
-Performance/StartWith:
-  Enabled: true
-Performance/StringReplacement:
-  Enabled: true
-Performance/TimesMap:
-  Enabled: true
-
-#
-# Rails
-#
-
-Rails/ActionFilter:
-  Enabled: true
-Rails/Date:
-  Enabled: true
-Rails/Delegate:
-  Enabled: true
-Rails/FindBy:
-  Enabled: true
-Rails/FindEach:
-  Enabled: true
-Rails/HasAndBelongsToMany:
-  Enabled: true
-Rails/Output:
-  Enabled: true
-Rails/PluralizationGrammar:
-  Enabled: true
-Rails/ReadWriteAttribute:
-  Enabled: true
-Rails/ScopeArgs:
-  Enabled: true
-Rails/TimeZone:
-  Enabled: true
-Rails/Validation:
-  Enabled: true
-
 #
 # Security
 #
@@ -319,12 +233,10 @@ Style/EvenOdd:
   Enabled: true
 Layout/ExtraSpacing:
   Enabled: true
-Style/FlipFlop:
+Lint/FlipFlop:
   Enabled: true
 Style/For:
   Enabled: true
-Style/FrozenStringLiteralComment:
-  Enabled: true
 Style/HashSyntax:
   Enabled: true
 Naming/HeredocDelimiterCase:
@@ -384,7 +296,7 @@ Style/NumericPredicate:
   EnforcedStyle: comparison
 Style/OneLineConditional:
   Enabled: true
-Style/OpMethod:
+Naming/BinaryOperatorParameterName:
   Enabled: true
 Style/OptionalArguments:
   Enabled: true
@@ -492,7 +404,10 @@ Style/TrailingCommaInHashLiteral:
   Enabled: true
   EnforcedStyleForMultiline: comma
 # rubocop's default gets this completely backwards
-Style/TrailingCommaInLiteral:
+Style/TrailingCommaInArray:
+  Enabled: true
+  EnforcedStyleForMultiline: comma
+Style/TrailingCommaInHash:
   Enabled: true
   EnforcedStyleForMultiline: comma
 Style/TrailingUnderscoreVariable:
@@ -570,7 +485,7 @@ Style/Encoding:
   Enabled: false
 
 # Dan is -1 on this one: https://github.com/chef/chef/pull/4526#issuecomment-179950045
-Layout/IndentHash:
+Layout/IndentFirstHashElement:
   Enabled: false
 
 # This is overly aggressive and autofix broke stuff, would need to exclude classes
@@ -623,6 +538,12 @@ Style/SpecialGlobalVars:
 Style/GuardClause:
   Enabled: false
 
+Style/RedundantSortBy:
+  Enabled: true
+
+Style/Sample:
+  Enabled: true
+
 # Let authors order gems however makes sense
 Bundler/OrderedGems:
   Enabled: false

data/config/disable_all.yml

@@ -13,8 +13,12 @@ Gemspec/OrderedDependencies:
   Enabled: false
 Gemspec/RequiredRubyVersion:
   Enabled: false
+Gemspec/RubyVersionGlobalsUsage:
+  Enabled: false
 Layout/AccessModifierIndentation:
   Enabled: false
+Layout/AlignArguments:
+  Enabled: false
 Layout/AlignArray:
   Enabled: false
 Layout/AlignHash:
@@ -83,9 +87,7 @@ Layout/FirstMethodArgumentLineBreak:
   Enabled: false
 Layout/FirstMethodParameterLineBreak:
   Enabled: false
-Layout/FirstParameterIndentation:
-  Enabled: false
-Layout/IndentArray:
+Layout/HeredocArgumentClosingParenthesis:
   Enabled: false
 Layout/IndentAssignment:
   Enabled: false
@@ -93,7 +95,13 @@ Layout/IndentationConsistency:
   Enabled: false
 Layout/IndentationWidth:
   Enabled: false
-Layout/IndentHash:
+Layout/IndentFirstArgument:
+  Enabled: false
+Layout/IndentFirstArrayElement:
+  Enabled: false
+Layout/IndentFirstHashElement:
+  Enabled: false
+Layout/IndentFirstParameter:
   Enabled: false
 Layout/IndentHeredoc:
   Enabled: false
@@ -105,12 +113,18 @@ Layout/LeadingCommentSpace:
   Enabled: false
 Layout/MultilineArrayBraceLayout:
   Enabled: false
+Layout/MultilineArrayLineBreaks:
+  Enabled: false
 Layout/MultilineAssignmentLayout:
   Enabled: false
 Layout/MultilineBlockLayout:
   Enabled: false
 Layout/MultilineHashBraceLayout:
   Enabled: false
+Layout/MultilineHashKeyLineBreaks:
+  Enabled: false
+Layout/MultilineMethodArgumentLineBreaks:
+  Enabled: false
 Layout/MultilineMethodCallBraceLayout:
   Enabled: false
 Layout/MultilineMethodCallIndentation:
@@ -193,6 +207,8 @@ Lint/Debugger:
   Enabled: false
 Lint/DeprecatedClassMethods:
   Enabled: false
+Lint/DisjunctiveAssignmentInConstructor:
+  Enabled: false
 Lint/DuplicateCaseCondition:
   Enabled: false
 Lint/DuplicateMethods:
@@ -217,12 +233,16 @@ Lint/EnsureReturn:
   Enabled: false
 Lint/ErbNewArguments:
   Enabled: false
+Lint/FlipFlop:
+  Enabled: false
 Lint/FloatOutOfRange:
   Enabled: false
 Lint/FormatParameterMismatch:
   Enabled: false
 Lint/HandleExceptions:
   Enabled: false
+Lint/HeredocMethodCallPosition:
+  Enabled: false
 Lint/ImplicitStringConcatenation:
   Enabled: false
 Lint/InheritException:
@@ -279,6 +299,8 @@ Lint/SafeNavigationConsistency:
   Enabled: false
 Lint/SafeNavigationChain:
   Enabled: false
+Lint/SafeNavigationWithEmpty:
+  Enabled: false
 Lint/ScriptPermission:
   Enabled: false
 Lint/ShadowedArgument:
@@ -291,6 +313,8 @@ Lint/StringConversionInInterpolation:
   Enabled: false
 Lint/Syntax:
   Enabled: false
+Lint/ToJSON:
+  Enabled: false
 Lint/UnderscorePrefixedVariableName:
   Enabled: false
 Lint/UnifiedInteger:
@@ -367,6 +391,8 @@ Naming/BinaryOperatorParameterName:
   Enabled: false
 Naming/PredicateName:
   Enabled: false
+Naming/RescuedExceptionsVariableName:
+  Enabled: false
 Naming/UncommunicativeBlockParamName:
   Enabled: false
 Naming/UncommunicativeMethodParamName:
@@ -375,64 +401,6 @@ Naming/VariableName:
   Enabled: false
 Naming/VariableNumber:
   Enabled: false
-Performance/Caller:
-  Enabled: false
-Performance/CaseWhenSplat:
-  Enabled: false
-Performance/Casecmp:
-  Enabled: false
-Performance/Count:
-  Enabled: false
-Performance/Detect:
-  Enabled: false
-Performance/DoubleStartEndWith:
-  Enabled: false
-Performance/EndWith:
-  Enabled: false
-Performance/FixedSize:
-  Enabled: false
-Performance/FlatMap:
-  Enabled: false
-Performance/InefficientHashSearch:
-  Enabled: false
-Performance/LstripRstrip:
-  Enabled: false
-Performance/OpenStruct:
-  Enabled: false
-Performance/RangeInclude:
-  Enabled: false
-Performance/RedundantBlockCall:
-  Enabled: false
-Performance/RedundantMatch:
-  Enabled: false
-Performance/RedundantMerge:
-  Enabled: false
-Performance/RedundantSortBy:
-  Enabled: false
-Performance/RegexpMatch:
-  Enabled: false
-Performance/ReverseEach:
-  Enabled: false
-Performance/Sample:
-  Enabled: false
-Performance/Size:
-  Enabled: false
-Performance/CompareWithBlock:
-  Enabled: false
-Performance/StartWith:
-  Enabled: false
-Performance/StringReplacement:
-  Enabled: false
-Performance/TimesMap:
-  Enabled: false
-Performance/UnfreezeString:
-  Enabled: false
-Performance/UnneededSort:
-  Enabled: false
-Performance/UriDefaultParser:
-  Enabled: false
-Performance/ChainArrayAllocation:
-  Enabled: false
 Style/AccessModifierDeclarations:
   Enabled: false
 Style/Alias:
@@ -483,6 +451,8 @@ Style/CommentedKeyword:
   Enabled: false
 Style/ConditionalAssignment:
   Enabled: false
+Style/ConstantVisibility:
+  Enabled: false
 Style/Copyright:
   Enabled: false
 Style/DateTime:
@@ -523,7 +493,7 @@ Style/EvenOdd:
   Enabled: false
 Style/ExpandPathArguments:
   Enabled: false
-Style/FlipFlop:
+Style/FloatDivision:
   Enabled: false
 Style/For:
   Enabled: false
@@ -605,6 +575,8 @@ Style/MutableConstant:
   Enabled: false
 Style/NegatedIf:
   Enabled: false
+Style/NegatedUnless:
+  Enabled: false
 Style/NegatedWhile:
   Enabled: false
 Style/NestedModifier:
@@ -655,6 +627,8 @@ Style/RandomWithOffset:
   Enabled: false
 Style/RedundantBegin:
   Enabled: false
+Style/RedundantConditional:
+  Enabled: false
 Style/RedundantException:
   Enabled: false
 Style/RedundantFreeze:
@@ -665,7 +639,7 @@ Style/RedundantReturn:
   Enabled: false
 Style/RedundantSelf:
   Enabled: false
-Style/RedundantConditional:
+Style/RedundantSortBy:
   Enabled: false
 Style/RegexpLiteral:
   Enabled: false
@@ -677,6 +651,8 @@ Style/ReturnNil:
   Enabled: false
 Style/SafeNavigation:
   Enabled: false
+Style/Sample:
+  Enabled: false
 Style/SelfAssignment:
   Enabled: false
 Style/Semicolon:
@@ -703,6 +679,8 @@ Style/StringLiteralsInInterpolation:
   Enabled: false
 Style/StringMethods:
   Enabled: false
+Style/Strip:
+  Enabled: false
 Style/StructInheritance:
   Enabled: false
 Style/SymbolArray:
@@ -741,6 +719,8 @@ Style/UnneededInterpolation:
   Enabled: false
 Style/UnneededPercentQ:
   Enabled: false
+Style/UnneededSort:
+  Enabled: false
 Style/UnpackFirst:
   Enabled: false
 Style/VariableInterpolation:
@@ -757,98 +737,6 @@ Style/YodaCondition:
   Enabled: false
 Style/ZeroLengthPredicate:
   Enabled: false
-Rails/ActionFilter:
-  Enabled: false
-Rails/ActiveRecordAliases:
-  Enabled: false
-Rails/ActiveSupportAliases:
-  Enabled: false
-Rails/ApplicationJob:
-  Enabled: false
-Rails/ApplicationRecord:
-  Enabled: false
-Rails/AssertNot:
-  Enabled: false
-Rails/Blank:
-  Enabled: false
-Rails/BulkChangeTable:
-  Enabled: false
-Rails/CreateTableWithTimestamps:
-  Enabled: false
-Rails/Date:
-  Enabled: false
-Rails/Delegate:
-  Enabled: false
-Rails/DelegateAllowBlank:
-  Enabled: false
-Rails/DynamicFindBy:
-  Enabled: false
-Rails/EnumUniqueness:
-  Enabled: false
-Rails/EnvironmentComparison:
-  Enabled: false
-Rails/Exit:
-  Enabled: false
-Rails/FilePath:
-  Enabled: false
-Rails/FindBy:
-  Enabled: false
-Rails/FindEach:
-  Enabled: false
-Rails/HasAndBelongsToMany:
-  Enabled: false
-Rails/HasManyOrHasOneDependent:
-  Enabled: false
-Rails/HttpPositionalArguments:
-  Enabled: false
-Rails/HttpStatus:
-  Enabled: false
-Rails/InverseOf:
-  Enabled: false
-Rails/LexicallyScopedActionFilter:
-  Enabled: false
-Rails/LinkToBlank:
-  Enabled: false
-Rails/NotNullColumn:
-  Enabled: false
-Rails/Output:
-  Enabled: false
-Rails/OutputSafety:
-  Enabled: false
-Rails/PluralizationGrammar:
-  Enabled: false
-Rails/Presence:
-  Enabled: false
-Rails/Present:
-  Enabled: false
-Rails/ReadWriteAttribute:
-  Enabled: false
-Rails/RedundantReceiverInWithOptions:
-  Enabled: false
-Rails/RefuteMethods:
-  Enabled: false
-Rails/RelativeDateConstant:
-  Enabled: false
-Rails/RequestReferer:
-  Enabled: false
-Rails/ReversibleMigration:
-  Enabled: false
-Rails/SafeNavigation:
-  Enabled: false
-Rails/SaveBang:
-  Enabled: false
-Rails/ScopeArgs:
-  Enabled: false
-Rails/SkipsModelValidations:
-  Enabled: false
-Rails/TimeZone:
-  Enabled: false
-Rails/UniqBeforePluck:
-  Enabled: false
-Rails/UnknownEnv:
-  Enabled: false
-Rails/Validation:
-  Enabled: false
 Security/Eval:
   Enabled: false
 Security/JSONLoad: