chefstyle 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2e8be47fb2751cf9c274107ed36e406fa4f24bffdd380fbcb6c97733ce19c20c
-  data.tar.gz: a71cd612eaccaa2b15a921fb67b1211ada8ee2b3319c4dec1744bb23d6e00b39
+  metadata.gz: 360289d97b80eca841ffa20be478fcaad392ac2934e0dea20e17763c02c6fd23
+  data.tar.gz: 0ad54108181dfdd289e4f83897743c438ad5a5f884abb0ca9757124c251451fd
 SHA512:
-  metadata.gz: 56d9c71745581b7cc4fa21e83331acac6d645c732beb505b06de293af572fa4c23adc8f3c80dceb7296cb9f62fc694dd4986ccb8267ea18056cae4ccc97407a8
-  data.tar.gz: 62fc6f13eb08931b655589a5da5d9dad868048bae361d2cae175b43af1c4751ccb8f4360d32bb3219174011a8e1fd45b8c30f5b4472a119ed57ec5a1183d3e63
+  metadata.gz: f0ab9fa0cd190c03c0de27bcfd76f5f8887820c6212b406291491f6271c17b6b50034be1d0ef2fdbc47c95c55d198c5f5e40713fef8fdbb3cf9fa6d9c2d3805a
+  data.tar.gz: fbc840097a36d3f79af3fa57155c9c75f57a07bd5774a72b0d2ac973342d34c0c719c796b9040f4b31ca6206366689552eebe246901a46b35b6c21a46e8a8e9d

data/config/chefstyle.yml

@@ -269,6 +269,7 @@ Layout/AccessModifierIndentation:
   Enabled: true
 Layout/AlignHash:
   Enabled: true
+  EnforcedLastArgumentHashStyle: ignore_implicit
 Style/AndOr:
   Enabled: true
 Style/ArrayJoin:
@@ -285,6 +286,8 @@ Style/CharacterLiteral:
   Enabled: true
 Style/ClassMethods:
   Enabled: true
+Layout/ClosingHeredocIndentation:
+  Enabled: true
 Style/ColonMethodCall:
   Enabled: true
 Style/CommandLiteral:
@@ -293,6 +296,8 @@ Naming/ConstantName:
   Enabled: true
 Style/DefWithParentheses:
   Enabled: true
+Layout/DotPosition:
+  Enabled: True
 Style/EachForSimpleLoop:
   Enabled: true
 Layout/ElseAlignment:
@@ -320,12 +325,18 @@ Style/For:
   Enabled: true
 Style/FrozenStringLiteralComment:
   Enabled: true
+Style/HashSyntax:
+  Enabled: true
+Naming/HeredocDelimiterCase:
+  Enabled: true
 Style/IfUnlessModifierOfIfUnless:
   Enabled: true
 Style/IfWithSemicolon:
   Enabled: true
 Layout/IndentAssignment:
   Enabled: true
+Layout/IndentHeredoc:
+  Enabled: true
 Layout/IndentationConsistency:
   Enabled: true
 Layout/IndentationWidth:
@@ -336,6 +347,8 @@ Layout/InitialIndentation:
   Enabled: true
 Style/LambdaCall:
   Enabled: true
+Layout/LeadingCommentSpace:
+  Enabled: true
 Style/MethodDefParentheses:
   Enabled: true
 Layout/MultilineBlockLayout:
@@ -353,6 +366,8 @@ Layout/MultilineOperationIndentation:
   EnforcedStyle: indented
 Style/MultilineTernaryOperator:
   Enabled: true
+Style/MutableConstant:
+  Enabled: true
 Style/NegatedWhile:
   Enabled: true
 Style/NestedModifier:
@@ -395,6 +410,8 @@ Style/PercentLiteralDelimiters:
     '%x': '{}'
 Style/PercentQLiterals:
   Enabled: true
+Style/PreferredHashMethods:
+  Enabled: true
 Style/RedundantBegin:
   Enabled: true
 Style/RedundantException:
@@ -471,6 +488,9 @@ Layout/TrailingBlankLines:
   Enabled: true
 Style/TrailingCommaInArguments:
   Enabled: true
+Style/TrailingCommaInHashLiteral:
+  Enabled: true
+  EnforcedStyleForMultiline: comma
 # rubocop's default gets this completely backwards
 Style/TrailingCommaInLiteral:
   Enabled: true
@@ -481,6 +501,8 @@ Layout/TrailingWhitespace:
   Enabled: true
 Style/UnneededCapitalW:
   Enabled: true
+Style/UnneededInterpolation:
+  Enabled: false # buggy: https://github.com/rubocop-hq/rubocop/issues/6099
 #Style/UnneededPercentQ:  # would like to enable this one but its buggy as of 0.35.1
 #  Enabled: true
 Naming/VariableName:
@@ -522,6 +544,8 @@ Layout/SpaceInsideParens:
   Enabled: false
 Layout/SpaceInsidePercentLiteralDelimiters:
   Enabled: false
+Layout/SpaceInsideArrayLiteralBrackets:
+  Enabled: false
 
 # more whitespace cops that we allow since they can enhance readability
 Layout/EmptyLinesAroundBlockBody:
@@ -602,3 +626,21 @@ Style/GuardClause:
 # Let authors order gems however makes sense
 Bundler/OrderedGems:
   Enabled: false
+
+# Naming cops produce fairly pointless makework (e.g. EOF on HEREDOC's is
+# perfectly fine and understandable, using 'ip' as a parameter to a function
+# is also perfectly descriptive even though its only 2 characters...).
+Naming/HeredocDelimiterNaming:
+  Enabled: false
+Naming/PredicateName:
+  Enabled: false
+Naming/UncommunicativeMethodParamName:
+  Enabled: false
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
+Naming/VariableNumber:
+  Enabled: false
+
+# This breaks all kinds of specs in chef (i don't think it will ever quite work correctly)
+Style/BracesAroundHashParameters:
+  Enabled: false

data/lib/chefstyle/version.rb

@@ -1,4 +1,4 @@
 module Chefstyle
-  VERSION = "0.10.0".freeze
+  VERSION = "0.11.0".freeze
   RUBOCOP_VERSION = "0.55.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chefstyle
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Thom May
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-07 00:00:00.000000000 Z
+date: 2018-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,14 +28,14 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '12.0'
 - !ruby/object:Gem::Dependency
@@ -74,15 +74,9 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
-- ".travis.yml"
-- Gemfile
 - LICENSE.txt
 - README.md
-- Rakefile
 - bin/chefstyle
-- chefstyle.gemspec
 - config/chefstyle.yml
 - config/default.yml
 - config/disable_all.yml
@@ -111,7 +105,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Rubocop configuration for Chef's ruby projects

data/.gitignore

@@ -1,9 +0,0 @@
-/.bundle/
-/.yardoc
-/Gemfile.lock
-/_yardoc/
-/coverage/
-/doc/
-/pkg/
-/spec/reports/
-/tmp/

data/.rspec

@@ -1,2 +0,0 @@
---format documentation
---color

data/.travis.yml

@@ -1,15 +0,0 @@
-language: ruby
-cache: bundler
-
-sudo: false
-
-branches:
-  only:
-    - master
-    
-before_install: gem install bundler -v 1.10.6
-
-rvm:
-  - 2.2.6
-  - 2.3.3
-  - 2.4.0

data/Gemfile

@@ -1,4 +0,0 @@
-source 'https://rubygems.org'
-
-# Specify your gem's dependencies in chefstyle.gemspec
-gemspec

data/Rakefile

@@ -1,30 +0,0 @@
-require "bundler/gem_tasks"
-
-upstream = Gem::Specification.find_by_name("rubocop")
-
-desc "Vendor rubocop-#{upstream.version} configuration into gem"
-task :vendor do
-  src = Pathname.new(upstream.gem_dir).join("config")
-  dst = Pathname.new(__FILE__).dirname.join("config")
-
-  mkdir_p dst
-  cp(src.join("default.yml"), dst.join("upstream.yml"))
-  cp(src.join("enabled.yml"), dst.join("enabled.yml"))
-  cp(src.join("disabled.yml"), dst.join("disabled.yml"))
-
-  require 'rubocop'
-  require 'yaml'
-  cfg = RuboCop::Cop::Cop.all.inject({}) { |acc, cop| acc[cop.cop_name] = {"Enabled" => false}; acc }
-  File.open(dst.join("disable_all.yml"), "w"){|fh| fh.write cfg.to_yaml }
-
-  sh %{git add #{dst}/{upstream,enabled,disabled,disable_all}.yml}
-  sh %{git commit -m "Vendor rubocop-#{upstream.version} upstream configuration."}
-end
-
-require "chefstyle"
-require "rubocop/rake_task"
-RuboCop::RakeTask.new(:style) do |task|
-  task.options << "--display-cop-names"
-end
-
-task default: [:build, :install]

data/chefstyle.gemspec

@@ -1,25 +0,0 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'chefstyle/version'
-
-Gem::Specification.new do |spec|
-  spec.name          = "chefstyle"
-  spec.version       = Chefstyle::VERSION
-  spec.authors       = ["Thom May"]
-  spec.email         = ["thom@chef.io"]
-
-  spec.summary       = %q{Rubocop configuration for Chef's ruby projects}
-  spec.homepage      = "https://github.com/chef/chefstyle"
-  spec.license       = "Apache-2.0"
-  spec.required_ruby_version = ">= 2.2"
-
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.executables    = %w[chefstyle]
-  spec.require_paths = ["lib"]
-
-  spec.add_development_dependency "bundler", "~> 1.10"
-  spec.add_development_dependency "rake", "~> 12.0"
-  spec.add_development_dependency "rspec"
-  spec.add_dependency("rubocop", Chefstyle::RUBOCOP_VERSION)
-end