chef 16.4.35 → 16.6.14

data/spec/unit/shell/shell_session_spec.rb

@@ -18,32 +18,10 @@
 require "spec_helper"
 require "ostruct"
 
-class TestableShellSession < Shell::ShellSession
-
-  def rebuild_node
-    nil
-  end
-
-  def rebuild_collection
-    nil
-  end
-
-  def loading
-    nil
-  end
-
-  def loading_complete
-    nil
-  end
-
-end
-
 describe Shell::ShellSession do
-
   it "is a singleton object" do
     expect(Shell::ShellSession).to include(Singleton)
   end
-
 end
 
 describe Shell::ClientSession do
@@ -120,20 +98,10 @@ end
 
 describe Shell::StandAloneSession do
   let(:json_attribs) { { "a" => "b" } }
-  let(:chef_rest) { double("Chef::ServerAPI") }
   let(:node) { Chef::Node.new }
-  let(:events) { Chef::EventDispatch::Dispatcher.new }
   let(:session) { Shell::StandAloneSession.instance }
-  let(:client) do
-    double("Chef::Client.new",
-      run_ohai: true,
-      load_node: true,
-      build_node: true,
-      register: true,
-      sync_cookbooks: {})
-  end
   let(:recipe) { Chef::Recipe.new(nil, nil, run_context) }
-  let(:run_context) { Chef::RunContext.new(node, {}, events) }
+  let(:run_context) { Chef::RunContext.new(node, {}, Chef::EventDispatch::Dispatcher.new) }
 
   before do
     Chef::Config[:shell_config] = { override_runlist: [Chef::RunList::RunListItem.new("shell::override")] }
@@ -172,6 +140,12 @@ describe Shell::StandAloneSession do
   end
 
   it "passes the shell CLI args to the client" do
+    client = double("Chef::Client.new",
+      run_ohai: true,
+      load_node: true,
+      build_node: true,
+      register: true,
+      sync_cookbooks: {})
     expect(Chef::Client).to receive(:new).with(json_attribs, Chef::Config[:shell_config]).and_return(client)
     session.send(:rebuild_node)
   end
@@ -180,68 +154,65 @@ end
 
 describe Shell::SoloLegacySession do
   let(:json_attribs) { { "a" => "b" } }
+  let(:node) { Chef::Node.new }
+  let(:session) { Shell::SoloLegacySession.instance }
+  let(:recipe) { Chef::Recipe.new(nil, nil, run_context) }
+  let(:run_context) { Chef::RunContext.new(node, {}, Chef::EventDispatch::Dispatcher.new) }
 
   before do
     Chef::Config[:shell_config] = { override_runlist: [Chef::RunList::RunListItem.new("shell::override")] }
-    Chef::Config[:shell_solo] = true
-    @session = Shell::SoloLegacySession.instance
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = @session.run_context = Chef::RunContext.new(@node, {}, @events)
-    @session.node = @node
-    @recipe = @session.recipe = Chef::Recipe.new(nil, nil, @run_context)
-    Shell::Extensions.extend_context_recipe(@recipe)
-  end
-
-  after do
-    Chef::Config[:shell_solo] = nil
+    Chef::Config[:solo_legacy_shell] = true
+    session.node = node
+    session.json_configuration = json_attribs
+    session.run_context = run_context
+    session.recipe = recipe
+    Shell::Extensions.extend_context_recipe(recipe)
   end
 
   it "returns a collection based on it's compilation object and the extra recipe provided by chef-shell" do
-    allow(@session).to receive(:node_built?).and_return(true)
+    allow(session).to receive(:node_built?).and_return(true)
     kitteh = Chef::Resource::Cat.new("keyboard")
-    @recipe.run_context.resource_collection << kitteh
-    expect(@session.resource_collection.include?(kitteh)).to be true
+    recipe.run_context.resource_collection << kitteh
+    expect(session.resource_collection.include?(kitteh)).to be true
   end
 
   it "returns definitions from its compilation object" do
-    expect(@session.definitions).to eq(@run_context.definitions)
+    expect(session.definitions).to eq(run_context.definitions)
   end
 
   it "keeps json attribs and passes them to the node for consumption" do
-    @session.node_attributes = { "besnard_lakes" => "are_the_dark_horse" }
-    expect(@session.node["besnard_lakes"]).to eq("are_the_dark_horse")
+    session.node_attributes = { "besnard_lakes" => "are_the_dark_horse" }
+    expect(session.node["besnard_lakes"]).to eq("are_the_dark_horse")
     # pending "1) keep attribs in an ivar 2) pass them to the node 3) feed them to the node on reset"
   end
 
   it "generates its resource collection from the compiled cookbooks and the ad hoc recipe" do
-    allow(@session).to receive(:node_built?).and_return(true)
+    allow(session).to receive(:node_built?).and_return(true)
     kitteh_cat = Chef::Resource::Cat.new("kitteh")
-    @run_context.resource_collection << kitteh_cat
+    run_context.resource_collection << kitteh_cat
     keyboard_cat = Chef::Resource::Cat.new("keyboard_cat")
-    @recipe.run_context.resource_collection << keyboard_cat
-    # @session.rebuild_collection
-    expect(@session.resource_collection.include?(kitteh_cat)).to be true
-    expect(@session.resource_collection.include?(keyboard_cat)).to be true
+    recipe.run_context.resource_collection << keyboard_cat
+    # session.rebuild_collection
+    expect(session.resource_collection.include?(kitteh_cat)).to be true
+    expect(session.resource_collection.include?(keyboard_cat)).to be true
   end
 
   it "runs chef with a resource collection from the compiled cookbooks" do
-    allow(@session).to receive(:node_built?).and_return(true)
+    allow(session).to receive(:node_built?).and_return(true)
     chef_runner = double("Chef::Runner.new", converge: :converged)
-    expect(Chef::Runner).to receive(:new).with(an_instance_of(Chef::RunContext)).and_return(chef_runner)
+    expect(Chef::Runner).to receive(:new).with(session.recipe.run_context).and_return(chef_runner)
 
-    expect(@recipe.run_chef).to eq(:converged)
+    expect(recipe.run_chef).to eq(:converged)
   end
 
   it "passes the shell CLI args to the client" do
-    @client = double("Chef::Client.new",
+    client = double("Chef::Client.new",
       run_ohai: true,
       load_node: true,
       build_node: true,
       register: true,
       sync_cookbooks: {})
-    expect(Chef::Client).to receive(:new).with(json_attribs, Chef::Config[:shell_config]).and_return(@client)
-    @session.json_configuration = json_attribs
-    @session.send(:rebuild_node)
+    expect(Chef::Client).to receive(:new).with(json_attribs, Chef::Config[:shell_config]).and_return(client)
+    session.send(:rebuild_node)
   end
 end

data/spec/unit/shell_spec.rb

@@ -18,26 +18,23 @@
 require "spec_helper"
 require "ostruct"
 
-ObjectTestHarness = Proc.new do
-  extend Shell::Extensions::ObjectCoreExtensions
-
-  def conf=(new_conf)
-    @conf = new_conf
-  end
-
-  def conf
-    @conf
-  end
+describe Shell do
+  let(:object_test_harness) do
+    Proc.new do
+      extend Shell::Extensions::ObjectCoreExtensions
 
-  desc "rspecin'"
-  def rspec_method; end
-end
+      def conf=(new_conf)
+        @conf = new_conf
+      end
 
-class TestJobManager
-  attr_accessor :jobs
-end
+      def conf
+        @conf
+      end
 
-describe Shell do
+      desc "rspecin'"
+      def rspec_method; end
+    end
+  end
 
   before do
     Shell.irb_conf = {}
@@ -66,7 +63,7 @@ describe Shell do
 
       conf = OpenStruct.new
       conf.main = Object.new
-      conf.main.instance_eval(&ObjectTestHarness)
+      conf.main.instance_eval(&object_test_harness)
       Shell.irb_conf[:IRB_RC].call(conf)
       expect(conf.prompt_c).to      eq("chef > ")
       expect(conf.return_format).to eq(" => %s \n")
@@ -107,7 +104,7 @@ describe Shell do
 
     before do
       @chef_object = Object.new
-      @chef_object.instance_eval(&ObjectTestHarness)
+      @chef_object.instance_eval(&object_test_harness)
     end
 
     it "creates help text for methods with descriptions" do

data/spec/unit/train_transport_spec.rb

@@ -19,32 +19,33 @@
 require "spec_helper"
 
 describe Chef::TrainTransport do
+  let(:transport) { Chef::TrainTransport.new(Chef::Log) }
+
   describe "load_credentials" do
-    let(:transport) { Chef::TrainTransport.new }
     let(:good_credentials) { { "switch.cisco.com" => { "user" => "cisco", "password" => "cisco", "enable_password" => "secret" } } }
 
     before do
-      allow(Chef::TrainTransport).to receive(:parse_credentials_file).and_return(good_credentials)
+      allow(transport).to receive(:parse_credentials_file).and_return(good_credentials)
     end
 
     it "matches credentials when they exist" do
-      expect(Chef::TrainTransport.load_credentials("switch.cisco.com")[:user]).to eq("cisco")
-      expect(Chef::TrainTransport.load_credentials("switch.cisco.com")[:password]).to eq("cisco")
-      expect(Chef::TrainTransport.load_credentials("switch.cisco.com")[:enable_password]).to eq("secret")
+      expect(transport.load_credentials("switch.cisco.com")[:user]).to eq("cisco")
+      expect(transport.load_credentials("switch.cisco.com")[:password]).to eq("cisco")
+      expect(transport.load_credentials("switch.cisco.com")[:enable_password]).to eq("secret")
     end
 
     it "returns nil if there is no match" do
-      expect(Chef::TrainTransport.load_credentials("router.unicorns.com")).to be_nil
+      expect(transport.load_credentials("router.unicorns.com")).to be_nil
     end
 
     # [foo.example.org]   => {"foo"=>{"example"=>{"org"=>{}}}}
     # ['foo.example.org'] => {"foo.example.org"=>{}}
     it "warns if the host has been split by toml" do
-      allow(Chef::TrainTransport).to receive(:credentials_file_path).and_return("/Users/scotthourglass/.chef/credentials")
-      allow(Chef::TrainTransport).to receive(:parse_credentials_file).and_return({ "foo" => { "example" => { "org" => {} } } })
+      allow(transport).to receive(:credentials_file_path).and_return("/Users/scotthourglass/.chef/credentials")
+      allow(transport).to receive(:parse_credentials_file).and_return({ "foo" => { "example" => { "org" => {} } } })
       expect(Chef::Log).to receive(:warn).with(/as a Hash/)
       expect(Chef::Log).to receive(:warn).with(/Hostnames must be surrounded by single quotes/)
-      expect(Chef::TrainTransport.load_credentials("foo.example.org")).to be_nil
+      expect(transport.load_credentials("foo.example.org")).to be_nil
     end
   end
 
@@ -60,25 +61,25 @@ describe Chef::TrainTransport do
 
       it "returns the path if it exists" do
         allow(File).to receive(:exist?).with(config_cred_file_path).and_return(true)
-        expect(Chef::TrainTransport.credentials_file_path).to eq(config_cred_file_path)
+        expect(transport.credentials_file_path).to eq(config_cred_file_path)
       end
 
       it "raises an error if it does not exist" do
         allow(File).to receive(:exist?).and_return(false)
-        expect { Chef::TrainTransport.credentials_file_path }.to raise_error(ArgumentError, /does not exist/)
+        expect { transport.credentials_file_path }.to raise_error(ArgumentError, /does not exist/)
       end
     end
 
     it "raises an error if the default creds files do not exist" do
       allow(File).to receive(:exist?).and_return(false)
-      expect { Chef::TrainTransport.credentials_file_path }.to raise_error(ArgumentError, /does not exist/)
+      expect { transport.credentials_file_path }.to raise_error(ArgumentError, /does not exist/)
     end
 
     it "returns the path to the default config file if it exists" do
       tm_config = double("Config Context", host: "foo.example.org", credentials_file: nil)
       allow(Chef::Config).to receive(:target_mode).and_return(tm_config)
       allow(File).to receive(:exist?).with(host_cred_file_path).and_return(true)
-      expect(Chef::TrainTransport.credentials_file_path).to eq(host_cred_file_path)
+      expect(transport.credentials_file_path).to eq(host_cred_file_path)
     end
   end
 end

data/spec/unit/util/selinux_spec.rb

@@ -31,6 +31,8 @@ describe Chef::Util::Selinux do
 
   before do
     allow(ChefUtils).to receive(:windows?).and_return(false)
+    allow(ENV).to receive(:[]).with("PATHEXT").and_return(nil)
+    allow(ENV).to receive(:[]).with("PATH").and_call_original
     TestClass.reset_state
     @test_instance = TestClass.new
   end

data/tasks/rspec.rb

@@ -20,8 +20,6 @@
 require "rubygems"
 require "rake"
 
-CHEF_ROOT = File.join(File.dirname(__FILE__), "..")
-
 begin
   require "rspec/core/rake_task"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chef
 version: !ruby/object:Gem::Version
-  version: 16.4.35
+  version: 16.6.14
 platform: ruby
 authors:
 - Adam Jacob
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-18 00:00:00.000000000 Z
+date: 2020-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chef-config
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 16.4.35
+        version: 16.6.14
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 16.4.35
+        version: 16.6.14
 - !ruby/object:Gem::Dependency
   name: chef-utils
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 16.4.35
+        version: 16.6.14
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 16.4.35
+        version: 16.6.14
 - !ruby/object:Gem::Dependency
   name: train-core
   requirement: !ruby/object:Gem::Requirement
@@ -76,22 +76,22 @@ dependencies:
   name: license-acceptance
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.5
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.5
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: mixlib-cli
   requirement: !ruby/object:Gem::Requirement
@@ -370,6 +370,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.6'
+- !ruby/object:Gem::Dependency
+  name: tty-table
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.11'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.11'
 - !ruby/object:Gem::Dependency
   name: pastel
   requirement: !ruby/object:Gem::Requirement
@@ -740,7 +754,6 @@ files:
 - lib/chef/deprecated.rb
 - lib/chef/deprecation/warnings.rb
 - lib/chef/digester.rb
-- lib/chef/dist.rb
 - lib/chef/dsl.rb
 - lib/chef/dsl/chef_vault.rb
 - lib/chef/dsl/cheffish.rb
@@ -854,7 +867,10 @@ files:
 - lib/chef/knife/client_show.rb
 - lib/chef/knife/config_get.rb
 - lib/chef/knife/config_get_profile.rb
+- lib/chef/knife/config_list.rb
 - lib/chef/knife/config_list_profiles.rb
+- lib/chef/knife/config_show.rb
+- lib/chef/knife/config_use.rb
 - lib/chef/knife/config_use_profile.rb
 - lib/chef/knife/configure.rb
 - lib/chef/knife/configure_client.rb
@@ -1096,6 +1112,7 @@ files:
 - lib/chef/provider/lwrp_base.rb
 - lib/chef/provider/mount.rb
 - lib/chef/provider/mount/aix.rb
+- lib/chef/provider/mount/linux.rb
 - lib/chef/provider/mount/mount.rb
 - lib/chef/provider/mount/solaris.rb
 - lib/chef/provider/mount/windows.rb
@@ -1207,6 +1224,7 @@ files:
 - lib/chef/provider/zypper_repository.rb
 - lib/chef/provider_resolver.rb
 - lib/chef/providers.rb
+- lib/chef/pwsh.rb
 - lib/chef/recipe.rb
 - lib/chef/request_id.rb
 - lib/chef/reserved_names.rb
@@ -1224,9 +1242,12 @@ files:
 - lib/chef/resource/breakpoint.rb
 - lib/chef/resource/build_essential.rb
 - lib/chef/resource/cab_package.rb
+- lib/chef/resource/chef_client_config.rb
 - lib/chef/resource/chef_client_cron.rb
+- lib/chef/resource/chef_client_launchd.rb
 - lib/chef/resource/chef_client_scheduled_task.rb
 - lib/chef/resource/chef_client_systemd_timer.rb
+- lib/chef/resource/chef_client_trusted_certificate.rb
 - lib/chef/resource/chef_gem.rb
 - lib/chef/resource/chef_handler.rb
 - lib/chef/resource/chef_sleep.rb
@@ -1325,6 +1346,7 @@ files:
 - lib/chef/resource/solaris_package.rb
 - lib/chef/resource/ssh_known_hosts_entry.rb
 - lib/chef/resource/sudo.rb
+- lib/chef/resource/support/client.erb
 - lib/chef/resource/support/cron.d.erb
 - lib/chef/resource/support/cron_access.erb
 - lib/chef/resource/support/ssh_known_hosts.erb
@@ -1994,10 +2016,9 @@ files:
 - spec/integration/knife/client_list_spec.rb
 - spec/integration/knife/client_show_spec.rb
 - spec/integration/knife/common_options_spec.rb
-- spec/integration/knife/config_get_profile_spec.rb
-- spec/integration/knife/config_get_spec.rb
-- spec/integration/knife/config_list_profiles_spec.rb
-- spec/integration/knife/config_use_profile_spec.rb
+- spec/integration/knife/config_list_spec.rb
+- spec/integration/knife/config_show_spec.rb
+- spec/integration/knife/config_use_spec.rb
 - spec/integration/knife/cookbook_api_ipv6_spec.rb
 - spec/integration/knife/cookbook_bulk_delete_spec.rb
 - spec/integration/knife/cookbook_download_spec.rb
@@ -2043,6 +2064,7 @@ files:
 - spec/integration/knife/serve_spec.rb
 - spec/integration/knife/show_spec.rb
 - spec/integration/knife/upload_spec.rb
+- spec/integration/ohai/ohai_spec.rb
 - spec/integration/recipes/accumulator_spec.rb
 - spec/integration/recipes/lwrp_inline_resources_spec.rb
 - spec/integration/recipes/lwrp_spec.rb
@@ -2166,6 +2188,7 @@ files:
 - spec/unit/daemon_spec.rb
 - spec/unit/data_bag_item_spec.rb
 - spec/unit/data_bag_spec.rb
+- spec/unit/data_collector/config_validation_spec.rb
 - spec/unit/data_collector_spec.rb
 - spec/unit/decorator/lazy_array_spec.rb
 - spec/unit/decorator/lazy_spec.rb
@@ -2397,6 +2420,7 @@ files:
 - spec/unit/provider/log_spec.rb
 - spec/unit/provider/mdadm_spec.rb
 - spec/unit/provider/mount/aix_spec.rb
+- spec/unit/provider/mount/linux_spec.rb
 - spec/unit/provider/mount/mount_spec.rb
 - spec/unit/provider/mount/solaris_spec.rb
 - spec/unit/provider/mount/windows_spec.rb
@@ -2499,9 +2523,12 @@ files:
 - spec/unit/resource/breakpoint_spec.rb
 - spec/unit/resource/build_essential_spec.rb
 - spec/unit/resource/cab_package_spec.rb
+- spec/unit/resource/chef_client_config_spec.rb
 - spec/unit/resource/chef_client_cron_spec.rb
+- spec/unit/resource/chef_client_launchd_spec.rb
 - spec/unit/resource/chef_client_scheduled_task_spec.rb
 - spec/unit/resource/chef_client_systemd_timer_spec.rb
+- spec/unit/resource/chef_client_trusted_certificate_spec.rb
 - spec/unit/resource/chef_gem_spec.rb
 - spec/unit/resource/chef_handler_spec.rb
 - spec/unit/resource/chef_sleep_spec.rb
@@ -2633,6 +2660,7 @@ files:
 - spec/unit/resource/windows_shortcut_spec.rb
 - spec/unit/resource/windows_task_spec.rb
 - spec/unit/resource/windows_uac_spec.rb
+- spec/unit/resource/windows_user_privilege_spec.rb
 - spec/unit/resource/windows_workgroup_spec.rb
 - spec/unit/resource/yum_package_spec.rb
 - spec/unit/resource/yum_repository_spec.rb
@@ -2713,7 +2741,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: A systems integration framework, built to bring the benefits of configuration