chef-provisioning-vsphere 2.0.7 → 2.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 03c5998bc43727c00125d14f4606ac01a3ee0f20
-  data.tar.gz: adeb79939b6432484539b9356f131945f3796134
+  metadata.gz: 9ac457d36ea3bae1eefdf3dcaba502d925840270
+  data.tar.gz: 76a60e37d9861883bc4932074c9f6d80034c2245
 SHA512:
-  metadata.gz: 29c3144c3b2456590b965b3de6e6f240170bfa5513d4862f2262ecbf6e7b1d544290e6a6edec657e4835b8fe1bd08ab80dea249c745c804a63c30b904ce30019
-  data.tar.gz: 8b9956c30bbd487e8649c1a0b76db0b3ae577f7558d9d8ff73313e7c6c93bb70eed88f90a881bc3f899b390c2566e00f4ddac745846735976bb472db10754d89
+  metadata.gz: 7996f02f1e180e2375fb790c06a961b8abcd32850085b31adc56e3b7feb12fbc5f6805199112443d143e2404c19c625f133a29922f48afc36d00245aa27bba31
+  data.tar.gz: 4e805e07531c27d64143917c094d3037b2e25aa2047ace08b2c2bf2eab8e78529cfc656bce0db161de72ac06d35e8510a14f67015b6ec2817806112be79754ad

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-04-20 16:38:44 -0500 using RuboCop version 0.47.1.
+# on 2017-10-20 14:57:28 -0700 using RuboCop version 0.49.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -12,14 +12,13 @@ Lint/AssignmentInCondition:
   Exclude:
     - 'lib/chef/provisioning/vsphere_driver/vsphere_helpers.rb'
 
-# Offense count: 2
+# Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleAlignWith, SupportedStylesAlignWith, AutoCorrect.
 # SupportedStylesAlignWith: start_of_line, def
 Lint/DefEndAlignment:
   Exclude:
     - 'lib/chef/provisioning/vsphere_driver/driver.rb'
-    - 'lib/chef/provisioning/vsphere_driver/vsphere_helpers.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
@@ -29,21 +28,21 @@ Lint/EndAlignment:
   Exclude:
     - 'lib/chef/provisioning/vsphere_driver/driver.rb'
 
-# Offense count: 4
+# Offense count: 6
 Lint/UselessAssignment:
   Exclude:
     - 'lib/chef/provisioning/vsphere_driver/clone_spec_builder.rb'
     - 'lib/chef/provisioning/vsphere_driver/vsphere_helpers.rb'
     - 'lib/kitchen/driver/vsphere.rb'
 
-# Offense count: 31
+# Offense count: 34
 Metrics/AbcSize:
   Max: 47
 
 # Offense count: 1
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 27
+  Max: 29
 
 # Offense count: 1
 # Configuration parameters: CountBlocks.
@@ -53,24 +52,24 @@ Metrics/BlockNesting:
 # Offense count: 3
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 650
+  Max: 627
 
-# Offense count: 7
+# Offense count: 11
 Metrics/CyclomaticComplexity:
   Max: 12
 
-# Offense count: 89
+# Offense count: 138
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
   Max: 189
 
-# Offense count: 40
+# Offense count: 41
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 62
 
-# Offense count: 5
+# Offense count: 8
 Metrics/PerceivedComplexity:
   Max: 14
 
@@ -84,24 +83,13 @@ Style/ClassVars:
   Exclude:
     - 'lib/kitchen/driver/vsphere.rb'
 
-# Offense count: 6
-Style/Documentation:
-  Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
-    - 'lib/chef/provisioning/vsphere_driver.rb'
-    - 'lib/chef/provisioning/vsphere_driver/clone_spec_builder.rb'
-    - 'lib/chef/provisioning/vsphere_driver/vsphere_helpers.rb'
-    - 'lib/chef/provisioning/vsphere_driver/vsphere_url.rb'
-    - 'lib/kitchen/driver/vsphere.rb'
-
 # Offense count: 5
 # Configuration parameters: AllowedVariables.
 Style/GlobalVars:
   Exclude:
     - 'lib/chef/provisioning/vsphere_driver/vsphere_helpers.rb'
 
-# Offense count: 12
+# Offense count: 13
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Exclude:
@@ -119,7 +107,7 @@ Style/NestedTernaryOperator:
   Exclude:
     - 'lib/chef/provisioning/vsphere_driver/driver.rb'
 
-# Offense count: 5
+# Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
 # SupportedStyles: predicate, comparison
@@ -127,7 +115,6 @@ Style/NumericPredicate:
   Exclude:
     - 'spec/**/*'
     - 'lib/chef/provisioning/vsphere_driver/driver.rb'
-    - 'lib/chef/provisioning/vsphere_driver/vsphere_helpers.rb'
 
 # Offense count: 3
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.

data/CHANGELOG.md

@@ -1,7 +1,18 @@
 # Change Log
 
-## [2.0.7](https://github.com/chef-partners/chef-provisioning-vsphere/tree/2.0.7) (2017-10-19)
-[Full Changelog](https://github.com/chef-partners/chef-provisioning-vsphere/compare/v2.0.6...2.0.7)
+## [2.0.8](https://github.com/chef-partners/chef-provisioning-vsphere/tree/2.0.8) (2017-10-23)
+[Full Changelog](https://github.com/chef-partners/chef-provisioning-vsphere/compare/v2.0.7...2.0.8)
+
+**Closed issues:**
+
+- Action :destroy fails on powered off VM [\#59](https://github.com/chef-partners/chef-provisioning-vsphere/issues/59)
+
+**Merged pull requests:**
+
+- rubocop -a && rubocop  --auto-gen-config [\#61](https://github.com/chef-partners/chef-provisioning-vsphere/pull/61) ([bemehiser](https://github.com/bemehiser))
+
+## [v2.0.7](https://github.com/chef-partners/chef-provisioning-vsphere/tree/v2.0.7) (2017-10-19)
+[Full Changelog](https://github.com/chef-partners/chef-provisioning-vsphere/compare/v2.0.6...v2.0.7)
 
 **Closed issues:**
 

data/Gemfile

@@ -1,4 +1,5 @@
 # -*- encoding: utf-8 -*-
 # frozen_string_literal: true
-source "https://rubygems.org"
+
+source 'https://rubygems.org'
 gemspec

data/Rakefile

@@ -1,40 +1,41 @@
 # frozen_string_literal: true
-require "bundler/gem_tasks"
-require "chef/provisioning/vsphere_driver/version"
-require "rspec/core/rake_task"
-require "rubocop/rake_task"
-require "yard"
 
-$LOAD_PATH.unshift(File.dirname(__FILE__) + "/lib")
+require 'bundler/gem_tasks'
+require 'chef/provisioning/vsphere_driver/version'
+require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
+require 'yard'
+
+$LOAD_PATH.unshift(File.dirname(__FILE__) + '/lib')
 
 RuboCop::RakeTask.new(:style) do |task|
-  task.options << "--display-cop-names"
+  task.options << '--display-cop-names'
 end
 
 RSpec::Core::RakeTask.new(:unit) do |task|
-  task.pattern = "spec/unit_tests/*_spec.rb"
-  task.rspec_opts = ["--color", "-f documentation"]
+  task.pattern = 'spec/unit_tests/*_spec.rb'
+  task.rspec_opts = ['--color', '-f documentation']
 end
 
 RSpec::Core::RakeTask.new(:integration) do |task|
-  task.pattern = "spec/integration_tests/*_spec.rb"
-  task.rspec_opts = ["--color", "-f documentation", "--out rspec.txt"]
+  task.pattern = 'spec/integration_tests/*_spec.rb'
+  task.rspec_opts = ['--color', '-f documentation', '--out rspec.txt']
 end
 
 begin
-  require "github_changelog_generator/task"
+  require 'github_changelog_generator/task'
 
   GitHubChangelogGenerator::RakeTask.new :changelog do |config|
     config.future_release = ChefProvisioningVsphere::VERSION
     config.issues = true
   end
 rescue LoadError
-  puts "github_changelog_generator is not available. gem install github_changelog_generator to generate changelogs"
+  puts 'github_changelog_generator is not available. gem install github_changelog_generator to generate changelogs'
 end
 
 YARD::Rake::YardocTask.new do |t|
-  t.files = ["lib/**/*.rb"] # optional
-  t.stats_options = ["--list-undoc"] # optional
+  t.files = ['lib/**/*.rb'] # optional
+  t.stats_options = ['--list-undoc'] # optional
 end
 
-task default: [:style, :unit]
+task default: %i[style unit]

data/chef-provisioning-vsphere.gemspec

@@ -1,37 +1,39 @@
 # frozen_string_literal: true
-$LOAD_PATH.unshift(File.dirname(__FILE__) + "/lib")
-require "chef/provisioning/vsphere_driver/version"
 
+$LOAD_PATH.unshift(File.dirname(__FILE__) + '/lib')
+require 'chef/provisioning/vsphere_driver/version'
+
+# rubocop Metrics/ModuleLength
 Gem::Specification.new do |s|
-  s.name = "chef-provisioning-vsphere"
+  s.name = 'chef-provisioning-vsphere'
   s.version = ChefProvisioningVsphere::VERSION
   s.platform = Gem::Platform::RUBY
-  s.extra_rdoc_files = ["README.md"]
-  s.summary = "Provisioner for creating vSphere VM instances in Chef Provisioning."
+  s.extra_rdoc_files = ['README.md']
+  s.summary = 'Provisioner for creating vSphere VM instances in Chef Provisioning.'
   s.description = s.summary
-  s.authors = ["CenturyLink Cloud", "JJ Asghar"]
-  s.email = "jj@chef.io"
-  s.homepage = "https://github.com/chef-partners/chef-provisioning-vsphere"
-  s.license = "MIT"
-  s.bindir       = "bin"
-  s.executables  = %w{}
-  s.require_path = "lib"
+  s.authors = ['CenturyLink Cloud', 'JJ Asghar']
+  s.email = 'jj@chef.io'
+  s.homepage = 'https://github.com/chef-partners/chef-provisioning-vsphere'
+  s.license = 'MIT'
+  s.bindir       = 'bin'
+  s.executables  = %w[]
+  s.require_path = 'lib'
   s.files        = `git ls-files -z`.split("\x0")
   s.test_files   = s.files.grep(%r{^(test|spec|features)/})
 
-  s.add_dependency "chef", ">= 12.0", "< 14.0"
-  s.add_dependency "chef-provisioning", "~> 2.0"
-  s.add_dependency "cheffish", ">= 4.0", "< 14.0"
-  s.add_dependency "rbvmomi", "~> 1.10"
+  s.add_dependency 'chef', '>= 12.0', '< 14.0'
+  s.add_dependency 'chef-provisioning', '~> 2.0'
+  s.add_dependency 'cheffish', '>= 4.0', '< 14.0'
+  s.add_dependency 'rbvmomi', '~> 1.10'
 
-  s.add_development_dependency "chefstyle"
-  s.add_development_dependency "github_changelog_generator"
-  s.add_development_dependency "pry"
-  s.add_development_dependency "pry-byebug"
-  s.add_development_dependency "pry-stack_explorer"
-  s.add_development_dependency "rake"
-  s.add_development_dependency "rb-readline"
-  s.add_development_dependency "rspec"
-  s.add_development_dependency "simplecov"
-  s.add_development_dependency "yard"
+  s.add_development_dependency 'chefstyle'
+  s.add_development_dependency 'github_changelog_generator'
+  s.add_development_dependency 'pry'
+  s.add_development_dependency 'pry-byebug'
+  s.add_development_dependency 'pry-stack_explorer'
+  s.add_development_dependency 'rake'
+  s.add_development_dependency 'rb-readline'
+  s.add_development_dependency 'rspec'
+  s.add_development_dependency 'simplecov'
+  s.add_development_dependency 'yard'
 end

data/lib/chef/provisioning/driver_init/vsphere.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
-require "chef/provisioning/vsphere_driver"
 
-Chef::Provisioning.register_driver_class("vsphere", ChefProvisioningVsphere::VsphereDriver)
+require 'chef/provisioning/vsphere_driver'
+
+Chef::Provisioning.register_driver_class('vsphere', ChefProvisioningVsphere::VsphereDriver)

data/lib/chef/provisioning/vsphere_driver.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
-require "chef/provisioning"
-require "chef/provisioning/vsphere_driver/driver"
+
+require 'chef/provisioning'
+require 'chef/provisioning/vsphere_driver/driver'
 
 # The main Chef class for all the Chef code!
 class Chef

data/lib/chef/provisioning/vsphere_driver/clone_spec_builder.rb

@@ -78,12 +78,12 @@ module ChefProvisioningVsphere
       elsif vm_template.config.template && !host.nil?
         rspec.pool = host.parent.resourcePool # assign to the "invisible" pool root
       elsif vm_template.config.template
-        raise "either :host or :resource_pool must be specified when cloning from a VM Template"
+        raise 'either :host or :resource_pool must be specified when cloning from a VM Template'
       end
 
       if options[:use_linked_clone]
         if vm_template.config.template
-          Chef::Log.warn("Using a VM Template, ignoring use_linked_clone.")
+          Chef::Log.warn('Using a VM Template, ignoring use_linked_clone.')
         else
           vsphere_helper.create_delta_disk(vm_template)
           rspec.diskMoveType = :moveChildMostDiskBacking
@@ -105,16 +105,16 @@ module ChefProvisioningVsphere
     def customization_options_from(vm_template, vm_name, options)
       if options.key?(:customization_spec)
         if options[:customization_spec].is_a?(Hash) ||
-            options[:customization_spec].is_a?(Cheffish::MergedConfig)
+           options[:customization_spec].is_a?(Cheffish::MergedConfig)
           cust_options = options[:customization_spec]
           ip_settings = cust_options[:ipsettings]
           cust_domain = cust_options[:domain]
 
-          raise ArgumentError, "domain is required" unless cust_domain
+          raise ArgumentError, 'domain is required' unless cust_domain
           cust_ip_settings = nil
           if ip_settings && ip_settings.key?(:ip)
             unless cust_options[:ipsettings].key?(:subnetMask)
-              raise ArgumentError, "subnetMask is required for static ip"
+              raise ArgumentError, 'subnetMask is required for static ip'
             end
             cust_ip_settings = RbVmomi::VIM::CustomizationIPSettings.new(
               ip_settings
@@ -145,7 +145,7 @@ module ChefProvisioningVsphere
           cust_hwclockutc = cust_options[:hw_clock_utc]
           cust_timezone = cust_options[:time_zone]
 
-          cust_prep = if vm_template.config.guestId.start_with?("win")
+          cust_prep = if vm_template.config.guestId.start_with?('win')
                         windows_prep_for(options, vm_name)
                       else
                         RbVmomi::VIM::CustomizationLinuxPrep.new(
@@ -158,7 +158,7 @@ module ChefProvisioningVsphere
           cust_adapter_mapping = [
             RbVmomi::VIM::CustomizationAdapterMapping.new(
               adapter: cust_ip_settings
-            ),
+            )
           ]
           RbVmomi::VIM::CustomizationSpec.new(
             identity: cust_prep,
@@ -179,7 +179,7 @@ module ChefProvisioningVsphere
       hostname = options[:hostname] || vm_name
       test = /^([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]*[a-zA-Z0-9])$/
       unless hostname =~ test
-        raise "Only letters, numbers or hyphens in hostnames allowed"
+        raise 'Only letters, numbers or hyphens in hostnames allowed'
       end
       RbVmomi::VIM::CustomizationFixedName.new(name: hostname)
     end
@@ -200,10 +200,10 @@ module ChefProvisioningVsphere
         plainText: true,
         value: options[:ssh][:password]
       )
-      if cust_options.key?(:domain) && (cust_options[:domain] != "local")
+      if cust_options.key?(:domain) && (cust_options[:domain] != 'local')
         cust_domain_password = RbVmomi::VIM::CustomizationPassword(
           plainText: true,
-          value: ENV["domainAdminPassword"] || cust_options[:domainAdminPassword]
+          value: ENV['domainAdminPassword'] || cust_options[:domainAdminPassword]
         )
         cust_id = RbVmomi::VIM::CustomizationIdentification.new(
           joinDomain: cust_options[:domain],
@@ -214,7 +214,7 @@ module ChefProvisioningVsphere
           with user: #{cust_options[:domainAdmin]}"
       else
         cust_id = RbVmomi::VIM::CustomizationIdentification.new(
-          joinWorkgroup: "WORKGROUP"
+          joinWorkgroup: 'WORKGROUP'
         )
       end
       cust_gui_unattended = RbVmomi::VIM::CustomizationGuiUnattended.new(

data/lib/chef/provisioning/vsphere_driver/driver.rb

@@ -1,14 +1,15 @@
 # frozen_string_literal: true
-require "chef"
-require "cheffish/merged_config"
-require "chef/provisioning/driver"
-require "chef/provisioning/machine/windows_machine"
-require "chef/provisioning/machine/unix_machine"
-require "chef/provisioning/vsphere_driver/clone_spec_builder"
-require "chef/provisioning/vsphere_driver/version"
-require "chef/provisioning/vsphere_driver/vsphere_helpers"
-require "chef/provisioning/vsphere_driver/vsphere_url"
-require "chef/provisioning/vsphere_driver/vm_helper"
+
+require 'chef'
+require 'cheffish/merged_config'
+require 'chef/provisioning/driver'
+require 'chef/provisioning/machine/windows_machine'
+require 'chef/provisioning/machine/unix_machine'
+require 'chef/provisioning/vsphere_driver/clone_spec_builder'
+require 'chef/provisioning/vsphere_driver/version'
+require 'chef/provisioning/vsphere_driver/vsphere_helpers'
+require 'chef/provisioning/vsphere_driver/vsphere_url'
+require 'chef/provisioning/vsphere_driver/vm_helper'
 
 # Provisions machines in vSphere.
 module ChefProvisioningVsphere
@@ -73,12 +74,12 @@ module ChefProvisioningVsphere
 
       uri = URI(driver_url)
       @connect_options = {
-        provider: "vsphere",
+        provider: 'vsphere',
         host: uri.host,
         port: uri.port,
         use_ssl: uri.use_ssl,
         insecure: uri.insecure,
-        path: uri.path,
+        path: uri.path
       }
 
       if driver_options
@@ -149,13 +150,13 @@ module ChefProvisioningVsphere
         )
         vm = vm_for(machine_spec)
         if vm
-          Chef::Log.warn "returning existing machine"
+          Chef::Log.warn 'returning existing machine'
           return vm
         else
           Chef::Log.warn machine_msg(
             machine_spec.name,
-            machine_spec.location["server_id"],
-            "no longer exists.  Recreating ..."
+            machine_spec.location['server_id'],
+            'no longer exists.  Recreating ...'
           )
         end
       end
@@ -172,7 +173,7 @@ module ChefProvisioningVsphere
       action_handler.performed_action(machine_msg(
                                         machine_spec.name,
                                         vm.config.instanceUuid,
-                                        "created"
+                                        'created'
       ))
       vm
     end
@@ -194,12 +195,12 @@ module ChefProvisioningVsphere
     # @param [Object] vm taken from Chef provisioning for all the vm state.
     def add_machine_spec_location(vm, machine_spec)
       machine_spec.location = {
-        "driver_url" => driver_url,
-        "driver_version" => VERSION,
-        "server_id" => vm.config.instanceUuid,
-        "is_windows" => is_windows?(vm),
-        "allocated_at" => Time.now.utc.to_s,
-        "ipaddress" => vm.guest.ipAddress,
+        'driver_url' => driver_url,
+        'driver_version' => VERSION,
+        'server_id' => vm.config.instanceUuid,
+        'is_windows' => is_windows?(vm),
+        'allocated_at' => Time.now.utc.to_s,
+        'ipaddress' => vm.guest.ipAddress
       }
     end
 
@@ -217,7 +218,7 @@ module ChefProvisioningVsphere
         Chef::Log.info machine_msg(
           machine_spec.name,
           vm.config.instanceUuid,
-          "already created"
+          'already created'
         )
       else
         vm = clone_vm(
@@ -238,7 +239,7 @@ module ChefProvisioningVsphere
       bootstrap_options.to_hash.each_pair do |key, value|
         if value.is_a?(Hash)
           temp_value = value.clone
-          temp_value[:password] = "*********" if value.key?(:password)
+          temp_value[:password] = '*********' if value.key?(:password)
         else
           temp_value = value
         end
@@ -269,7 +270,7 @@ module ChefProvisioningVsphere
       vm = start_machine(action_handler, machine_spec, machine_options)
       if vm.nil?
         raise "Machine #{machine_spec.name} does not have a server "\
-        "associated with it, or server does not exist."
+        'associated with it, or server does not exist.'
       end
 
       bootstrap_options = machine_options[:bootstrap_options]
@@ -290,7 +291,7 @@ module ChefProvisioningVsphere
       end
 
       ## Check if true available after added nic
-      @vm_helper.open_port?(machine_spec.location["ipaddress"], @vm_helper.port) unless machine_spec.location["ipaddress"].nil?
+      @vm_helper.open_port?(machine_spec.location['ipaddress'], @vm_helper.port) unless machine_spec.location['ipaddress'].nil?
       machine
     end
 
@@ -311,7 +312,7 @@ module ChefProvisioningVsphere
         bootstrap_options,
         vm
       )
-      if is_windows?(vm) && !new_nics.nil? && @vm_helper.open_port?(machine_spec.location["ipaddress"], @vm_helper.port)
+      if is_windows?(vm) && !new_nics.nil? && @vm_helper.open_port?(machine_spec.location['ipaddress'], @vm_helper.port)
         new_nics.each do |nic|
           nic_label = nic.device.deviceInfo.label
           machine.execute_always(
@@ -340,13 +341,13 @@ module ChefProvisioningVsphere
       # Customization below may change this to a valid ip
       wait_until_ready(action_handler, machine_spec, machine_options, vm)
 
-      if !machine_spec.location["ipaddress"] || !has_ip?(machine_spec.location["ipaddress"], vm)
+      if !machine_spec.location['ipaddress'] || !has_ip?(machine_spec.location['ipaddress'], vm)
         # find the ip we actually want
         # this will be the static ip to assign
         # or the ip reported back by the vm if using dhcp
         # it *may* be nil if just cloned
         vm_ip = ip_to_bootstrap(bootstrap_options, vm) || vm.guest.ipAddress
-        machine_spec.location["ipaddress"] = vm_ip
+        machine_spec.location['ipaddress'] = vm_ip
         transport = nil
         unless vm_ip.nil?
           transport = transport_for(machine_spec, bootstrap_options[:ssh], vm_ip)
@@ -355,9 +356,9 @@ module ChefProvisioningVsphere
         unless !transport.nil? && transport.available? && has_ip?(vm_ip, vm)
           attempt_ip(machine_options, action_handler, vm, machine_spec)
         end
-        machine_spec.location["ipaddress"] = vm_ip # vm.guest.ipAddress vmWare ip_address here can be 0.0.0.0
+        machine_spec.location['ipaddress'] = vm_ip # vm.guest.ipAddress vmWare ip_address here can be 0.0.0.0
         action_handler.report_progress(
-          "IP address obtained: #{machine_spec.location["ipaddress"]}"
+          "IP address obtained: #{machine_spec.location['ipaddress']}"
         )
       end
 
@@ -367,14 +368,14 @@ module ChefProvisioningVsphere
         wait_for_transport(action_handler, machine_spec, machine_options, vm)
       rescue Timeout::Error
         # Only ever reboot once, and only if it's been less than 10 minutes since we stopped waiting
-        if machine_spec.location["started_at"] ||
-            remaining_wait_time(machine_spec, machine_options) < -(10 * 60)
+        if machine_spec.location['started_at'] ||
+           remaining_wait_time(machine_spec, machine_options) < -(10 * 60)
           raise
         else
           Chef::Log.warn(machine_msg(
                            machine_spec.name,
                            vm.config.instanceUuid,
-                           "started but SSH did not come up.  Rebooting..."
+                           'started but SSH did not come up.  Rebooting...'
           ))
           restart_server(action_handler, machine_spec, machine_options)
           wait_until_ready(action_handler, machine_spec, machine_options, vm)
@@ -391,18 +392,18 @@ module ChefProvisioningVsphere
     # @param [Object] machine_spec The spec required to talk to the VM.
     def attempt_ip(machine_options, action_handler, vm, machine_spec)
       vm_ip = ip_to_bootstrap(machine_options[:bootstrap_options], vm)
-      machine_spec.location["ipaddress"] = vm_ip
+      machine_spec.location['ipaddress'] = vm_ip
 
       wait_for_ip(vm, machine_options, machine_spec, action_handler)
 
       unless has_ip?(vm_ip, vm)
-        action_handler.report_progress "rebooting..."
-        if vm.guest.toolsRunningStatus != "guestToolsRunning"
-          msg = "tools have stopped. current power state is "
+        action_handler.report_progress 'rebooting...'
+        if vm.guest.toolsRunningStatus != 'guestToolsRunning'
+          msg = 'tools have stopped. current power state is '
           msg << vm.runtime.powerState
-          msg << " and tools state is "
+          msg << ' and tools state is '
           msg << vm.guest.toolsRunningStatus
-          msg << ". powering up server..."
+          msg << '. powering up server...'
           action_handler.report_progress(msg)
           vsphere_helper.start_vm(vm)
         else
@@ -433,7 +434,7 @@ module ChefProvisioningVsphere
 
       return unless domain
 
-      if is_windows?(vm) && domain != "local"
+      if is_windows?(vm) && domain != 'local'
         start = Time.now.utc
         trimmed_name = machine_spec.name.byteslice(0, 15)
         expected_name = "#{trimmed_name}.#{domain}"
@@ -441,8 +442,8 @@ module ChefProvisioningVsphere
           "waiting to domain join and be named #{expected_name}"
         )
         until (Time.now.utc - start) > 30 ||
-            (vm.guest.hostName == expected_name)
-          print "."
+              (vm.guest.hostName == expected_name)
+          print '.'
           sleep 5
         end
       end
@@ -459,12 +460,12 @@ module ChefProvisioningVsphere
       ip_to_bootstrap(bootstrap_options, vm)
       ready_timeout = machine_options[:ready_timeout] || 300
       msg1 = "waiting up to #{ready_timeout} seconds for customization"
-      msg2 = " and find #{machine_spec.location["ipaddress"]}" unless machine_spec.location["ipaddress"].nil? # unless vm_ip == vm.guest.ipAddress # RuntimeError: can't modify frozen String
+      msg2 = " and find #{machine_spec.location['ipaddress']}" unless machine_spec.location['ipaddress'].nil? # unless vm_ip == vm.guest.ipAddress # RuntimeError: can't modify frozen String
       msg = [msg1, msg2].join
       action_handler.report_progress msg
 
       vm_ip = ip_to_bootstrap(bootstrap_options, vm) || vm.guest.ipAddress
-      machine_spec.location["ipaddress"] = vm_ip
+      machine_spec.location['ipaddress'] = vm_ip
       until transport_for(
         machine_spec,
         machine_options[:bootstrap_options][:ssh],
@@ -474,7 +475,7 @@ module ChefProvisioningVsphere
           "IP addresses found: #{all_ips_for(vm)}"
         )
         vm_ip = ip_to_bootstrap(bootstrap_options, vm) || vm.guest.ipAddress
-        machine_spec.location["ipaddress"] = vm_ip
+        machine_spec.location['ipaddress'] = vm_ip
         if has_ip?(vm_ip, vm)
           transport_for(
             machine_spec,
@@ -526,7 +527,7 @@ module ChefProvisioningVsphere
             vsphere_helper.stop_vm(vm, machine_options[:stop_timeout])
             vm.Destroy_Task.wait_for_completion
           rescue RbVmomi::Fault => fault
-            raise fault unless fault.fault.class.wsdl_name == "ManagedObjectNotFound"
+            raise fault unless fault.fault.class.wsdl_name == 'ManagedObjectNotFound'
           ensure
             machine_spec.location = nil
           end
@@ -578,7 +579,7 @@ module ChefProvisioningVsphere
       action_handler.perform_action "restart machine #{machine_spec.name} (#{driver_url})" do
         stop_machine(action_handler, machine_spec, machine_options)
         start_machine(action_handler, machine_spec, machine_options)
-        machine_spec.location["started_at"] = Time.now.utc.to_s
+        machine_spec.location['started_at'] = Time.now.utc.to_s
       end
     end
 
@@ -590,24 +591,24 @@ module ChefProvisioningVsphere
     # @param [Object] _machine_spec The machine spec required to start the VM.
     # @param [Object] machine Machine object to connect to.
     def setup_ubuntu_dns(machine, bootstrap_options, _machine_spec)
-      host_lookup = machine.execute_always("host google.com")
+      host_lookup = machine.execute_always('host google.com')
       if host_lookup.exitstatus != 0
-        if host_lookup.stdout.include?("setlocale: LC_ALL")
-          machine.execute_always("locale-gen en_US && update-locale LANG=en_US")
+        if host_lookup.stdout.include?('setlocale: LC_ALL')
+          machine.execute_always('locale-gen en_US && update-locale LANG=en_US')
         end
         distro = machine.execute_always("lsb_release -i | sed -e 's/Distributor ID://g'").stdout.strip
         Chef::Log.info "Found distro:#{distro}"
-        if distro == "Ubuntu"
-          distro_version = machine.execute_always("lsb_release -r | sed -e s/[^0-9.]//g").stdout.strip.to_f
+        if distro == 'Ubuntu'
+          distro_version = machine.execute_always('lsb_release -r | sed -e s/[^0-9.]//g').stdout.strip.to_f
           Chef::Log.info "Found distro version:#{distro_version}"
           if distro_version >= 12.04
-            Chef::Log.info "Ubuntu version 12.04 or greater. Need to patch DNS."
-            interfaces_file = "/etc/network/interfaces"
-            nameservers = bootstrap_options[:customization_spec][:ipsettings][:dnsServerList].join(" ")
+            Chef::Log.info 'Ubuntu version 12.04 or greater. Need to patch DNS.'
+            interfaces_file = '/etc/network/interfaces'
+            nameservers = bootstrap_options[:customization_spec][:ipsettings][:dnsServerList].join(' ')
             machine.execute_always("if ! cat #{interfaces_file} | grep -q dns-search ; then echo 'dns-search #{bootstrap_options[:customization_spec][:domain]}' >> #{interfaces_file} ; fi")
             machine.execute_always("if ! cat #{interfaces_file} | grep -q dns-nameservers ; then echo 'dns-nameservers #{nameservers}' >> #{interfaces_file} ; fi")
-            machine.execute_always("/etc/init.d/networking restart")
-            machine.execute_always("apt-get -qq update")
+            machine.execute_always('/etc/init.d/networking restart')
+            machine.execute_always('apt-get -qq update')
           end
         end
       end
@@ -632,22 +633,22 @@ module ChefProvisioningVsphere
     end
 
     def remaining_wait_time(machine_spec, machine_options)
-      if machine_spec.location["started_at"]
+      if machine_spec.location['started_at']
         (machine_options[:start_timeout] || 600) -
-          (Time.now.utc - Time.parse(machine_spec.location["started_at"]))
+          (Time.now.utc - Time.parse(machine_spec.location['started_at']))
       else
         (machine_options[:create_timeout] || 600) -
-          (Time.now.utc - Time.parse(machine_spec.location["allocated_at"]))
+          (Time.now.utc - Time.parse(machine_spec.location['allocated_at']))
       end
     end
 
     def wait_until_ready(action_handler, machine_spec, machine_options, vm)
-      if vm.guest.toolsRunningStatus != "guestToolsRunning"
+      if vm.guest.toolsRunningStatus != 'guestToolsRunning'
         if action_handler.should_perform_actions
           action_handler.report_progress "waiting for #{machine_spec.name} (#{vm.config.instanceUuid} on #{driver_url}) to be ready ..."
           until remaining_wait_time(machine_spec, machine_options) < 0 ||
-              (vm.guest.toolsRunningStatus == "guestToolsRunning" && vm.guest.ipAddress && !vm.guest.ipAddress.empty?)
-            print "."
+                (vm.guest.toolsRunningStatus == 'guestToolsRunning' && vm.guest.ipAddress && !vm.guest.ipAddress.empty?)
+            print '.'
             sleep 5
           end
           action_handler.report_progress "#{machine_spec.name} is now ready"
@@ -657,7 +658,7 @@ module ChefProvisioningVsphere
 
     def vm_for(machine_spec)
       if machine_spec.location
-        vsphere_helper.find_vm_by_id(machine_spec.location["server_id"])
+        vsphere_helper.find_vm_by_id(machine_spec.location['server_id'])
       end
     end
 
@@ -686,7 +687,7 @@ module ChefProvisioningVsphere
         size = size.to_i
         next if size == 0
         if bootstrap_options[:datastore].to_s.empty?
-          raise ":datastore must be specified when adding a disk to a cloned vm"
+          raise ':datastore must be specified when adding a disk to a cloned vm'
         end
         task = vm.ReconfigVM_Task(
           spec: RbVmomi::VIM.VirtualMachineConfigSpec(
@@ -695,7 +696,7 @@ module ChefProvisioningVsphere
                 vm,
                 bootstrap_options[:datastore],
                 size
-              ),
+              )
             ]
           )
         )
@@ -730,7 +731,7 @@ module ChefProvisioningVsphere
       )
       strategy = convergence_strategy_for(machine_spec, machine_options)
 
-      if machine_spec.location["is_windows"]
+      if machine_spec.location['is_windows']
         Chef::Provisioning::Machine::WindowsMachine.new(
           machine_spec, transport, strategy
         )
@@ -743,13 +744,13 @@ module ChefProvisioningVsphere
 
     def is_windows?(vm)
       return false if vm.nil?
-      vm.config.guestId.start_with?("win")
+      vm.config.guestId.start_with?('win')
     end
 
     def convergence_strategy_for(machine_spec, machine_options)
-      require "chef/provisioning/convergence_strategy/install_msi"
-      require "chef/provisioning/convergence_strategy/install_cached"
-      require "chef/provisioning/convergence_strategy/no_converge"
+      require 'chef/provisioning/convergence_strategy/install_msi'
+      require 'chef/provisioning/convergence_strategy/install_cached'
+      require 'chef/provisioning/convergence_strategy/no_converge'
 
       mopts = machine_options[:convergence_options].to_hash.dup
       if mopts[:chef_server]
@@ -763,7 +764,7 @@ module ChefProvisioningVsphere
         )
       end
 
-      if machine_spec.location["is_windows"]
+      if machine_spec.location['is_windows']
         Chef::Provisioning::ConvergenceStrategy::InstallMsi.new(
           mopts, config
         )
@@ -791,7 +792,7 @@ module ChefProvisioningVsphere
           action_handler.report_progress "waiting for #{machine_spec.name} (#{vm.config.instanceUuid} on #{driver_url}) to be connectable (transport up and running) ..."
 
           until remaining_wait_time(machine_spec, machine_options) < 0 || transport.available?
-            print "."
+            print '.'
             sleep 5
           end
 
@@ -808,9 +809,9 @@ module ChefProvisioningVsphere
     def transport_for(
       machine_spec,
       remoting_options,
-      ip = machine_spec.location["ipaddress"]
+      ip = machine_spec.location['ipaddress']
     )
-      if machine_spec.location["is_windows"]
+      if machine_spec.location['is_windows']
         create_winrm_transport(ip, remoting_options)
       else
         create_ssh_transport(ip, remoting_options)
@@ -822,7 +823,7 @@ module ChefProvisioningVsphere
     # @param [String] host The host the VM is connecting to
     # @param [Object] options Options that are required to connect to the host from Chef-Provisioning
     def create_winrm_transport(host, options)
-      require "chef/provisioning/transport/winrm"
+      require 'chef/provisioning/transport/winrm'
       winrm_transport = if options[:port] == 5986
                           :ssl
                         else
@@ -831,7 +832,7 @@ module ChefProvisioningVsphere
       port = options[:port] || @vm_helper.port
       winrm_options = {
         user: (options[:user]).to_s,
-        pass: options[:password],
+        pass: options[:password]
       }
       if options[:winrm_opts].nil?
         opt = options[:user].include?('\\') ? :disable_sspi : :basic_auth_only
@@ -855,14 +856,14 @@ module ChefProvisioningVsphere
     # @param [String] host The host the VM is connecting to
     # @param [Object] options Options that are required to connect to the host from Chef-Provisioning
     def create_ssh_transport(host, options)
-      require "chef/provisioning/transport/ssh"
+      require 'chef/provisioning/transport/ssh'
       ssh_user = options[:user]
       options = options.each_with_object({}) { |(k, v), memo| memo[k.to_sym] = v; }
       Chef::Provisioning::Transport::SSH.new(
         host,
         ssh_user,
         options.to_hash,
-        @config[:machine_options][:sudo] ? { prefix: "sudo " } : {},
+        @config[:machine_options][:sudo] ? { prefix: 'sudo ' } : {},
         config
       )
     end
@@ -881,7 +882,7 @@ module ChefProvisioningVsphere
         else
           ## Check if true available
           vm_ip = bootstrap_options[:customization_spec][:ipsettings][:ip] unless vm_helper.ip?
-          print "." until @vm_helper.open_port?(vm_ip, @vm_helper.port, 1)
+          print '.' until @vm_helper.open_port?(vm_ip, @vm_helper.port, 1)
         end
       else
         if use_ipv4_during_bootstrap?(bootstrap_options)
@@ -920,18 +921,18 @@ module ChefProvisioningVsphere
     # @param [Object] vm The VM object from Chef-Provisioning
     def wait_for_ipv4(timeout, vm)
       sleep_time = 5
-      print "Waiting for ipv4 address."
+      print 'Waiting for ipv4 address.'
       tries = 0
       start_search_ip = true
       max_tries = timeout > sleep_time ? timeout / sleep_time : 1
       while start_search_ip && (tries += 1) <= max_tries
-        print "."
+        print '.'
         sleep sleep_time
         vm_ip = vm.guest.ipAddress if vm_guest_ip?(vm)
         start_search_ip = false if @vm_helper.open_port?(vm_ip, @vm_helper.port, 1)
       end
-      raise "Timed out waiting for ipv4 address!" if tries > max_tries
-      puts "Found ipv4 address!"
+      raise 'Timed out waiting for ipv4 address!' if tries > max_tries
+      puts 'Found ipv4 address!'
       true
     end
 
@@ -939,7 +940,7 @@ module ChefProvisioningVsphere
     #
     # @param [Object] vm The VM object from Chef-Provisioning
     def vm_guest_ip?(vm)
-      vm.guest.guestState == "running" && vm.guest.toolsRunningStatus == "guestToolsRunning" && !vm.guest.ipAddress.nil? && IPAddr.new(vm.guest.ipAddress).ipv4?
+      vm.guest.guestState == 'running' && vm.guest.toolsRunningStatus == 'guestToolsRunning' && !vm.guest.ipAddress.nil? && IPAddr.new(vm.guest.ipAddress).ipv4?
     end
   end
 end

data/lib/chef/provisioning/vsphere_driver/version.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: false
+
 # Provisions machines in vSphere.
 module ChefProvisioningVsphere
   # The version of this awesome Gem. BOOM.
-  VERSION = "2.0.7".freeze
+  VERSION = '2.0.8'.freeze
 end

data/lib/chef/provisioning/vsphere_driver/vm_helper.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
-require "chef/provisioning/driver"
+
+require 'chef/provisioning/driver'
 
 # Provisions machines in vSphere.
 module ChefProvisioningVsphere
@@ -36,16 +37,16 @@ module ChefProvisioningVsphere
     def find_port?(vm, options)
       @port = options[:ssh][:port]
       customization_spec = options[:customization_spec]
-      if vm.config.guestId.start_with?("win")
+      if vm.config.guestId.start_with?('win')
         if customization_spec.is_a?(Hash)
           winrm_transport =
             customization_spec[:winrm_transport].nil? ? :negotiate : customization_spec[:winrm_transport].to_sym
         end
         winrm_transport ||= :negotiate
-        default_win_port = winrm_transport == :ssl ? "5986" : "5985"
+        default_win_port = winrm_transport == :ssl ? '5986' : '5985'
         @port = default_win_port if @port.nil?
       elsif port.nil?
-        @port = "22"
+        @port = '22'
       end
       true
     end

data/lib/chef/provisioning/vsphere_driver/vsphere_helpers.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
-require "rbvmomi"
-require "uri"
-require "net/http"
+
+require 'rbvmomi'
+require 'uri'
+require 'net/http'
 
 # Provisions machines in vSphere.
 module ChefProvisioningVsphere
@@ -70,7 +71,7 @@ module ChefProvisioningVsphere
     # @param [Object] _wait_on_port Defaults to port 22, to connect and verify it's up.
     def start_vm(vm, _wait_on_port = 22)
       state = vm.runtime.powerState
-      vm.PowerOnVM_Task.wait_for_completion unless state == "poweredOn"
+      vm.PowerOnVM_Task.wait_for_completion unless state == 'poweredOn'
     end
 
     # Stops the VM
@@ -79,12 +80,12 @@ module ChefProvisioningVsphere
     # @param [Object] timeout Defaults to 600 seconds or 10 mins before giving up.
     def stop_vm(vm, timeout = 600)
       start = Time.now.utc
-      return if vm.runtime.powerState == "poweredOff"
+      return if vm.runtime.powerState == 'poweredOff'
       begin
         vm.ShutdownGuest
         until (Time.now.utc - start) > timeout ||
-            vm.runtime.powerState == "poweredOff"
-          print "."
+              vm.runtime.powerState == 'poweredOff'
+          print '.'
           sleep 2
         end
       rescue
@@ -99,9 +100,9 @@ module ChefProvisioningVsphere
     def find_folder(folder_name)
       base = datacenter.vmFolder
       unless folder_name.nil?
-        folder_name.split("/").reject(&:empty?).each do |item|
+        folder_name.split('/').reject(&:empty?).each do |item|
           base = base.find(item, RbVmomi::VIM::Folder) ||
-            raise("vSphere Folder not found [#{folder_name}]")
+                 raise("vSphere Folder not found [#{folder_name}]")
         end
       end
       base
@@ -151,7 +152,7 @@ module ChefProvisioningVsphere
       )
       device = RbVmomi::VIM::VirtualVmxnet3(
         backing: backing_info,
-        deviceInfo: RbVmomi::VIM::Description(label: network_label, summary: network_name.split("/").last),
+        deviceInfo: RbVmomi::VIM::Description(label: network_label, summary: network_name.split('/').last),
         key: device_key,
         connectable: connectable
       )
@@ -179,10 +180,10 @@ module ChefProvisioningVsphere
 
       if deviceAdditions.count > 0
         current_networks = find_ethernet_cards_for(vm).map { |card| network_id_for(card.backing) }
-        new_devices = deviceAdditions.select { |device| !current_networks.include?(network_id_for(device.device.backing)) }
+        new_devices = deviceAdditions.reject { |device| current_networks.include?(network_id_for(device.device.backing)) }
 
         if new_devices.count > 0
-          action_handler.report_progress "Adding extra NICs"
+          action_handler.report_progress 'Adding extra NICs'
           task = vm.ReconfigVM_Task(spec: RbVmomi::VIM.VirtualMachineConfigSpec(deviceChange: new_devices))
           task.wait_for_completion
           new_devices
@@ -211,7 +212,7 @@ module ChefProvisioningVsphere
           deviceChange: [
             {
               operation: :remove,
-              device: disk,
+              device: disk
             },
             {
               operation: :add,
@@ -220,9 +221,9 @@ module ChefProvisioningVsphere
                 new_disk.backing = new_disk.backing.dup
                 new_disk.backing.fileName = "[#{disk.backing.datastore.name}]"
                 new_disk.backing.parent = disk.backing
-              end,
-            },
-          ],
+              end
+            }
+          ]
         }
         vm_template.ReconfigVM_Task(spec: spec).wait_for_completion
       end
@@ -242,7 +243,7 @@ module ChefProvisioningVsphere
           key: idx,
           backing: RbVmomi::VIM.VirtualDiskFlatVer2BackingInfo(
             fileName: "[#{datastore}]",
-            diskMode: "persistent",
+            diskMode: 'persistent',
             thinProvisioned: true
           ),
           capacityInKB: size_gb * 1024 * 1024,
@@ -271,14 +272,14 @@ module ChefProvisioningVsphere
         backing_info = backing_info_for(action_handler, networks[i])
         if card = cards.shift
           key = card.key
-          operation = RbVmomi::VIM::VirtualDeviceConfigSpecOperation("edit")
+          operation = RbVmomi::VIM::VirtualDeviceConfigSpecOperation('edit')
           action_handler.report_progress "changing template nic for #{networks[i]}"
           changes.push(
             network_adapter_for(operation, networks[i], label, key, backing_info)
           )
         else
           key += 1
-          operation = RbVmomi::VIM::VirtualDeviceConfigSpecOperation("add")
+          operation = RbVmomi::VIM::VirtualDeviceConfigSpecOperation('add')
           action_handler.report_progress "will be adding nic for #{networks[i]}"
           additions.push(
             network_adapter_for(operation, networks[i], label, key, backing_info)
@@ -293,7 +294,7 @@ module ChefProvisioningVsphere
     # @param [Object] action_handler TODO
     # @param [String] network_name The network name to attach to
     def backing_info_for(action_handler, network_name)
-      action_handler.report_progress("finding networks...")
+      action_handler.report_progress('finding networks...')
       network = find_network(network_name)
       action_handler.report_progress(
         "network: #{network_name} is a #{network.class}"
@@ -308,7 +309,7 @@ module ChefProvisioningVsphere
         )
       else
         RbVmomi::VIM::VirtualEthernetCardNetworkBackingInfo(
-          deviceName: network_name.split("/").last
+          deviceName: network_name.split('/').last
         )
       end
     end
@@ -325,11 +326,11 @@ module ChefProvisioningVsphere
     # @param [String] name The name of the "thing."
     # @param [String] parent_folder The name of the folder to start from.
     def find_entity(name, parent_folder)
-      parts = name.split("/").reject(&:empty?)
+      parts = name.split('/').reject(&:empty?)
       parts.each do |item|
         Chef::Log.debug("Identifying entity part: #{item} in folder type: #{parent_folder.class}")
         if parent_folder.is_a? RbVmomi::VIM::Folder
-          Chef::Log.debug("Parent folder is a folder")
+          Chef::Log.debug('Parent folder is a folder')
           parent_folder = parent_folder.childEntity.find { |f| f.name == item }
         else
           parent_folder = yield(parent_folder, item)
@@ -393,7 +394,7 @@ module ChefProvisioningVsphere
     # @param [String] name Name of the Network.
     def find_network(name)
       base = datacenter.networkFolder
-      entity_array = name.split("/").reject(&:empty?)
+      entity_array = name.split('/').reject(&:empty?)
       entity_array.each do |item|
         case base
         when RbVmomi::VIM::Folder
@@ -446,8 +447,8 @@ module ChefProvisioningVsphere
 
       req = Net::HTTP::Put.new("#{uri.path}?#{uri.query}")
       req.body_stream = File.open(local)
-      req["Content-Type"] = "application/octet-stream"
-      req["Content-Length"] = size
+      req['Content-Type'] = 'application/octet-stream'
+      req['Content-Length'] = size
       res = http.request(req)
       unless res.is_a?(Net::HTTPSuccess)
         raise "Error: #{res.inspect} :: #{res.body} :: sending #{local} to #{remote} at #{vm.name} via #{endpoint} with a size of #{size}"

data/lib/chef/provisioning/vsphere_driver/vsphere_url.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: false
-require "uri"
+
+require 'uri'
 
 # The main URI Module
 module URI
@@ -8,20 +9,20 @@ module URI
     # Default port for connecting to the vSphere cluster Webserver
     DEFAULT_PORT = 443
     # Default path for connecting to the vSphere cluster URL
-    DEFAULT_PATH = "/sdk".freeze
+    DEFAULT_PATH = '/sdk'.freeze
 
     # Creates the URL from options that are decided
     #
     def self.from_config(options)
       parts = []
-      parts << "vsphere://"
+      parts << 'vsphere://'
       parts << options[:host]
-      parts << ":"
+      parts << ':'
       parts << (options[:port] || DEFAULT_PORT)
       parts << (options[:path] || DEFAULT_PATH)
-      parts << "?use_ssl="
+      parts << '?use_ssl='
       parts << (options[:use_ssl] == false ? false : true)
-      parts << "&insecure="
+      parts << '&insecure='
       parts << (options[:insecure] || false)
       URI parts.join
     end
@@ -30,10 +31,10 @@ module URI
     #
     def use_ssl
       if query
-        ssl_query = query.split("&").each.select do |q|
-          q.start_with?("use_ssl=")
+        ssl_query = query.split('&').each.select do |q|
+          q.start_with?('use_ssl=')
         end.first
-        ssl_query == "use_ssl=true"
+        ssl_query == 'use_ssl=true'
       else
         true
       end
@@ -43,14 +44,14 @@ module URI
     #
     def insecure
       if query
-        insecure_query = query.split("&").each.select do |q|
-          q.start_with?("insecure=")
+        insecure_query = query.split('&').each.select do |q|
+          q.start_with?('insecure=')
         end.first
-        insecure_query == "insecure=true"
+        insecure_query == 'insecure=true'
       else
         false
       end
     end
   end
-  @@schemes["VSPHERE"] = VsphereUrl
+  @@schemes['VSPHERE'] = VsphereUrl
 end

data/lib/kitchen/driver/vsphere.rb

@@ -1,8 +1,9 @@
 # frozen_string_literal: true
-require "json"
-require "kitchen"
-require "chef/provisioning/vsphere_driver"
-require "chef/provisioning/machine_spec"
+
+require 'json'
+require 'kitchen'
+require 'chef/provisioning/vsphere_driver'
+require 'chef/provisioning/machine_spec'
 
 # Main Kitchen Module
 module Kitchen
@@ -20,14 +21,14 @@ module Kitchen
                      bootstrap_options: {
                        use_linked_clone: true,
                        ssh: {
-                         user: "root",
+                         user: 'root',
                          paranoid: false,
-                         port: 22,
+                         port: 22
                        },
                        convergence_options: {},
                        customization_spec: {
-                         domain: "local",
-                       },
+                         domain: 'local'
+                       }
                      }
 
       default_config(:vsphere_name) do |driver|
@@ -46,8 +47,8 @@ module Kitchen
         machine = with_provisioning_driver(state) do |action_handler, driver, machine_spec|
           driver.allocate_machine(action_handler, machine_spec, config[:machine_options])
           driver.ready_machine(action_handler, machine_spec, config[:machine_options])
-          state[:server_id] = machine_spec.location["server_id"]
-          state[:hostname] = machine_spec.location["ipaddress"]
+          state[:server_id] = machine_spec.location['server_id']
+          state[:hostname] = machine_spec.location['ipaddress']
           machine_spec.save(action_handler)
         end
       end
@@ -59,8 +60,8 @@ module Kitchen
         return if state[:server_id].nil?
 
         with_provisioning_driver(state) do |action_handler, driver, machine_spec|
-          machine_spec.location = { "driver_url" => driver.driver_url,
-                                    "server_id" => state[:server_id] }
+          machine_spec.location = { 'driver_url' => driver.driver_url,
+                                    'server_id' => state[:server_id] }
           driver.destroy_machine(action_handler, machine_spec, config[:machine_options])
         end
 
@@ -93,7 +94,7 @@ module Kitchen
             unless @@chef_zero_server
               Chef::Config.local_mode = true
               Chef::Config.chef_repo_path = Chef::Config.find_chef_repo_path(Dir.pwd)
-              require "chef/local_mode"
+              require 'chef/local_mode'
               Chef::LocalMode.setup_server_connectivity
               @@chef_zero_server = true
             end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: chef-provisioning-vsphere
 version: !ruby/object:Gem::Version
-  version: 2.0.7
+  version: 2.0.8
 platform: ruby
 authors:
 - CenturyLink Cloud
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-19 00:00:00.000000000 Z
+date: 2017-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chef