chef-handler-datadog 0.4.0 → 0.5.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZGY5NzgzNTc5ZDY5YjA3ZGZkNWY4OTRhM2U4NmE4ZWI0NGYyNDBhMg==
+    Y2VjMTZmYjcxMGU0ZTk3MTZkNWM3NzYzNWU1Y2VlMjI5ZjI4MGQ4Zg==
   data.tar.gz: !binary |-
-    ZjkxZDg0ZDUyOGMxOWY5YWZhMjNlNmZmMTIxN2NmMjE3ZGU5Y2Y1MA==
+    ZGE2NGJjZjYwMGQ1MDczZjhlYjM5Yjg5N2ZmODU5NzYzN2EzMDBkYQ==
 SHA512:
   metadata.gz: !binary |-
-    ODRiMjJhZTAyMDAzZDljN2M3NWRhYmI4NTRmZTQzM2U4YzQwNmY1ZWRhZjZh
-    ZmMzNTBkOWM4ZjIyN2NjOWZmMzcyYmZiYjc5ZTEyOWIzZWVkODQ3ZTNjMzEz
-    NmE2NTYxNTM5NWEyMGY4NTBmZjdkYTM5MDIyNGQ1YzVmMzVhODA=
+    Y2UwYTVkMTc3MzE0ZjFhMTM3ZDQ5YjcwMDg2NTM1MTQwMDY1YmIwMGY0OWI2
+    N2IxZmFhZTFiMTI2YjljYTA2ODJhOTlhZTkwZjMwN2Y5Y2Q1NmM5MGY4YmE3
+    ZTllNTZhZjFhODAzYjJiYTJjODY5YmM2ZWQxYjNlODhjOWZlNzc=
   data.tar.gz: !binary |-
-    MmNjZGRmYjc1Mzg3YjJmM2E0ZjJhNzZkNDViYWVkNTZhMGFkMTg1YjhkMjI2
-    NGIzZDkxZGQyMzZiNDYyYTVmOTI0MDk4N2M0MmZlODQyYmU5NGUzOTBmOTY2
-    N2I4YjhlMDFiYjkxYmE1ODVkN2IwNjIwYmQ2MDdlMzA2NDNkODY=
+    Y2Q5MjczZDBiYmM5MTg3YzNkMzcyYTBlNzkxZWUwMTk3MGQ1NzEzM2ZiOTJi
+    ZTQ0MjQ2MjM0NWY3MjUzMTQzOTM2ODFhOTcyOGQ2Njg5Mjg2MDczZDA4M2Vi
+    YjdhYTNiMmY1Y2FiNjE4YzliNDVlYmFhOGJhNzdkMTZmMDcxYWM=

data/.gitignore

@@ -58,3 +58,6 @@ Gemfile.lock
 
 # Any environment-specific files
 .env
+
+# Ignore Appraisal lock files
+gemfiles/*.gemfile.lock

data/.rubocop.yml

@@ -36,3 +36,7 @@ CyclomaticComplexity:
 # be a little lofty.
 MethodLength:
   Max: 78
+
+# TODO: select_hostname, report are both higher than the default of 7
+PerceivedComplexity:
+  Max: 9

data/.travis.yml

@@ -7,6 +7,7 @@ gemfile:
   - gemfiles/chef_10.32.2.gemfile
   - gemfiles/chef_11.8.2.gemfile
   - gemfiles/chef_11.10.4.gemfile
-  - gemfiles/chef_11.12.2.gemfile
+  - gemfiles/chef_11.12.8.gemfile
+  - gemfiles/chef_11.14.2.gemfile
 env:
   - API_KEY=somefakeapikey APPLICATION_KEY=somefakeapplicationkey

data/Appraisals

@@ -4,7 +4,8 @@
 %w(
   11.8.2
   11.10.4
-  11.12.2
+  11.12.8
+  11.14.2
 ).each do |tv|
   appraise "chef-#{tv}" do
     gem 'chef', tv

data/CHANGELOG.md

@@ -1,7 +1,15 @@
 Changes
 =======
 
-# 0.4.0 / Unreleased
+# 0.5.0 / 2014-08-21
+
+* [FEATURE] Place recent updated resources above stacktrace on failure, [#46][] [@miketheman][]
+* [BUGFIX] Handle cases where Chef fails during compile phase, [#51][] [@miketheman][]
+* [FEATURE] Allow credentials to be passed as string keys vs symbols, [#50][] [@dwradcliffe][]
+* [MISC] Testing framework updates, [@miketheman][]
+* [MISC] Doc updates
+
+# 0.4.0 / 2014-05-08
 
 * [FEATURE] Allow specification of a `:hostname` to config to override `node.name`, [#41][] [@miketheman][]
 * [FEATURE] Allow passing an array of handles in config to alert when Chef fails, [#29][] [@miketheman][]
@@ -46,6 +54,10 @@ And all other versions were prior to this. See git history for more.
 [#37]: https://github.com/DataDog/chef-handler-datadog/issues/37
 [#39]: https://github.com/DataDog/chef-handler-datadog/issues/39
 [#41]: https://github.com/DataDog/chef-handler-datadog/issues/41
+[#46]: https://github.com/DataDog/chef-handler-datadog/issues/46
+[#50]: https://github.com/DataDog/chef-handler-datadog/issues/50
+[#51]: https://github.com/DataDog/chef-handler-datadog/issues/51
 [@alq]: https://github.com/alq
+[@dwradcliffe]: https://github.com/dwradcliffe
 [@miketheman]: https://github.com/miketheman
 [@remh]: https://github.com/remh

data/CONTRIBUTING.md

@@ -0,0 +1,23 @@
+# Contributing
+
+If you'd like to run the test suite, fix a bug or add a feature, please follow these steps:
+
+* Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it
+* Check out the latest `master` branch to make sure the feature hasn't been implemented or the bug hasn't been fixed
+* Fork the project
+* Install all dependencies: `bundle install`
+* Start a feature/bugfix branch: `git checkout -b my_feature_name`
+* Place a `.env` file in the root of the project with `API_KEY` and `APPLICATION_KEY`:
+
+        API_KEY: myapikey
+        APPLICATION_KEY: chefhandlerspecificapplicationkey
+
+  This file is intentionally .gitignored to prevent security exposure.
+  You may use your own Datadog account keys, as the keys are filtered from the test recordings.
+  Running the test suite will _not_ make calls to Datadog for existing tests, see `spec/support/cassettes/` for more.
+
+* Run `rake` to execute tests, ensure they pass
+* Commit and push until you are happy with your contribution
+* Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
+* Please try not to mess with the `Rakefile`, version, or history.
+  If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.

data/Gemfile

@@ -5,6 +5,10 @@ source 'http://rubygems.org'
 gemspec
 
 group :localdev do
+  gem 'guard'
+  gem 'guard-rspec'
+  gem 'guard-rubocop'
   gem 'pry'
+  gem 'terminal-notifier-guard'
   gem 'travis-lint'
 end

data/Guardfile

@@ -0,0 +1,37 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+guard :rubocop do
+  watch(%r{.+\.rb$})
+  watch(%r{(?:.+/)?\.rubocop\.yml$}) { |m| File.dirname(m[0]) }
+end
+
+# Note: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rsspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separetly)
+#  * 'just' rspec: 'rspec'
+guard :rspec, cmd: 'bundle exec rspec' do
+  watch(%r{^spec/.+_spec\.rb$})
+  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
+  watch('spec/spec_helper.rb')  { "spec" }
+
+  # Rails example
+  watch(%r{^app/(.+)\.rb$})                           { |m| "spec/#{m[1]}_spec.rb" }
+  watch(%r{^app/(.*)(\.erb|\.haml|\.slim)$})          { |m| "spec/#{m[1]}#{m[2]}_spec.rb" }
+  watch(%r{^app/controllers/(.+)_(controller)\.rb$})  { |m| ["spec/routing/#{m[1]}_routing_spec.rb", "spec/#{m[2]}s/#{m[1]}_#{m[2]}_spec.rb", "spec/acceptance/#{m[1]}_spec.rb"] }
+  watch(%r{^spec/support/(.+)\.rb$})                  { "spec" }
+  watch('config/routes.rb')                           { "spec/routing" }
+  watch('app/controllers/application_controller.rb')  { "spec/controllers" }
+  watch('spec/rails_helper.rb')                       { "spec" }
+
+  # Capybara features specs
+  watch(%r{^app/views/(.+)/.*\.(erb|haml|slim)$})     { |m| "spec/features/#{m[1]}_spec.rb" }
+
+  # Turnip features and steps
+  watch(%r{^spec/acceptance/(.+)\.feature$})
+  watch(%r{^spec/acceptance/steps/(.+)_steps\.rb$})   { |m| Dir[File.join("**/#{m[1]}.feature")][0] || 'spec/acceptance' }
+end

data/README.md

@@ -2,35 +2,27 @@
 
 An Exception and Report Handler for Chef.
 
-[![Gem Version](https://badge.fury.io/rb/chef-handler-datadog.png)](http://badge.fury.io/rb/chef-handler-datadog)
-[![Build Status](https://secure.travis-ci.org/DataDog/chef-handler-datadog.png?branch=master)](http://travis-ci.org/DataDog/chef-handler-datadog)
-[![Code Climate](https://codeclimate.com/github/DataDog/chef-handler-datadog.png)](https://codeclimate.com/github/DataDog/chef-handler-datadog)
-[![Dependency Status](https://gemnasium.com/DataDog/chef-handler-datadog.png)](https://gemnasium.com/DataDog/chef-handler-datadog)
+[![Gem Version](https://badge.fury.io/rb/chef-handler-datadog.svg)](http://badge.fury.io/rb/chef-handler-datadog)
+[![Build Status](https://travis-ci.org/DataDog/chef-handler-datadog.svg?branch=master)](https://travis-ci.org/DataDog/chef-handler-datadog)
+[![Code Climate](https://codeclimate.com/github/DataDog/chef-handler-datadog/badges/gpa.svg)](https://codeclimate.com/github/DataDog/chef-handler-datadog)
+[![Dependency Status](https://gemnasium.com/DataDog/chef-handler-datadog.svg)](https://gemnasium.com/DataDog/chef-handler-datadog)
 
 ## Using chef-handler-datadog
 
-The Datadog Docs on [Chef](http://docs.datadoghq.com/guides/chef/#deployhandler) has detailed instructions.
-
-## Contributing to chef-handler-datadog
+This can be installed by using the `dd-handler` recipe from the [datadog cookbook][cookbook].
 
-* Check out the latest `master` to make sure the feature hasn't been implemented or the bug hasn't been fixed yet
-* Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it
-* Fork the project
-* Start a feature/bugfix branch
-* Place a `.env` file in the root of the project with `API_KEY` and `APPLICATION_KEY`:
+```ruby
+run_list 'foo::bar', 'datadog::dd-handler'
+```
 
-        API_KEY: myapikey
-        APPLICATION_KEY: chefhandlerspecificapplicationkey
+The Datadog Docs on [Chef](http://docs.datadoghq.com/guides/chef/#deployhandler) has detailed instructions.
 
-  This file is intentionally .gitignored to prevent security exposure.
+## Contributing to chef-handler-datadog
 
-* Run `rake` to execute tests, ensure they pass
-* Commit and push until you are happy with your contribution
-* Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
-* Please try not to mess with the `Rakefile`, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.
+See [CONTRIBUTING.md](CONTRIBUTING.md)
 
 ## Copyright
 
 Copyright (c) 2012-2014 Datadog, Inc. See LICENSE.txt for further details.
 
-[![Bitdeli Badge](https://d2weczhvl823v0.cloudfront.net/DataDog/chef-handler-datadog/trend.png)](https://bitdeli.com/free "Bitdeli Badge")
+[cookbook]: https://supermarket.getchef.com/cookbooks/datadog

data/Rakefile

@@ -14,4 +14,4 @@ CLEAN.include(['coverage/', 'doc/', 'pkg/'])
 
 RSpec::Core::RakeTask.new(:spec)
 
-Rubocop::RakeTask.new(:cops)
+RuboCop::RakeTask.new(:cops)

data/chef-handler-datadog.gemspec

@@ -3,8 +3,8 @@ require File.expand_path('../lib/chef_handler_datadog', __FILE__)
 
 Gem::Specification.new do |gem|
   gem.name          = 'chef-handler-datadog'
-  gem.summary       = %q(Chef Handler for DataDog events and metrics)
-  gem.description   = %q(This Handler will report the events and metrics for a chef-client run to DataDog.)
+  gem.summary       = 'Chef Handler reports events and metrics to Datadog'
+  gem.description   = 'This Handler will report the events and metrics for a chef-client run to Datadog.'
   gem.license       = 'BSD'
   gem.version       = ChefHandlerDatadog::VERSION
 
@@ -21,8 +21,8 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'chef', '>= 10', '<= 12'
   gem.add_development_dependency 'dotenv'
   gem.add_development_dependency 'rake'
-  gem.add_development_dependency 'rspec'
-  gem.add_development_dependency 'rubocop', '~> 0.21.0'
+  gem.add_development_dependency 'rspec', '~> 3.0.0'
+  gem.add_development_dependency 'rubocop', '~> 0.25.0'
   gem.add_development_dependency 'simplecov'
   gem.add_development_dependency 'vcr'
   gem.add_development_dependency 'webmock'

data/gemfiles/chef_10.26.0.gemfile

@@ -6,7 +6,11 @@ gem "chef", "10.26.0"
 gem "json", "1.7.7"
 
 group :localdev do
+  gem "guard"
+  gem "guard-rspec"
+  gem "guard-rubocop"
   gem "pry"
+  gem "terminal-notifier-guard"
   gem "travis-lint"
 end
 

data/gemfiles/chef_10.32.2.gemfile

@@ -6,7 +6,11 @@ gem "chef", "10.32.2"
 gem "json", "1.7.7"
 
 group :localdev do
+  gem "guard"
+  gem "guard-rspec"
+  gem "guard-rubocop"
   gem "pry"
+  gem "terminal-notifier-guard"
   gem "travis-lint"
 end
 

data/gemfiles/chef_11.10.4.gemfile

@@ -5,7 +5,11 @@ source "http://rubygems.org"
 gem "chef", "11.10.4"
 
 group :localdev do
+  gem "guard"
+  gem "guard-rspec"
+  gem "guard-rubocop"
   gem "pry"
+  gem "terminal-notifier-guard"
   gem "travis-lint"
 end
 

data/gemfiles/{chef_11.12.2.gemfile → chef_11.12.8.gemfile}

@@ -2,10 +2,14 @@
 
 source "http://rubygems.org"
 
-gem "chef", "11.12.2"
+gem "chef", "11.12.8"
 
 group :localdev do
+  gem "guard"
+  gem "guard-rspec"
+  gem "guard-rubocop"
   gem "pry"
+  gem "terminal-notifier-guard"
   gem "travis-lint"
 end
 

data/gemfiles/chef_11.14.2.gemfile

@@ -0,0 +1,16 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "chef", "11.14.2"
+
+group :localdev do
+  gem "guard"
+  gem "guard-rspec"
+  gem "guard-rubocop"
+  gem "pry"
+  gem "terminal-notifier-guard"
+  gem "travis-lint"
+end
+
+gemspec :path => "../"

data/gemfiles/chef_11.8.2.gemfile

@@ -5,7 +5,11 @@ source "http://rubygems.org"
 gem "chef", "11.8.2"
 
 group :localdev do
+  gem "guard"
+  gem "guard-rspec"
+  gem "guard-rubocop"
   gem "pry"
+  gem "terminal-notifier-guard"
   gem "travis-lint"
 end
 

data/lib/chef/handler/datadog.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 require 'rubygems'
 require 'chef/handler'
+require 'chef/mash'
 require 'dogapi'
 
 class Chef
@@ -13,9 +14,9 @@ class Chef
       # "Account Settings" page here: https://app.datadoghq.com/account/settings
       # It should be passed along from the node/role/environemnt attributes, as the default is nil.
       def initialize(config = {})
-        @config = config
+        @config = Mash.new(config)
         # If *any* api_key is not provided, this will fail immediately.
-        @dog = Dogapi::Client.new(config[:api_key], config[:application_key])
+        @dog = Dogapi::Client.new(@config[:api_key], @config[:application_key])
       end
 
       def report
@@ -78,11 +79,26 @@ class Chef
       # @param run_status [Chef::RunStatus] current run status
       # @return [Array] alert_type, event_priority, event_title, event_body
       def build_event_data(hostname, run_status)
+        # bail early in case of a compiletime failure
+        # OPTIMIZE: Use better inspectors to handle failure scenarios, refactor needed.
+        if run_status.elapsed_time.nil?
+
+          alert_type = 'error'
+          event_title = "Chef failed during compile phase on #{hostname} "
+          event_priority = 'normal'
+          event_body = 'Chef was unable to complete a run, an error during compilation may have occurred.'
+
+          return [alert_type, event_priority, event_title, event_body]
+        end
+
         run_time = pluralize(run_status.elapsed_time, 'second')
 
         # This is the first line of the Event body, the rest is appended here.
         event_body = "Chef updated #{run_status.updated_resources.length} resources out of #{run_status.all_resources.length} resources total."
 
+        # Show the updated resource list, truncated when failed to 5
+        event_body << updated_resource_list(run_status)
+
         if run_status.success?
           alert_type = 'success'
           event_priority = 'low'
@@ -98,22 +114,36 @@ class Chef
             event_body << "\nAlerting: #{handles.join(' ')}\n"
           end
 
-          event_body << "\n@@@\n#{run_status.formatted_exception}\n@@@\n"
-          event_body << "\n@@@\n#{run_status.backtrace.join("\n")}\n@@@\n"
-        end
-
-        if run_status.updated_resources.length.to_i > 0
-          event_body << "\n@@@\n"
-          run_status.updated_resources.each do |r|
-            event_body << "- #{r} (#{r.defined_at})\n"
-          end
-          event_body << "\n@@@\n"
+          event_body << "\n$$$\n#{run_status.formatted_exception}\n$$$\n"
+          event_body << "\n$$$\n#{run_status.backtrace.join("\n")}\n$$$\n"
         end
 
         # Return resolved data
         [alert_type, event_priority, event_title, event_body]
       end
 
+      # Compose a list of resources updated during a run.
+      # Shorten the list when there is a failure for stacktrace debugging
+      #
+      # @param run_status [Chef::RunStatus] current run status
+      # @return [String] formatted list of resources updated, truncated on failure
+      def updated_resource_list(run_status)
+        # No resources updated? Go away.
+        return '' unless run_status.updated_resources.length.to_i > 0
+
+        if run_status.failed?
+          report_resources = run_status.updated_resources.last(5)
+        else
+          report_resources = run_status.updated_resources
+        end
+
+        event_body = "\n$$$\n"
+        report_resources.each do |r|
+          event_body << "- #{r} (#{r.defined_at})\n"
+        end
+        event_body << "\n$$$\n"
+      end
+
       # Emit Event to Datadog Event Stream
       #
       # @param hostname [String] resolved hostname to attach to Event
@@ -154,6 +184,11 @@ class Chef
       # @param hostname [String] resolved hostname to attach to series
       # @param run_status [Chef::RunStatus] current run status
       def emit_metrics_to_datadog(hostname, run_status)
+        # If there is a failure during compile phase, a large portion of
+        # run_status may be unavailable. Bail out here
+        warn_msg = 'Error during compile phase, no Datadog metrics available.'
+        return Chef::Log.warn(warn_msg) if run_status.elapsed_time.nil?
+
         @dog.emit_point('chef.resources.total', run_status.all_resources.length, :host => hostname)
         @dog.emit_point('chef.resources.updated', run_status.updated_resources.length, :host => hostname)
         @dog.emit_point('chef.resources.elapsed_time', run_status.elapsed_time, :host => hostname)

data/lib/chef_handler_datadog.rb

@@ -2,5 +2,5 @@
 # Helper module for version number only.
 # Real deal in 'chef/handler/datadog.rb'
 module ChefHandlerDatadog
-  VERSION = '0.4.0'
+  VERSION = '0.5.0'
 end

data/spec/datadog_spec.rb

@@ -23,6 +23,15 @@ describe Chef::Handler::Datadog, :vcr => :new_episodes do
     )
   end
 
+  describe 'initialize' do
+    it 'should allow config hash to have string keys' do
+      Chef::Handler::Datadog.new(
+        'api_key'         => API_KEY,
+        'application_key' => APPLICATION_KEY,
+      )
+    end
+  end
+
   describe 'reports metrics event and sets tags' do
     # Construct a good run_status
     before(:each) do
@@ -33,7 +42,7 @@ describe Chef::Handler::Datadog, :vcr => :new_episodes do
       @run_status = Chef::RunStatus.new(@node, @events)
 
       @expected_time = Time.now
-      Time.stub(:now).and_return(@expected_time, @expected_time + 5)
+      allow(Time).to receive(:now).and_return(@expected_time, @expected_time + 5)
       @run_status.start_clock
       @run_status.stop_clock
 
@@ -97,7 +106,7 @@ describe Chef::Handler::Datadog, :vcr => :new_episodes do
       @run_context = Chef::RunContext.new(@node, {}, @events)
       @run_status = Chef::RunStatus.new(@node, @events)
       @expected_time = Time.now
-      Time.stub(:now).and_return(@expected_time, @expected_time + 5)
+      allow(Time).to receive(:now).and_return(@expected_time, @expected_time + 5)
       @run_status.start_clock
       @run_status.stop_clock
       @run_status.run_context = @run_context
@@ -144,7 +153,7 @@ describe Chef::Handler::Datadog, :vcr => :new_episodes do
       @run_context = Chef::RunContext.new(@node, {}, @events)
       @run_status = Chef::RunStatus.new(@node, @events)
       @expected_time = Time.now
-      Time.stub(:now).and_return(@expected_time, @expected_time + 5)
+      allow(Time).to receive(:now).and_return(@expected_time, @expected_time + 5)
       @run_status.start_clock
       @run_status.stop_clock
       @run_status.run_context = @run_context
@@ -185,7 +194,7 @@ describe Chef::Handler::Datadog, :vcr => :new_episodes do
       @run_status = Chef::RunStatus.new(@node, @events)
 
       @expected_time = Time.now
-      Time.stub(:now).and_return(@expected_time, @expected_time + 5)
+      allow(Time).to receive(:now).and_return(@expected_time, @expected_time + 5)
       @run_status.start_clock
       @run_status.stop_clock
 
@@ -220,7 +229,7 @@ describe Chef::Handler::Datadog, :vcr => :new_episodes do
       @run_status = Chef::RunStatus.new(@node, @events)
 
       @expected_time = Time.now
-      Time.stub(:now).and_return(@expected_time, @expected_time + 5)
+      allow(Time).to receive(:now).and_return(@expected_time, @expected_time + 5)
       @run_status.start_clock
       @run_status.stop_clock
 
@@ -248,8 +257,19 @@ describe Chef::Handler::Datadog, :vcr => :new_episodes do
       @run_context = Chef::RunContext.new(@node, {}, @events)
       @run_status = Chef::RunStatus.new(@node, @events)
 
+      all_resources = [
+        Chef::Resource.new('whiskers'),
+        Chef::Resource.new('paws'),
+        Chef::Resource.new('ears'),
+        Chef::Resource.new('nose'),
+        Chef::Resource.new('tail'),
+        Chef::Resource.new('fur')
+        ]
+      all_resources.map { |r| r.updated_by_last_action(true) }
+      @run_context.resource_collection.all_resources.replace(all_resources)
+
       @expected_time = Time.now
-      Time.stub(:now).and_return(@expected_time, @expected_time + 2)
+      allow(Time).to receive(:now).and_return(@expected_time, @expected_time + 2)
       @run_status.start_clock
       @run_status.stop_clock
 
@@ -257,7 +277,7 @@ describe Chef::Handler::Datadog, :vcr => :new_episodes do
 
       # Construct an exception
       exception = Chef::Exceptions::UnsupportedAction.new('Something awry.')
-      exception.set_backtrace(['file.rb:2', 'file.rb:1'])
+      exception.set_backtrace(['whiskers.rb:2', 'paws.rb:1', 'file.rb:2', 'file.rb:1'])
       @run_status.exception = exception
 
       # Run the report
@@ -303,7 +323,7 @@ describe Chef::Handler::Datadog, :vcr => :new_episodes do
       @run_context.resource_collection.all_resources.replace(all_resources)
 
       @expected_time = Time.now
-      Time.stub(:now).and_return(@expected_time, @expected_time + 8)
+      allow(Time).to receive(:now).and_return(@expected_time, @expected_time + 8)
       @run_status.start_clock
       @run_status.stop_clock
 
@@ -322,6 +342,36 @@ describe Chef::Handler::Datadog, :vcr => :new_episodes do
     end
   end
 
+  describe 'resources' do
+    before(:each) do
+      @node = Chef::Node.build('chef.handler.datadog.test-resources')
+      @node.send(:chef_environment, 'resources')
+      @events = Chef::EventDispatch::Dispatcher.new
+      @run_context = Chef::RunContext.new(@node, {}, @events)
+      @run_status = Chef::RunStatus.new(@node, @events)
+    end
+
+    context 'failure during compile phase' do
+      before(:each) do
+        @handler.run_report_unsafe(@run_status)
+      end
+
+      it 'does not emit metrics' do
+        expect(a_request(:post, METRICS_ENDPOINT).with(
+          :query => { 'api_key' => @handler.config[:api_key] }
+        )).to_not have_been_made
+      end
+
+      it 'posts an event' do
+        expect(a_request(:post, EVENTS_ENDPOINT).with(
+          :query => { 'api_key' => @handler.config[:api_key] },
+          :body => hash_including(:msg_text => 'Chef was unable to complete a run, an error during compilation may have occured.'),
+          :body => hash_including(:msg_title => "Chef failed during compile phase on #{@node.name} "),
+        )).to have_been_made.times(1)
+      end
+    end
+  end
+
     # TODO: test failures:
     # @run_status.exception = Exception.new('Boy howdy!')
 end